EC-CUBE / ec-cube

src/Eccube/Di/Scanner/RepositoryScanner.php

Doc Comments +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
 {
     /**
      * RepositoryAutoWiring constructor.
-     * @param array|string[] $scanDirs
+     * @param string[] $scanDirs
      */
     public function __construct($scanDirs)
     {

src/Eccube/Di/Di.php

Braces +3 added lines, -1 removed lines

@@ -161,7 +161,9 @@
             }
 
             if (!empty($components)) {
-                if ($snippets) $snippets .= PHP_EOL;
+                if ($snippets) {
+                    $snippets .= PHP_EOL;
+                }
                 $snippets .= $wiring->generate($twig, $components);
                 $snippets .= $wiring->generateExtend($twig, $components);
             }

src/Eccube/ServiceProvider/DiServiceProvider.php

Spacing +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
 {
     public function register(Container $app)
     {
-        $app['eccube.di'] = function (Container $app) {
+        $app['eccube.di'] = function(Container $app) {
             $di = new Di(
                 $app['eccube.di.generator.dir'],
                 $app['eccube.di.generator.class'],

src/Eccube/EventListener/ForwardOnlyListener.php

Unused Use Statements -3 removed lines

@@ -6,9 +6,6 @@
 use Eccube\Annotation\ForwardOnly;
 use Monolog\Logger;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
-use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\HttpFoundation\Session\SessionInterface;
 use Symfony\Component\HttpKernel\Event\FilterControllerEvent;
 use Symfony\Component\HttpKernel\KernelEvents;
 

src/Eccube/ServiceProvider/EccubePluginServiceProvider.php

Spacing +14 added lines, -14 removed lines

@@ -27,7 +27,7 @@ 
     public function register(Container $app)
     {
         // EventDispatcher
-        $app['eccube.event.dispatcher'] = function () {
+        $app['eccube.event.dispatcher'] = function() {
             return new EventDispatcher();
         };
 
@@ -36,7 +36,7 @@ 
 
         $enabledPlugins = $app['orm.em']->getRepository('Eccube\Entity\Plugin')->findAllEnabled();
 
-        $app['eccube.routers.plugin'] = function ($app) use ($enabledPlugins) {
+        $app['eccube.routers.plugin'] = function($app) use ($enabledPlugins) {
             $pluginDirs = array_map(function($plugin) use ($app) {
                 return $app['config']['root_dir'].'/app/Plugin/'.$plugin->getCode();
             }, $enabledPlugins);
@@ -63,7 +63,7 @@ 
             $config = $pluginConfig['config'];
 
             if (isset($config['const'])) {
-                $app->extend('config', function ($eccubeConfig) use ($config) {
+                $app->extend('config', function($eccubeConfig) use ($config) {
                     $eccubeConfig[$config['code']] = array(
                         'const' => $config['const'],
                     );
@@ -85,7 +85,7 @@ 
     public function initPluginEventDispatcher(Application $app)
     {
         // hook point
-        $app->on(KernelEvents::REQUEST, function (GetResponseEvent $event) use ($app) {
+        $app->on(KernelEvents::REQUEST, function(GetResponseEvent $event) use ($app) {
             if (!$event->isMasterRequest()) {
                 return;
             }
@@ -93,7 +93,7 @@ 
             $app['eccube.event.dispatcher']->dispatch($hookpoint, $event);
         }, Application::EARLY_EVENT);
 
-        $app->on(KernelEvents::REQUEST, function (GetResponseEvent $event) use ($app) {
+        $app->on(KernelEvents::REQUEST, function(GetResponseEvent $event) use ($app) {
             if (!$event->isMasterRequest()) {
                 return;
             }
@@ -102,7 +102,7 @@ 
             $app['eccube.event.dispatcher']->dispatch($hookpoint, $event);
         });
 
-        $app->on(KernelEvents::RESPONSE, function (FilterResponseEvent $event) use ($app) {
+        $app->on(KernelEvents::RESPONSE, function(FilterResponseEvent $event) use ($app) {
             if (!$event->isMasterRequest()) {
                 return;
             }
@@ -111,7 +111,7 @@ 
             $app['eccube.event.dispatcher']->dispatch($hookpoint, $event);
         });
 
-        $app->on(KernelEvents::RESPONSE, function (FilterResponseEvent $event) use ($app) {
+        $app->on(KernelEvents::RESPONSE, function(FilterResponseEvent $event) use ($app) {
             if (!$event->isMasterRequest()) {
                 return;
             }
@@ -119,13 +119,13 @@ 
             $app['eccube.event.dispatcher']->dispatch($hookpoint, $event);
         }, Application::LATE_EVENT);
 
-        $app->on(KernelEvents::TERMINATE, function (PostResponseEvent $event) use ($app) {
+        $app->on(KernelEvents::TERMINATE, function(PostResponseEvent $event) use ($app) {
             $route = $event->getRequest()->attributes->get('_route');
             $hookpoint = "eccube.event.controller.$route.finish";
             $app['eccube.event.dispatcher']->dispatch($hookpoint, $event);
         });
 
-        $app->on(\Symfony\Component\HttpKernel\KernelEvents::RESPONSE, function (\Symfony\Component\HttpKernel\Event\FilterResponseEvent $event) use ($app) {
+        $app->on(\Symfony\Component\HttpKernel\KernelEvents::RESPONSE, function(\Symfony\Component\HttpKernel\Event\FilterResponseEvent $event) use ($app) {
             if (!$event->isMasterRequest()) {
                 return;
             }
@@ -134,7 +134,7 @@ 
         });
 
         // Request Event
-        $app->on(\Symfony\Component\HttpKernel\KernelEvents::REQUEST, function (\Symfony\Component\HttpKernel\Event\GetResponseEvent $event) use ($app) {
+        $app->on(\Symfony\Component\HttpKernel\KernelEvents::REQUEST, function(\Symfony\Component\HttpKernel\Event\GetResponseEvent $event) use ($app) {
 
             if (!$event->isMasterRequest()) {
                 return;
@@ -165,7 +165,7 @@ 
         }, 30); // Routing(32)が解決し, 認証判定(8)が実行される前のタイミング.
 
         // Controller Event
-        $app->on(\Symfony\Component\HttpKernel\KernelEvents::CONTROLLER, function (\Symfony\Component\HttpKernel\Event\FilterControllerEvent $event) use ($app) {
+        $app->on(\Symfony\Component\HttpKernel\KernelEvents::CONTROLLER, function(\Symfony\Component\HttpKernel\Event\FilterControllerEvent $event) use ($app) {
 
             if (!$event->isMasterRequest()) {
                 return;
@@ -194,7 +194,7 @@ 
         });
 
         // Response Event
-        $app->on(\Symfony\Component\HttpKernel\KernelEvents::RESPONSE, function (\Symfony\Component\HttpKernel\Event\FilterResponseEvent $event) use ($app) {
+        $app->on(\Symfony\Component\HttpKernel\KernelEvents::RESPONSE, function(\Symfony\Component\HttpKernel\Event\FilterResponseEvent $event) use ($app) {
             if (!$event->isMasterRequest()) {
                 return;
             }
@@ -223,7 +223,7 @@ 
         });
 
         // Exception Event
-        $app->on(\Symfony\Component\HttpKernel\KernelEvents::EXCEPTION, function (\Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent $event) use ($app) {
+        $app->on(\Symfony\Component\HttpKernel\KernelEvents::EXCEPTION, function(\Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent $event) use ($app) {
 
             if (!$event->isMasterRequest()) {
                 return;
@@ -253,7 +253,7 @@ 
         });
 
         // Terminate Event
-        $app->on(\Symfony\Component\HttpKernel\KernelEvents::TERMINATE, function (\Symfony\Component\HttpKernel\Event\PostResponseEvent $event) use ($app) {
+        $app->on(\Symfony\Component\HttpKernel\KernelEvents::TERMINATE, function(\Symfony\Component\HttpKernel\Event\PostResponseEvent $event) use ($app) {
 
             $route = $event->getRequest()->attributes->get('_route');
 

src/Eccube/Controller/Mypage/MypageController.php

Unused Use Statements -1 removed lines

@@ -32,7 +32,6 @@
 use Eccube\Controller\AbstractController;
 use Eccube\Entity\BaseInfo;
 use Eccube\Entity\CustomerFavoriteProduct;
-use Eccube\Entity\Product;
 use Eccube\Event\EccubeEvents;
 use Eccube\Event\EventArgs;
 use Eccube\Exception\CartException;

src/Eccube/Repository/CustomerRepository.php

Doc Comments +1 added lines, -1 removed lines

@@ -392,7 +392,7 @@
     /**
      * 会員の初回購入時間、購入時間、購入回数、購入金額を更新する
      *
-     * @param $app
+     * @param \Eccube\Application $app
      * @param  Customer $Customer
      * @param  $orderStatusId
      */

src/Eccube/Repository/NewsRepository.php

Indentation +1 added lines, -1 removed lines

@@ -114,7 +114,7 @@
      */
     public function delete($News)
     {
-       $this->createQueryBuilder('n')
+        $this->createQueryBuilder('n')
             ->update()
             ->set('n.rank', 'n.rank - 1')
             ->where('n.rank > :rank')

src/Eccube/Controller/Admin/Content/NewsController.php

Spacing +1 added lines, -1 removed lines

@@ -122,7 +122,7 @@
             $News = new \Eccube\Entity\News();
         }
 
-        $News->setLinkMethod((bool)$News->getLinkMethod());
+        $News->setLinkMethod((bool) $News->getLinkMethod());
 
         $builder = $this->formFactory
             ->createBuilder(NewsType::class, $News);