Completed
Pull Request — experimental/3.1 (#2561)
by k-yamamura
222:41 queued 215:24
created
src/Eccube/Application/ApplicationTrait.php 1 patch
Doc Comments   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -16,6 +16,7 @@  discard block
 block discarded – undo
16 16
 {
17 17
     /**
18 18
      * Application Shortcut Methods
19
+     * @param string $message
19 20
      */
20 21
     public function addSuccess($message, $namespace = 'front')
21 22
     {
@@ -58,6 +59,9 @@  discard block
 block discarded – undo
58 59
         $this->addWarning('admin.delete.warning', 'admin');
59 60
     }
60 61
 
62
+    /**
63
+     * @param string $targetPath
64
+     */
61 65
     public function setLoginTargetPath($targetPath, $namespace = null)
62 66
     {
63 67
         if (is_null($namespace)) {
@@ -109,7 +113,7 @@  discard block
 block discarded – undo
109 113
      * @param string $path フォワード先のパス
110 114
      * @param array $requestParameters
111 115
      * @param Response $response
112
-     * @return Application
116
+     * @return ApplicationTrait
113 117
      */
114 118
     public function forwardChain($path, array $requestParameters = [], Response &$response = null)
115 119
     {
@@ -122,7 +126,7 @@  discard block
 block discarded – undo
122 126
      * Pimple標準では再登録を行うと, `RuntimeException: Cannot override frozen service`が投げられるため,一度unsetしてから再登録を行う.
123 127
      * config系の変更程度に利用はとどめること
124 128
      *
125
-     * @param $key
129
+     * @param string $key
126 130
      * @param $service
127 131
      * @throws \InvalidArgumentException keyが存在しない場合.
128 132
      */
Please login to merge, or discard this patch.
src/Eccube/DI/AutoWiring/FormExtensionAutoWiring.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
 {
32 32
     /**
33 33
      * FormExtensionAutoWiring constructor.
34
-     * @param array|string[] $scanDirs
34
+     * @param string[] $scanDirs
35 35
      */
36 36
     public function __construct($scanDirs)
37 37
     {
Please login to merge, or discard this patch.
src/Eccube/DI/AutoWiring/RepositoryAutoWiring.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
 {
31 31
     /**
32 32
      * RepositoryAutoWiring constructor.
33
-     * @param array|string[] $scanDirs
33
+     * @param string[] $scanDirs
34 34
      */
35 35
     public function __construct($scanDirs)
36 36
     {
Please login to merge, or discard this patch.
src/Eccube/DI/AutoWiring/RepositoryDefinition.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -30,8 +30,8 @@
 block discarded – undo
30 30
 {
31 31
     /**
32 32
      * RepositoryDefinition constructor.
33
-     * @param $id
34
-     * @param $refClass
33
+     * @param string $id
34
+     * @param \ReflectionClass $refClass
35 35
      */
36 36
     public function __construct($id, $refClass)
37 37
     {
Please login to merge, or discard this patch.
src/Eccube/Service/EntityProxyService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -194,7 +194,7 @@
 block discarded – undo
194 194
 
195 195
     /**
196 196
      * EntityからTraitを削除.
197
-     * @param $entityTokens Tokens Entityのトークン
197
+     * @param Tokens $entityTokens Tokens Entityのトークン
198 198
      * @param $trait string 削除するTraitのFQCN
199 199
      */
200 200
     private function removeTrait($entityTokens, $trait)
Please login to merge, or discard this patch.
src/Eccube/Service/PluginService.php 1 patch
Doc Comments   +26 added lines patch added patch discarded remove patch
@@ -91,6 +91,10 @@  discard block
 block discarded – undo
91 91
     const EVENT_YML = 'event.yml';
92 92
 
93 93
     // ファイル指定してのプラグインインストール
94
+
95
+    /**
96
+     * @param string $path
97
+     */
94 98
     public function install($path, $source = 0)
95 99
     {
96 100
         $pluginBaseDir = null;
@@ -139,6 +143,10 @@  discard block
 block discarded – undo
139 143
     }
140 144
 
141 145
     // インストール事後処理
146
+
147
+    /**
148
+     * @param integer $source
149
+     */
142 150
     public function postInstall($config, $event, $source)
143 151
     {
144 152
         // Proxyのクラスをロードせずにスキーマを更新するために、
@@ -185,6 +193,9 @@  discard block
 block discarded – undo
185 193
         }
186 194
     }
187 195
 
196
+    /**
197
+     * @param string $dir
198
+     */
188 199
     public function unpackPluginArchive($archive, $dir)
189 200
     {
190 201
         $extension = pathinfo($archive, PATHINFO_EXTENSION);
@@ -244,6 +255,9 @@  discard block
 block discarded – undo
244 255
         }
245 256
     }
246 257
 
258
+    /**
259
+     * @param string $yml
260
+     */
247 261
     public function readYml($yml)
248 262
     {
249 263
         if (file_exists($yml)) {
@@ -261,6 +275,9 @@  discard block
 block discarded – undo
261 275
         // ディレクトリ名などに使われれるので厳しめ
262 276
     }
263 277
 
278
+    /**
279
+     * @param string $path
280
+     */
264 281
     public function deleteFile($path)
265 282
     {
266 283
         $f = new Filesystem();
@@ -280,6 +297,9 @@  discard block
 block discarded – undo
280 297
         return $this->appConfig['plugin_realdir'].'/'.$name;
281 298
     }
282 299
 
300
+    /**
301
+     * @param string $d
302
+     */
283 303
     public function createPluginDir($d)
284 304
     {
285 305
         $b = @mkdir($d);
@@ -337,6 +357,9 @@  discard block
 block discarded – undo
337 357
         return $p;
338 358
     }
339 359
 
360
+    /**
361
+     * @param string $method
362
+     */
340 363
     public function callPluginManagerMethod($meta, $method)
341 364
     {
342 365
         $class = '\\Plugin'.'\\'.$meta['code'].'\\'.'PluginManager';
@@ -453,6 +476,9 @@  discard block
 block discarded – undo
453 476
         return true;
454 477
     }
455 478
 
479
+    /**
480
+     * @param string $path
481
+     */
456 482
     public function update(\Eccube\Entity\Plugin $plugin, $path)
457 483
     {
458 484
         $pluginBaseDir = null;
Please login to merge, or discard this patch.