DoctrineOrmExtension::__construct() - Code Metrics - Inspection of "Merge pull request #2321 from chihiro-adachi/dev-f..." - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — experimental/3.1 ( 243c6b...0c67c0 )

by Yangsin

created 2017-05-18 02:26 UTC

DoctrineOrmExtension::__construct() A

↳ Parent: DoctrineOrmExtension

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
c	0
b	0
f	0
nc	1
nop	1
dl	0
loc	4
rs	10

<?php
/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 */

namespace Eccube\Form\Extension;

use Doctrine\ORM\EntityManager;
use Symfony\Component\Form\AbstractTypeExtension;
use Symfony\Component\Form\Extension\Core\Type\FormType;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\Form\FormEvent;
use Symfony\Component\Form\FormEvents;
use Symfony\Component\Form\FormInterface;
use Symfony\Component\Form\FormView;
use Symfony\Component\OptionsResolver\OptionsResolver;

class DoctrineOrmExtension extends AbstractTypeExtension

{
    /**
     * @var EntityManager
     */
    protected $em;

    public function __construct(EntityManager $em)
function someFunction(ManagerRegistry $registry) {
    $em = $registry->getManager();
    $em->getConnection()->beginTransaction();
    try {
        // Do something.
        $em->getConnection()->commit();
    } catch (\Exception $ex) {
        $em->getConnection()->rollback();
        $em->close();

        throw $ex;
    }
}
    {
        $this->em = $em;
    }

    /**
     * {@inheritdoc}
     */
    public function buildForm(FormBuilderInterface $builder, array $options)
    {
        $builder->addEventListener(
            FormEvents::PRE_SET_DATA,
            function (FormEvent $event) {
                $form = $event->getForm();
                $config = $form->getConfig();
                // data_classオプションが必要
                $class = $config->getDataClass();
                if (is_null($class)) {
                    return;
                }
                // メタデータの取得
                try {
                    $meta = $this->em->getClassMetadata($class);
                } catch (\Exception $e) {
                    return;
                }
                // フィールドからフォームへ定義
                $names = $meta->getFieldNames();
                foreach ($names as $name) {
                    $mapping = $meta->getFieldMapping($name);
                    if (isset($mapping['options']['eccube_form_options'])) {
                        $options = $mapping['options']['eccube_form_options'];
                        if (isset($options['auto_render']) && true === $options['auto_render']) {
                            $fieldName = $mapping['fieldName'];
                            if (!isset($form[$fieldName])) {
                                $form->add(
                                    $mapping['fieldName'],
                                    null,
                                    [
                                        'eccube_form_options' => $options,
                                    ]
                                );
                            }
                        }
                    }
                }
                // TODO Assosiationも対応する
            }
        );
    }

    public function buildView(FormView $view, FormInterface $form, array $options)

    {
        $options = $form->getConfig()->getOption('eccube_form_options');
        $view->vars['eccube_form_options'] = $options;
    }

    public function configureOptions(OptionsResolver $resolver)

    {
        $resolver->setDefault(
            'eccube_form_options',
            [
                'auto_render' => false,
                'form_theme' => null,
            ]
        );
    }

    public function getExtendedType()

    {
        return FormType::class;
    }
}


1			<?php
2			/*
3			* This file is part of EC-CUBE
4			*
5			* Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
6			*
7			* http://www.lockon.co.jp/
8			*
9			* This program is free software; you can redistribute it and/or
10			* modify it under the terms of the GNU General Public License
11			* as published by the Free Software Foundation; either version 2
12			* of the License, or (at your option) any later version.
13			*
14			* This program is distributed in the hope that it will be useful,
15			* but WITHOUT ANY WARRANTY; without even the implied warranty of
16			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17			* GNU General Public License for more details.
18			*
19			* You should have received a copy of the GNU General Public License
20			* along with this program; if not, write to the Free Software
21			* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
22			*/
23
24			namespace Eccube\Form\Extension;
25
26			use Doctrine\ORM\EntityManager;
27			use Symfony\Component\Form\AbstractTypeExtension;
28			use Symfony\Component\Form\Extension\Core\Type\FormType;
29			use Symfony\Component\Form\FormBuilderInterface;
30			use Symfony\Component\Form\FormEvent;
31			use Symfony\Component\Form\FormEvents;
32			use Symfony\Component\Form\FormInterface;
33			use Symfony\Component\Form\FormView;
34			use Symfony\Component\OptionsResolver\OptionsResolver;
35
36			class DoctrineOrmExtension extends AbstractTypeExtension
			0 ignored issues – show introduced 2017-04-11 09:55 UTC by Report Bug Copy Issue Report Missing class doc comment Loading history...
37			{
38			/**
39			* @var EntityManager
40			*/
41			protected $em;
42
43			public function __construct(EntityManager $em)
			0 ignored issues – show Bug introduced 2017-04-13 02:47 UTC by Report Bug Copy Issue Report You have injected the EntityManager via parameter `$em`. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via `getManager()` each time you need it. The `EntityManager` might become unusable for example if a transaction is rolled back and it gets closed. Let’s assume that somewhere in your application, or in a third-party library, there is code such as the following: function someFunction(ManagerRegistry $registry) { $em = $registry->getManager(); $em->getConnection()->beginTransaction(); try { // Do something. $em->getConnection()->commit(); } catch (\Exception $ex) { $em->getConnection()->rollback(); $em->close(); throw $ex; } } If that code throws an exception and the `EntityManager` is closed. Any other code which depends on the same instance of the `EntityManager` during this request will fail. On the other hand, if you instead inject the `ManagerRegistry`, the `getManager()` method guarantees that you will always get a usable manager instance. Loading history... introduced 2017-04-13 02:47 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
44			{
45			$this->em = $em;
46			}
47
48			/**
49			* {@inheritdoc}
50			*/
51			public function buildForm(FormBuilderInterface $builder, array $options)
52			{
53			$builder->addEventListener(
54			FormEvents::PRE_SET_DATA,
55			function (FormEvent $event) {
56			$form = $event->getForm();
57			$config = $form->getConfig();
58			// data_classオプションが必要
59			$class = $config->getDataClass();
60			if (is_null($class)) {
61			return;
62			}
63			// メタデータの取得
64			try {
65			$meta = $this->em->getClassMetadata($class);
66			} catch (\Exception $e) {
67			return;
68			}
69			// フィールドからフォームへ定義
70			$names = $meta->getFieldNames();
71			foreach ($names as $name) {
72			$mapping = $meta->getFieldMapping($name);
73			if (isset($mapping['options']['eccube_form_options'])) {
74			$options = $mapping['options']['eccube_form_options'];
75			if (isset($options['auto_render']) && true === $options['auto_render']) {
76			$fieldName = $mapping['fieldName'];
77			if (!isset($form[$fieldName])) {
78			$form->add(
79			$mapping['fieldName'],
80			null,
81			[
82			'eccube_form_options' => $options,
83			]
84			);
85			}
86			}
87			}
88			}
89			// TODO Assosiationも対応する
90			}
91			);
92			}
93
94			public function buildView(FormView $view, FormInterface $form, array $options)
			0 ignored issues – show introduced 2017-05-17 08:17 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
95			{
96			$options = $form->getConfig()->getOption('eccube_form_options');
97			$view->vars['eccube_form_options'] = $options;
98			}
99
100			public function configureOptions(OptionsResolver $resolver)
			0 ignored issues – show introduced 2016-12-15 10:20 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
101			{
102			$resolver->setDefault(
103			'eccube_form_options',
104			[
105			'auto_render' => false,
106			'form_theme' => null,
107			]
108			);
109			}
110
111			public function getExtendedType()
			0 ignored issues – show introduced 2017-04-11 09:55 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
112			{
113			return FormType::class;
114			}
115			}
116

EC-CUBE / ec-cube

Push — experimental/3.1 ( 243c6b...0c67c0 )

DoctrineOrmExtension::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like