Complex classes like CartService often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use CartService, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
35 | class CartService |
||
|
|||
36 | { |
||
37 | /** @var \Eccube\Application */ |
||
38 | public $app; |
||
39 | |||
40 | /** |
||
41 | * @var Session |
||
42 | */ |
||
43 | private $session; |
||
44 | |||
45 | /** |
||
46 | * @var EntityManager |
||
47 | */ |
||
48 | private $entityManager; |
||
49 | |||
50 | /** |
||
51 | * @var \Eccube\Entity\Cart |
||
52 | */ |
||
53 | private $cart; |
||
54 | |||
55 | /** |
||
56 | * @var \Eccube\Entity\BaseInfo |
||
57 | */ |
||
58 | private $BaseInfo; |
||
59 | |||
60 | /** |
||
61 | * @var array |
||
62 | */ |
||
63 | private $errors = array(); |
||
64 | |||
65 | private $ProductType = null; |
||
66 | |||
67 | /** |
||
68 | * @var array |
||
69 | */ |
||
70 | private $messages = array(); |
||
71 | |||
72 | /** |
||
73 | * @var array |
||
74 | */ |
||
75 | private $error; |
||
76 | |||
77 | 182 | public function __construct(\Eccube\Application $app) |
|
78 | { |
||
79 | 182 | $this->app = $app; |
|
80 | 182 | $this->session = $app['session']; |
|
81 | 182 | $this->entityManager = $app['orm.em']; |
|
82 | |||
83 | 182 | if ($this->session->has('cart')) { |
|
84 | $this->cart = $this->session->get('cart'); |
||
85 | } else { |
||
86 | 182 | $this->cart = new \Eccube\Entity\Cart(); |
|
87 | } |
||
88 | |||
89 | 182 | $this->loadProductClassFromCart(); |
|
90 | |||
91 | 182 | $this->BaseInfo = $app['eccube.repository.base_info']->get(); |
|
92 | } |
||
93 | |||
94 | /** |
||
95 | * カートに保存されている商品の ProductClass エンティティを読み込み、カートへ設定します。 |
||
96 | */ |
||
97 | 182 | protected function loadProductClassFromCart() |
|
98 | { |
||
99 | /* @var $softDeleteFilter \Eccube\Doctrine\Filter\SoftDeleteFilter */ |
||
100 | 182 | $softDeleteFilter = $this->entityManager->getFilters()->getFilter('soft_delete'); |
|
101 | 182 | $excludes = $softDeleteFilter->getExcludes(); |
|
102 | 182 | $softDeleteFilter->setExcludes(array( |
|
103 | 182 | 'Eccube\Entity\ProductClass', |
|
104 | )); |
||
105 | |||
106 | 182 | foreach ($this->cart->getCartItems() as $CartItem) { |
|
107 | 182 | $this->loadProductClassFromCartItem($CartItem); |
|
108 | } |
||
109 | |||
110 | 182 | $softDeleteFilter->setExcludes($excludes); |
|
111 | } |
||
112 | |||
113 | /** |
||
114 | * CartItem に対応する ProductClass を設定します。 |
||
115 | * |
||
116 | * @param CartItem $CartItem |
||
117 | */ |
||
118 | 47 | protected function loadProductClassFromCartItem(CartItem $CartItem) |
|
119 | { |
||
120 | $ProductClass = $this |
||
121 | 47 | ->entityManager |
|
122 | 47 | ->getRepository($CartItem->getClassName()) |
|
123 | 47 | ->find($CartItem->getClassId()); |
|
124 | |||
125 | 47 | $CartItem->setObject($ProductClass); |
|
126 | |||
127 | 47 | if (is_null($this->ProductType) && $ProductClass->getDelFlg() == Constant::DISABLED) { |
|
128 | $this->setCanAddProductType($ProductClass->getProductType()); |
||
129 | } |
||
130 | } |
||
131 | |||
132 | 88 | public function setCanAddProductType(\Eccube\Entity\Master\ProductType $ProductType) |
|
140 | |||
141 | 82 | public function save() |
|
142 | { |
||
143 | 82 | return $this->session->set('cart', $this->cart); |
|
144 | } |
||
145 | |||
146 | 4 | public function unlock() |
|
152 | |||
153 | 38 | public function lock() |
|
159 | |||
160 | /** |
||
161 | * @return bool |
||
162 | */ |
||
163 | 47 | public function isLocked() |
|
164 | { |
||
165 | 47 | return $this->cart->getLock(); |
|
166 | } |
||
167 | |||
168 | /** |
||
169 | * @param string $pre_order_id |
||
170 | * @return \Eccube\Service\CartService |
||
171 | */ |
||
172 | 40 | public function setPreOrderId($pre_order_id) |
|
173 | { |
||
174 | 40 | $this->cart->setPreOrderId($pre_order_id); |
|
175 | |||
176 | 40 | return $this; |
|
177 | } |
||
178 | |||
179 | /** |
||
180 | * @return string |
||
181 | */ |
||
182 | 39 | public function getPreOrderId() |
|
183 | { |
||
184 | 39 | return $this->cart->getPreOrderId(); |
|
185 | } |
||
186 | |||
187 | /** |
||
188 | * @return \Eccube\Service\CartService |
||
189 | */ |
||
190 | 13 | public function clear() |
|
191 | { |
||
192 | 13 | $this->cart |
|
193 | 13 | ->setPreOrderId(null) |
|
194 | 13 | ->setLock(false) |
|
195 | 13 | ->clearCartItems(); |
|
196 | |||
197 | 13 | return $this; |
|
198 | } |
||
199 | |||
200 | 1 | public function getCanAddProductType() |
|
204 | |||
205 | /** |
||
206 | * |
||
207 | * @param string $productClassId |
||
208 | * @param integer $quantity |
||
209 | * @return \Eccube\Service\CartService |
||
210 | */ |
||
211 | 44 | public function addProduct($productClassId, $quantity = 1) |
|
218 | |||
219 | /** |
||
220 | * @param string $productClassId |
||
221 | * @return integer |
||
222 | */ |
||
223 | 53 | public function getProductQuantity($productClassId) |
|
224 | { |
||
225 | 53 | $CartItem = $this->cart->getCartItemByIdentifier('Eccube\Entity\ProductClass', (string) $productClassId); |
|
226 | 53 | if ($CartItem) { |
|
227 | 7 | return $CartItem->getQuantity(); |
|
228 | } else { |
||
229 | 51 | return 0; |
|
230 | } |
||
231 | } |
||
232 | |||
233 | /** |
||
234 | * @param \Eccube\Entity\ProductClass|integer $ProductClass |
||
235 | * @param integer $quantity |
||
236 | * @return \Eccube\Service\CartService |
||
237 | * @throws CartException |
||
238 | */ |
||
239 | 91 | public function setProductQuantity($ProductClass, $quantity) |
|
240 | { |
||
241 | 91 | if (!$ProductClass instanceof ProductClass) { |
|
242 | 86 | $ProductClass = $this->entityManager |
|
243 | 86 | ->getRepository('Eccube\Entity\ProductClass') |
|
244 | 86 | ->find($ProductClass); |
|
245 | 86 | if (!$ProductClass) { |
|
246 | 3 | throw new CartException('cart.product.delete'); |
|
247 | } |
||
248 | } |
||
249 | 88 | if ($ProductClass->getProduct()->getStatus()->getId() !== Disp::DISPLAY_SHOW) { |
|
250 | 1 | $this->removeProduct($ProductClass->getId()); |
|
251 | 1 | throw new CartException('cart.product.not.status'); |
|
252 | } |
||
253 | |||
254 | 87 | $productName = $ProductClass->getProduct()->getName(); |
|
255 | 87 | if ($ProductClass->hasClassCategory1()) { |
|
256 | 87 | $productName .= " - ".$ProductClass->getClassCategory1()->getName(); |
|
257 | } |
||
258 | 87 | if ($ProductClass->hasClassCategory2()) { |
|
259 | 85 | $productName .= " - ".$ProductClass->getClassCategory2()->getName(); |
|
260 | } |
||
261 | |||
262 | // 商品種別に紐づく配送業者を取得 |
||
263 | 87 | $deliveries = $this->app['eccube.repository.delivery']->getDeliveries($ProductClass->getProductType()); |
|
264 | |||
265 | 87 | if (count($deliveries) == 0) { |
|
266 | // 商品種別が存在しなければエラー |
||
267 | $this->removeProduct($ProductClass->getId()); |
||
268 | $this->addError('cart.product.not.producttype', $productName); |
||
269 | throw new CartException('cart.product.not.producttype'); |
||
270 | } |
||
271 | |||
272 | 87 | $this->setCanAddProductType($ProductClass->getProductType()); |
|
273 | |||
274 | 87 | if ($this->BaseInfo->getOptionMultipleShipping() != Constant::ENABLED) { |
|
275 | 79 | if (!$this->canAddProduct($ProductClass->getId())) { |
|
276 | // 複数配送対応でなければ商品種別が異なればエラー |
||
277 | 79 | throw new CartException('cart.product.type.kind'); |
|
278 | } |
||
279 | } else { |
||
280 | // 複数配送の場合、同一支払方法がなければエラー |
||
281 | 8 | if (!$this->canAddProductPayment($ProductClass->getProductType())) { |
|
282 | 1 | throw new CartException('cart.product.payment.kind'); |
|
283 | } |
||
284 | |||
285 | } |
||
286 | |||
287 | 87 | $tmp_subtotal = 0; |
|
288 | 87 | $tmp_quantity = 0; |
|
289 | 87 | foreach ($this->getCart()->getCartItems() as $cartitem) { |
|
290 | 8 | $pc = $cartitem->getObject(); |
|
291 | 8 | if ($pc->getId() != $ProductClass->getId()) { |
|
292 | // まず、追加された商品以外のtotal priceをセット |
||
293 | 87 | $tmp_subtotal += $cartitem->getTotalPrice(); |
|
294 | } |
||
295 | } |
||
296 | 87 | for ($i = 0; $i < $quantity; $i++) { |
|
297 | 87 | $tmp_subtotal += $ProductClass->getPrice02IncTax(); |
|
298 | 87 | if ($tmp_subtotal > $this->app['config']['max_total_fee']) { |
|
299 | 1 | $this->setError('cart.over.price_limit'); |
|
300 | 1 | break; |
|
301 | } |
||
302 | 86 | $tmp_quantity++; |
|
303 | } |
||
304 | 87 | $quantity = $tmp_quantity; |
|
305 | |||
306 | 87 | $tmp_quantity = 0; |
|
307 | |||
308 | /* |
||
309 | * 実際の在庫は ProductClass::ProductStock だが、購入時にロックがかかるため、 |
||
310 | * ここでは ProductClass::stock で在庫のチェックをする |
||
311 | */ |
||
312 | 87 | if (!$ProductClass->getStockUnlimited() && $quantity > $ProductClass->getStock()) { |
|
313 | 2 | if ($ProductClass->getSaleLimit() && $ProductClass->getStock() > $ProductClass->getSaleLimit()) { |
|
314 | 1 | $tmp_quantity = $ProductClass->getSaleLimit(); |
|
315 | 1 | $this->addError('cart.over.sale_limit', $productName); |
|
316 | } else { |
||
317 | 1 | $tmp_quantity = $ProductClass->getStock(); |
|
318 | 1 | $this->addError('cart.over.stock', $productName); |
|
319 | } |
||
320 | } |
||
321 | 87 | if ($ProductClass->getSaleLimit() && $quantity > $ProductClass->getSaleLimit()) { |
|
322 | 2 | $tmp_quantity = $ProductClass->getSaleLimit(); |
|
323 | 2 | $this->addError('cart.over.sale_limit', $productName); |
|
324 | } |
||
325 | 87 | if ($tmp_quantity) { |
|
326 | 3 | $quantity = $tmp_quantity; |
|
327 | } |
||
328 | |||
329 | 87 | $CartItem = new CartItem(); |
|
330 | $CartItem |
||
331 | 87 | ->setClassName('Eccube\Entity\ProductClass') |
|
332 | 87 | ->setClassId((string) $ProductClass->getId()) |
|
333 | 87 | ->setPrice($ProductClass->getPrice02IncTax()) |
|
334 | 87 | ->setQuantity($quantity); |
|
335 | |||
336 | 87 | $this->cart->setCartItem($CartItem); |
|
337 | |||
338 | 87 | return $this; |
|
339 | } |
||
340 | |||
341 | /** |
||
342 | * @param string $productClassId |
||
343 | * @return boolean |
||
344 | */ |
||
345 | 79 | public function canAddProduct($productClassId) |
|
346 | { |
||
347 | $ProductClass = $this |
||
348 | 79 | ->entityManager |
|
349 | 79 | ->getRepository('\Eccube\Entity\ProductClass') |
|
350 | 79 | ->find($productClassId); |
|
351 | |||
352 | 79 | if (!$ProductClass) { |
|
353 | return false; |
||
354 | } |
||
355 | |||
356 | 79 | $ProductType = $ProductClass->getProductType(); |
|
357 | |||
358 | 79 | return $this->ProductType == $ProductType; |
|
359 | } |
||
360 | |||
361 | /** |
||
362 | * @param \Eccube\Entity\Master\ProductType $ProductType |
||
363 | * @return bool |
||
364 | */ |
||
365 | 9 | public function canAddProductPayment(\Eccube\Entity\Master\ProductType $ProductType) |
|
366 | { |
||
367 | $deliveries = $this |
||
368 | 9 | ->entityManager |
|
369 | 9 | ->getRepository('\Eccube\Entity\Delivery') |
|
370 | 9 | ->findBy(array('ProductType' => $ProductType)); |
|
371 | |||
372 | // 支払方法を取得 |
||
373 | 9 | $payments = $this->entityManager->getRepository('Eccube\Entity\Payment')->findAllowedPayments($deliveries); |
|
374 | |||
375 | 9 | if ($this->getCart()->getTotalPrice() < 1) { |
|
376 | // カートになければ支払方法を全て設定 |
||
377 | 9 | $this->getCart()->setPayments($payments); |
|
378 | 9 | return true; |
|
379 | } |
||
380 | |||
381 | // カートに存在している支払方法と追加された商品の支払方法チェック |
||
382 | 7 | $arr = array(); |
|
383 | 7 | foreach ($payments as $payment) { |
|
384 | 7 | foreach ($this->getCart()->getPayments() as $p) { |
|
385 | 7 | if ($payment['id'] == $p['id']) { |
|
386 | 6 | $arr[] = $payment; |
|
387 | 7 | break; |
|
388 | } |
||
389 | } |
||
390 | } |
||
391 | |||
392 | 7 | if (count($arr) > 0) { |
|
393 | 6 | $this->getCart()->setPayments($arr); |
|
394 | 6 | return true; |
|
395 | } |
||
396 | |||
397 | // 支払条件に一致しない |
||
398 | 1 | return false; |
|
399 | |||
400 | } |
||
401 | |||
402 | /** |
||
403 | * カートを取得します。 |
||
404 | * |
||
405 | * @return \Eccube\Entity\Cart |
||
406 | */ |
||
407 | 159 | public function getCart() |
|
408 | { |
||
409 | 159 | foreach ($this->cart->getCartItems() as $CartItem) { |
|
410 | 47 | $ProductClass = $CartItem->getObject(); |
|
411 | 47 | if (!$ProductClass) { |
|
412 | 47 | $this->loadProductClassFromCartItem($CartItem); |
|
413 | |||
414 | 47 | $ProductClass = $CartItem->getObject(); |
|
415 | } |
||
416 | |||
417 | 47 | if ($ProductClass->getDelFlg() == Constant::DISABLED) { |
|
418 | // 商品情報が有効 |
||
419 | 47 | $stockUnlimited = $ProductClass->getStockUnlimited(); |
|
420 | 47 | if ($stockUnlimited == Constant::DISABLED && $ProductClass->getStock() < 1) { |
|
421 | // 在庫がなければカートから削除 |
||
422 | $this->setError('cart.zero.stock'); |
||
423 | $this->removeProduct($ProductClass->getId()); |
||
424 | } else { |
||
425 | 47 | $quantity = $CartItem->getQuantity(); |
|
426 | 47 | $saleLimit = $ProductClass->getSaleLimit(); |
|
427 | 47 | if ($stockUnlimited == Constant::DISABLED && $ProductClass->getStock() < $quantity) { |
|
428 | // 購入数が在庫数を超えている場合、メッセージを表示 |
||
429 | $this->setError('cart.over.stock'); |
||
430 | 47 | } elseif (!is_null($saleLimit) && $saleLimit < $quantity) { |
|
431 | // 購入数が販売制限数を超えている場合、メッセージを表示 |
||
432 | 47 | $this->setError('cart.over.sale_limit'); |
|
433 | } |
||
434 | } |
||
435 | } else { |
||
436 | // 商品情報が削除されていたらエラー |
||
437 | $this->setError('cart.product.delete'); |
||
438 | // カートから削除 |
||
439 | 159 | $this->removeProduct($ProductClass->getId()); |
|
440 | } |
||
441 | } |
||
442 | |||
443 | 159 | return $this->cart; |
|
444 | } |
||
445 | |||
446 | /** |
||
447 | * @param string $productClassId |
||
448 | * @return \Eccube\Service\CartService |
||
449 | */ |
||
450 | 9 | public function removeProduct($productClassId) |
|
451 | { |
||
452 | 9 | $this->cart->removeCartItemByIdentifier('Eccube\Entity\ProductClass', (string) $productClassId); |
|
453 | |||
454 | // 支払方法の再設定 |
||
455 | 9 | if ($this->BaseInfo->getOptionMultipleShipping() == Constant::ENABLED) { |
|
456 | |||
457 | // 複数配送対応 |
||
458 | 1 | $productTypes = array(); |
|
459 | 1 | foreach ($this->getCart()->getCartItems() as $item) { |
|
460 | /* @var $ProductClass \Eccube\Entity\ProductClass */ |
||
461 | 1 | $ProductClass = $item->getObject(); |
|
462 | 1 | $productTypes[] = $ProductClass->getProductType(); |
|
463 | } |
||
464 | |||
465 | // 配送業者を取得 |
||
466 | 1 | $deliveries = $this->entityManager->getRepository('Eccube\Entity\Delivery')->getDeliveries($productTypes); |
|
467 | |||
468 | // 支払方法を取得 |
||
469 | 1 | $payments = $this->entityManager->getRepository('Eccube\Entity\Payment')->findAllowedPayments($deliveries); |
|
470 | |||
471 | 1 | $this->getCart()->setPayments($payments); |
|
472 | } |
||
473 | |||
474 | 9 | return $this; |
|
475 | } |
||
476 | |||
477 | /** |
||
478 | * @param string $error |
||
479 | * @param string $productName |
||
480 | * @return \Eccube\Service\CartService |
||
481 | */ |
||
482 | 4 | public function addError($error = null, $productName = null) |
|
483 | { |
||
484 | 4 | $this->errors[] = $error; |
|
485 | 4 | $this->session->getFlashBag()->add('eccube.front.request.error', $error); |
|
486 | 4 | if (!is_null($productName)) { |
|
487 | 3 | $this->session->getFlashBag()->add('eccube.front.request.product', $productName); |
|
488 | } |
||
489 | 4 | return $this; |
|
490 | } |
||
491 | |||
492 | /** |
||
493 | * @param string $productClassId |
||
494 | * @return \Eccube\Service\CartService |
||
495 | */ |
||
496 | 4 | public function upProductQuantity($productClassId) |
|
497 | { |
||
498 | 4 | $quantity = $this->getProductQuantity($productClassId) + 1; |
|
499 | 4 | $this->setProductQuantity($productClassId, $quantity); |
|
500 | |||
501 | 3 | return $this; |
|
502 | } |
||
503 | |||
504 | /** |
||
505 | * @param string $productClassId |
||
506 | * @return \Eccube\Service\CartService |
||
507 | */ |
||
508 | 5 | public function downProductQuantity($productClassId) |
|
509 | { |
||
510 | 5 | $quantity = $this->getProductQuantity($productClassId) - 1; |
|
511 | |||
512 | 5 | if ($quantity > 0) { |
|
513 | 1 | $this->setProductQuantity($productClassId, $quantity); |
|
514 | } else { |
||
515 | 4 | $this->removeProduct($productClassId); |
|
516 | } |
||
517 | |||
518 | 5 | return $this; |
|
519 | } |
||
520 | |||
521 | /** |
||
522 | * @return array |
||
523 | */ |
||
524 | 40 | public function getProductTypes() |
|
525 | { |
||
526 | |||
527 | 40 | $productTypes = array(); |
|
528 | 40 | foreach ($this->getCart()->getCartItems() as $item) { |
|
529 | /* @var $ProductClass \Eccube\Entity\ProductClass */ |
||
530 | 40 | $ProductClass = $item->getObject(); |
|
531 | 40 | $productTypes[] = $ProductClass->getProductType(); |
|
532 | } |
||
533 | 40 | return array_unique($productTypes); |
|
534 | |||
535 | } |
||
536 | |||
537 | /** |
||
538 | * @return string[] |
||
539 | */ |
||
540 | 3 | public function getErrors() |
|
544 | |||
545 | /** |
||
546 | * @return string[] |
||
547 | */ |
||
548 | 1 | public function getMessages() |
|
549 | { |
||
550 | 1 | return $this->messages; |
|
551 | } |
||
552 | |||
553 | /** |
||
554 | * @param string $message |
||
555 | * @return \Eccube\Service\CartService |
||
556 | */ |
||
557 | 1 | public function setMessage($message) |
|
558 | { |
||
559 | 1 | $this->messages[] = $message; |
|
560 | |||
561 | 1 | return $this; |
|
562 | } |
||
563 | |||
564 | /** |
||
565 | * @return string |
||
566 | */ |
||
567 | 1 | public function getError() |
|
571 | |||
572 | /** |
||
573 | * @param string $error |
||
574 | * @return \Eccube\Service\CartService |
||
575 | */ |
||
576 | 1 | public function setError($error = null) |
|
577 | { |
||
578 | 1 | $this->error = $error; |
|
579 | 1 | $this->session->getFlashBag()->set('eccube.front.request.error', $error); |
|
580 | 1 | return $this; |
|
581 | } |
||
582 | |||
583 | } |
||
584 |