EC-CUBE / ec-cube

src/Eccube/ServiceProvider/DebugServiceProvider.php

Spacing +9 added lines, -9 removed lines

@@ -66,7 +66,7 @@ 
 {
     public function register(Application $app)
     {
-        $app['var_dumper.cloner'] = $app->share(function ($app) {
+        $app['var_dumper.cloner'] = $app->share(function($app) {
             $cloner = new VarCloner();
 
             if (isset($app['debug.max_items'])) {
@@ -80,23 +80,23 @@ 
             return $cloner;
         });
 
-        $app['data_collector.templates'] = $app->share($app->extend('data_collector.templates', function ($templates) {
+        $app['data_collector.templates'] = $app->share($app->extend('data_collector.templates', function($templates) {
             return array_merge($templates, array(array('dump', '@Debug/Profiler/dump.html.twig')));
         }));
 
-        $app['data_collector.dump'] = $app->share(function ($app) {
+        $app['data_collector.dump'] = $app->share(function($app) {
             return new DumpDataCollector($app['stopwatch'], $app['code.file_link_format']);
         });
 
-        $app['data_collectors'] = $app->share($app->extend('data_collectors', function ($collectors, $app) {
-            $collectors['dump'] = $app->share(function ($app) {
+        $app['data_collectors'] = $app->share($app->extend('data_collectors', function($collectors, $app) {
+            $collectors['dump'] = $app->share(function($app) {
                 return $app['data_collector.dump'];
             });
 
             return $collectors;
         }));
 
-        $app['twig'] = $app->share($app->extend('twig', function ($twig, $app) {
+        $app['twig'] = $app->share($app->extend('twig', function($twig, $app) {
             if (class_exists('\Symfony\Bridge\Twig\Extension\DumpExtension')) {
                 $twig->addExtension(new DumpExtension($app['var_dumper.cloner']));
             }
@@ -104,13 +104,13 @@ 
             return $twig;
         }));
 
-        $app['twig.loader.filesystem'] = $app->share($app->extend('twig.loader.filesystem', function ($loader, $app) {
+        $app['twig.loader.filesystem'] = $app->share($app->extend('twig.loader.filesystem', function($loader, $app) {
             $loader->addPath($app['debug.templates_path'], 'Debug');
 
             return $loader;
         }));
 
-        $app['debug.templates_path'] = function () {
+        $app['debug.templates_path'] = function() {
             $r = new \ReflectionClass('Symfony\Bundle\DebugBundle\DependencyInjection\Configuration');
 
             return dirname(dirname($r->getFileName())).'/Resources/views';
@@ -122,7 +122,7 @@ 
         // This code is here to lazy load the dump stack. This default
         // configuration for CLI mode is overridden in HTTP mode on
         // 'kernel.request' event
-        VarDumper::setHandler(function ($var) use ($app) {
+        VarDumper::setHandler(function($var) use ($app) {
             $dumper = new CliDumper();
             $dumper->dump($app['var_dumper.cloner']->cloneVar($var));
         });

src/Eccube/Controller/Admin/Store/PluginController.php

Unused Use Statements -1 removed lines

@@ -36,7 +36,6 @@
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 use Symfony\Component\Routing\Exception\RouteNotFoundException;
 use Symfony\Component\Validator\Constraints as Assert;
-use Symfony\Component\Form\FormError;
 
 class PluginController extends AbstractController
 {

Doc Comments -1 removed lines

@@ -307,7 +307,6 @@
      * 対象プラグインの README を返却します。
      *
      * @param Application $app
-     * @param unknown $code
      */
     public function readme(Application $app, Request $request, $id)
     {

src/Eccube/Form/Type/Admin/SearchProductType.php

Unused Use Statements -1 removed lines

@@ -27,7 +27,6 @@
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\Extension\Core\Type;
 use Symfony\Component\Form\FormBuilderInterface;
-use Symfony\Component\Validator\Constraints as Assert;
 
 class SearchProductType extends AbstractType
 {

src/Eccube/Controller/Admin/Content/CacheController.php

Spacing +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
                 }
                 if ($dir == 'doctrine') {
                     // doctrineが指定された場合は, cache driver経由で削除.
-                    $config =  $app['orm.em']->getConfiguration();
+                    $config = $app['orm.em']->getConfiguration();
                     $this->deleteDoctrineCache($config->getMetadataCacheImpl());
                     $this->deleteDoctrineCache($config->getQueryCacheImpl());
                     $this->deleteDoctrineCache($config->getResultCacheImpl());

src/Eccube/Form/Type/Admin/ChangePasswordType.php

Doc Comments +3 added lines

@@ -36,6 +36,9 @@
 {
     protected $app;
 
+    /**
+     * @param \Silex\Application $app
+     */
     public function __construct($app)
     {
         $this->app = $app;

Unused Use Statements -2 removed lines

@@ -25,8 +25,6 @@
 
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\FormBuilderInterface;
-use Symfony\Component\Form\FormError;
-use Symfony\Component\Form\FormEvents;
 use Symfony\Component\OptionsResolver\OptionsResolverInterface;
 use Symfony\Component\Security\Core\Validator\Constraints\UserPassword;
 use Symfony\Component\Validator\Constraints as Assert;

src/Eccube/Controller/Admin/AdminController.php

Spacing +3 added lines, -3 removed lines

@@ -65,12 +65,12 @@ 
     {
         // install.phpのチェック.
         if (isset($app['config']['eccube_install']) && $app['config']['eccube_install'] == 1) {
-            $file = $app['config']['root_dir'] . '/html/install.php';
+            $file = $app['config']['root_dir'].'/html/install.php';
             if (file_exists($file)) {
                 $message = $app->trans('admin.install.warning', array('installphpPath' => 'html/install.php'));
                 $app->addWarning($message, 'admin');
             }
-            $fileOnRoot = $app['config']['root_dir'] . '/install.php';
+            $fileOnRoot = $app['config']['root_dir'].'/install.php';
             if (file_exists($fileOnRoot)) {
                 $message = $app->trans('admin.install.warning', array('installphpPath' => 'install.php'));
                 $app->addWarning($message, 'admin');
@@ -311,7 +311,7 @@ 
                     t1.status
                 ORDER BY
                     t1.status';
-        $rsm = new ResultSetMapping();;
+        $rsm = new ResultSetMapping(); ;
         $rsm->addScalarResult('status', 'status');
         $rsm->addScalarResult('count', 'count');
         $query = $em->createNativeQuery($sql, $rsm);

src/Eccube/Controller/Admin/Setting/System/MasterdataController.php

Spacing +1 added lines, -1 removed lines

@@ -128,7 +128,7 @@
                 $entityName = str_replace('-', '\\', $data['masterdata_name']);
                 $entity = new $entityName();
                 $rank = 0;
-                $ids = array_map(function ($v) {return $v['id'];}, $data['data']);
+                $ids = array_map(function($v) {return $v['id']; }, $data['data']);
                 foreach ($data['data'] as $key => $value) {
                     if ($value['id'] !== null && $value['name'] !== null) {
                         $entity->setId($value['id']);

src/Eccube/ServiceProvider/EccubeServiceProvider.php

Spacing +59 added lines, -59 removed lines

@@ -41,28 +41,28 @@ 
     public function register(BaseApplication $app)
     {
         // Service
-        $app['eccube.service.system'] = $app->share(function () use ($app) {
+        $app['eccube.service.system'] = $app->share(function() use ($app) {
             return new \Eccube\Service\SystemService($app);
         });
-        $app['view'] = $app->share(function () use ($app) {
+        $app['view'] = $app->share(function() use ($app) {
             return $app['twig'];
         });
-        $app['eccube.service.cart'] = $app->share(function () use ($app) {
+        $app['eccube.service.cart'] = $app->share(function() use ($app) {
             return new \Eccube\Service\CartService($app);
         });
-        $app['eccube.service.order'] = $app->share(function () use ($app) {
+        $app['eccube.service.order'] = $app->share(function() use ($app) {
             return new \Eccube\Service\OrderService($app);
         });
-        $app['eccube.service.tax_rule'] = $app->share(function () use ($app) {
+        $app['eccube.service.tax_rule'] = $app->share(function() use ($app) {
             return new \Eccube\Service\TaxRuleService($app['eccube.repository.tax_rule']);
         });
-        $app['eccube.service.plugin'] = $app->share(function () use ($app) {
+        $app['eccube.service.plugin'] = $app->share(function() use ($app) {
             return new \Eccube\Service\PluginService($app);
         });
-        $app['eccube.service.mail'] = $app->share(function () use ($app) {
+        $app['eccube.service.mail'] = $app->share(function() use ($app) {
             return new \Eccube\Service\MailService($app);
         });
-        $app['eccube.service.csv.export'] = $app->share(function () use ($app) {
+        $app['eccube.service.csv.export'] = $app->share(function() use ($app) {
             $csvService = new \Eccube\Service\CsvExportService();
             $csvService->setEntityManager($app['orm.em']);
             $csvService->setConfig($app['config']);
@@ -74,173 +74,173 @@ 
 
             return $csvService;
         });
-        $app['eccube.service.shopping'] = $app->share(function () use ($app) {
+        $app['eccube.service.shopping'] = $app->share(function() use ($app) {
             return new \Eccube\Service\ShoppingService($app, $app['eccube.service.cart'], $app['eccube.service.order']);
         });
 
         // Repository
-        $app['eccube.repository.master.authority'] = $app->share(function () use ($app) {
+        $app['eccube.repository.master.authority'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\Master\Authority');
         });
-        $app['eccube.repository.master.tag'] = $app->share(function () use ($app) {
+        $app['eccube.repository.master.tag'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\Master\Tag');
         });
-        $app['eccube.repository.master.pref'] = $app->share(function () use ($app) {
+        $app['eccube.repository.master.pref'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\Master\Pref');
         });
-        $app['eccube.repository.master.sex'] = $app->share(function () use ($app) {
+        $app['eccube.repository.master.sex'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\Master\Sex');
         });
-        $app['eccube.repository.master.disp'] = $app->share(function () use ($app) {
+        $app['eccube.repository.master.disp'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\Master\Disp');
         });
-        $app['eccube.repository.master.product_type'] = $app->share(function () use ($app) {
+        $app['eccube.repository.master.product_type'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\Master\ProductType');
         });
-        $app['eccube.repository.master.page_max'] = $app->share(function () use ($app) {
+        $app['eccube.repository.master.page_max'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\Master\PageMax');
         });
-        $app['eccube.repository.master.order_status'] = $app->share(function () use ($app) {
+        $app['eccube.repository.master.order_status'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\Master\OrderStatus');
         });
-        $app['eccube.repository.master.device_type'] = $app->share(function () use ($app) {
+        $app['eccube.repository.master.device_type'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\Master\DeviceType');
         });
-        $app['eccube.repository.master.csv_type'] = $app->share(function () use ($app) {
+        $app['eccube.repository.master.csv_type'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\Master\CsvType');
         });
 
-        $app['eccube.repository.delivery'] = $app->share(function () use ($app) {
+        $app['eccube.repository.delivery'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\Delivery');
         });
-        $app['eccube.repository.delivery_date'] = $app->share(function () use ($app) {
+        $app['eccube.repository.delivery_date'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\DeliveryDate');
         });
-        $app['eccube.repository.delivery_fee'] = $app->share(function () use ($app) {
+        $app['eccube.repository.delivery_fee'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\DeliveryFee');
         });
-        $app['eccube.repository.delivery_time'] = $app->share(function () use ($app) {
+        $app['eccube.repository.delivery_time'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\DeliveryTime');
         });
-        $app['eccube.repository.payment'] = $app->share(function () use ($app) {
+        $app['eccube.repository.payment'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\Payment');
         });
-        $app['eccube.repository.payment_option'] = $app->share(function () use ($app) {
+        $app['eccube.repository.payment_option'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\PaymentOption');
         });
-        $app['eccube.repository.category'] = $app->share(function () use ($app) {
+        $app['eccube.repository.category'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\Category');
         });
-        $app['eccube.repository.customer'] = $app->share(function () use ($app) {
+        $app['eccube.repository.customer'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\Customer');
         });
-        $app['eccube.repository.news'] = $app->share(function () use ($app) {
+        $app['eccube.repository.news'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\News');
         });
-        $app['eccube.repository.mail_history'] = $app->share(function () use ($app) {
+        $app['eccube.repository.mail_history'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\MailHistory');
         });
-        $app['eccube.repository.member'] = $app->share(function () use ($app) {
+        $app['eccube.repository.member'] = $app->share(function() use ($app) {
             $memberRepository = $app['orm.em']->getRepository('Eccube\Entity\Member');
             $memberRepository->setEncoderFactorty($app['security.encoder_factory']);
             return $memberRepository;
         });
-        $app['eccube.repository.order'] = $app->share(function () use ($app) {
+        $app['eccube.repository.order'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\Order');
         });
-        $app['eccube.repository.product'] = $app->share(function () use ($app) {
+        $app['eccube.repository.product'] = $app->share(function() use ($app) {
             $productRepository = $app['orm.em']->getRepository('Eccube\Entity\Product');
             return $productRepository;
         });
-        $app['eccube.repository.product_image'] = $app->share(function () use ($app) {
+        $app['eccube.repository.product_image'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\ProductImage');
         });
-        $app['eccube.repository.product_class'] = $app->share(function () use ($app) {
+        $app['eccube.repository.product_class'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\ProductClass');
         });
-        $app['eccube.repository.product_stock'] = $app->share(function () use ($app) {
+        $app['eccube.repository.product_stock'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\ProductStock');
         });
-        $app['eccube.repository.product_tag'] = $app->share(function () use ($app) {
+        $app['eccube.repository.product_tag'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\ProductTag');
         });
-        $app['eccube.repository.class_name'] = $app->share(function () use ($app) {
+        $app['eccube.repository.class_name'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\ClassName');
         });
-        $app['eccube.repository.class_category'] = $app->share(function () use ($app) {
+        $app['eccube.repository.class_category'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\ClassCategory');
         });
-        $app['eccube.repository.customer_favorite_product'] = $app->share(function () use ($app) {
+        $app['eccube.repository.customer_favorite_product'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\CustomerFavoriteProduct');
         });
-        $app['eccube.repository.base_info'] = $app->share(function () use ($app) {
+        $app['eccube.repository.base_info'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\BaseInfo');
         });
-        $app['eccube.repository.tax_rule'] = $app->share(function () use ($app) {
+        $app['eccube.repository.tax_rule'] = $app->share(function() use ($app) {
             $taxRuleRepository = $app['orm.em']->getRepository('Eccube\Entity\TaxRule');
             $taxRuleRepository->setApplication($app);
 
             return $taxRuleRepository;
         });
-        $app['eccube.repository.page_layout'] = $app->share(function () use ($app) {
+        $app['eccube.repository.page_layout'] = $app->share(function() use ($app) {
             $pageLayoutRepository = $app['orm.em']->getRepository('Eccube\Entity\PageLayout');
             $pageLayoutRepository->setApplication($app);
 
             return $pageLayoutRepository;
         });
-        $app['eccube.repository.block'] = $app->share(function () use ($app) {
+        $app['eccube.repository.block'] = $app->share(function() use ($app) {
             $blockRepository = $app['orm.em']->getRepository('Eccube\Entity\Block');
             $blockRepository->setApplication($app);
 
             return $blockRepository;
         });
-        $app['eccube.repository.order'] = $app->share(function () use ($app) {
+        $app['eccube.repository.order'] = $app->share(function() use ($app) {
             $orderRepository = $app['orm.em']->getRepository('Eccube\Entity\Order');
             $orderRepository->setApplication($app);
 
             return $orderRepository;
         });
-        $app['eccube.repository.customer_address'] = $app->share(function () use ($app) {
+        $app['eccube.repository.customer_address'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\CustomerAddress');
         });
-        $app['eccube.repository.shipping'] = $app->share(function () use ($app) {
+        $app['eccube.repository.shipping'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\Shipping');
         });
-        $app['eccube.repository.customer_status'] = $app->share(function () use ($app) {
+        $app['eccube.repository.customer_status'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\Master\CustomerStatus');
         });
-        $app['eccube.repository.order_status'] = $app->share(function () use ($app) {
+        $app['eccube.repository.order_status'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\Master\OrderStatus');
         });
-        $app['eccube.repository.mail_template'] = $app->share(function () use ($app) {
+        $app['eccube.repository.mail_template'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\MailTemplate');
         });
-        $app['eccube.repository.csv'] = $app->share(function () use ($app) {
+        $app['eccube.repository.csv'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\Csv');
         });
-        $app['eccube.repository.template'] = $app->share(function () use ($app) {
+        $app['eccube.repository.template'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\Template');
         });
-        $app['eccube.repository.authority_role'] = $app->share(function () use ($app) {
+        $app['eccube.repository.authority_role'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\AuthorityRole');
         });
 
-        $app['paginator'] = $app->protect(function () {
+        $app['paginator'] = $app->protect(function() {
             return new \Knp\Component\Pager\Paginator();
         });
 
-        $app['eccube.repository.help'] = $app->share(function () use ($app) {
+        $app['eccube.repository.help'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\Help');
         });
-        $app['eccube.repository.plugin'] = $app->share(function () use ($app) {
+        $app['eccube.repository.plugin'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\Plugin');
         });
-        $app['eccube.repository.plugin_event_handler'] = $app->share(function () use ($app) {
+        $app['eccube.repository.plugin_event_handler'] = $app->share(function() use ($app) {
             return $app['orm.em']->getRepository('Eccube\Entity\PluginEventHandler');
         });
         // em
         if (isset($app['orm.em'])) {
-            $app['orm.em'] = $app->share($app->extend('orm.em', function (\Doctrine\ORM\EntityManager $em, \Silex\Application $app) {
+            $app['orm.em'] = $app->share($app->extend('orm.em', function(\Doctrine\ORM\EntityManager $em, \Silex\Application $app) {
                 // tax_rule
                 $taxRuleRepository = $em->getRepository('Eccube\Entity\TaxRule');
                 $taxRuleRepository->setApplication($app);
@@ -263,13 +263,13 @@ 
         }
 
         // Form\Type
-        $app['form.type.extensions'] = $app->share($app->extend('form.type.extensions', function ($extensions) use ($app) {
+        $app['form.type.extensions'] = $app->share($app->extend('form.type.extensions', function($extensions) use ($app) {
             $extensions[] = new \Eccube\Form\Extension\HelpTypeExtension();
             $extensions[] = new \Eccube\Form\Extension\FreezeTypeExtension();
 
             return $extensions;
         }));
-        $app['form.types'] = $app->share($app->extend('form.types', function ($types) use ($app) {
+        $app['form.types'] = $app->share($app->extend('form.types', function($types) use ($app) {
             $types[] = new \Eccube\Form\Type\NameType($app['config']);
             $types[] = new \Eccube\Form\Type\KanaType($app['config']);
             $types[] = new \Eccube\Form\Type\TelType($app['config']);

src/Eccube/Doctrine/ORM/Query/Extract.php

Spacing +1 added lines, -1 removed lines

@@ -108,7 +108,7 @@
         if ($driver == 'pdo_sqlite') {
             return sprintf("CAST(STRFTIME('%s', %s) AS INTEGER)", $this->formats[$this->field], $this->source->dispatch($sqlWalker));
         } else {
-            return sprintf('EXTRACT(%s FROM %s %s)', $this->field, (string)$this->type, $this->source->dispatch($sqlWalker));
+            return sprintf('EXTRACT(%s FROM %s %s)', $this->field, (string) $this->type, $this->source->dispatch($sqlWalker));
         }
     }
 }
\ No newline at end of file