DoctrineOrmExtension::buildForm() - Code Metrics - Inspection of "エンティティからフォームを生成する機構の追加" - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — experimental/3.1 (#2268)

by chihiro

created 2017-04-13 00:56 UTC

DoctrineOrmExtension::buildForm() C

↳ Parent: DoctrineOrmExtension

Complexity

Conditions	7
Paths	1

Size

Total Lines	35
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	7
eloc	20
c	0
b	0
f	0
nc	1
nop	2
dl	0
loc	35
rs	6.7272

<?php
/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 */
namespace Eccube\Form\Extension;

use Doctrine\ORM\EntityManager;
use Eccube\Application;
use Symfony\Component\Form\AbstractTypeExtension;
use Symfony\Component\Form\Extension\Core\Type\FormType;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\Form\FormEvent;
use Symfony\Component\Form\FormEvents;

class DoctrineOrmExtension extends AbstractTypeExtension

{
    /**
     * @var EntityManager
     */
    protected $em;

    public function __construct(EntityManager $em)
function someFunction(ManagerRegistry $registry) {
    $em = $registry->getManager();
    $em->getConnection()->beginTransaction();
    try {
        // Do something.
        $em->getConnection()->commit();
    } catch (\Exception $ex) {
        $em->getConnection()->rollback();
        $em->close();

        throw $ex;
    }
}
    {
        $this->em = $em;
    }

    /**
     * {@inheritdoc}
     */
    public function buildForm(FormBuilderInterface $builder, array $options)
    {
        $builder->addEventListener(
            FormEvents::PRE_SET_DATA,
            function (FormEvent $event) {
                $form = $event->getForm();
                $config = $form->getConfig();
                // data_classオプションが必要
                $class = $config->getDataClass();
                if (is_null($class)) {
                    return;
                }
                // メタデータの取得
                try {
                    $meta = $this->em->getClassMetadata($class);
                } catch (\Exception $e) {
                    return;
                }
                // フィールドからフォームへ定義
                $names = $meta->getFieldNames();
                foreach ($names as $name) {
                    $mapping = $meta->getFieldMapping($name);
                    // eccube_form_renderがtrueのときに実行
                    // -> @ORM\Column(..., options={"eccube_form_render": true})
                    if (isset($mapping['options']['eccube_form_render']) && $mapping['options']['eccube_form_render']) {
                        $fieldName = $mapping['fieldName'];
                        if (!isset($form[$fieldName])) {
                            $form->add($mapping['fieldName']);
                        }
                    }
                }
                // TODO Assosiationも対応する
            }
        );
    }

    public function getExtendedType()

    {
        return FormType::class;
    }
}


1			<?php
2			/*
3			* This file is part of EC-CUBE
4			*
5			* Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
6			*
7			* http://www.lockon.co.jp/
8			*
9			* This program is free software; you can redistribute it and/or
10			* modify it under the terms of the GNU General Public License
11			* as published by the Free Software Foundation; either version 2
12			* of the License, or (at your option) any later version.
13			*
14			* This program is distributed in the hope that it will be useful,
15			* but WITHOUT ANY WARRANTY; without even the implied warranty of
16			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17			* GNU General Public License for more details.
18			*
19			* You should have received a copy of the GNU General Public License
20			* along with this program; if not, write to the Free Software
21			* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
22			*/
23			namespace Eccube\Form\Extension;
24
25			use Doctrine\ORM\EntityManager;
26			use Eccube\Application;
27			use Symfony\Component\Form\AbstractTypeExtension;
28			use Symfony\Component\Form\Extension\Core\Type\FormType;
29			use Symfony\Component\Form\FormBuilderInterface;
30			use Symfony\Component\Form\FormEvent;
31			use Symfony\Component\Form\FormEvents;
32
33			class DoctrineOrmExtension extends AbstractTypeExtension
			0 ignored issues – show introduced 2017-04-11 09:55 UTC by Report Bug Copy Issue Report Missing class doc comment Loading history...
34			{
35			/**
36			* @var EntityManager
37			*/
38			protected $em;
39
40			public function __construct(EntityManager $em)
			0 ignored issues – show Bug introduced 2017-04-13 02:47 UTC by Report Bug Copy Issue Report You have injected the EntityManager via parameter `$em`. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via `getManager()` each time you need it. The `EntityManager` might become unusable for example if a transaction is rolled back and it gets closed. Let’s assume that somewhere in your application, or in a third-party library, there is code such as the following: function someFunction(ManagerRegistry $registry) { $em = $registry->getManager(); $em->getConnection()->beginTransaction(); try { // Do something. $em->getConnection()->commit(); } catch (\Exception $ex) { $em->getConnection()->rollback(); $em->close(); throw $ex; } } If that code throws an exception and the `EntityManager` is closed. Any other code which depends on the same instance of the `EntityManager` during this request will fail. On the other hand, if you instead inject the `ManagerRegistry`, the `getManager()` method guarantees that you will always get a usable manager instance. Loading history... introduced 2017-04-13 02:47 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
41			{
42			$this->em = $em;
43			}
44
45			/**
46			* {@inheritdoc}
47			*/
48			public function buildForm(FormBuilderInterface $builder, array $options)
49			{
50			$builder->addEventListener(
51			FormEvents::PRE_SET_DATA,
52			function (FormEvent $event) {
53			$form = $event->getForm();
54			$config = $form->getConfig();
55			// data_classオプションが必要
56			$class = $config->getDataClass();
57			if (is_null($class)) {
58			return;
59			}
60			// メタデータの取得
61			try {
62			$meta = $this->em->getClassMetadata($class);
63			} catch (\Exception $e) {
64			return;
65			}
66			// フィールドからフォームへ定義
67			$names = $meta->getFieldNames();
68			foreach ($names as $name) {
69			$mapping = $meta->getFieldMapping($name);
70			// eccube_form_renderがtrueのときに実行
71			// -> @ORM\Column(..., options={"eccube_form_render": true})
72			if (isset($mapping['options']['eccube_form_render']) && $mapping['options']['eccube_form_render']) {
73			$fieldName = $mapping['fieldName'];
74			if (!isset($form[$fieldName])) {
75			$form->add($mapping['fieldName']);
76			}
77			}
78			}
79			// TODO Assosiationも対応する
80			}
81			);
82			}
83
84			public function getExtendedType()
			0 ignored issues – show introduced 2017-04-11 09:55 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
85			{
86			return FormType::class;
87			}
88			}
89

EC-CUBE / ec-cube

Pull Request — experimental/3.1 (#2268)

DoctrineOrmExtension::buildForm() C

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like