Eccube\Controller\Admin\Setting\Shop\TaxRuleController

Complexity

Total Complexity

16

Size/Duplication

Total Lines	206
Duplicated Lines	11.65 %

Coupling/Cohesion

Components	0
Dependencies	10

Test Coverage

Coverage

96.67%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
B	index()	0	73	6
B	delete()	0	26	3
B	editParameter()	24	42	3
B	isValid()	0	35	4

<?php
/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 */


namespace Eccube\Controller\Admin\Setting\Shop;

use Doctrine\ORM\EntityManager;
use Eccube\Application;
use Eccube\Controller\AbstractController;
use Eccube\Event\EccubeEvents;
use Eccube\Event\EventArgs;
use Symfony\Component\Form\Form;
use Symfony\Component\Form\FormError;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

class TaxRuleController extends AbstractController

Missing class doc comment

{

    /**
     * 税率設定の初期表示・登録
     *
     * @param Application $app
     * @param Request $request

Expected 5 spaces after parameter type; 1 found

     * @param null $id

Expected 8 spaces after parameter type; 1 found

     * @return \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response
     */
    public function index(Application $app, Request $request, $id = null)
    {
        $TargetTaxRule = null;

$TargetTaxRule is not used, you could remove the assignment.

        if ($id == null) {
            $TargetTaxRule = $app['eccube.repository.tax_rule']->newTaxRule();
        } else {
            $TargetTaxRule = $app['eccube.repository.tax_rule']->find($id);
            if (is_null($TargetTaxRule)) {
                throw new NotFoundHttpException();
            }
        }

        /** @var  $BaseInfo \Eccube\Entity\BaseInfo */
        $BaseInfo = $app['eccube.repository.base_info']->get();

        $builder = $app['form.factory']
            ->createBuilder('tax_rule', $TargetTaxRule);

        $builder
            ->get('option_product_tax_rule')
            ->setData($BaseInfo->getOptionProductTaxRule());

        if ($TargetTaxRule->isDefaultTaxRule()) {
            // 基本税率設定は適用日時の変更は行わない
            $builder = $builder->remove('apply_date');
        }

        $event = new EventArgs(
            array(
                'builder' => $builder,
                'BaseInfo' => $BaseInfo,
                'TargetTaxRule' => $TargetTaxRule,
            ),
            $request
        );
        $app['eccube.event.dispatcher']->dispatch(EccubeEvents::ADMIN_SETTING_SHOP_TAX_RULE_INDEX_INITIALIZE, $event);

        /* @var $form \Symfony\Component\Form\FormInterface */
        $form = $builder->getForm();

        if ('POST' === $request->getMethod()) {
            $form->handleRequest($request);
            if ($this->isValid($app['orm.em'], $form)) {

$form of type object<Symfony\Component\Form\FormInterface> is not a sub-type of object<Symfony\Component\Form\Form>. It seems like you assume a concrete implementation of the interface Symfony\Component\Form\FormInterface to be always present.

                $app['orm.em']->persist($TargetTaxRule);

                $app['orm.em']->flush();

                $event = new EventArgs(
                    array(
                        'form' => $form,
                        'BaseInfo' => $BaseInfo,
                        'TargetTaxRule' => $TargetTaxRule,
                    ),
                    $request
                );
                $app['eccube.event.dispatcher']->dispatch(EccubeEvents::ADMIN_SETTING_SHOP_TAX_RULE_INDEX_COMPLETE, $event);

                $app->addSuccess('admin.shop.tax.save.complete', 'admin');

                return $app->redirect($app->url('admin_setting_shop_tax'));
            }
        }

        // 共通税率一覧
        $TaxRules = $app['eccube.repository.tax_rule']->getList();

        return $app->render('Setting/Shop/tax_rule.twig', array(
            'TargetTaxRule' => $TargetTaxRule,
            'TaxRules' => $TaxRules,
            'form' => $form->createView(),
        ));
    }

    /**

Doc comment for parameter "$id" missing

     * 税率設定の削除
     *
     * @param Application $app
     * @param Request $request

Expected 5 spaces after parameter type; 1 found

     * @param $id

Missing parameter name

     * @return \Symfony\Component\HttpFoundation\RedirectResponse
     */
    public function delete(Application $app, Request $request, $id)
    {
        $this->isTokenValid($app);

        $TargetTaxRule = $app['eccube.repository.tax_rule']->find($id);
        if (!$TargetTaxRule) {
            $app->deleteMessage();
            return $app->redirect($app->url('admin_setting_shop_tax'));

Missing blank line before return statement

        }

        if (!$TargetTaxRule->isDefaultTaxRule()) {
            $app['eccube.repository.tax_rule']->delete($TargetTaxRule);

            $event = new EventArgs(
                array(
                    'TargetTaxRule' => $TargetTaxRule,
                ),
                $request
            );
            $app['eccube.event.dispatcher']->dispatch(EccubeEvents::ADMIN_SETTING_SHOP_TAX_RULE_DELETE_COMPLETE, $event);

            $app->addSuccess('admin.shop.tax.delete.complete', 'admin');
        }

        return $app->redirect($app->url('admin_setting_shop_tax'));
    }

    /**
     * 軽減税率の有効/無効設定
     *
     * @param Application $app
     * @param Request $request

Expected 5 spaces after parameter type; 1 found

     * @return \Symfony\Component\HttpFoundation\RedirectResponse
     */
    public function editParameter(Application $app, Request $request)
    {
        $builder = $app['form.factory']
            ->createBuilder('tax_rule');

        $event = new EventArgs(
            array(
                'builder' => $builder,
            ),
            $request
        );
        $app['eccube.event.dispatcher']->dispatch(EccubeEvents::ADMIN_SETTING_SHOP_TAX_RULE_EDIT_PARAMETER_INITIALIZE, $event);

        $form = $builder->getForm();

        if ('POST' === $request->getMethod()) {

This code seems to be duplicated across your project.

            $form->handleRequest($request);

            // 軽減税率設定の項目のみ処理する
            $optionForm = $form->get('option_product_tax_rule');
            if ($optionForm->isValid()) {
                /** @var  $BaseInfo \Eccube\Entity\BaseInfo */
                $BaseInfo = $app['eccube.repository.base_info']->get();
                $BaseInfo->setOptionProductTaxRule($optionForm->getData());

                $app['orm.em']->flush();

                $event = new EventArgs(
                    array(
                        'form' => $form,
                        'BaseInfo' => $BaseInfo,
                    ),
                    $request
                );
                $app['eccube.event.dispatcher']->dispatch(EccubeEvents::ADMIN_SETTING_SHOP_TAX_RULE_EDIT_PARAMETER_COMPLETE, $event);

                $app->addSuccess('admin.shop.tax.save.complete', 'admin');
            }
        }

        return $app->redirect($app->url('admin_setting_shop_tax'));
    }

    protected function isValid(EntityManager $em, Form $form)
    {
        if (!$form->isValid()) {
            return false;
        }
        /**
         * 同一日時のエラーチェック.
         */
        /** @var $TargetTaxRule \Eccube\Entity\TaxRule */
        $TargetTaxRule = $form->getData();
        $parameters = array();
        $parameters['apply_date'] = $TargetTaxRule->getApplyDate();
        $qb = $em
            ->getRepository('Eccube\Entity\TaxRule')
            ->createQueryBuilder('t')
            ->select('count(t.id)')
            ->where('t.apply_date = :apply_date');
        // 編集時は, 編集対象をのぞいて検索.
        if ($TargetTaxRule->getId()) {
            $qb->andWhere('t.id <> :id');
            $parameters['id'] = $TargetTaxRule->getId();
        }
        $qb->setParameters($parameters);
        $count = $qb
            ->getQuery()
            ->getSingleScalarResult();
        // 同じ適用日時の登録データがあればエラーとする.
        if ($count > 0) {
            $form['apply_date']->addError(new FormError('既に同じ適用日時で登録されています。'));

            return false;
        }

        return true;
    }
}