Eccube\Service\PurchaseFlow\Processor\OrderCodePurchaseProcessor

Complexity

Total Complexity

12

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
C	process()	0	38	11

<?php

namespace Eccube\Service\PurchaseFlow\Processor;

use Eccube\Entity\ItemHolderInterface;
use Eccube\Service\PurchaseFlow\PurchaseContext;
use Eccube\Service\PurchaseFlow\PurchaseProcessor;
use Eccube\Service\PurchaseFlow\ProcessResult;
use Doctrine\ORM\EntityManager;

class OrderCodePurchaseProcessor implements PurchaseProcessor

Missing class doc comment

{
    

Please trim any trailing whitespace

    private $orderNoFormat;
    

Please trim any trailing whitespace

    private $entityManager;
    

Please trim any trailing whitespace

    public function __construct(EntityManager $entityManager, $orderNoFormat)

You have injected the EntityManager via parameter $entityManager. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via getManager() each time you need it.

Missing function doc comment

    {
        $this->entityManager = $entityManager;
        

Please trim any trailing whitespace

        $this->orderNoFormat = $orderNoFormat;
    }
    

Please trim any trailing whitespace

    /**
     * {@inheritdoc}
     */
    public function process(ItemHolderInterface $itemHolder, PurchaseContext $context)
    {
        $Order = $itemHolder;
        

Please trim any trailing whitespace

        if ($Order instanceof \Eccube\Entity\Order) {
            if ($Order->getCode() == "") {
                if (is_null($Order->getId())) {
                    $this->entityManager->persist($Order);
                    $this->entityManager->flush();
                }
                

Please trim any trailing whitespace

                $orderCode = preg_replace_callback('/\${(.*)}/U', function($matches) use ($Order) {

Expected 1 space after FUNCTION keyword; 0 found

                    if (count($matches) == 2) {
                        switch ($matches[1]) {
                            case "yyyy":
                                return date('Y');
                            case "mm":
                                return date('m');
                            case "dd":
                                return date('d');
                            default:
                                $no = explode(',', $matches[1]);
                                if (count($no) == 2 && $no[0] == 'number' && is_numeric($no[1])) {
                                    return sprintf("%0{$no[1]}d", $Order->getId());
                                }
                                return "";

Missing blank line before return statement

                        }
                    }
                    

Please trim any trailing whitespace

                    return "";
                }, $this->orderNoFormat);
                

Please trim any trailing whitespace

                $Order->setCode($orderCode);
            }
        }
        

Please trim any trailing whitespace

        return ProcessResult::success();
    }
}