Eccube\Service\CartService

Complexity

Total Complexity

37

Size/Duplication

Total Lines	266
Duplicated Lines	6.77 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

88.73%

Importance

Changes	1
Bugs	0	Features	0

15 Methods

Rating	Name	Duplication	Size	Complexity
A	getCarts()	0	8	2
A	getCart()	0	11	3
A	loadItems()	0	11	3
B	mergeAllCartItems()	0	25	6
A	restoreCarts()	0	19	3
C	addProduct()	9	32	7
B	removeProduct()	9	29	5
A	save()	0	4	1
A	unlock()	0	6	1
A	lock()	0	6	1
A	isLocked()	0	4	1
A	setPreOrderId()	0	6	1
A	getPreOrderId()	0	4	1
A	clear()	0	10	1
A	setCartItemComparator()	0	4	1

<?php
/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 */


namespace Eccube\Service;

use Doctrine\ORM\EntityManager;
use Eccube\Annotation\Inject;
use Eccube\Annotation\Service;
use Eccube\Entity\Cart;
use Eccube\Entity\CartItem;
use Eccube\Entity\ItemHolderInterface;
use Eccube\Entity\ProductClass;
use Eccube\Repository\ProductClassRepository;
use Eccube\Service\Cart\CartItemAllocator;
use Eccube\Service\Cart\CartItemComparator;
use Symfony\Component\HttpFoundation\Session\Session;

/**
 * @Service
 */
class CartService
{
    /**
     * @var Session
     * @Inject("session")
     */
    protected $session;

    /**
     * @var EntityManager
     * @Inject("orm.em")
     */
    protected $em;

    /**
     * @var ItemHolderInterface
     * @deprecated
     */
    protected $cart;

    /**
     * @var ProductClassRepository
     * @Inject(ProductClassRepository::class)
     */
    protected $productClassRepository;

    /**
     * @var CartItemComparator
     * @Inject(CartItemComparator::class)
     */
    protected $cartItemComparator;

    /**
     * @var CartItemAllocator
     * @Inject(CartItemAllocator::class)
     */
    protected $cartItemAllocator;

    /**
     * @var Cart[]
     */
    protected $carts;

    public function getCarts()

Missing function doc comment

    {
        if (is_null($this->carts)) {
            $this->carts = $this->session->get('carts', []);

It seems like $this->session->get('carts', array()) of type * is incompatible with the declared type array<integer,object<Eccube\Entity\Cart>> of property $carts.

            $this->loadItems();
        }
        return $this->carts;

Missing blank line before return statement

    }

    /**
     * @return ItemHolderInterface|Cart
     */
    public function getCart()
    {
        $Carts = $this->getCarts();
        if (!$Carts) {
            if (!$this->cart) {

The property Eccube\Service\CartService::$cart has been deprecated.

                $this->cart = new Cart();

It seems like new \Eccube\Entity\Cart() of type object<Eccube\Entity\Cart> is incompatible with the declared type object<Eccube\Entity\ItemHolderInterface> of property $cart.

The property Eccube\Service\CartService::$cart has been deprecated.

            }
            return $this->cart;

The property Eccube\Service\CartService::$cart has been deprecated.

Missing blank line before return statement

        }
        return current($this->getCarts());

Missing blank line before return statement

    }

    protected function loadItems()
    {
        foreach ($this->getCarts() as $Cart) {
            /** @var CartItem $item */
            foreach ($Cart->getItems() as $item) {
                /** @var ProductClass $ProductClass */
                $ProductClass = $this->productClassRepository->find($item->getProductClassId());
                $item->setProductClass($ProductClass);
            }
        }
    }

    /**
     * @param CartItem[] $cartItems
     * @return CartItem[]
     */
    protected function mergeAllCartItems($cartItems = [])
    {
        /** @var CartItem[] $allCartItems */
        $allCartItems = $cartItems;

        foreach ($this->getCarts() as $Cart) {
            /** @var CartItem $item */
            foreach ($Cart->getItems() as $item) {
                $itemExists = false;
                foreach ($allCartItems as $itemInArray) {
                    // 同じ明細があればマージする
                    if ($this->cartItemComparator->compare($item, $itemInArray)) {
                        $itemInArray->setQuantity($itemInArray->getQuantity() + $item->getQuantity());
                        $itemExists = true;
                        break;
                    }
                }
                if (!$itemExists) {
                    $allCartItems[] = $item;
                }
            }
        }

        return $allCartItems;
    }

    protected function restoreCarts($cartItems)
    {
        /** @var Cart $Carts */
        $Carts = [];

        foreach ($cartItems as $item) {
            $cartId = $this->cartItemAllocator->allocate($item);
            if (isset($Carts[$cartId])) {
                $Carts[$cartId]->addCartItem($item);
            } else {
                $Cart = new Cart();
                $Cart->addCartItem($item);
                $Carts[$cartId] = $Cart;
            }
        }

        $this->session->set('carts', $Carts);
        $this->carts = $Carts;

It seems like $Carts of type object<Eccube\Entity\Cart> is incompatible with the declared type array<integer,object<Eccube\Entity\Cart>> of property $carts.

    }

    /**

Doc comment for parameter "$ProductClass" missing

Doc comment for parameter "$quantity" missing

     * カートに商品を追加します.
     * @param $ProductClass ProductClass 商品規格

Missing parameter name

     * @param $quantity int 数量

Missing parameter name

     * @return bool 商品を追加できた場合はtrue
     */
    public function addProduct($ProductClass, $quantity = 1)

Declare public methods first, then protected ones and finally private ones

    {
        if (!$ProductClass instanceof ProductClass) {
            $ProductClassId = $ProductClass;
            $ProductClass = $this->em
                ->getRepository(ProductClass::class)
                ->find($ProductClassId);
            if (is_null($ProductClass)) {
                return false;
            }
        }

        $ClassCategory1 = $ProductClass->getClassCategory1();
        if ($ClassCategory1 && !$ClassCategory1->isVisible()) {
            return false;
        }
        $ClassCategory2 = $ProductClass->getClassCategory2();
        if ($ClassCategory2 && !$ClassCategory2->isVisible()) {
            return false;
        }

        $newItem = new CartItem();
        $newItem->setQuantity($quantity);
        $newItem->setPrice($ProductClass->getPrice01IncTax());
        $newItem->setProductClass($ProductClass);

        $allCartItems = $this->mergeAllCartItems([$newItem]);
        $this->restoreCarts($allCartItems);


        return true;
    }

    public function removeProduct($ProductClass)

Missing function doc comment

    {
        if (!$ProductClass instanceof ProductClass) {
            $ProductClassId = $ProductClass;
            $ProductClass = $this->em
                ->getRepository(ProductClass::class)
                ->find($ProductClassId);
            if (is_null($ProductClass)) {
                return false;
            }
        }

        $removeItem = new CartItem();
        $removeItem->setPrice($ProductClass->getPrice01IncTax());
        $removeItem->setProductClass($ProductClass);

        $allCartItems = $this->mergeAllCartItems();
        $foundIndex = -1;
        foreach ($allCartItems as $index=>$itemInCart) {

Expected 1 space before "=>"; 0 found

Expected 1 space after "=>"; 0 found

            if ($this->cartItemComparator->compare($itemInCart, $removeItem)) {
                $foundIndex = $index;
                break;
            }
        }
        array_splice($allCartItems, $foundIndex, 1);
        $this->restoreCarts($allCartItems);

        return true;
    }

    public function save()

Missing function doc comment

    {
        return $this->session->set('carts', $this->carts);
    }

    public function unlock()

Missing function doc comment

    {
        $this->getCart()
            ->setLock(false)
            ->setPreOrderId(null);
    }

    public function lock()

Missing function doc comment

    {
        $this->getCart()
            ->setLock(true)
            ->setPreOrderId(null);
    }

    /**
     * @return bool
     */
    public function isLocked()
    {
        return $this->getCart()->getLock();
    }

    /**
     * @param  string $pre_order_id
     * @return \Eccube\Service\CartService
     */
    public function setPreOrderId($pre_order_id)
    {
        $this->getCart()->setPreOrderId($pre_order_id);

        return $this;
    }

    /**
     * @return string
     */
    public function getPreOrderId()
    {
        return $this->getCart()->getPreOrderId();
    }

    /**
     * @return \Eccube\Service\CartService
     */
    public function clear()
    {
        $this->getCart()
            ->setPreOrderId(null)
            ->setLock(false)
            ->setTotalPrice(0)
            ->clearCartItems();

        return $this;
    }

    /**
     * @param CartItemComparator $cartItemComparator
     */
    public function setCartItemComparator($cartItemComparator)
    {
        $this->cartItemComparator = $cartItemComparator;
    }
}