EC-CUBE / ec-cube

src/Eccube/Repository/PluginEventHandlerRepository.php

Indentation +15 added lines, -15 removed lines

@@ -73,17 +73,17 @@ 
 
         $qb = $this->createQueryBuilder('e');
         $qb->andWhere("e.priority >= $range_end ")
-           ->andWhere("e.priority <= $range_start ")
-           ->andWhere('e.event = :event')
-           ->setParameter('event',$event)
-           ->setMaxResults(1)
-           ->orderBy('e.priority','ASC');
+            ->andWhere("e.priority <= $range_start ")
+            ->andWhere('e.event = :event')
+            ->setParameter('event',$event)
+            ->setMaxResults(1)
+            ->orderBy('e.priority','ASC');
 
         $result=$qb->getQuery()->getResult();
         if(count($result)){
-             return $result[0]->getPriority() -1;
+                return $result[0]->getPriority() -1;
         }else{
-             return $range_start;
+                return $range_start;
         }
 
     }
@@ -96,14 +96,14 @@ 
         $qb = $this->createQueryBuilder('e');
 
         $qb->andWhere("e.priority >= $range_end ")
-           ->andWhere("e.priority <= $range_start ")
-           ->andWhere("e.del_flg = 0 ") 
-           ->andWhere('e.priority '.($up ?  '>' : '<' ).' :pri')
-           ->andWhere('e.event = :event')
-           ->setParameter('event',$pluginEventHandler->getEvent())
-           ->setParameter('pri',  $pluginEventHandler->getPriority()  )
-           ->setMaxResults(1)
-           ->orderBy('e.priority', ($up ? 'ASC':'DESC' )  );
+            ->andWhere("e.priority <= $range_start ")
+            ->andWhere("e.del_flg = 0 ") 
+            ->andWhere('e.priority '.($up ?  '>' : '<' ).' :pri')
+            ->andWhere('e.event = :event')
+            ->setParameter('event',$pluginEventHandler->getEvent())
+            ->setParameter('pri',  $pluginEventHandler->getPriority()  )
+            ->setMaxResults(1)
+            ->orderBy('e.priority', ($up ? 'ASC':'DESC' )  );
 
         $result=$qb->getQuery()->getResult();
 

Spacing +31 added lines, -31 removed lines

@@ -42,8 +42,8 @@ 
         $qb = $this->createQueryBuilder('e')
             ->innerJoin('e.Plugin', 'p')
             ->andWhere('e.del_flg = 0 ')  
-            ->Orderby('e.event','ASC') 
-            ->addOrderby('e.priority','DESC');
+            ->Orderby('e.event', 'ASC') 
+            ->addOrderby('e.priority', 'DESC');
             ;
 
         return $qb->getQuery()->getResult();
@@ -52,66 +52,66 @@ 
     public function getPriorityRange($type)
     {
 
-        if(PluginEventHandler::EVENT_HANDLER_TYPE_FIRST==$type){
-            $range_start=PluginEventHandler::EVENT_PRIORITY_FIRST_START;
-            $range_end=PluginEventHandler::EVENT_PRIORITY_FIRST_END;
-        }elseif(PluginEventHandler::EVENT_HANDLER_TYPE_LAST==$type){
-            $range_start=PluginEventHandler::EVENT_PRIORITY_LAST_START;
-            $range_end=PluginEventHandler::EVENT_PRIORITY_LAST_END;
-        }else{
-            $range_start=PluginEventHandler::EVENT_PRIORITY_NORMAL_START;
-            $range_end=PluginEventHandler::EVENT_PRIORITY_NORMAL_END;
+        if (PluginEventHandler::EVENT_HANDLER_TYPE_FIRST == $type) {
+            $range_start = PluginEventHandler::EVENT_PRIORITY_FIRST_START;
+            $range_end = PluginEventHandler::EVENT_PRIORITY_FIRST_END;
+        }elseif (PluginEventHandler::EVENT_HANDLER_TYPE_LAST == $type) {
+            $range_start = PluginEventHandler::EVENT_PRIORITY_LAST_START;
+            $range_end = PluginEventHandler::EVENT_PRIORITY_LAST_END;
+        } else {
+            $range_start = PluginEventHandler::EVENT_PRIORITY_NORMAL_START;
+            $range_end = PluginEventHandler::EVENT_PRIORITY_NORMAL_END;
         }
-        return array($range_start,$range_end);
+        return array($range_start, $range_end);
 
     }
 
-    public function calcNewPriority($event , $type)
+    public function calcNewPriority($event, $type)
     {
 
-        list($range_start,$range_end) = $this->getPriorityRange($type);
+        list($range_start, $range_end) = $this->getPriorityRange($type);
 
         $qb = $this->createQueryBuilder('e');
         $qb->andWhere("e.priority >= $range_end ")
            ->andWhere("e.priority <= $range_start ")
            ->andWhere('e.event = :event')
-           ->setParameter('event',$event)
+           ->setParameter('event', $event)
            ->setMaxResults(1)
-           ->orderBy('e.priority','ASC');
+           ->orderBy('e.priority', 'ASC');
 
-        $result=$qb->getQuery()->getResult();
-        if(count($result)){
-             return $result[0]->getPriority() -1;
-        }else{
+        $result = $qb->getQuery()->getResult();
+        if (count($result)) {
+             return $result[0]->getPriority() - 1;
+        } else {
              return $range_start;
         }
 
     }
 
-    public function upPriority($pluginEventHandler,$up=true)
+    public function upPriority($pluginEventHandler, $up = true)
     {
 
-        list($range_start,$range_end) = $this->getPriorityRange($pluginEventHandler->getHandlerType());
+        list($range_start, $range_end) = $this->getPriorityRange($pluginEventHandler->getHandlerType());
 
         $qb = $this->createQueryBuilder('e');
 
         $qb->andWhere("e.priority >= $range_end ")
            ->andWhere("e.priority <= $range_start ")
            ->andWhere("e.del_flg = 0 ") 
-           ->andWhere('e.priority '.($up ?  '>' : '<' ).' :pri')
+           ->andWhere('e.priority '.($up ? '>' : '<').' :pri')
            ->andWhere('e.event = :event')
-           ->setParameter('event',$pluginEventHandler->getEvent())
-           ->setParameter('pri',  $pluginEventHandler->getPriority()  )
+           ->setParameter('event', $pluginEventHandler->getEvent())
+           ->setParameter('pri', $pluginEventHandler->getPriority())
            ->setMaxResults(1)
-           ->orderBy('e.priority', ($up ? 'ASC':'DESC' )  );
+           ->orderBy('e.priority', ($up ? 'ASC' : 'DESC'));
 
-        $result=$qb->getQuery()->getResult();
+        $result = $qb->getQuery()->getResult();
 
-        if(count($result)){
-            $em =$this->getEntityManager();
+        if (count($result)) {
+            $em = $this->getEntityManager();
             $em->getConnection()->beginTransaction();
             // 2個のentityのprioriryを入れ替える
-            $tmp=$pluginEventHandler->getPriority();
+            $tmp = $pluginEventHandler->getPriority();
             $pluginEventHandler->setPriority($result[0]->getPriority());
             $result[0]->setPriority($tmp);
             $em->persist($result[0]);
@@ -119,7 +119,7 @@ 
             $em->flush();
             $em->getConnection()->commit();
             # 移動する
-        }else{
+        } else {
             # 移動しない
             throw new PluginException("Can't swap");
         }

Braces +4 added lines, -4 removed lines

@@ -55,10 +55,10 @@ 
         if(PluginEventHandler::EVENT_HANDLER_TYPE_FIRST==$type){
             $range_start=PluginEventHandler::EVENT_PRIORITY_FIRST_START;
             $range_end=PluginEventHandler::EVENT_PRIORITY_FIRST_END;
-        }elseif(PluginEventHandler::EVENT_HANDLER_TYPE_LAST==$type){
+        } elseif(PluginEventHandler::EVENT_HANDLER_TYPE_LAST==$type){
             $range_start=PluginEventHandler::EVENT_PRIORITY_LAST_START;
             $range_end=PluginEventHandler::EVENT_PRIORITY_LAST_END;
-        }else{
+        } else{
             $range_start=PluginEventHandler::EVENT_PRIORITY_NORMAL_START;
             $range_end=PluginEventHandler::EVENT_PRIORITY_NORMAL_END;
         }
@@ -82,7 +82,7 @@ 
         $result=$qb->getQuery()->getResult();
         if(count($result)){
              return $result[0]->getPriority() -1;
-        }else{
+        } else{
              return $range_start;
         }
 
@@ -119,7 +119,7 @@ 
             $em->flush();
             $em->getConnection()->commit();
             # 移動する
-        }else{
+        } else{
             # 移動しない
             throw new PluginException("Can't swap");
         }

src/Eccube/Security/Core/Encoder/PasswordEncoder.php

Spacing +2 added lines, -2 removed lines

@@ -53,7 +53,7 @@ 
         if ($this->config['auth_type'] == 'PLAIN') {
             $res = $raw;
         } else {
-            $res = hash_hmac($this->config['password_hash_algos'], $raw . ':' . $this->config['auth_magic'], $salt);
+            $res = hash_hmac($this->config['password_hash_algos'], $raw.':'.$this->config['auth_magic'], $salt);
         }
 
         return $res;
@@ -81,7 +81,7 @@ 
         } else {
             // 旧バージョン(2.11未満)からの移行を考慮
             if (empty($salt)) {
-                $hash = sha1($raw . ':' . $this->config['auth_magic']);
+                $hash = sha1($raw.':'.$this->config['auth_magic']);
             } else {
                 $hash = $this->encodePassword($raw, $salt);
             }

src/Eccube/Util/Str.php

Spacing +5 added lines, -5 removed lines

@@ -159,7 +159,7 @@ 
             return $value;
         }
 
-        return rtrim(mb_substr($value, 0, $length, 'UTF-8')) . $end;
+        return rtrim(mb_substr($value, 0, $length, 'UTF-8')).$end;
     }
 
 
@@ -186,18 +186,18 @@ 
         }
         if ($diff->m == 1 || $diff->days > 0) {
             if ($diff->days <= 31) {
-                return $diff->days . '日前';
+                return $diff->days.'日前';
             }
             // return $date->format("Y/m/d H:i");
             return $date->format("Y/m/d");
         }
         if ($diff->h > 0) {
-            return $diff->h . "時間前";
+            return $diff->h."時間前";
         }
         if ($diff->i > 0) {
-            return $diff->i . "分前";
+            return $diff->i."分前";
         }
-        return $diff->s . "秒前";
+        return $diff->s."秒前";
     }
 
     /**

src/Eccube/Form/Type/Admin/AuthorityRoleType.php

Spacing +1 added lines, -1 removed lines

@@ -59,7 +59,7 @@
                 'label' => '拒否URL',
                 'required' => false,
             ))
-            ->addEventListener(FormEvents::POST_SUBMIT, function (FormEvent $event) {
+            ->addEventListener(FormEvents::POST_SUBMIT, function(FormEvent $event) {
                 $form = $event->getForm();
 
                 $Authority = $form['Authority']->getData();

src/Eccube/Security/Voter/AuthorityVoter.php

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
 
     public function __construct(Application $app)
     {
-        $this->app     = $app;
+        $this->app = $app;
     }
 
     public function supportsAttribute($attribute)

src/Eccube/Service/CsvExportService.php

Spacing +2 added lines, -2 removed lines

@@ -307,7 +307,7 @@ 
     {
         $config = $this->config;
 
-        return function ($value) use ($config) {
+        return function($value) use ($config) {
             return mb_convert_encoding(
                 (string) $value, $config['csv_export_encoding'], 'UTF-8'
             );
@@ -431,7 +431,7 @@ 
             if ($Conditions instanceof ArrayCollection) {
                 $Conditions = new ArrayCollection(
                     array_map(
-                        function ($Entity) use ($em) {
+                        function($Entity) use ($em) {
                             return $em->getRepository(get_class($Entity))->find($Entity->getId());
                         }, $Conditions->toArray()
                     )

Doc Comments -2 removed lines

@@ -325,7 +325,6 @@ 
 
     /**
      * @param $row
-     * @param null $callback
      */
     public function fputcsv($row)
     {
@@ -424,7 +423,6 @@ 
      * XXX self::setExportQueryBuilder() をコールする前に EntityManager を取得したいので、引数で渡している
      *
      * @param array $searchData セッションから取得した検索条件の配列
-     * @param EntityManager $em
      */
     protected function findDeserializeObjects(array &$searchData)
     {

src/Eccube/Controller/Admin/Customer/CustomerEditController.php

Spacing +1 added lines, -1 removed lines

@@ -88,7 +88,7 @@
                         ->setCompanyName($Customer->getCompanyName())
                         ->setZip01($Customer->getZip01())
                         ->setZip02($Customer->getZip02())
-                        ->setZipcode($Customer->getZip01() . $Customer->getZip02())
+                        ->setZipcode($Customer->getZip01().$Customer->getZip02())
                         ->setPref($Customer->getPref())
                         ->setAddr01($Customer->getAddr01())
                         ->setAddr02($Customer->getAddr02())

Unused Use Statements -1 removed lines

@@ -35,7 +35,6 @@
 use Eccube\Repository\CustomerRepository;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
 use Symfony\Component\EventDispatcher\EventDispatcher;
 use Symfony\Component\Form\FormFactory;
 use Symfony\Component\HttpFoundation\Request;

src/Eccube/Controller/Admin/Product/ProductClassController.php

Indentation +1 added lines, -1 removed lines

@@ -138,7 +138,7 @@
                                 'allow_add' => true,
                                 'allow_delete' => true,
                                 'data' => $ProductClasses,
-                             ));
+                                ));
 
                         $event = new EventArgs(
                             array(

Spacing +1 added lines, -1 removed lines

@@ -106,7 +106,7 @@
                     $class2Valied = $this->isValiedCategory($ClassName2);
 
                     // 規格が選択されていないか、選択された状態で分類が保有されていれば、画面表示
-                    if($class1Valied && $class2Valied){
+                    if ($class1Valied && $class2Valied) {
                         $hasClassCategoryFlg = true;
                     }
 

Doc Comments +5 added lines

@@ -529,6 +529,9 @@ 
     /**
      * 登録、更新時のエラー画面表示
      *
+     * @param Application $app
+     * @param boolean $not_product_class
+     * @param \Symfony\Component\Form\FormInterface $classForm
      */
     protected function render($app, $Product, $ProductClass, $not_product_class, $classForm, $error = null)
     {
@@ -580,6 +583,7 @@ 
 
     /**
      * 規格1と規格2を組み合わせた商品規格を作成
+     * @param Application $app
      */
     private function createProductClasses($app, Product $Product, ClassName $ClassName1 = null, ClassName $ClassName2 = null)
     {
@@ -667,6 +671,7 @@ 
      *
      * @param $productClassDest コピー先となる商品規格
      * @param $productClassOrig コピー元となる商品規格
+     * @param Application $app
      */
     private function setDefualtProductClass($app, $productClassDest, $productClassOrig) {
         $productClassDest->setDeliveryDate($productClassOrig->getDeliveryDate());

Unused Use Statements -1 removed lines

@@ -46,7 +46,6 @@
 use Eccube\Repository\TaxRuleRepository;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
 use Symfony\Bridge\Doctrine\Form\Type\EntityType;
 use Symfony\Component\EventDispatcher\EventDispatcher;
 use Symfony\Component\Form\Extension\Core\Type\CollectionType;

src/Eccube/Twig/Extension/EccubeExtension.php

Doc Comments +2 added lines, -2 removed lines

@@ -40,7 +40,7 @@ 
     /**
      * Returns a list of functions to add to the existing list.
      *
-     * @return array An array of functions
+     * @return \Twig_SimpleFunction[] An array of functions
      */
     public function getFunctions()
     {
@@ -61,7 +61,7 @@ 
     /**
      * Returns a list of filters.
      *
-     * @return array
+     * @return \Twig_SimpleFilter[]
      */
     public function getFilters()
     {

Spacing +2 added lines, -2 removed lines

@@ -68,7 +68,7 @@ 
                     if (is_callable($function)) {
                         return call_user_func_array($function, $arg_list);
                     }
-                    trigger_error('Called to an undefined function : php_'. $function, E_USER_WARNING);
+                    trigger_error('Called to an undefined function : php_'.$function, E_USER_WARNING);
 
             }, ['pre_escape' => 'html', 'is_safe' => ['html']]),
 
@@ -156,7 +156,7 @@ 
     public function getCsrfTokenForAnchor()
     {
         $token = $this->app['csrf.token_manager']->getToken(Constant::TOKEN_NAME)->getValue();
-        return 'token-for-anchor=\'' . $token . '\'';
+        return 'token-for-anchor=\''.$token.'\'';
     }
 
     /**