EC-CUBE /
ec-cube
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 27 | class ShoppingConfirmPage extends AbstractFrontPage |
||
| 28 | { |
||
| 29 | public function __construct(\AcceptanceTester $I) |
||
| 30 | { |
||
| 31 | parent::__construct($I); |
||
| 32 | } |
||
| 33 | |||
| 34 | public static function at($I) |
||
| 35 | { |
||
| 36 | $page = new self($I); |
||
| 37 | $page->tester->see('ご注文内容のご確認', 'div.ec-pageHeader h1'); |
||
| 38 | $page->tester->see('お客様情報', '#shopping-form div.ec-orderAccount div.ec-rectHeading h2'); |
||
| 39 | $page->tester->see('配送情報', '#shopping-form div.ec-orderDelivery div.ec-rectHeading h2'); |
||
| 40 | $page->tester->see('お支払方法', '#shopping-form div.ec-orderPayment div.ec-rectHeading h2'); |
||
| 41 | $page->tester->see('お問い合わせ', '#shopping-form div.ec-orderConfirm div.ec-rectHeading h2'); |
||
| 42 | $page->tester->see('小計', '#shopping-form div.ec-orderRole__summary div.ec-totalBox'); |
||
| 43 | $page->tester->see('手数料', '#shopping-form div.ec-orderRole__summary div.ec-totalBox'); |
||
| 44 | $page->tester->see('送料', '#shopping-form div.ec-orderRole__summary div.ec-totalBox'); |
||
| 45 | $page->tester->see('合計', '#shopping-form div.ec-orderRole__summary div.ec-totalBox'); |
||
| 46 | return $page; |
||
| 47 | } |
||
| 48 | |||
| 49 | public function 注文する() |
||
| 50 | { |
||
| 51 | $this->tester->click('#shopping-form div.ec-orderRole__summary div.ec-totalBox button'); |
||
| 52 | return $this; |
||
| 53 | } |
||
| 54 | } |
