Eccube\Service\PurchaseFlow\Processor\UsePointProcessor

Complexity

Total Complexity

11

Size/Duplication

Total Lines	113
Duplicated Lines	7.96 %

Coupling/Cohesion

Components	1
Dependencies	8

Test Coverage

Coverage

0%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	process()	0	16	3
A	addPointDiscountItem()	0	33	2
A	removePointDiscountItem()	9	9	4
A	usePointToPrice()	0	4	1

<?php

/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Eccube\Service\PurchaseFlow\Processor;

use Doctrine\ORM\EntityManagerInterface;
use Eccube\Entity\BaseInfo;
use Eccube\Entity\ItemHolderInterface;
use Eccube\Entity\Master\OrderItemType;
use Eccube\Entity\Master\TaxDisplayType;
use Eccube\Entity\Master\TaxType;
use Eccube\Entity\Order;
use Eccube\Entity\OrderItem;
use Eccube\Service\PurchaseFlow\ItemHolderProcessor;
use Eccube\Service\PurchaseFlow\ProcessResult;
use Eccube\Service\PurchaseFlow\PurchaseContext;

/**
 * 使用ポイント値引明細追加.
 */
class UsePointProcessor implements ItemHolderProcessor
{
    /**
     * @var EntityManagerInterface
     */
    protected $entityManager;

    /**
     * @var BaseInfo
     */
    protected $BaseInfo;

    /**
     * UsePointProcessor constructor.
     *
     * @param EntityManagerInterface $entityManager
     * @param BaseInfo $BaseInfo
     */
    public function __construct(EntityManagerInterface $entityManager, BaseInfo $BaseInfo)
    {
        $this->entityManager = $entityManager;
        $this->BaseInfo = $BaseInfo;
    }

    /**
     * @param ItemHolderInterface $itemHolder
     * @param PurchaseContext     $context
     *
     * @return ProcessResult
     */
    public function process(ItemHolderInterface $itemHolder, PurchaseContext $context)
    {
        if ($itemHolder->getUsePoint() > 0) {
            if ($itemHolder->getUsePoint() > $context->getUser()->getPoint()) {
                // TODO カートに戻さないように修正する
                return ProcessResult::error('利用ポイントが所有ポイントを上回っています.');
            }

            // XXX delete/insert ではなく, update/insert の方がいいかも
            $this->removePointDiscountItem($itemHolder);

            return $this->addPointDiscountItem($itemHolder);
        }

        return ProcessResult::success();
    }

    /**
     * 明細追加処理
     *
     * @param ItemHolderInterface $itemHolder
     */
    protected function addPointDiscountItem(ItemHolderInterface $itemHolder)
    {
        $DiscountType = $this->entityManager
            ->find(OrderItemType::class, OrderItemType::DISCOUNT);
        // TODO
        $TaxInclude = $this->entityManager
            ->find(TaxDisplayType::class, TaxDisplayType::INCLUDED);
        $Taxion = $this->entityManager
            ->find(TaxType::class, TaxType::TAXATION);

        /** @var Order $Order */
        $Order = $itemHolder;

        $priceOfUsePoint = $this->usePointToPrice($Order->getUsePoint());
        if (($itemHolder->getTotal() + $priceOfUsePoint) < 0) {
            // TODO カートに戻さないように修正する
            // TODO 送料・手数料も考慮する
            return ProcessResult::error('利用ポイントがお支払い金額を上回っています.');
        }
        $OrderItem = new OrderItem();
        $OrderItem->setProductName('ポイント値引')
            ->setPrice($priceOfUsePoint)
            ->setPriceIncTax($priceOfUsePoint)
            ->setTaxRate(8)
            ->setQuantity(1)
            ->setOrderItemType($DiscountType)
            ->setTaxDisplayType($TaxInclude)
            ->setTaxType($Taxion)
            ->setOrder($itemHolder);

$itemHolder is of type object<Eccube\Entity\ItemHolderInterface>, but the function expects a null|object<Eccube\Entity\Order>.

        $itemHolder->addItem($OrderItem);

        return ProcessResult::success();
    }

    /**
     * 既存のポイント明細を削除する.
     *
     * @param ItemHolderInterface $itemHolder
     */
    protected function removePointDiscountItem(ItemHolderInterface $itemHolder)

This method seems to be duplicated in your project.

    {
        foreach ($itemHolder->getItems() as $item) {
            if ($item->isDiscount() && $item->getProductName() == 'ポイント値引') {

It seems like you code against a concrete implementation and not the interface Eccube\Entity\ItemInterface as the method getProductName() does only exist in the following implementations of said interface: Eccube\Entity\OrderItem.

                $itemHolder->removeOrderItem($item);

It seems like you code against a concrete implementation and not the interface Eccube\Entity\ItemHolderInterface as the method removeOrderItem() does only exist in the following implementations of said interface: Eccube\Entity\Order.

                $this->entityManager->remove($item);
            }
        }
    }

    /**
     * 利用ポイントを単価に換算する.
     *
     * @param integer $usePoint 利用ポイント
     *
     * @return integer
     */
    protected function usePointToPrice($usePoint)
    {
        return ($usePoint * $this->BaseInfo->getPointConversionRate()) * -1;
    }
}