Eccube\Repository\PaymentRepository

Complexity

Total Complexity

14

Size/Duplication

Total Lines	123
Duplicated Lines	17.89 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	findOrCreate()	3	15	3
A	createPayment()	19	19	2
A	findAllArray()	0	12	1
A	findPayments()	0	20	2
B	findAllowedPayments()	0	31	6

<?php
/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 */


namespace Eccube\Repository;

use Doctrine\ORM\EntityRepository;
use Doctrine\ORM\Query;

/**
 * PaymentRepository
 *
 * This class was generated by the Doctrine ORM. Add your own custom
 * repository methods below.
 */
class PaymentRepository extends EntityRepository
{
    public function findOrCreate($id, $Creator = null)

Missing function doc comment

    {
        if ($id == 0) {
            $em = $this->getEntityManager();
            if ($Creator == null) {

This code seems to be duplicated across your project.

                $Creator = $em->getRepository('\Eccube\Entity\Member')->findOneBy(array(), array('rank' => 'DESC'));
            }

            $Payment = $this->createPayment($Creator);
        } else {
            $Payment = $this->find($id);
        }

        return $Payment;
    }

    /**
     * create Payment
     * @param \Eccube\Entity\Member $Creator
     * @return \Eccube\Entity\Payment
     */
    private function createPayment($Creator)

This method seems to be duplicated in your project.

    {
        $PaymentOld = $this->findOneBy(array(), array('rank' => 'DESC'));

        $rank = 1;
        if ($PaymentOld) {
            $rank = $PaymentOld->getRank() + 1;
        }

        $Payment = new \Eccube\Entity\Payment();
        $Payment
            ->setRank($rank)
            ->setDelFlg(0)
            ->setFixFlg(1)
            ->setChargeFlg(1)
            ->setCreator($Creator);

        return $Payment;
    }

    public function findAllArray()

Missing function doc comment

Declare public methods first, then protected ones and finally private ones

    {

        $query = $this
            ->getEntityManager()
            ->createQuery('SELECT p FROM Eccube\Entity\Payment p INDEX BY p.id');
        $result = $query
            ->getResult(Query::HYDRATE_ARRAY);

        return $result;

    }

    /**

Doc comment for parameter "$delivery" missing

Doc comment for parameter "$returnType" missing

     * 支払方法を取得
     * 条件によってはDoctrineのキャッシュが返されるため、arrayで結果を返すパターンも用意
     *
     * @param $delivery

Missing parameter name

     * @param $returnType true : Object、false: arrayが戻り値

Missing parameter name

     * @return array
     */
    public function findPayments($delivery, $returnType = false)
    {

        $query = $this->createQueryBuilder('p')
            ->innerJoin('Eccube\Entity\PaymentOption', 'po', 'WITH', 'po.payment_id = p.id')
            ->where('po.Delivery = (:delivery)')
            ->orderBy('p.rank', 'DESC')
            ->setParameter('delivery', $delivery)
            ->getQuery();

        $query->expireResultCache(false);

        if ($returnType) {
            $payments = $query->getResult();
        } else {
            $payments = $query->getArrayResult();
        }

        return $payments;
    }

    /**

Doc comment for parameter "$deliveries" missing

     * 共通の支払方法を取得
     *
     * @param $deliveries

Missing parameter name

     * @return array
     */
    public function findAllowedPayments($deliveries)
    {
        $payments = array();
        $i = 0;

        foreach ($deliveries as $Delivery) {
            $p = $this->findPayments($Delivery);

            if ($i != 0) {

Blank line found at start of control structure

                $arr = array();
                foreach ($p as $payment) {
                    foreach ($payments as $pay) {
                        if ($payment['id'] == $pay['id']) {
                            $arr[] = $payment;
                            break;
                        }
                    }
                }

                $payments = $arr;

Blank line found at end of control structure

            } else {
                $payments = $p;
            }
            $i++;
        }

        return $payments;

    }
}