UsePointProcessor::removePointDiscountItem() - Code Metrics - Inspection of "[WIP] ポイント機能の実装" - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — experimental/3.1 (#2624)

by Kentaro

created 2017-11-13 05:21 UTC

UsePointProcessor::removePointDiscountItem() A

↳ Parent: UsePointProcessor

Complexity

Conditions	4
Paths	3

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	4
nc	3
nop	1
dl	0
loc	8
rs	9.2
c	0
b	0
f	0

<?php

namespace Eccube\Service\PurchaseFlow\Processor;

use Doctrine\ORM\EntityManager;
use Eccube\Annotation\Inject;
use Eccube\Entity\ItemHolderInterface;
use Eccube\Entity\Master\OrderItemType;
use Eccube\Entity\Master\TaxDisplayType;
use Eccube\Entity\Master\TaxType;
use Eccube\Entity\BaseInfo;
use Eccube\Entity\Order;
use Eccube\Entity\OrderItem;
use Eccube\Entity\Shipping;
use Eccube\Service\PurchaseFlow\ItemHolderProcessor;
use Eccube\Service\PurchaseFlow\ProcessResult;
use Eccube\Service\PurchaseFlow\PurchaseContext;

/**
 * 使用ポイント値引明細追加.
 */
class UsePointProcessor implements ItemHolderProcessor
{
    /**
     * @Inject("orm.em")
     * @var EntityManager
     */
    protected $entityManager;

    /**
     * @var BaseInfo
     */
    protected $BaseInfo;

    /**

     * DeliveryFeeProcessor constructor.
     *
     * @param $app

     */
    public function __construct(EntityManager $entityManager, BaseInfo $BaseInfo)
function someFunction(ManagerRegistry $registry) {
    $em = $registry->getManager();
    $em->getConnection()->beginTransaction();
    try {
        // Do something.
        $em->getConnection()->commit();
    } catch (\Exception $ex) {
        $em->getConnection()->rollback();
        $em->close();

        throw $ex;
    }
}
    {
        $this->entityManager = $entityManager;
        $this->BaseInfo = $BaseInfo;
    }

    /**
     * @param ItemHolderInterface $itemHolder
     * @param PurchaseContext     $context
     *
     * @return ProcessResult
     */
    public function process(ItemHolderInterface $itemHolder, PurchaseContext $context)
    {
        if ($itemHolder->getUsePoint() > 0) {
            if ($itemHolder->getUsePoint() > $context->getUser()->getPoint()) {
                // TODO カートに戻さないように修正する
                return ProcessResult::error('利用ポイントが所有ポイントを上回っています.');
            }

            $this->removePointDiscountItem($itemHolder);
            return $this->addPointDiscountItem($itemHolder);

        }

        return ProcessResult::success();
    }

    /**
     * 明細追加処理
     *
     * @param ItemHolderInterface $itemHolder
     */
    protected function addPointDiscountItem(ItemHolderInterface $itemHolder)
    {
        $DiscountType = $this->entityManager
            ->find(OrderItemType::class, OrderItemType::DISCOUNT);
        // TODO
        $TaxInclude = $this->entityManager
            ->find(TaxDisplayType::class, TaxDisplayType::INCLUDED);
        $Taxion = $this->entityManager
            ->find(TaxType::class, TaxType::TAXATION);

        /** @var Order $Order */
        $Order = $itemHolder;

        $priceOfUsePoint = $Order->getUsePoint() * -1; // TODO ポイント換算率
        if (($itemHolder->getTotal() + $priceOfUsePoint) < 0) {
            // TODO カートに戻さないように修正する
            // TODO 送料・手数料も考慮する
            return ProcessResult::error('利用ポイントがお支払い金額を上回っています.');
        }
        $OrderItem = new OrderItem();
        $OrderItem->setProductName('ポイント値引')
            ->setPrice($priceOfUsePoint)
            ->setPriceIncTax($priceOfUsePoint)
            ->setTaxRate(8)
            ->setQuantity(1)
            ->setOrderItemType($DiscountType)
            ->setTaxDisplayType($TaxInclude)
            ->setTaxType($Taxion);
        $itemHolder->addItem($OrderItem);
        return ProcessResult::success();

    }

    /**
     * 既存のポイント明細を削除する.
     *
     * @param ItemHolderInterface $itemHolder
     */
    protected function removePointDiscountItem(ItemHolderInterface $itemHolder)
    {
        foreach ($itemHolder->getItems() as $item) {
            if ($item->isDiscount() && $item->getProductName() == 'ポイント値引') {
                $this->entityManager->remove($item);
            }
        }
    }
}


1			<?php
2
3			namespace Eccube\Service\PurchaseFlow\Processor;
4
5			use Doctrine\ORM\EntityManager;
6			use Eccube\Annotation\Inject;
7			use Eccube\Entity\ItemHolderInterface;
8			use Eccube\Entity\Master\OrderItemType;
9			use Eccube\Entity\Master\TaxDisplayType;
10			use Eccube\Entity\Master\TaxType;
11			use Eccube\Entity\BaseInfo;
12			use Eccube\Entity\Order;
13			use Eccube\Entity\OrderItem;
14			use Eccube\Entity\Shipping;
15			use Eccube\Service\PurchaseFlow\ItemHolderProcessor;
16			use Eccube\Service\PurchaseFlow\ProcessResult;
17			use Eccube\Service\PurchaseFlow\PurchaseContext;
18
19			/**
20			* 使用ポイント値引明細追加.
21			*/
22			class UsePointProcessor implements ItemHolderProcessor
23			{
24			/**
25			* @Inject("orm.em")
26			* @var EntityManager
27			*/
28			protected $entityManager;
29
30			/**
31			* @var BaseInfo
32			*/
33			protected $BaseInfo;
34
35			/**
			0 ignored issues – show introduced 2017-11-13 06:19 UTC by Report Bug Copy Issue Report Doc comment for parameter "$entityManager" missing Loading history... introduced 2017-11-13 06:19 UTC by Report Bug Copy Issue Report Doc comment for parameter "$BaseInfo" missing Loading history...
36			* DeliveryFeeProcessor constructor.
37			*
38			* @param $app
			0 ignored issues – show introduced 2017-11-13 06:19 UTC by Report Bug Copy Issue Report Missing parameter name Loading history...
39			*/
40			public function __construct(EntityManager $entityManager, BaseInfo $BaseInfo)
			0 ignored issues – show Bug introduced 2017-11-13 06:19 UTC by Report Bug Copy Issue Report You have injected the EntityManager via parameter `$entityManager`. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via `getManager()` each time you need it. The `EntityManager` might become unusable for example if a transaction is rolled back and it gets closed. Let’s assume that somewhere in your application, or in a third-party library, there is code such as the following: function someFunction(ManagerRegistry $registry) { $em = $registry->getManager(); $em->getConnection()->beginTransaction(); try { // Do something. $em->getConnection()->commit(); } catch (\Exception $ex) { $em->getConnection()->rollback(); $em->close(); throw $ex; } } If that code throws an exception and the `EntityManager` is closed. Any other code which depends on the same instance of the `EntityManager` during this request will fail. On the other hand, if you instead inject the `ManagerRegistry`, the `getManager()` method guarantees that you will always get a usable manager instance. Loading history...
41			{
42			$this->entityManager = $entityManager;
43			$this->BaseInfo = $BaseInfo;
44			}
45
46			/**
47			* @param ItemHolderInterface $itemHolder
48			* @param PurchaseContext $context
49			*
50			* @return ProcessResult
51			*/
52			public function process(ItemHolderInterface $itemHolder, PurchaseContext $context)
53			{
54			if ($itemHolder->getUsePoint() > 0) {
55			if ($itemHolder->getUsePoint() > $context->getUser()->getPoint()) {
56			// TODO カートに戻さないように修正する
57			return ProcessResult::error('利用ポイントが所有ポイントを上回っています.');
58			}
59
60			$this->removePointDiscountItem($itemHolder);
61			return $this->addPointDiscountItem($itemHolder);
			0 ignored issues – show introduced 2017-11-13 06:19 UTC by Report Bug Copy Issue Report Missing blank line before return statement Loading history...
62			}
63
64			return ProcessResult::success();
65			}
66
67			/**
68			* 明細追加処理
69			*
70			* @param ItemHolderInterface $itemHolder
71			*/
72			protected function addPointDiscountItem(ItemHolderInterface $itemHolder)
73			{
74			$DiscountType = $this->entityManager
75			->find(OrderItemType::class, OrderItemType::DISCOUNT);
76			// TODO
77			$TaxInclude = $this->entityManager
78			->find(TaxDisplayType::class, TaxDisplayType::INCLUDED);
79			$Taxion = $this->entityManager
80			->find(TaxType::class, TaxType::TAXATION);
81
82			/** @var Order $Order */
83			$Order = $itemHolder;
84
85			$priceOfUsePoint = $Order->getUsePoint() * -1; // TODO ポイント換算率
86			if (($itemHolder->getTotal() + $priceOfUsePoint) < 0) {
87			// TODO カートに戻さないように修正する
88			// TODO 送料・手数料も考慮する
89			return ProcessResult::error('利用ポイントがお支払い金額を上回っています.');
90			}
91			$OrderItem = new OrderItem();
92			$OrderItem->setProductName('ポイント値引')
93			->setPrice($priceOfUsePoint)
94			->setPriceIncTax($priceOfUsePoint)
95			->setTaxRate(8)
96			->setQuantity(1)
97			->setOrderItemType($DiscountType)
98			->setTaxDisplayType($TaxInclude)
99			->setTaxType($Taxion);
100			$itemHolder->addItem($OrderItem);
101			return ProcessResult::success();
			0 ignored issues – show introduced 2017-11-13 06:19 UTC by Report Bug Copy Issue Report Missing blank line before return statement Loading history...
102			}
103
104			/**
105			* 既存のポイント明細を削除する.
106			*
107			* @param ItemHolderInterface $itemHolder
108			*/
109			protected function removePointDiscountItem(ItemHolderInterface $itemHolder)
110			{
111			foreach ($itemHolder->getItems() as $item) {
112			if ($item->isDiscount() && $item->getProductName() == 'ポイント値引') {
113			$this->entityManager->remove($item);
114			}
115			}
116			}
117			}
118

EC-CUBE / ec-cube

Pull Request — experimental/3.1 (#2624)

UsePointProcessor::removePointDiscountItem() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like