Completed
Push — experimental/3.1 ( 62371a...ff3a02 )
by Yangsin
51:06 queued 14:43
created
app/Acme/Controller/RoutingTestController.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@
 block discarded – undo
16 16
      * @Security("has_role('ROLE_ADMIN')")
17 17
      *
18 18
      * @param Application $app
19
-     * @return \Symfony\Component\HttpFoundation\Response
19
+     * @return string
20 20
      */
21 21
     public function testAdmin(Application $app)
22 22
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Acme\Controller;
4 4
 
5 5
 use Eccube\Application;
6
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\Cache;
7 6
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
8 7
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Security;
9 8
 
Please login to merge, or discard this patch.
app/Acme/Controller/TestController.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -4,13 +4,10 @@
 block discarded – undo
4 4
 use Eccube\Application;
5 5
 use Symfony\Component\HttpFoundation\Response;
6 6
 use Symfony\Component\HttpFoundation\Request;
7
-use Symfony\Component\HttpFoundation\ParameterBag;
8
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\Cache;
9 7
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
10 8
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
11 9
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Security;
12 10
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
13
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
14 11
 
15 12
 /**
16 13
  * @Route("/test")
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Store/PluginController.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,6 @@
 block discarded – undo
31 31
 use Eccube\Form\Type\Admin\PluginLocalInstallType;
32 32
 use Eccube\Form\Type\Admin\PluginManagementType;
33 33
 use Eccube\Util\Str;
34
-use Monolog\Logger;
35 34
 use Symfony\Component\Filesystem\Filesystem;
36 35
 use Symfony\Component\Finder\Finder;
37 36
 use Symfony\Component\Form\Extension\Core\Type\TextType;
Please login to merge, or discard this patch.
src/Eccube/Service/CartService.php 3 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
     }
232 232
 
233 233
     /**
234
-     * @param  \Eccube\Entity\ProductClass|integer $ProductClass
234
+     * @param  string $ProductClass
235 235
      * @param  integer $quantity
236 236
      * @return \Eccube\Service\CartService
237 237
      * @throws CartException
@@ -645,7 +645,7 @@  discard block
 block discarded – undo
645 645
      * 在庫数と販売制限数ともに個数が超えていれば、少ない方を適用させてメッセージを表示する
646 646
      *
647 647
      * @param ProductClass $ProductClass
648
-     * @param $productName
648
+     * @param string $productName
649 649
      * @param $quantity
650 650
      * @return int チェック後に更新した個数
651 651
      */
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -302,7 +302,7 @@
 block discarded – undo
302 302
         // 制限数チェック(在庫不足の場合は、処理の中でカート内商品を削除している)
303 303
         $quantity = $this->setProductLimit($ProductClass, $productName, $tmp_quantity);
304 304
 
305
-		// 新しい数量でカート内商品を登録する
305
+        // 新しい数量でカート内商品を登録する
306 306
         if (0 < $quantity) {
307 307
             $CartItem = new CartItem();
308 308
             $CartItem
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
      */
223 223
     public function getProductQuantity($productClassId)
224 224
     {
225
-        $CartItem = $this->cart->getCartItemByIdentifier('Eccube\Entity\ProductClass', (string)$productClassId);
225
+        $CartItem = $this->cart->getCartItemByIdentifier('Eccube\Entity\ProductClass', (string) $productClassId);
226 226
         if ($CartItem) {
227 227
             return $CartItem->getQuantity();
228 228
         } else {
@@ -307,7 +307,7 @@  discard block
 block discarded – undo
307 307
             $CartItem = new CartItem();
308 308
             $CartItem
309 309
                 ->setClassName('Eccube\Entity\ProductClass')
310
-                ->setClassId((string)$ProductClass->getId())
310
+                ->setClassId((string) $ProductClass->getId())
311 311
                 ->setPrice($ProductClass->getPrice02IncTax())
312 312
                 ->setQuantity($quantity);
313 313
 
@@ -465,7 +465,7 @@  discard block
 block discarded – undo
465 465
      */
466 466
     public function removeProduct($productClassId)
467 467
     {
468
-        $this->cart->removeCartItemByIdentifier('Eccube\Entity\ProductClass', (string)$productClassId);
468
+        $this->cart->removeCartItemByIdentifier('Eccube\Entity\ProductClass', (string) $productClassId);
469 469
 
470 470
         // 支払方法の再設定
471 471
         if ($this->BaseInfo->getOptionMultipleShipping() == Constant::ENABLED) {
Please login to merge, or discard this patch.
src/Eccube/Form/Type/Admin/MasterdataDataType.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@
 block discarded – undo
65 65
             ->add('name', TextType::class, array(
66 66
                 'required' => false,
67 67
             ))
68
-        ->addEventListener(FormEvents::POST_SUBMIT, function (FormEvent $event) use ($app) {
68
+        ->addEventListener(FormEvents::POST_SUBMIT, function(FormEvent $event) use ($app) {
69 69
             $form = $event->getForm();
70 70
             $data = $form->getData();
71 71
             if (strlen($data['id']) && strlen($data['name']) == 0) {
Please login to merge, or discard this patch.
src/Eccube/Command/GeneratorCommand/generatortemplate/ServiceProvider.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
         $app->match('/plugin/[lower_code]/hello', 'Plugin\[code]\Controller\[code]Controller::index')->bind('plugin_[code]_hello');
34 34
 
35 35
         // Form
36
-        $app['form.types'] = $app->extend('form.types', function ($types) use ($app) {
36
+        $app['form.types'] = $app->extend('form.types', function($types) use ($app) {
37 37
             $types[] = new [code]ConfigType();
38 38
 
39 39
             return $types;
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
         // }
58 58
 
59 59
         // ログファイル設定
60
-        $app['monolog.logger.[lower_code]'] = function ($app) {
60
+        $app['monolog.logger.[lower_code]'] = function($app) {
61 61
 
62 62
             $logger = new $app['monolog.logger.class']('[lower_code]');
63 63
 
Please login to merge, or discard this patch.
src/Eccube/Doctrine/ORM/Query/Extract.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -121,14 +121,14 @@
 block discarded – undo
121 121
                 $sql = sprintf(
122 122
                     "EXTRACT(%s FROM %s %s $op INTERVAL '$second SECONDS')",
123 123
                     $this->field,
124
-                    (string)$this->type,
124
+                    (string) $this->type,
125 125
                     $this->source->dispatch($sqlWalker));
126 126
                 break;
127 127
             default:
128 128
                 $sql = sprintf(
129 129
                     "EXTRACT(%s FROM %s %s $op INTERVAL $second SECOND)",
130 130
                     $this->field,
131
-                    (string)$this->type,
131
+                    (string) $this->type,
132 132
                     $this->source->dispatch($sqlWalker));
133 133
         }
134 134
 
Please login to merge, or discard this patch.
src/Eccube/Doctrine/Common/CsvDataFixtures/CsvFixture.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 use Doctrine\Common\DataFixtures\FixtureInterface;
6 6
 use Doctrine\Common\Persistence\ObjectManager;
7 7
 use Doctrine\DBAL\Connection;
8
-use Doctrine\DBAL\Schema\Table;
9 8
 
10 9
 /**
11 10
  * CSVファイルを扱うためのフィクスチャ.
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
     public function load(ObjectManager $manager)
29 29
     {
30 30
         // CSV Reader に設定
31
-        $this->file->setFlags(\SplFileObject::READ_CSV | \SplFileObject::READ_AHEAD | \SplFileObject::SKIP_EMPTY |\SplFileObject::DROP_NEW_LINE);
31
+        $this->file->setFlags(\SplFileObject::READ_CSV|\SplFileObject::READ_AHEAD|\SplFileObject::SKIP_EMPTY|\SplFileObject::DROP_NEW_LINE);
32 32
 
33 33
         // ヘッダ行を取得
34 34
         $headers = $this->file->current();
Please login to merge, or discard this patch.
src/Eccube/Doctrine/Common/CsvDataFixtures/Loader.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
             ->name('*.csv')
44 44
             ->sort(
45 45
                 // 定義ファイルに記載の順にソート.
46
-                function (\SplFileInfo $a, \SplFileInfo $b) use ($definition) {
46
+                function(\SplFileInfo $a, \SplFileInfo $b) use ($definition) {
47 47
                     if (!isset($definition[$a->getFilename()])) {
48 48
                         throw new \Exception(sprintf('"%s" is undefined in %s', $a->getFilename()));
49 49
                     }
Please login to merge, or discard this patch.