Eccube\Controller\Admin\Customer\CustomerDeliveryEditController

Complexity

Total Complexity

11

Size/Duplication

Total Lines	162
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	11

Importance

Changes	3
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
C	edit()	0	73	7
B	delete()	0	37	4

<?php
/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 */

namespace Eccube\Controller\Admin\Customer;

use Doctrine\ORM\EntityManager;
use Eccube\Annotation\Inject;
use Eccube\Application;
use Eccube\Common\Constant;
use Eccube\Controller\AbstractController;
use Eccube\Entity\CustomerAddress;
use Eccube\Event\EccubeEvents;
use Eccube\Event\EventArgs;
use Eccube\Form\Type\Admin\CustomerType;
use Eccube\Repository\CustomerRepository;
use Eccube\Repository\CustomerAddressRepository;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Symfony\Component\EventDispatcher\EventDispatcher;
use Symfony\Component\Form\FormFactory;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Eccube\Form\Type\Front\CustomerAddressType;
use Doctrine\DBAL\Exception\ForeignKeyConstraintViolationException;
use Eccube\Entity\Customer;

/**
 * @Route(service=CustomerDeliveryEditController::class)
 */
class CustomerDeliveryEditController extends AbstractController
{
    /**
     * @Inject("eccube.event.dispatcher")
     * @var EventDispatcher
     */
    protected $eventDispatcher;
    

Please trim any trailing whitespace

    /**
     * @Inject("form.factory")
     * @var FormFactory
     */
    protected $formFactory;
    

Please trim any trailing whitespace

    /**
     * @Inject("config")
     * @var array
     */
    protected $appConfig;
    

Please trim any trailing whitespace

    /**
     * @Inject("orm.em")
     * @var EntityManager
     */
    protected $entityManager;
    

Please trim any trailing whitespace

    /**
     * @Inject(CustomerRepository::class)
     * @var CustomerRepository
     */
    protected $customerRepository;
    

Please trim any trailing whitespace

    /**
     * @Inject(CustomerAddressRepository::class)
     * @var CustomerAddressRepository
     */
    protected $customerAddressRepository;
    

Please trim any trailing whitespace

    /**

Doc comment for parameter "$app" missing

Doc comment for parameter "$request" missing

Doc comment for parameter "$Customer" missing

Doc comment for parameter "$did" missing

     * お届け先編集画面.
     *
     * @Route("/{_admin}/customer/{id}/delivery/new", name="admin_customer_delivery_new", requirements={"id" = "\d+"})
     * @Route("/{_admin}/customer/{id}/delivery/{did}/edit", name="admin_customer_delivery_edit", requirements={"id" = "\d+", "did" = "\d+"})
     * @Template("Customer/delivery_edit.twig")
     */

Missing @return tag in function comment

    public function edit(Application $app, Request $request, Customer $Customer, $did = null)
    {   

Please trim any trailing whitespace

        // 配送先住所最大値判定
        // $idが存在する際は、追加処理ではなく、編集の処理ため本ロジックスキップ
        if (is_null($did)) {
            $addressCurrNum = count($Customer->getCustomerAddresses());
            $addressMax = $this->appConfig['deliv_addr_max'];
            if ($addressCurrNum >= $addressMax) {
                throw new NotFoundHttpException('お届け先の登録数の上限を超えています');
            }
        } else {
            $CustomerAddress = $this->customerAddressRepository->find($did);
            if (is_null($CustomerAddress) || $CustomerAddress->getCustomer()->getId() != $Customer->getId()) {
                throw new NotFoundHttpException();
            }
        }
        

Please trim any trailing whitespace

        $CustomerAddress = $this->customerAddressRepository->findOrCreateByCustomerAndId($Customer, $did);

The method Eccube\Repository\CustomerAddressRepository::findOrCreateByCustomerAndId() has been deprecated with message: 呼び出し元で制御する

        $builder = $this->formFactory
            ->createBuilder(CustomerAddressType::class, $CustomerAddress);
        

Please trim any trailing whitespace

        $event = new EventArgs(
            array(
                'builder' => $builder,
                'Customer' => $Customer,
                'CustomerAddress' => $CustomerAddress,
            ),
            $request
        );
        

Please trim any trailing whitespace

        $this->eventDispatcher->dispatch(EccubeEvents::ADMIN_CUSTOMER_DELIVERY_EDIT_INDEX_INITIALIZE, $event);
        

Please trim any trailing whitespace

        $form = $builder->getForm();
        

Please trim any trailing whitespace

        if ('POST' === $request->getMethod()) {
            $form->handleRequest($request);
            if ($form->isValid()) {
                log_info('お届け先登録開始', array($did));
                

Please trim any trailing whitespace

                $this->entityManager->persist($CustomerAddress);
                $this->entityManager->flush();
                

Please trim any trailing whitespace

                log_info('お届け先登録完了', array($did));
                

Please trim any trailing whitespace

                $event = new EventArgs(
                    array(
                        'form' => $form,
                        'Customer' => $Customer,
                        'CustomerAddress' => $CustomerAddress,
                    ),
                    $request
                    );
                $this->eventDispatcher->dispatch(EccubeEvents::ADMIN_CUSTOMER_DELIVERY_EDIT_INDEX_COMPLETE, $event);
                

Please trim any trailing whitespace

                $app->addSuccess('admin.customer.delivery.save.complete', 'admin');
                

Please trim any trailing whitespace

                return $app->redirect($app->url('admin_customer_delivery_edit', array(
                    'id' => $Customer->getId(),
                    'did' => $CustomerAddress->getId(),
                )));
            } else {
                $app->addError('admin.customer.delivery.save.failed', 'admin');
            }
        }
        

Please trim any trailing whitespace

        return [
            'form' => $form->createView(),
            'Customer' => $Customer,
            'CustomerAddress' => $CustomerAddress,
        ];
                    

Please trim any trailing whitespace

    }
    

Please trim any trailing whitespace

    /**

Doc comment for parameter "$app" missing

Doc comment for parameter "$request" missing

Doc comment for parameter "$Customer" missing

Doc comment for parameter "$did" missing

     * @Method("DELETE")
     * @Route("/{_admin}/customer/{id}/delivery/{did}/delete", requirements={"id" = "\d+", "did" = "\d+"}, name="admin_customer_delivery_delete")
     */

Missing @return tag in function comment

    public function delete(Application $app, Request $request, Customer $Customer, $did)
    {
        $this->isTokenValid($app);
    

Please trim any trailing whitespace

        log_info('お届け先削除開始', array($did));
        

Please trim any trailing whitespace

        $CustomerAddress = $this->customerAddressRepository->find($did);
        if (is_null($CustomerAddress)) {
            throw new NotFoundHttpException();
        } else if ($CustomerAddress->getCustomer()->getId() != $Customer->getId()) {
            $app->deleteMessage();
            return $app->redirect($app->url('admin_customer_edit', array('id' => $Customer->getId())));

Missing blank line before return statement

        }
    

Please trim any trailing whitespace

        try {
            $this->customerAddressRepository->delete($CustomerAddress);
            $app->addSuccess('admin.customer.delivery.delete.complete', 'admin');
        } catch (ForeignKeyConstraintViolationException $e) {
            log_error('お届け先削除失敗', [$e], 'admin');

The call to log_error() has too many arguments starting with 'admin'.

Please trim any trailing whitespace

            $message = $app->trans('admin.delete.failed.foreign_key', ['%name%' => 'お届け先']);
            $app->addError($message, 'admin');
        }
    

Please trim any trailing whitespace

        log_info('お届け先削除完了', array($did));
    

Please trim any trailing whitespace

        $event = new EventArgs(
            array(
                'Customer' => $Customer,
                'CustomerAddress' => $CustomerAddress,
            ),
            $request
        );
        $this->eventDispatcher->dispatch(EccubeEvents::ADMIN_CUSTOMER_DELIVERY_DELETE_COMPLETE, $event);
    

Please trim any trailing whitespace

        return $app->redirect($app->url('admin_customer_edit', array('id' => $Customer->getId())));
    }
    

Please trim any trailing whitespace

}