CartService::getProductQuantity() - Code Metrics - Inspection of "Merge pull request #2091 from eccubevn/bug_fix_#12..." - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c2113a...957c9d )

by Ryo

created 2017-02-13 00:59 UTC

CartService::getProductQuantity() A

↳ Parent: CartService

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	9
ccs	5
cts	5
cp	1
rs	9.6666
cc	2
eloc	6
nc	2
nop	1
crap	2

<?php
/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 */


namespace Eccube\Service;

use Doctrine\ORM\EntityManager;
use Eccube\Common\Constant;
use Eccube\Entity\CartItem;
use Eccube\Entity\Master\Disp;
use Eccube\Entity\ProductClass;
use Eccube\Exception\CartException;
use Symfony\Component\HttpFoundation\Session\Session;

class CartService

{
    /** @var \Eccube\Application */
    public $app;

    /**
     * @var Session
     */
    private $session;

    /**
     * @var EntityManager
     */
    private $entityManager;

    /**
     * @var \Eccube\Entity\Cart
     */
    private $cart;

    /**
     * @var \Eccube\Entity\BaseInfo
     */
    private $BaseInfo;

    /**
     * @var array
     */
    private $errors = array();

    private $ProductType = null;

    /**
     * @var array
     */
    private $messages = array();

    /**
     * @var array
     */
    private $error;

    public function __construct(\Eccube\Application $app)

    {
        $this->app = $app;
        $this->session = $app['session'];
        $this->entityManager = $app['orm.em'];

        if ($this->session->has('cart')) {
            $this->cart = $this->session->get('cart');
        } else {
            $this->cart = new \Eccube\Entity\Cart();
        }

        $this->loadProductClassFromCart();

        $this->BaseInfo = $app['eccube.repository.base_info']->get();
    }

    /**
     * カートに保存されている商品の ProductClass エンティティを読み込み、カートへ設定します。
     */
    protected function loadProductClassFromCart()
    {
        /* @var $softDeleteFilter \Eccube\Doctrine\Filter\SoftDeleteFilter */
        $softDeleteFilter = $this->entityManager->getFilters()->getFilter('soft_delete');
        $excludes = $softDeleteFilter->getExcludes();
        $softDeleteFilter->setExcludes(array(
            'Eccube\Entity\ProductClass',
        ));

        foreach ($this->cart->getCartItems() as $CartItem) {
            $this->loadProductClassFromCartItem($CartItem);
        }

        $softDeleteFilter->setExcludes($excludes);
    }

    /**
     * CartItem に対応する ProductClass を設定します。
     *
     * @param CartItem $CartItem
     */
    protected function loadProductClassFromCartItem(CartItem $CartItem)
    {
        $ProductClass = $this
            ->entityManager
            ->getRepository($CartItem->getClassName())
            ->find($CartItem->getClassId());

        $CartItem->setObject($ProductClass);

        if (is_null($this->ProductType) && $ProductClass->getDelFlg() == Constant::DISABLED) {
            $this->setCanAddProductType($ProductClass->getProductType());
        }
    }

    public function setCanAddProductType(\Eccube\Entity\Master\ProductType $ProductType)

    {
        if (is_null($this->ProductType)) {
            $this->ProductType = $ProductType;
        }

        return $this;
    }

    public function save()

    {
        return $this->session->set('cart', $this->cart);
    }

    public function unlock()

    {
        $this->cart
            ->setLock(false)
            ->setPreOrderId(null);
    }

    public function lock()

    {
        $this->cart
            ->setLock(true)
            ->setPreOrderId(null);
    }

    /**
     * @return bool
     */
    public function isLocked()
    {
        return $this->cart->getLock();
    }

    /**
     * @param  string $pre_order_id
     * @return \Eccube\Service\CartService
     */
    public function setPreOrderId($pre_order_id)
    {
        $this->cart->setPreOrderId($pre_order_id);

        return $this;
    }

    /**
     * @return string
     */
    public function getPreOrderId()
    {
        return $this->cart->getPreOrderId();
    }

    /**
     * @return \Eccube\Service\CartService
     */
    public function clear()
    {
        $this->cart
            ->setPreOrderId(null)
            ->setLock(false)
            ->clearCartItems();

        return $this;
    }

    public function getCanAddProductType()

    {
        return $this->ProductType;
    }

    /**
     *
     * @param  string $productClassId

     * @param  integer $quantity
     * @return \Eccube\Service\CartService
     */
    public function addProduct($productClassId, $quantity = 1)
    {
        $quantity += $this->getProductQuantity($productClassId);
        $this->setProductQuantity($productClassId, $quantity);

        return $this;
    }

    /**
     * @param  string $productClassId
     * @return integer
     */
    public function getProductQuantity($productClassId)
    {
        $CartItem = $this->cart->getCartItemByIdentifier('Eccube\Entity\ProductClass', (string) $productClassId);
        if ($CartItem) {
            return $CartItem->getQuantity();
        } else {
            return 0;
        }
    }

    /**
     * @param  \Eccube\Entity\ProductClass|integer $ProductClass
     * @param  integer $quantity

     * @return \Eccube\Service\CartService
     * @throws CartException
     */
    public function setProductQuantity($ProductClass, $quantity)
    {
        if (!$ProductClass instanceof ProductClass) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
            $ProductClass = $this->entityManager
                ->getRepository('Eccube\Entity\ProductClass')
                ->find($ProductClass);
            if (!$ProductClass) {
                throw new CartException('cart.product.delete');
            }
        }
        if ($ProductClass->getProduct()->getStatus()->getId() !== Disp::DISPLAY_SHOW) {
            $this->removeProduct($ProductClass->getId());
            throw new CartException('cart.product.not.status');
        }

        $productName = $ProductClass->getProduct()->getName();
        if ($ProductClass->hasClassCategory1()) {
            $productName .= " - ".$ProductClass->getClassCategory1()->getName();
        }
        if ($ProductClass->hasClassCategory2()) {
            $productName .= " - ".$ProductClass->getClassCategory2()->getName();
        }

        // 商品種別に紐づく配送業者を取得
        $deliveries = $this->app['eccube.repository.delivery']->getDeliveries($ProductClass->getProductType());

        if (count($deliveries) == 0) {
            // 商品種別が存在しなければエラー
            $this->removeProduct($ProductClass->getId());
            $this->addError('cart.product.not.producttype', $productName);
            throw new CartException('cart.product.not.producttype');
        }

        $this->setCanAddProductType($ProductClass->getProductType());

        if ($this->BaseInfo->getOptionMultipleShipping() != Constant::ENABLED) {
            if (!$this->canAddProduct($ProductClass->getId())) {
                // 複数配送対応でなければ商品種別が異なればエラー
                throw new CartException('cart.product.type.kind');
            }
        } else {
            // 複数配送の場合、同一支払方法がなければエラー
            if (!$this->canAddProductPayment($ProductClass->getProductType())) {
                throw new CartException('cart.product.payment.kind');
            }


        }

        $tmp_subtotal = 0;
        $tmp_quantity = 0;
        foreach ($this->getCart()->getCartItems() as $cartitem) {
            $pc = $cartitem->getObject();
            if ($pc->getId() != $ProductClass->getId()) {
                // まず、追加された商品以外のtotal priceをセット
                $tmp_subtotal += $cartitem->getTotalPrice();
            }
        }
        for ($i = 0; $i < $quantity; $i++) {
            $tmp_subtotal += $ProductClass->getPrice02IncTax();
            if ($tmp_subtotal > $this->app['config']['max_total_fee']) {
                $this->setError('cart.over.price_limit');
                break;
            }
            $tmp_quantity++;
        }
        $quantity = $tmp_quantity;

        $tmp_quantity = 0;

        /*
         * 実際の在庫は ProductClass::ProductStock だが、購入時にロックがかかるため、
         * ここでは ProductClass::stock で在庫のチェックをする
         */
        if (!$ProductClass->getStockUnlimited() && $quantity > $ProductClass->getStock()) {
            if ($ProductClass->getSaleLimit() && $ProductClass->getStock() > $ProductClass->getSaleLimit()) {
                $tmp_quantity = $ProductClass->getSaleLimit();
                $this->addError('cart.over.sale_limit', $productName);
            } else {
                $tmp_quantity = $ProductClass->getStock();
                $this->addError('cart.over.stock', $productName);
            }
        }
        if ($ProductClass->getSaleLimit() && $quantity > $ProductClass->getSaleLimit()) {
            $tmp_quantity = $ProductClass->getSaleLimit();
            $this->addError('cart.over.sale_limit', $productName);
        }
        if ($tmp_quantity) {
            $quantity = $tmp_quantity;
        }

        $CartItem = new CartItem();
        $CartItem
            ->setClassName('Eccube\Entity\ProductClass')
            ->setClassId((string) $ProductClass->getId())
            ->setPrice($ProductClass->getPrice02IncTax())
            ->setQuantity($quantity);

        $this->cart->setCartItem($CartItem);

        return $this;
    }

    /**
     * @param  string $productClassId
     * @return boolean
     */
    public function canAddProduct($productClassId)
    {
        $ProductClass = $this
            ->entityManager
            ->getRepository('\Eccube\Entity\ProductClass')
            ->find($productClassId);

        if (!$ProductClass) {
            return false;
        }

        $ProductType = $ProductClass->getProductType();

        return $this->ProductType == $ProductType;
    }

    /**
     * @param \Eccube\Entity\Master\ProductType $ProductType
     * @return bool
     */
    public function canAddProductPayment(\Eccube\Entity\Master\ProductType $ProductType)
    {
        $deliveries = $this
            ->entityManager
            ->getRepository('\Eccube\Entity\Delivery')
            ->findBy(array('ProductType' => $ProductType));

        // 支払方法を取得
        $payments = $this->entityManager->getRepository('Eccube\Entity\Payment')->findAllowedPayments($deliveries);

        if ($this->getCart()->getTotalPrice() < 1) {
            // カートになければ支払方法を全て設定
            $this->getCart()->setPayments($payments);
            return true;

        }

        // カートに存在している支払方法と追加された商品の支払方法チェック
        $arr = array();
        foreach ($payments as $payment) {
            foreach ($this->getCart()->getPayments() as $p) {
                if ($payment['id'] == $p['id']) {
                    $arr[] = $payment;
                    break;
                }
            }
        }

        if (count($arr) > 0) {
            $this->getCart()->setPayments($arr);
            return true;

        }

        // 支払条件に一致しない
        return false;

    }

    /**
     * カートを取得します。
     *
     * @return \Eccube\Entity\Cart
     */
    public function getCart()
    {
        foreach ($this->cart->getCartItems() as $CartItem) {
            $ProductClass = $CartItem->getObject();
            if (!$ProductClass) {
                $this->loadProductClassFromCartItem($CartItem);

                $ProductClass = $CartItem->getObject();
            }

            if ($ProductClass->getDelFlg() == Constant::DISABLED) {
                // 商品情報が有効
                $stockUnlimited = $ProductClass->getStockUnlimited();
                if ($stockUnlimited == Constant::DISABLED && $ProductClass->getStock() < 1) {
                    // 在庫がなければカートから削除
                    $this->setError('cart.zero.stock');
                    $this->removeProduct($ProductClass->getId());
                } else {
                    $quantity = $CartItem->getQuantity();
                    $saleLimit = $ProductClass->getSaleLimit();
                    if ($stockUnlimited == Constant::DISABLED && $ProductClass->getStock() < $quantity) {
                        // 購入数が在庫数を超えている場合、メッセージを表示
                        $this->setError('cart.over.stock');
                    } elseif (!is_null($saleLimit) && $saleLimit < $quantity) {
                        // 購入数が販売制限数を超えている場合、メッセージを表示
                        $this->setError('cart.over.sale_limit');
                    }
                }
            } else {
                // 商品情報が削除されていたらエラー
                $this->setError('cart.product.delete');
                // カートから削除
                $this->removeProduct($ProductClass->getId());
            }
        }

        return $this->cart;
    }

    /**
     * @param  string $productClassId
     * @return \Eccube\Service\CartService
     */
    public function removeProduct($productClassId)
    {
        $this->cart->removeCartItemByIdentifier('Eccube\Entity\ProductClass', (string) $productClassId);

        // 支払方法の再設定
        if ($this->BaseInfo->getOptionMultipleShipping() == Constant::ENABLED) {


            // 複数配送対応
            $productTypes = array();
            foreach ($this->getCart()->getCartItems() as $item) {
                /* @var $ProductClass \Eccube\Entity\ProductClass */
                $ProductClass = $item->getObject();
                $productTypes[] = $ProductClass->getProductType();
            }

            // 配送業者を取得
            $deliveries = $this->entityManager->getRepository('Eccube\Entity\Delivery')->getDeliveries($productTypes);

            // 支払方法を取得
            $payments = $this->entityManager->getRepository('Eccube\Entity\Payment')->findAllowedPayments($deliveries);

            $this->getCart()->setPayments($payments);
        }

        return $this;
    }

    /**
     * @param  string $error
     * @param  string $productName
     * @return \Eccube\Service\CartService
     */
    public function addError($error = null, $productName = null)
    {
        $this->errors[] = $error;
        $this->session->getFlashBag()->add('eccube.front.request.error', $error);
        if (!is_null($productName)) {
            $this->session->getFlashBag()->add('eccube.front.request.product', $productName);
        }
        return $this;

    }

    /**
     * @param  string $productClassId
     * @return \Eccube\Service\CartService
     */
    public function upProductQuantity($productClassId)
    {
        $quantity = $this->getProductQuantity($productClassId) + 1;
        $this->setProductQuantity($productClassId, $quantity);

        return $this;
    }

    /**
     * @param  string $productClassId
     * @return \Eccube\Service\CartService
     */
    public function downProductQuantity($productClassId)
    {
        $quantity = $this->getProductQuantity($productClassId) - 1;
        if ($quantity > 0) {
            $this->setProductQuantity($productClassId, $quantity);
        }

        return $this;
    }

    /**
     * @return array
     */
    public function getProductTypes()
    {

        $productTypes = array();
        foreach ($this->getCart()->getCartItems() as $item) {
            /* @var $ProductClass \Eccube\Entity\ProductClass */
            $ProductClass = $item->getObject();
            $productTypes[] = $ProductClass->getProductType();
        }
        return array_unique($productTypes);


    }

    /**
     * @return string[]
     */
    public function getErrors()
    {
        return $this->errors;
    }

    /**
     * @return string[]
     */
    public function getMessages()
    {
        return $this->messages;
    }

    /**
     * @param  string $message
     * @return \Eccube\Service\CartService
     */
    public function setMessage($message)
    {
        $this->messages[] = $message;

        return $this;
    }

    /**
     * @return string
     */
    public function getError()
    {
        return $this->error;
    }

    /**
     * @param  string $error
     * @return \Eccube\Service\CartService
     */
    public function setError($error = null)
    {
        $this->error = $error;

        $this->session->getFlashBag()->set('eccube.front.request.error', $error);
        return $this;

    }

}


Push — master ( c2113a...957c9d )

CartService::getProductQuantity() A

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing dependencies

2. Missing use statement

1		<?php
2		/*
3		* This file is part of EC-CUBE
4		*
5		* Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
6		*
7		* http://www.lockon.co.jp/
8		*
9		* This program is free software; you can redistribute it and/or
10		* modify it under the terms of the GNU General Public License
11		* as published by the Free Software Foundation; either version 2
12		* of the License, or (at your option) any later version.
13		*
14		* This program is distributed in the hope that it will be useful,
15		* but WITHOUT ANY WARRANTY; without even the implied warranty of
16		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17		* GNU General Public License for more details.
18		*
19		* You should have received a copy of the GNU General Public License
20		* along with this program; if not, write to the Free Software
21		* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
22		*/
23
24
25		namespace Eccube\Service;
26
27		use Doctrine\ORM\EntityManager;
28		use Eccube\Common\Constant;
29		use Eccube\Entity\CartItem;
30		use Eccube\Entity\Master\Disp;
31		use Eccube\Entity\ProductClass;
32		use Eccube\Exception\CartException;
33		use Symfony\Component\HttpFoundation\Session\Session;
34
35		class CartService
		0 ignored issues – show introduced 2015-11-21 02:41 UTC by Report Bug Copy Issue Report Missing class doc comment Loading history...
36		{
37		/** @var \Eccube\Application */
38		public $app;
39
40		/**
41		* @var Session
42		*/
43		private $session;
44
45		/**
46		* @var EntityManager
47		*/
48		private $entityManager;
49
50		/**
51		* @var \Eccube\Entity\Cart
52		*/
53		private $cart;
54
55		/**
56		* @var \Eccube\Entity\BaseInfo
57		*/
58		private $BaseInfo;
59
60		/**
61		* @var array
62		*/
63		private $errors = array();
64
65		private $ProductType = null;
66
67		/**
68		* @var array
69		*/
70		private $messages = array();
71
72		/**
73		* @var array
74		*/
75		private $error;
76
77	218	public function __construct(\Eccube\Application $app)
		0 ignored issues – show introduced 2015-11-21 02:41 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
78		{
79	218	$this->app = $app;
80	218	$this->session = $app['session'];
81	218	$this->entityManager = $app['orm.em'];
82
83	218	if ($this->session->has('cart')) {
84		$this->cart = $this->session->get('cart');
85		} else {
86	218	$this->cart = new \Eccube\Entity\Cart();
87		}
88
89	218	$this->loadProductClassFromCart();
90
91	218	$this->BaseInfo = $app['eccube.repository.base_info']->get();
92		}
93
94		/**
95		* カートに保存されている商品の ProductClass エンティティを読み込み、カートへ設定します。
96		*/
97	218	protected function loadProductClassFromCart()
98		{
99		/* @var $softDeleteFilter \Eccube\Doctrine\Filter\SoftDeleteFilter */
100	218	$softDeleteFilter = $this->entityManager->getFilters()->getFilter('soft_delete');
101	218	$excludes = $softDeleteFilter->getExcludes();
102	218	$softDeleteFilter->setExcludes(array(
103	218	'Eccube\Entity\ProductClass',
104		));
105
106	218	foreach ($this->cart->getCartItems() as $CartItem) {
107	218	$this->loadProductClassFromCartItem($CartItem);
108		}
109
110	218	$softDeleteFilter->setExcludes($excludes);
111		}
112
113		/**
114		* CartItem に対応する ProductClass を設定します。
115		*
116		* @param CartItem $CartItem
117		*/
118	85	protected function loadProductClassFromCartItem(CartItem $CartItem)
119		{
120		$ProductClass = $this
121	85	->entityManager
122	85	->getRepository($CartItem->getClassName())
123	85	->find($CartItem->getClassId());
124
125	85	$CartItem->setObject($ProductClass);
126
127	85	if (is_null($this->ProductType) && $ProductClass->getDelFlg() == Constant::DISABLED) {
128		$this->setCanAddProductType($ProductClass->getProductType());
129		}
130		}
131
132	124	public function setCanAddProductType(\Eccube\Entity\Master\ProductType $ProductType)
		0 ignored issues – show introduced 2015-12-13 02:12 UTC by Report Bug Copy Issue Report Declare public methods first, then protected ones and finally private ones Loading history... introduced 2015-11-21 02:41 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
133		{
134	124	if (is_null($this->ProductType)) {
135	124	$this->ProductType = $ProductType;
136		}
137
138	124	return $this;
139		}
140
141	118	public function save()
		0 ignored issues – show introduced 2015-11-21 02:41 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
142		{
143	118	return $this->session->set('cart', $this->cart);
144		}
145
146	8	public function unlock()
		0 ignored issues – show introduced 2015-11-21 02:41 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
147		{
148	8	$this->cart
149	8	->setLock(false)
150	8	->setPreOrderId(null);
151		}
152
153	74	public function lock()
		0 ignored issues – show introduced 2015-11-21 02:41 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
154		{
155	74	$this->cart
156	74	->setLock(true)
157	74	->setPreOrderId(null);
158		}
159
160		/**
161		* @return bool
162		*/
163	83	public function isLocked()
164		{
165	83	return $this->cart->getLock();
166		}
167
168		/**
169		* @param string $pre_order_id
170		* @return \Eccube\Service\CartService
171		*/
172	75	public function setPreOrderId($pre_order_id)
173		{
174	75	$this->cart->setPreOrderId($pre_order_id);
175
176	75	return $this;
177		}
178
179		/**
180		* @return string
181		*/
182	73	public function getPreOrderId()
183		{
184	73	return $this->cart->getPreOrderId();
185		}
186
187		/**
188		* @return \Eccube\Service\CartService
189		*/
190	22	public function clear()
191		{
192	22	$this->cart
193	22	->setPreOrderId(null)
194	22	->setLock(false)
195	22	->clearCartItems();
196
197	22	return $this;
198		}
199
200	1	public function getCanAddProductType()
		0 ignored issues – show introduced 2015-11-21 02:41 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
201		{
202	1	return $this->ProductType;
203		}
204
205		/**
206		*
207		* @param string $productClassId
		0 ignored issues – show introduced 2015-11-21 02:41 UTC by Report Bug Copy Issue Report Expected 2 spaces after parameter type; 1 found Loading history...
208		* @param integer $quantity
209		* @return \Eccube\Service\CartService
210		*/
211	80	public function addProduct($productClassId, $quantity = 1)
212		{
213	80	$quantity += $this->getProductQuantity($productClassId);
214	80	$this->setProductQuantity($productClassId, $quantity);
215
216	79	return $this;
217		}
218
219		/**
220		* @param string $productClassId
221		* @return integer
222		*/
223	89	public function getProductQuantity($productClassId)
224		{
225	89	$CartItem = $this->cart->getCartItemByIdentifier('Eccube\Entity\ProductClass', (string) $productClassId);
226	89	if ($CartItem) {
227	37	return $CartItem->getQuantity();
228		} else {
229	86	return 0;
230		}
231		}
232
233		/**
234		* @param \Eccube\Entity\ProductClass\|integer $ProductClass
235		* @param integer $quantity
		0 ignored issues – show introduced 2015-11-21 02:41 UTC by Report Bug Copy Issue Report Expected 29 spaces after parameter type; 1 found Loading history...
236		* @return \Eccube\Service\CartService
237		* @throws CartException
238		*/
239	127	public function setProductQuantity($ProductClass, $quantity)
240		{
241	127	if (!$ProductClass instanceof ProductClass) {
		0 ignored issues – show Bug introduced 2015-12-14 01:00 UTC by Report Bug Copy Issue Report The class `Eccube\Entity\ProductClass` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
242	122	$ProductClass = $this->entityManager
243	122	->getRepository('Eccube\Entity\ProductClass')
244	122	->find($ProductClass);
245	122	if (!$ProductClass) {
246	3	throw new CartException('cart.product.delete');
247		}
248		}
249	124	if ($ProductClass->getProduct()->getStatus()->getId() !== Disp::DISPLAY_SHOW) {
250	1	$this->removeProduct($ProductClass->getId());
251	1	throw new CartException('cart.product.not.status');
252		}
253
254	123	$productName = $ProductClass->getProduct()->getName();
255	123	if ($ProductClass->hasClassCategory1()) {
256	123	$productName .= " - ".$ProductClass->getClassCategory1()->getName();
257		}
258	123	if ($ProductClass->hasClassCategory2()) {
259	114	$productName .= " - ".$ProductClass->getClassCategory2()->getName();
260		}
261
262		// 商品種別に紐づく配送業者を取得
263	123	$deliveries = $this->app['eccube.repository.delivery']->getDeliveries($ProductClass->getProductType());
264
265	123	if (count($deliveries) == 0) {
266		// 商品種別が存在しなければエラー
267		$this->removeProduct($ProductClass->getId());
268		$this->addError('cart.product.not.producttype', $productName);
269		throw new CartException('cart.product.not.producttype');
270		}
271
272	123	$this->setCanAddProductType($ProductClass->getProductType());
273
274	123	if ($this->BaseInfo->getOptionMultipleShipping() != Constant::ENABLED) {
275	79	if (!$this->canAddProduct($ProductClass->getId())) {
276		// 複数配送対応でなければ商品種別が異なればエラー
277	79	throw new CartException('cart.product.type.kind');
278		}
279		} else {
280		// 複数配送の場合、同一支払方法がなければエラー
281	44	if (!$this->canAddProductPayment($ProductClass->getProductType())) {
282	1	throw new CartException('cart.product.payment.kind');
283		}
284
		0 ignored issues – show Coding Style introduced 2016-03-01 10:06 UTC by Report Bug Copy Issue Report Blank line found at end of control structure Loading history...
285		}
286
287	123	$tmp_subtotal = 0;
288	123	$tmp_quantity = 0;
289	123	foreach ($this->getCart()->getCartItems() as $cartitem) {
290	43	$pc = $cartitem->getObject();
291	43	if ($pc->getId() != $ProductClass->getId()) {
292		// まず、追加された商品以外のtotal priceをセット
293	123	$tmp_subtotal += $cartitem->getTotalPrice();
294		}
295		}
296	123	for ($i = 0; $i < $quantity; $i++) {
297	123	$tmp_subtotal += $ProductClass->getPrice02IncTax();
298	123	if ($tmp_subtotal > $this->app['config']['max_total_fee']) {
299	1	$this->setError('cart.over.price_limit');
300	1	break;
301		}
302	122	$tmp_quantity++;
303		}
304	123	$quantity = $tmp_quantity;
305
306	123	$tmp_quantity = 0;
307
308		/*
309		* 実際の在庫は ProductClass::ProductStock だが、購入時にロックがかかるため、
310		* ここでは ProductClass::stock で在庫のチェックをする
311		*/
312	123	if (!$ProductClass->getStockUnlimited() && $quantity > $ProductClass->getStock()) {
313	2	if ($ProductClass->getSaleLimit() && $ProductClass->getStock() > $ProductClass->getSaleLimit()) {
314	1	$tmp_quantity = $ProductClass->getSaleLimit();
315	1	$this->addError('cart.over.sale_limit', $productName);
316		} else {
317	1	$tmp_quantity = $ProductClass->getStock();
318	1	$this->addError('cart.over.stock', $productName);
319		}
320		}
321	123	if ($ProductClass->getSaleLimit() && $quantity > $ProductClass->getSaleLimit()) {
322	2	$tmp_quantity = $ProductClass->getSaleLimit();
323	2	$this->addError('cart.over.sale_limit', $productName);
324		}
325	123	if ($tmp_quantity) {
326	3	$quantity = $tmp_quantity;
327		}
328
329	123	$CartItem = new CartItem();
330		$CartItem
331	123	->setClassName('Eccube\Entity\ProductClass')
332	123	->setClassId((string) $ProductClass->getId())
333	123	->setPrice($ProductClass->getPrice02IncTax())
334	123	->setQuantity($quantity);
335
336	123	$this->cart->setCartItem($CartItem);
337
338	123	return $this;
339		}
340
341		/**
342		* @param string $productClassId
343		* @return boolean
344		*/
345	79	public function canAddProduct($productClassId)
346		{
347		$ProductClass = $this
348	79	->entityManager
349	79	->getRepository('\Eccube\Entity\ProductClass')
350	79	->find($productClassId);
351
352	79	if (!$ProductClass) {
353		return false;
354		}
355
356	79	$ProductType = $ProductClass->getProductType();
357
358	79	return $this->ProductType == $ProductType;
359		}
360
361		/**
362		* @param \Eccube\Entity\Master\ProductType $ProductType
363		* @return bool
364		*/
365	45	public function canAddProductPayment(\Eccube\Entity\Master\ProductType $ProductType)
366		{
367		$deliveries = $this
368	45	->entityManager
369	45	->getRepository('\Eccube\Entity\Delivery')
370	45	->findBy(array('ProductType' => $ProductType));
371
372		// 支払方法を取得
373	45	$payments = $this->entityManager->getRepository('Eccube\Entity\Payment')->findAllowedPayments($deliveries);
374
375	45	if ($this->getCart()->getTotalPrice() < 1) {
376		// カートになければ支払方法を全て設定
377	45	$this->getCart()->setPayments($payments);
378	45	return true;
		0 ignored issues – show introduced 2016-03-29 12:43 UTC by Report Bug Copy Issue Report Missing blank line before return statement Loading history...
379		}
380
381		// カートに存在している支払方法と追加された商品の支払方法チェック
382	41	$arr = array();
383	41	foreach ($payments as $payment) {
384	41	foreach ($this->getCart()->getPayments() as $p) {
385	41	if ($payment['id'] == $p['id']) {
386	40	$arr[] = $payment;
387	41	break;
388		}
389		}
390		}
391
392	41	if (count($arr) > 0) {
393	40	$this->getCart()->setPayments($arr);
394	40	return true;
		0 ignored issues – show introduced 2016-03-29 12:43 UTC by Report Bug Copy Issue Report Missing blank line before return statement Loading history...
395		}
396
397		// 支払条件に一致しない
398	1	return false;
399
400		}
401
402		/**
403		* カートを取得します。
404		*
405		* @return \Eccube\Entity\Cart
406		*/
407	195	public function getCart()
408		{
409	195	foreach ($this->cart->getCartItems() as $CartItem) {
410	85	$ProductClass = $CartItem->getObject();
411	85	if (!$ProductClass) {
412	85	$this->loadProductClassFromCartItem($CartItem);
413
414	85	$ProductClass = $CartItem->getObject();
415		}
416
417	85	if ($ProductClass->getDelFlg() == Constant::DISABLED) {
418		// 商品情報が有効
419	85	$stockUnlimited = $ProductClass->getStockUnlimited();
420	85	if ($stockUnlimited == Constant::DISABLED && $ProductClass->getStock() < 1) {
421		// 在庫がなければカートから削除
422		$this->setError('cart.zero.stock');
423		$this->removeProduct($ProductClass->getId());
424		} else {
425	85	$quantity = $CartItem->getQuantity();
426	85	$saleLimit = $ProductClass->getSaleLimit();
427	85	if ($stockUnlimited == Constant::DISABLED && $ProductClass->getStock() < $quantity) {
428		// 購入数が在庫数を超えている場合、メッセージを表示
429		$this->setError('cart.over.stock');
430	85	} elseif (!is_null($saleLimit) && $saleLimit < $quantity) {
431		// 購入数が販売制限数を超えている場合、メッセージを表示
432	85	$this->setError('cart.over.sale_limit');
433		}
434		}
435		} else {
436		// 商品情報が削除されていたらエラー
437		$this->setError('cart.product.delete');
438		// カートから削除
439	195	$this->removeProduct($ProductClass->getId());
440		}
441		}
442
443	195	return $this->cart;
444		}
445
446		/**
447		* @param string $productClassId
448		* @return \Eccube\Service\CartService
449		*/
450	5	public function removeProduct($productClassId)
451		{
452	5	$this->cart->removeCartItemByIdentifier('Eccube\Entity\ProductClass', (string) $productClassId);
453
454		// 支払方法の再設定
455	5	if ($this->BaseInfo->getOptionMultipleShipping() == Constant::ENABLED) {
		0 ignored issues – show Coding Style introduced 2016-03-01 10:06 UTC by Report Bug Copy Issue Report Blank line found at start of control structure Loading history...
456
457		// 複数配送対応
458	1	$productTypes = array();
459	1	foreach ($this->getCart()->getCartItems() as $item) {
460		/* @var $ProductClass \Eccube\Entity\ProductClass */
461	1	$ProductClass = $item->getObject();
462	1	$productTypes[] = $ProductClass->getProductType();
463		}
464
465		// 配送業者を取得
466	1	$deliveries = $this->entityManager->getRepository('Eccube\Entity\Delivery')->getDeliveries($productTypes);
467
468		// 支払方法を取得
469	1	$payments = $this->entityManager->getRepository('Eccube\Entity\Payment')->findAllowedPayments($deliveries);
470
471	1	$this->getCart()->setPayments($payments);
472		}
473
474	5	return $this;
475		}
476
477		/**
478		* @param string $error
479		* @param string $productName
480		* @return \Eccube\Service\CartService
481		*/
482	4	public function addError($error = null, $productName = null)
483		{
484	4	$this->errors[] = $error;
485	4	$this->session->getFlashBag()->add('eccube.front.request.error', $error);
486	4	if (!is_null($productName)) {
487	3	$this->session->getFlashBag()->add('eccube.front.request.product', $productName);
488		}
489	4	return $this;
		0 ignored issues – show introduced 2016-03-29 12:43 UTC by Report Bug Copy Issue Report Missing blank line before return statement Loading history...
490		}
491
492		/**
493		* @param string $productClassId
494		* @return \Eccube\Service\CartService
495		*/
496	4	public function upProductQuantity($productClassId)
497		{
498	4	$quantity = $this->getProductQuantity($productClassId) + 1;
499	4	$this->setProductQuantity($productClassId, $quantity);
500
501	3	return $this;
502		}
503
504		/**
505		* @param string $productClassId
506		* @return \Eccube\Service\CartService
507		*/
508	5	public function downProductQuantity($productClassId)
509		{
510	5	$quantity = $this->getProductQuantity($productClassId) - 1;
511	5	if ($quantity > 0) {
512	1	$this->setProductQuantity($productClassId, $quantity);
513		}
514
515	5	return $this;
516		}
517
518		/**
519		* @return array
520		*/
521	75	public function getProductTypes()
522		{
523
524	75	$productTypes = array();
525	75	foreach ($this->getCart()->getCartItems() as $item) {
526		/* @var $ProductClass \Eccube\Entity\ProductClass */
527	75	$ProductClass = $item->getObject();
528	75	$productTypes[] = $ProductClass->getProductType();
529		}
530	75	return array_unique($productTypes);
		0 ignored issues – show introduced 2015-11-21 02:41 UTC by Report Bug Copy Issue Report Missing blank line before return statement Loading history...
531
532		}
533
534		/**
535		* @return string[]
536		*/
537	3	public function getErrors()
538		{
539	3	return $this->errors;
540		}
541
542		/**
543		* @return string[]
544		*/
545	1	public function getMessages()
546		{
547	1	return $this->messages;
548		}
549
550		/**
551		* @param string $message
552		* @return \Eccube\Service\CartService
553		*/
554	1	public function setMessage($message)
555		{
556	1	$this->messages[] = $message;
557
558	1	return $this;
559		}
560
561		/**
562		* @return string
563		*/
564	1	public function getError()
565		{
566	1	return $this->error;
567		}
568
569		/**
570		* @param string $error
571		* @return \Eccube\Service\CartService
572		*/
573	1	public function setError($error = null)
574		{
575	1	$this->error = $error;
		0 ignored issues – show Documentation Bug introduced 2015-11-21 02:41 UTC by Report Bug Copy Issue Report It seems like `$error` of type `string` or `null` is incompatible with the declared type `array` of property `$error`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
576	1	$this->session->getFlashBag()->set('eccube.front.request.error', $error);
577	1	return $this;
		0 ignored issues – show introduced 2017-02-13 01:45 UTC by Report Bug Copy Issue Report Missing blank line before return statement Loading history...
578		}
579
580		}
581

EC-CUBE / ec-cube

Push — master ( c2113a...957c9d )

CartService::getProductQuantity() A

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like