Completed
Pull Request — master (#1504)
by Kentaro
60:07 queued 04:12
created
src/Eccube/ServiceProvider/EccubeServiceProvider.php 1 patch
Spacing   +58 added lines, -58 removed lines patch added patch discarded remove patch
@@ -41,28 +41,28 @@  discard block
 block discarded – undo
41 41
     public function register(BaseApplication $app)
42 42
     {
43 43
         // Service
44
-        $app['eccube.service.system'] = $app->share(function () use ($app) {
44
+        $app['eccube.service.system'] = $app->share(function() use ($app) {
45 45
             return new \Eccube\Service\SystemService($app);
46 46
         });
47
-        $app['view'] = $app->share(function () use ($app) {
47
+        $app['view'] = $app->share(function() use ($app) {
48 48
             return $app['twig'];
49 49
         });
50
-        $app['eccube.service.cart'] = $app->share(function () use ($app) {
50
+        $app['eccube.service.cart'] = $app->share(function() use ($app) {
51 51
             return new \Eccube\Service\CartService($app);
52 52
         });
53
-        $app['eccube.service.order'] = $app->share(function () use ($app) {
53
+        $app['eccube.service.order'] = $app->share(function() use ($app) {
54 54
             return new \Eccube\Service\OrderService($app);
55 55
         });
56
-        $app['eccube.service.tax_rule'] = $app->share(function () use ($app) {
56
+        $app['eccube.service.tax_rule'] = $app->share(function() use ($app) {
57 57
             return new \Eccube\Service\TaxRuleService($app['eccube.repository.tax_rule']);
58 58
         });
59
-        $app['eccube.service.plugin'] = $app->share(function () use ($app) {
59
+        $app['eccube.service.plugin'] = $app->share(function() use ($app) {
60 60
             return new \Eccube\Service\PluginService($app);
61 61
         });
62
-        $app['eccube.service.mail'] = $app->share(function () use ($app) {
62
+        $app['eccube.service.mail'] = $app->share(function() use ($app) {
63 63
             return new \Eccube\Service\MailService($app);
64 64
         });
65
-        $app['eccube.service.csv.export'] = $app->share(function () use ($app) {
65
+        $app['eccube.service.csv.export'] = $app->share(function() use ($app) {
66 66
             $csvService = new \Eccube\Service\CsvExportService();
67 67
             $csvService->setConfig($app['config']);
68 68
             $csvService->setCsvRepository($app['eccube.repository.csv']);
@@ -73,170 +73,170 @@  discard block
 block discarded – undo
73 73
 
74 74
             return $csvService;
75 75
         });
76
-        $app['eccube.service.shopping'] = $app->share(function () use ($app) {
76
+        $app['eccube.service.shopping'] = $app->share(function() use ($app) {
77 77
             return new \Eccube\Service\ShoppingService($app, $app['eccube.service.cart'], $app['eccube.service.order']);
78 78
         });
79 79
 
80 80
         // Repository
81
-        $app['eccube.repository.master.authority'] = $app->share(function () use ($app) {
81
+        $app['eccube.repository.master.authority'] = $app->share(function() use ($app) {
82 82
             return $app['orm.em']->getRepository('Eccube\Entity\Master\Authority');
83 83
         });
84
-        $app['eccube.repository.master.tag'] = $app->share(function () use ($app) {
84
+        $app['eccube.repository.master.tag'] = $app->share(function() use ($app) {
85 85
             return $app['orm.em']->getRepository('Eccube\Entity\Master\Tag');
86 86
         });
87
-        $app['eccube.repository.master.pref'] = $app->share(function () use ($app) {
87
+        $app['eccube.repository.master.pref'] = $app->share(function() use ($app) {
88 88
             return $app['orm.em']->getRepository('Eccube\Entity\Master\Pref');
89 89
         });
90
-        $app['eccube.repository.master.sex'] = $app->share(function () use ($app) {
90
+        $app['eccube.repository.master.sex'] = $app->share(function() use ($app) {
91 91
             return $app['orm.em']->getRepository('Eccube\Entity\Master\Sex');
92 92
         });
93
-        $app['eccube.repository.master.disp'] = $app->share(function () use ($app) {
93
+        $app['eccube.repository.master.disp'] = $app->share(function() use ($app) {
94 94
             return $app['orm.em']->getRepository('Eccube\Entity\Master\Disp');
95 95
         });
96
-        $app['eccube.repository.master.product_type'] = $app->share(function () use ($app) {
96
+        $app['eccube.repository.master.product_type'] = $app->share(function() use ($app) {
97 97
             return $app['orm.em']->getRepository('Eccube\Entity\Master\ProductType');
98 98
         });
99
-        $app['eccube.repository.master.page_max'] = $app->share(function () use ($app) {
99
+        $app['eccube.repository.master.page_max'] = $app->share(function() use ($app) {
100 100
             return $app['orm.em']->getRepository('Eccube\Entity\Master\PageMax');
101 101
         });
102
-        $app['eccube.repository.master.order_status'] = $app->share(function () use ($app) {
102
+        $app['eccube.repository.master.order_status'] = $app->share(function() use ($app) {
103 103
             return $app['orm.em']->getRepository('Eccube\Entity\Master\OrderStatus');
104 104
         });
105
-        $app['eccube.repository.master.device_type'] = $app->share(function () use ($app) {
105
+        $app['eccube.repository.master.device_type'] = $app->share(function() use ($app) {
106 106
             return $app['orm.em']->getRepository('Eccube\Entity\Master\DeviceType');
107 107
         });
108
-        $app['eccube.repository.master.csv_type'] = $app->share(function () use ($app) {
108
+        $app['eccube.repository.master.csv_type'] = $app->share(function() use ($app) {
109 109
             return $app['orm.em']->getRepository('Eccube\Entity\Master\CsvType');
110 110
         });
111 111
 
112
-        $app['eccube.repository.delivery'] = $app->share(function () use ($app) {
112
+        $app['eccube.repository.delivery'] = $app->share(function() use ($app) {
113 113
             return $app['orm.em']->getRepository('Eccube\Entity\Delivery');
114 114
         });
115
-        $app['eccube.repository.delivery_date'] = $app->share(function () use ($app) {
115
+        $app['eccube.repository.delivery_date'] = $app->share(function() use ($app) {
116 116
             return $app['orm.em']->getRepository('Eccube\Entity\DeliveryDate');
117 117
         });
118
-        $app['eccube.repository.delivery_fee'] = $app->share(function () use ($app) {
118
+        $app['eccube.repository.delivery_fee'] = $app->share(function() use ($app) {
119 119
             return $app['orm.em']->getRepository('Eccube\Entity\DeliveryFee');
120 120
         });
121
-        $app['eccube.repository.delivery_time'] = $app->share(function () use ($app) {
121
+        $app['eccube.repository.delivery_time'] = $app->share(function() use ($app) {
122 122
             return $app['orm.em']->getRepository('Eccube\Entity\DeliveryTime');
123 123
         });
124
-        $app['eccube.repository.payment'] = $app->share(function () use ($app) {
124
+        $app['eccube.repository.payment'] = $app->share(function() use ($app) {
125 125
             return $app['orm.em']->getRepository('Eccube\Entity\Payment');
126 126
         });
127
-        $app['eccube.repository.payment_option'] = $app->share(function () use ($app) {
127
+        $app['eccube.repository.payment_option'] = $app->share(function() use ($app) {
128 128
             return $app['orm.em']->getRepository('Eccube\Entity\PaymentOption');
129 129
         });
130
-        $app['eccube.repository.category'] = $app->share(function () use ($app) {
130
+        $app['eccube.repository.category'] = $app->share(function() use ($app) {
131 131
             return $app['orm.em']->getRepository('Eccube\Entity\Category');
132 132
         });
133
-        $app['eccube.repository.customer'] = $app->share(function () use ($app) {
133
+        $app['eccube.repository.customer'] = $app->share(function() use ($app) {
134 134
             return $app['orm.em']->getRepository('Eccube\Entity\Customer');
135 135
         });
136
-        $app['eccube.repository.news'] = $app->share(function () use ($app) {
136
+        $app['eccube.repository.news'] = $app->share(function() use ($app) {
137 137
             return $app['orm.em']->getRepository('Eccube\Entity\News');
138 138
         });
139
-        $app['eccube.repository.mail_history'] = $app->share(function () use ($app) {
139
+        $app['eccube.repository.mail_history'] = $app->share(function() use ($app) {
140 140
             return $app['orm.em']->getRepository('Eccube\Entity\MailHistory');
141 141
         });
142
-        $app['eccube.repository.member'] = $app->share(function () use ($app) {
142
+        $app['eccube.repository.member'] = $app->share(function() use ($app) {
143 143
             $memberRepository = $app['orm.em']->getRepository('Eccube\Entity\Member');
144 144
             $memberRepository->setEncoderFactorty($app['security.encoder_factory']);
145 145
             return $memberRepository;
146 146
         });
147
-        $app['eccube.repository.order'] = $app->share(function () use ($app) {
147
+        $app['eccube.repository.order'] = $app->share(function() use ($app) {
148 148
             return $app['orm.em']->getRepository('Eccube\Entity\Order');
149 149
         });
150
-        $app['eccube.repository.product'] = $app->share(function () use ($app) {
150
+        $app['eccube.repository.product'] = $app->share(function() use ($app) {
151 151
             $productRepository = $app['orm.em']->getRepository('Eccube\Entity\Product');
152 152
             return $productRepository;
153 153
         });
154
-        $app['eccube.repository.product_image'] = $app->share(function () use ($app) {
154
+        $app['eccube.repository.product_image'] = $app->share(function() use ($app) {
155 155
             return $app['orm.em']->getRepository('Eccube\Entity\ProductImage');
156 156
         });
157
-        $app['eccube.repository.product_class'] = $app->share(function () use ($app) {
157
+        $app['eccube.repository.product_class'] = $app->share(function() use ($app) {
158 158
             return $app['orm.em']->getRepository('Eccube\Entity\ProductClass');
159 159
         });
160
-        $app['eccube.repository.product_stock'] = $app->share(function () use ($app) {
160
+        $app['eccube.repository.product_stock'] = $app->share(function() use ($app) {
161 161
             return $app['orm.em']->getRepository('Eccube\Entity\ProductStock');
162 162
         });
163
-        $app['eccube.repository.class_name'] = $app->share(function () use ($app) {
163
+        $app['eccube.repository.class_name'] = $app->share(function() use ($app) {
164 164
             return $app['orm.em']->getRepository('Eccube\Entity\ClassName');
165 165
         });
166
-        $app['eccube.repository.class_category'] = $app->share(function () use ($app) {
166
+        $app['eccube.repository.class_category'] = $app->share(function() use ($app) {
167 167
             return $app['orm.em']->getRepository('Eccube\Entity\ClassCategory');
168 168
         });
169
-        $app['eccube.repository.customer_favorite_product'] = $app->share(function () use ($app) {
169
+        $app['eccube.repository.customer_favorite_product'] = $app->share(function() use ($app) {
170 170
             return $app['orm.em']->getRepository('Eccube\Entity\CustomerFavoriteProduct');
171 171
         });
172
-        $app['eccube.repository.base_info'] = $app->share(function () use ($app) {
172
+        $app['eccube.repository.base_info'] = $app->share(function() use ($app) {
173 173
             return $app['orm.em']->getRepository('Eccube\Entity\BaseInfo');
174 174
         });
175
-        $app['eccube.repository.tax_rule'] = $app->share(function () use ($app) {
175
+        $app['eccube.repository.tax_rule'] = $app->share(function() use ($app) {
176 176
             $taxRuleRepository = $app['orm.em']->getRepository('Eccube\Entity\TaxRule');
177 177
             $taxRuleRepository->setApplication($app);
178 178
 
179 179
             return $taxRuleRepository;
180 180
         });
181
-        $app['eccube.repository.page_layout'] = $app->share(function () use ($app) {
181
+        $app['eccube.repository.page_layout'] = $app->share(function() use ($app) {
182 182
             $pageLayoutRepository = $app['orm.em']->getRepository('Eccube\Entity\PageLayout');
183 183
             $pageLayoutRepository->setApplication($app);
184 184
 
185 185
             return $pageLayoutRepository;
186 186
         });
187
-        $app['eccube.repository.block'] = $app->share(function () use ($app) {
187
+        $app['eccube.repository.block'] = $app->share(function() use ($app) {
188 188
             $blockRepository = $app['orm.em']->getRepository('Eccube\Entity\Block');
189 189
             $blockRepository->setApplication($app);
190 190
 
191 191
             return $blockRepository;
192 192
         });
193
-        $app['eccube.repository.order'] = $app->share(function () use ($app) {
193
+        $app['eccube.repository.order'] = $app->share(function() use ($app) {
194 194
             $orderRepository = $app['orm.em']->getRepository('Eccube\Entity\Order');
195 195
             $orderRepository->setApplication($app);
196 196
 
197 197
             return $orderRepository;
198 198
         });
199
-        $app['eccube.repository.customer_address'] = $app->share(function () use ($app) {
199
+        $app['eccube.repository.customer_address'] = $app->share(function() use ($app) {
200 200
             return $app['orm.em']->getRepository('Eccube\Entity\CustomerAddress');
201 201
         });
202
-        $app['eccube.repository.shipping'] = $app->share(function () use ($app) {
202
+        $app['eccube.repository.shipping'] = $app->share(function() use ($app) {
203 203
             return $app['orm.em']->getRepository('Eccube\Entity\Shipping');
204 204
         });
205
-        $app['eccube.repository.customer_status'] = $app->share(function () use ($app) {
205
+        $app['eccube.repository.customer_status'] = $app->share(function() use ($app) {
206 206
             return $app['orm.em']->getRepository('Eccube\Entity\Master\CustomerStatus');
207 207
         });
208
-        $app['eccube.repository.order_status'] = $app->share(function () use ($app) {
208
+        $app['eccube.repository.order_status'] = $app->share(function() use ($app) {
209 209
             return $app['orm.em']->getRepository('Eccube\Entity\Master\OrderStatus');
210 210
         });
211
-        $app['eccube.repository.mail_template'] = $app->share(function () use ($app) {
211
+        $app['eccube.repository.mail_template'] = $app->share(function() use ($app) {
212 212
             return $app['orm.em']->getRepository('Eccube\Entity\MailTemplate');
213 213
         });
214
-        $app['eccube.repository.csv'] = $app->share(function () use ($app) {
214
+        $app['eccube.repository.csv'] = $app->share(function() use ($app) {
215 215
             return $app['orm.em']->getRepository('Eccube\Entity\Csv');
216 216
         });
217
-        $app['eccube.repository.template'] = $app->share(function () use ($app) {
217
+        $app['eccube.repository.template'] = $app->share(function() use ($app) {
218 218
             return $app['orm.em']->getRepository('Eccube\Entity\Template');
219 219
         });
220
-        $app['eccube.repository.authority_role'] = $app->share(function () use ($app) {
220
+        $app['eccube.repository.authority_role'] = $app->share(function() use ($app) {
221 221
             return $app['orm.em']->getRepository('Eccube\Entity\AuthorityRole');
222 222
         });
223 223
 
224
-        $app['paginator'] = $app->protect(function () {
224
+        $app['paginator'] = $app->protect(function() {
225 225
             return new \Knp\Component\Pager\Paginator();
226 226
         });
227 227
 
228
-        $app['eccube.repository.help'] = $app->share(function () use ($app) {
228
+        $app['eccube.repository.help'] = $app->share(function() use ($app) {
229 229
             return $app['orm.em']->getRepository('Eccube\Entity\Help');
230 230
         });
231
-        $app['eccube.repository.plugin'] = $app->share(function () use ($app) {
231
+        $app['eccube.repository.plugin'] = $app->share(function() use ($app) {
232 232
             return $app['orm.em']->getRepository('Eccube\Entity\Plugin');
233 233
         });
234
-        $app['eccube.repository.plugin_event_handler'] = $app->share(function () use ($app) {
234
+        $app['eccube.repository.plugin_event_handler'] = $app->share(function() use ($app) {
235 235
             return $app['orm.em']->getRepository('Eccube\Entity\PluginEventHandler');
236 236
         });
237 237
         // em
238 238
         if (isset($app['orm.em'])) {
239
-            $app['orm.em'] = $app->share($app->extend('orm.em', function (\Doctrine\ORM\EntityManager $em, \Silex\Application $app) {
239
+            $app['orm.em'] = $app->share($app->extend('orm.em', function(\Doctrine\ORM\EntityManager $em, \Silex\Application $app) {
240 240
                 // tax_rule
241 241
                 $taxRuleRepository = $em->getRepository('Eccube\Entity\TaxRule');
242 242
                 $taxRuleRepository->setApplication($app);
@@ -259,13 +259,13 @@  discard block
 block discarded – undo
259 259
         }
260 260
 
261 261
         // Form\Type
262
-        $app['form.type.extensions'] = $app->share($app->extend('form.type.extensions', function ($extensions) use ($app) {
262
+        $app['form.type.extensions'] = $app->share($app->extend('form.type.extensions', function($extensions) use ($app) {
263 263
             $extensions[] = new \Eccube\Form\Extension\HelpTypeExtension();
264 264
             $extensions[] = new \Eccube\Form\Extension\FreezeTypeExtension();
265 265
 
266 266
             return $extensions;
267 267
         }));
268
-        $app['form.types'] = $app->share($app->extend('form.types', function ($types) use ($app) {
268
+        $app['form.types'] = $app->share($app->extend('form.types', function($types) use ($app) {
269 269
             $types[] = new \Eccube\Form\Type\NameType($app['config']);
270 270
             $types[] = new \Eccube\Form\Type\KanaType($app['config']);
271 271
             $types[] = new \Eccube\Form\Type\TelType($app['config']);
Please login to merge, or discard this patch.
src/Eccube/ServiceProvider/DebugServiceProvider.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 {
67 67
     public function register(Application $app)
68 68
     {
69
-        $app['var_dumper.cloner'] = $app->share(function ($app) {
69
+        $app['var_dumper.cloner'] = $app->share(function($app) {
70 70
             $cloner = new VarCloner();
71 71
 
72 72
             if (isset($app['debug.max_items'])) {
@@ -85,19 +85,19 @@  discard block
 block discarded – undo
85 85
             array(array('dump', '@Debug/Profiler/dump.html.twig'))
86 86
         );
87 87
 
88
-        $app['data_collector.dump'] = $app->share(function ($app) {
88
+        $app['data_collector.dump'] = $app->share(function($app) {
89 89
             return new DumpDataCollector($app['stopwatch'], $app['code.file_link_format']);
90 90
         });
91 91
 
92
-        $app['data_collectors'] = $app->share($app->extend('data_collectors', function ($collectors, $app) {
93
-            $collectors['dump'] = $app->share(function ($app) {
92
+        $app['data_collectors'] = $app->share($app->extend('data_collectors', function($collectors, $app) {
93
+            $collectors['dump'] = $app->share(function($app) {
94 94
                 return $app['data_collector.dump'];
95 95
             });
96 96
 
97 97
             return $collectors;
98 98
         }));
99 99
 
100
-        $app['twig'] = $app->share($app->extend('twig', function ($twig, $app) {
100
+        $app['twig'] = $app->share($app->extend('twig', function($twig, $app) {
101 101
             if (class_exists('\Symfony\Bridge\Twig\Extension\DumpExtension')) {
102 102
                 $twig->addExtension(new DumpExtension($app['var_dumper.cloner']));
103 103
             }
@@ -105,13 +105,13 @@  discard block
 block discarded – undo
105 105
             return $twig;
106 106
         }));
107 107
 
108
-        $app['twig.loader.filesystem'] = $app->share($app->extend('twig.loader.filesystem', function ($loader, $app) {
108
+        $app['twig.loader.filesystem'] = $app->share($app->extend('twig.loader.filesystem', function($loader, $app) {
109 109
             $loader->addPath($app['debug.templates_path'], 'Debug');
110 110
 
111 111
             return $loader;
112 112
         }));
113 113
 
114
-        $app['debug.templates_path'] = function () {
114
+        $app['debug.templates_path'] = function() {
115 115
             $r = new \ReflectionClass('Symfony\Bundle\DebugBundle\DependencyInjection\Configuration');
116 116
 
117 117
             return dirname(dirname($r->getFileName())).'/Resources/views';
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
         // This code is here to lazy load the dump stack. This default
124 124
         // configuration for CLI mode is overridden in HTTP mode on
125 125
         // 'kernel.request' event
126
-        VarDumper::setHandler(function ($var) use ($app) {
126
+        VarDumper::setHandler(function($var) use ($app) {
127 127
             $dumper = new CliDumper();
128 128
             $dumper->dump($app['var_dumper.cloner']->cloneVar($var));
129 129
         });
Please login to merge, or discard this patch.
src/Eccube/Controller/AbstractController.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -52,11 +52,17 @@
 block discarded – undo
52 52
         return $form;
53 53
     }
54 54
 
55
+    /**
56
+     * @param Application $app
57
+     */
55 58
     protected function getSecurity($app)
56 59
     {
57 60
         return $app['security.token_storage'];
58 61
     }
59 62
 
63
+    /**
64
+     * @param Application $app
65
+     */
60 66
     protected function isTokenValid($app)
61 67
     {
62 68
         $csrf = $app['form.csrf_provider'];
Please login to merge, or discard this patch.
src/Eccube/Application.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -725,7 +725,7 @@
 block discarded – undo
725 725
      * 成功 : trueを返却
726 726
      * 失敗 : \Doctrine\DBAL\DBALExceptionエラーが発生( 接続に失敗した場合 )、エラー画面を表示しdie()
727 727
      * 備考 : app['debug']がtrueの際は処理を行わない
728
-     * @return boolean true
728
+     * @return null|boolean true
729 729
      *
730 730
      */
731 731
     protected function checkDatabaseConnection()
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,6 @@
 block discarded – undo
29 29
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
30 30
 use Symfony\Component\Finder\Finder;
31 31
 use Symfony\Component\Yaml\Yaml;
32
-use Monolog\Logger;
33 32
 
34 33
 class FormEventSubscriber implements EventSubscriberInterface
35 34
 {
Please login to merge, or discard this patch.
src/Eccube/Controller/ProductController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@
 block discarded – undo
106 106
             ));
107 107
             $addCartForm = $builder->getForm();
108 108
 
109
-            if ($request->getMethod() === 'POST' && (string)$Product->getId() === $request->get('product_id')) {
109
+            if ($request->getMethod() === 'POST' && (string) $Product->getId() === $request->get('product_id')) {
110 110
                 $addCartForm->handleRequest($request);
111 111
 
112 112
                 if ($addCartForm->isValid()) {
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Product/ProductClassController.php 2 patches
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -510,6 +510,8 @@  discard block
 block discarded – undo
510 510
     /**
511 511
      * 登録、更新時のエラー画面表示
512 512
      *
513
+     * @param Application $app
514
+     * @param boolean $not_product_class
513 515
      */
514 516
     protected function render($app, $Product, $ProductClass, $not_product_class, $classForm, $error = null)
515 517
     {
@@ -559,6 +561,7 @@  discard block
 block discarded – undo
559 561
 
560 562
     /**
561 563
      * 規格1と規格2を組み合わせた商品規格を作成
564
+     * @param Application $app
562 565
      */
563 566
     private function createProductClasses($app, Product $Product, ClassName $ClassName1 = null, ClassName $ClassName2 = null)
564 567
     {
@@ -646,6 +649,7 @@  discard block
 block discarded – undo
646 649
      *
647 650
      * @param $productClassDest コピー先となる商品規格
648 651
      * @param $productClassOrig コピー元となる商品規格
652
+     * @param Application $app
649 653
      */
650 654
     private function setDefualtProductClass($app, $productClassDest, $productClassOrig) {
651 655
         $productClassDest->setDeliveryDate($productClassOrig->getDeliveryDate());
@@ -687,6 +691,7 @@  discard block
 block discarded – undo
687 691
      * 商品規格を登録
688 692
      *
689 693
      * @param $ProductClasses 登録される商品規格
694
+     * @param Application $app
690 695
      */
691 696
     private function insertProductClass($app, $Product, $ProductClasses) {
692 697
 
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -138,7 +138,7 @@
 block discarded – undo
138 138
                                 'allow_add' => true,
139 139
                                 'allow_delete' => true,
140 140
                                 'data' => $ProductClasses,
141
-                             ));
141
+                                ));
142 142
 
143 143
                         $event = new EventArgs(
144 144
                             array(
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Setting/System/SystemController.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
 
49 49
                 return $phpinfo;
50 50
 
51
-               break;
51
+                break;
52 52
             default:
53 53
                 break;
54 54
         }
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -66,10 +66,10 @@
 block discarded – undo
66 66
         $server = $app['request'];
67 67
 
68 68
         $arrSystemInfo = array(
69
-            array('title' => 'EC-CUBE',     'value' => Constant::VERSION),
70
-            array('title' => 'サーバーOS',    'value' => php_uname()),
71
-            array('title' => 'DBサーバー',    'value' => $system->getDbversion()),
72
-            array('title' => 'WEBサーバー',   'value' => $server->server->get("SERVER_SOFTWARE")),
69
+            array('title' => 'EC-CUBE', 'value' => Constant::VERSION),
70
+            array('title' => 'サーバーOS', 'value' => php_uname()),
71
+            array('title' => 'DBサーバー', 'value' => $system->getDbversion()),
72
+            array('title' => 'WEBサーバー', 'value' => $server->server->get("SERVER_SOFTWARE")),
73 73
         );
74 74
 
75 75
         $value = phpversion().' ('.implode(', ', get_loaded_extensions()).')';
Please login to merge, or discard this patch.
src/Eccube/Form/Type/Admin/ShippingType.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
                 'format' => 'yyyy-MM-dd',
142 142
                 'required' => false,
143 143
             ))
144
-            ->addEventListener(FormEvents::PRE_SET_DATA, function (FormEvent $event) use ($BaseInfo) {
144
+            ->addEventListener(FormEvents::PRE_SET_DATA, function(FormEvent $event) use ($BaseInfo) {
145 145
                 if ($BaseInfo->getOptionMultipleShipping() == Constant::ENABLED) {
146 146
                     $form = $event->getForm();
147 147
                     $form->add('ShipmentItems', 'collection', array(
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
                     ));
153 153
                 }
154 154
             })
155
-            ->addEventListener(FormEvents::POST_SET_DATA, function (FormEvent $event) {
155
+            ->addEventListener(FormEvents::POST_SET_DATA, function(FormEvent $event) {
156 156
                 /** @var \Eccube\Entity\Shipping $data */
157 157
                 $data = $event->getData();
158 158
                 /** @var \Symfony\Component\Form\Form $form */
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
                     'empty_value' => '指定なし',
173 173
                     'empty_data' => null,
174 174
                     'required' => false,
175
-                    'query_builder' => function (EntityRepository $er) use ($Delivery) {
175
+                    'query_builder' => function(EntityRepository $er) use ($Delivery) {
176 176
                         return $er->createQueryBuilder('dt')
177 177
                             ->where('dt.Delivery = :Delivery')
178 178
                             ->setParameter('Delivery', $Delivery);
@@ -180,7 +180,7 @@  discard block
 block discarded – undo
180 180
                 ));
181 181
 
182 182
             })
183
-            ->addEventListener(FormEvents::PRE_SUBMIT, function (FormEvent $event) use ($app) {
183
+            ->addEventListener(FormEvents::PRE_SUBMIT, function(FormEvent $event) use ($app) {
184 184
                 $data = $event->getData();
185 185
                 $form = $event->getForm();
186 186
                 if (!$data) {
@@ -201,14 +201,14 @@  discard block
 block discarded – undo
201 201
                     'empty_value' => '指定なし',
202 202
                     'empty_data' => null,
203 203
                     'required' => false,
204
-                    'query_builder' => function (EntityRepository $er) use ($Delivery) {
204
+                    'query_builder' => function(EntityRepository $er) use ($Delivery) {
205 205
                         return $er->createQueryBuilder('dt')
206 206
                             ->where('dt.Delivery = :Delivery')
207 207
                             ->setParameter('Delivery', $Delivery);
208 208
                     },
209 209
                 ));
210 210
             })
211
-            ->addEventListener(FormEvents::POST_SUBMIT, function (FormEvent $event) use ($BaseInfo) {
211
+            ->addEventListener(FormEvents::POST_SUBMIT, function(FormEvent $event) use ($BaseInfo) {
212 212
                 if ($BaseInfo->getOptionMultipleShipping() == Constant::ENABLED) {
213 213
                     $form = $event->getForm();
214 214
                     $shipmentItems = $form['ShipmentItems']->getData();
Please login to merge, or discard this patch.
src/Eccube/Repository/PluginEventHandlerRepository.php 2 patches
Indentation   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -69,11 +69,11 @@  discard block
 block discarded – undo
69 69
 
70 70
         $qb = $this->createQueryBuilder('e');
71 71
         $qb->andWhere("e.priority >= $range_end ")
72
-           ->andWhere("e.priority <= $range_start ")
73
-           ->andWhere('e.event = :event')
74
-           ->setParameter('event',$event)
75
-           ->setMaxResults(1)
76
-           ->orderBy('e.priority','ASC');
72
+            ->andWhere("e.priority <= $range_start ")
73
+            ->andWhere('e.event = :event')
74
+            ->setParameter('event',$event)
75
+            ->setMaxResults(1)
76
+            ->orderBy('e.priority','ASC');
77 77
 
78 78
         $result=$qb->getQuery()->getResult();
79 79
         if (count($result)) {
@@ -90,14 +90,14 @@  discard block
 block discarded – undo
90 90
         $qb = $this->createQueryBuilder('e');
91 91
 
92 92
         $qb->andWhere("e.priority >= $range_end ")
93
-           ->andWhere("e.priority <= $range_start ")
94
-           ->andWhere("e.del_flg = 0 ")
95
-           ->andWhere('e.priority '.($up ?  '>' : '<' ).' :pri')
96
-           ->andWhere('e.event = :event')
97
-           ->setParameter('event',$pluginEventHandler->getEvent())
98
-           ->setParameter('pri',  $pluginEventHandler->getPriority()  )
99
-           ->setMaxResults(1)
100
-           ->orderBy('e.priority', ($up ? 'ASC':'DESC' )  );
93
+            ->andWhere("e.priority <= $range_start ")
94
+            ->andWhere("e.del_flg = 0 ")
95
+            ->andWhere('e.priority '.($up ?  '>' : '<' ).' :pri')
96
+            ->andWhere('e.event = :event')
97
+            ->setParameter('event',$pluginEventHandler->getEvent())
98
+            ->setParameter('pri',  $pluginEventHandler->getPriority()  )
99
+            ->setMaxResults(1)
100
+            ->orderBy('e.priority', ($up ? 'ASC':'DESC' )  );
101 101
 
102 102
         $result=$qb->getQuery()->getResult();
103 103
 
Please login to merge, or discard this patch.
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -41,8 +41,8 @@  discard block
 block discarded – undo
41 41
         $qb = $this->createQueryBuilder('e')
42 42
             ->innerJoin('e.Plugin', 'p')
43 43
             ->andWhere('e.del_flg = 0 ')
44
-            ->Orderby('e.event','ASC')
45
-            ->addOrderby('e.priority','DESC');
44
+            ->Orderby('e.event', 'ASC')
45
+            ->addOrderby('e.priority', 'DESC');
46 46
         ;
47 47
 
48 48
         return $qb->getQuery()->getResult();
@@ -60,20 +60,20 @@  discard block
 block discarded – undo
60 60
             $range_start = PluginEventHandler::EVENT_PRIORITY_NORMAL_START;
61 61
             $range_end = PluginEventHandler::EVENT_PRIORITY_NORMAL_END;
62 62
         }
63
-        return array($range_start,$range_end);
63
+        return array($range_start, $range_end);
64 64
     }
65 65
 
66
-    public function calcNewPriority($event , $type)
66
+    public function calcNewPriority($event, $type)
67 67
     {
68
-        list($range_start,$range_end) = $this->getPriorityRange($type);
68
+        list($range_start, $range_end) = $this->getPriorityRange($type);
69 69
 
70 70
         $qb = $this->createQueryBuilder('e');
71 71
         $qb->andWhere("e.priority >= $range_end ")
72 72
            ->andWhere("e.priority <= $range_start ")
73 73
            ->andWhere('e.event = :event')
74
-           ->setParameter('event',$event)
74
+           ->setParameter('event', $event)
75 75
            ->setMaxResults(1)
76
-           ->orderBy('e.priority','ASC');
76
+           ->orderBy('e.priority', 'ASC');
77 77
 
78 78
         $result = $qb->getQuery()->getResult();
79 79
         if (count($result)) {
@@ -83,21 +83,21 @@  discard block
 block discarded – undo
83 83
         }
84 84
     }
85 85
 
86
-    public function upPriority($pluginEventHandler,$up = true)
86
+    public function upPriority($pluginEventHandler, $up = true)
87 87
     {
88
-        list($range_start,$range_end) = $this->getPriorityRange($pluginEventHandler->getHandlerType());
88
+        list($range_start, $range_end) = $this->getPriorityRange($pluginEventHandler->getHandlerType());
89 89
 
90 90
         $qb = $this->createQueryBuilder('e');
91 91
 
92 92
         $qb->andWhere("e.priority >= $range_end ")
93 93
            ->andWhere("e.priority <= $range_start ")
94 94
            ->andWhere("e.del_flg = 0 ")
95
-           ->andWhere('e.priority '.($up ?  '>' : '<' ).' :pri')
95
+           ->andWhere('e.priority '.($up ? '>' : '<').' :pri')
96 96
            ->andWhere('e.event = :event')
97
-           ->setParameter('event',$pluginEventHandler->getEvent())
98
-           ->setParameter('pri',  $pluginEventHandler->getPriority()  )
97
+           ->setParameter('event', $pluginEventHandler->getEvent())
98
+           ->setParameter('pri', $pluginEventHandler->getPriority())
99 99
            ->setMaxResults(1)
100
-           ->orderBy('e.priority', ($up ? 'ASC':'DESC' )  );
100
+           ->orderBy('e.priority', ($up ? 'ASC' : 'DESC'));
101 101
 
102 102
         $result = $qb->getQuery()->getResult();
103 103
 
Please login to merge, or discard this patch.