Failed Conditions
Pull Request — experimental/sf (#3225)
by Kentaro
50:47 queued 42:12
created
src/Eccube/Service/CartService.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -438,6 +438,9 @@
 block discarded – undo
438 438
         return $user;
439 439
     }
440 440
 
441
+    /**
442
+     * @param string $allocatedId
443
+     */
441 444
     protected function createCartKey($allocatedId, Customer $Customer = null)
442 445
     {
443 446
         if ($Customer instanceof Customer) {
Please login to merge, or discard this patch.
src/Eccube/Service/Composer/ComposerProcessService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -229,7 +229,7 @@
 block discarded – undo
229 229
     /**
230 230
      * Get mode
231 231
      *
232
-     * @return mixed|string
232
+     * @return string
233 233
      */
234 234
     public function getMode()
235 235
     {
Please login to merge, or discard this patch.
src/Eccube/Service/PluginService.php 1 patch
Doc Comments   +13 added lines, -7 removed lines patch added patch discarded remove patch
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
      * @param string $path   path to tar.gz/zip plugin file
148 148
      * @param int    $source
149 149
      *
150
-     * @return mixed
150
+     * @return boolean
151 151
      *
152 152
      * @throws PluginException
153 153
      * @throws \Exception
@@ -274,8 +274,8 @@  discard block
 block discarded – undo
274 274
     }
275 275
 
276 276
     /**
277
-     * @param $archive
278
-     * @param $dir
277
+     * @param string $archive
278
+     * @param string $dir
279 279
      *
280 280
      * @throws PluginException
281 281
      */
@@ -344,6 +344,9 @@  discard block
 block discarded – undo
344 344
         }
345 345
     }
346 346
 
347
+    /**
348
+     * @param string $yml
349
+     */
347 350
     public function readYml($yml)
348 351
     {
349 352
         if (file_exists($yml)) {
@@ -361,6 +364,9 @@  discard block
 block discarded – undo
361 364
         // ディレクトリ名などに使われれるので厳しめ
362 365
     }
363 366
 
367
+    /**
368
+     * @param string $path
369
+     */
364 370
     public function deleteFile($path)
365 371
     {
366 372
         $f = new Filesystem();
@@ -381,7 +387,7 @@  discard block
 block discarded – undo
381 387
     }
382 388
 
383 389
     /**
384
-     * @param $d
390
+     * @param string $d
385 391
      *
386 392
      * @throws PluginException
387 393
      */
@@ -456,7 +462,7 @@  discard block
 block discarded – undo
456 462
 
457 463
     /**
458 464
      * @param $meta
459
-     * @param $method
465
+     * @param string $method
460 466
      */
461 467
     public function callPluginManagerMethod($meta, $method)
462 468
     {
@@ -997,7 +1003,7 @@  discard block
 block discarded – undo
997 1003
      * [プラグインコード]/Resource/assets
998 1004
      * 配下に置かれているファイルが所定の位置へコピーされる
999 1005
      *
1000
-     * @param $pluginBaseDir
1006
+     * @param string $pluginBaseDir
1001 1007
      * @param $pluginCode
1002 1008
      */
1003 1009
     public function copyAssets($pluginBaseDir, $pluginCode)
@@ -1033,7 +1039,7 @@  discard block
 block discarded – undo
1033 1039
      * @param string $pluginVersion
1034 1040
      * @param string $remoteVersion
1035 1041
      *
1036
-     * @return mixed
1042
+     * @return boolean
1037 1043
      */
1038 1044
     public function isUpdate($pluginVersion, $remoteVersion)
1039 1045
     {
Please login to merge, or discard this patch.