Cash - Code Metrics - Inspection of "[WIP] PaymentMethod の改良" - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — experimental/sf (#3225)

by Kentaro

created 2018-06-28 00:22 UTC

Cash A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
dl	0
loc	42
rs	10
c	0
b	0
f	0
ccs	6
cts	6
cp	1
wmc	5
lcom	0
cbo	1

5 Methods

Rating	Name	Size	Complexity
A	checkout()	4	1
A	apply()	4	1
A	setFormType()	4	1
A	verify()	4	1
A	setOrder()	4	1

<?php

/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Eccube\Service\Payment\Method;

use Eccube\Entity\Order;
use Eccube\Service\Payment\PaymentMethod;
use Eccube\Service\Payment\PaymentResult;
use Symfony\Component\Form\FormInterface;

class Cash implements PaymentMethod

{
    /**
     * {@inheritdoc}
     */
    public function checkout()
    {
        return new PaymentResult();
    }

    /**
     * {@inheritdoc}
     */
    public function apply()
    {
        return false;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * {@inheritdoc}
     */
    public function setFormType(FormInterface $form)
    {
        // quiet
    }

    /**
     * {@inheritdoc}
     */
    public function verify()
    {
        return false;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * {@inheritdoc}
     */
    public function setOrder(Order $Order)
    {
        // quiet
    }
}


1		<?php
2
3		/*
4		* This file is part of EC-CUBE
5		*
6		* Copyright(c) LOCKON CO.,LTD. All Rights Reserved.
7		*
8		* http://www.lockon.co.jp/
9		*
10		* For the full copyright and license information, please view the LICENSE
11		* file that was distributed with this source code.
12		*/
13
14		namespace Eccube\Service\Payment\Method;
15
16		use Eccube\Entity\Order;
17		use Eccube\Service\Payment\PaymentMethod;
18		use Eccube\Service\Payment\PaymentResult;
19		use Symfony\Component\Form\FormInterface;
20
21		class Cash implements PaymentMethod
		0 ignored issues – show introduced 2016-12-15 10:20 UTC by Report Bug Copy Issue Report Missing class doc comment Loading history...
22		{
23		/**
24		* {@inheritdoc}
25		*/
26	7	public function checkout()
27		{
28	7	return new PaymentResult();
29		}
30
31		/**
32		* {@inheritdoc}
33		*/
34	7	public function apply()
35		{
36	7	return false;
		0 ignored issues – show Bug Best Practice introduced 2018-06-28 01:12 UTC by Report Bug Copy Issue Report The return type of `return false;` (`false`) is incompatible with the return type declared by the interface `Eccube\Service\Payment\PaymentMethod::apply` of type `Eccube\Service\Payment\PaymentDispatcher`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
37		}
38
39		/**
40		* {@inheritdoc}
41		*/
42		public function setFormType(FormInterface $form)
43		{
44		// quiet
45		}
46
47		/**
48		* {@inheritdoc}
49		*/
50	5	public function verify()
51		{
52	5	return false;
		0 ignored issues – show Bug Best Practice introduced 2018-06-28 01:12 UTC by Report Bug Copy Issue Report The return type of `return false;` (`false`) is incompatible with the return type declared by the interface `Eccube\Service\Payment\PaymentMethod::verify` of type `Eccube\Service\Payment\PaymentResult`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
53		}
54
55		/**
56		* {@inheritdoc}
57		*/
58		public function setOrder(Order $Order)
59		{
60		// quiet
61		}
62		}
63

EC-CUBE / ec-cube

Pull Request — experimental/sf (#3225)

Cash A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

5 Methods

Duplication Side-by-Side

Filter issues like