Issues in ChangeController.php - All Issues - Inspection of "Merge pull request #4114 from okazy/fix-4-pre-orde..." - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 4.0 ( b48f64...137622 )

by chihiro

created 2019-03-22 04:15 UTC

src/Eccube/Controller/Mypage/ChangeController.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Chihiro Adachi 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Eccube\Controller\Mypage;

use Eccube\Controller\AbstractController;
use Eccube\Event\EccubeEvents;
use Eccube\Event\EventArgs;
use Eccube\Form\Type\Front\EntryType;
use Eccube\Repository\CustomerRepository;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Routing\Annotation\Route;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorage;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
use Symfony\Component\Security\Core\Encoder\EncoderFactoryInterface;

class ChangeController extends AbstractController
{
    /**
     * @var TokenStorage
     */
    protected $tokenStorage;

    /**
     * @var CustomerRepository
     */
    protected $customerRepository;

    /**
     * @var EncoderFactoryInterface
     */
    protected $encoderFactory;

    public function __construct(
        CustomerRepository $customerRepository,
        EncoderFactoryInterface $encoderFactory,
        TokenStorageInterface $tokenStorage
    ) {
        $this->customerRepository = $customerRepository;
        $this->encoderFactory = $encoderFactory;
        $this->tokenStorage = $tokenStorage;
    }

    /**
     * 会員情報編集画面.
     *
     * @Route("/mypage/change", name="mypage_change")
     * @Template("Mypage/change.twig")
     */
    public function index(Request $request)
    {
        $Customer = $this->getUser();
        $LoginCustomer = clone $Customer;
        $this->entityManager->detach($LoginCustomer);

        $previous_password = $Customer->getPassword();
        $Customer->setPassword($this->eccubeConfig['eccube_default_password']);

        /* @var $builder \Symfony\Component\Form\FormBuilderInterface */
        $builder = $this->formFactory->createBuilder(EntryType::class, $Customer);

        $event = new EventArgs(
            [
                'builder' => $builder,
                'Customer' => $Customer,
            ],
            $request
        );
        $this->eventDispatcher->dispatch(EccubeEvents::FRONT_MYPAGE_CHANGE_INDEX_INITIALIZE, $event);

        /* @var $form \Symfony\Component\Form\FormInterface */
        $form = $builder->getForm();
        $form->handleRequest($request);

        if ($form->isSubmitted() && $form->isValid()) {
            log_info('会員編集開始');

            if ($Customer->getPassword() === $this->eccubeConfig['eccube_default_password']) {
                $Customer->setPassword($previous_password);
            } else {
                $encoder = $this->encoderFactory->getEncoder($Customer);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                if ($Customer->getSalt() === null) {
                    $Customer->setSalt($encoder->createSalt());
                }
                $Customer->setPassword(
                    $encoder->encodePassword($Customer->getPassword(), $Customer->getSalt())
                );
            }
            $this->entityManager->flush();

            log_info('会員編集完了');

            $event = new EventArgs(
                [
                    'form' => $form,
                    'Customer' => $Customer,
                ],
                $request
            );
            $this->eventDispatcher->dispatch(EccubeEvents::FRONT_MYPAGE_CHANGE_INDEX_COMPLETE, $event);

            return $this->redirect($this->generateUrl('mypage_change_complete'));
        }

        $this->tokenStorage->getToken()->setUser($LoginCustomer);

        return [
            'form' => $form->createView(),
        ];
    }

    /**
     * 会員情報編集完了画面.
     *
     * @Route("/mypage/change_complete", name="mypage_change_complete")
     * @Template("Mypage/change_complete.twig")
     */
    public function complete(Request $request)
    {
        return [];
    }
}


1			<?php
2
3			/*
4			* This file is part of EC-CUBE
5			*
6			* Copyright(c) LOCKON CO.,LTD. All Rights Reserved.
7			*
8			* http://www.lockon.co.jp/
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Eccube\Controller\Mypage;
15
16			use Eccube\Controller\AbstractController;
17			use Eccube\Event\EccubeEvents;
18			use Eccube\Event\EventArgs;
19			use Eccube\Form\Type\Front\EntryType;
20			use Eccube\Repository\CustomerRepository;
21			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
22			use Symfony\Component\HttpFoundation\Request;
23			use Symfony\Component\Routing\Annotation\Route;
24			use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorage;
25			use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
26			use Symfony\Component\Security\Core\Encoder\EncoderFactoryInterface;
27
28			class ChangeController extends AbstractController
29			{
30			/**
31			* @var TokenStorage
32			*/
33			protected $tokenStorage;
34
35			/**
36			* @var CustomerRepository
37			*/
38			protected $customerRepository;
39
40			/**
41			* @var EncoderFactoryInterface
42			*/
43			protected $encoderFactory;
44
45	5		public function __construct(
46			CustomerRepository $customerRepository,
47			EncoderFactoryInterface $encoderFactory,
48			TokenStorageInterface $tokenStorage
49			) {
50	5		$this->customerRepository = $customerRepository;
51	5		$this->encoderFactory = $encoderFactory;
52	5		$this->tokenStorage = $tokenStorage;
53			}
54
55			/**
56			* 会員情報編集画面.
57			*
58			* @Route("/mypage/change", name="mypage_change")
59			* @Template("Mypage/change.twig")
60			*/
61	4		public function index(Request $request)
62			{
63	4		$Customer = $this->getUser();
64	4		$LoginCustomer = clone $Customer;
65	4		$this->entityManager->detach($LoginCustomer);
66
67	4		$previous_password = $Customer->getPassword();
68	4		$Customer->setPassword($this->eccubeConfig['eccube_default_password']);
69
70			/* @var $builder \Symfony\Component\Form\FormBuilderInterface */
71	4		$builder = $this->formFactory->createBuilder(EntryType::class, $Customer);
72
73	4		$event = new EventArgs(
74			[
75	4		'builder' => $builder,
76	4		'Customer' => $Customer,
77			],
78	4		$request
79			);
80	4		$this->eventDispatcher->dispatch(EccubeEvents::FRONT_MYPAGE_CHANGE_INDEX_INITIALIZE, $event);
81
82			/* @var $form \Symfony\Component\Form\FormInterface */
83	4		$form = $builder->getForm();
84	4		$form->handleRequest($request);
85
86	4		if ($form->isSubmitted() && $form->isValid()) {
87	2		log_info('会員編集開始');
88
89	2	View Code Duplication	if ($Customer->getPassword() === $this->eccubeConfig['eccube_default_password']) {
90	1		$Customer->setPassword($previous_password);
91			} else {
92	1		$encoder = $this->encoderFactory->getEncoder($Customer);
			0 ignored issues – show Documentation introduced 2018-06-08 04:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$Customer` is of type `null\|object`, but the function expects a `object<Symfony\Component...r\UserInterface>\|string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
93	1		if ($Customer->getSalt() === null) {
94			$Customer->setSalt($encoder->createSalt());
95			}
96	1		$Customer->setPassword(
97	1		$encoder->encodePassword($Customer->getPassword(), $Customer->getSalt())
98			);
99			}
100	2		$this->entityManager->flush();
101
102	2		log_info('会員編集完了');
103
104	2		$event = new EventArgs(
105			[
106	2		'form' => $form,
107	2		'Customer' => $Customer,
108			],
109	2		$request
110			);
111	2		$this->eventDispatcher->dispatch(EccubeEvents::FRONT_MYPAGE_CHANGE_INDEX_COMPLETE, $event);
112
113	2		return $this->redirect($this->generateUrl('mypage_change_complete'));
114			}
115
116	2		$this->tokenStorage->getToken()->setUser($LoginCustomer);
117
118			return [
119	2		'form' => $form->createView(),
120			];
121			}
122
123			/**
124			* 会員情報編集完了画面.
125			*
126			* @Route("/mypage/change_complete", name="mypage_change_complete")
127			* @Template("Mypage/change_complete.twig")
128			*/
129	1		public function complete(Request $request)
130			{
131	1		return [];
132			}
133			}
134

EC-CUBE / ec-cube

Push — 4.0 ( b48f64...137622 )

src/Eccube/Controller/Mypage/ChangeController.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like