WithdrawController::index() - Code Metrics - Inspection of "Merge pull request #4114 from okazy/fix-4-pre-orde..." - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 4.0 ( b48f64...137622 )

by chihiro

created 2019-03-22 04:15 UTC

WithdrawController::index() B

↳ Parent: WithdrawController

Complexity

Conditions	5
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	19
CRAP Score	5.0031

Importance

Changes

Metric	Value
cc	5
nc	4
nop	1
dl	0
loc	72
ccs	19
cts	20
cp	0.95
crap	5.0031
rs	8.2997
c	0
b	0
f	0

How to fix Long Method

<?php

/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Eccube\Controller\Mypage;

use Eccube\Controller\AbstractController;
use Eccube\Entity\Master\CustomerStatus;
use Eccube\Event\EccubeEvents;
use Eccube\Event\EventArgs;
use Eccube\Repository\Master\CustomerStatusRepository;
use Eccube\Service\CartService;
use Eccube\Service\MailService;
use Eccube\Service\OrderHelper;
use Eccube\Util\StringUtil;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Routing\Annotation\Route;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorage;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;

class WithdrawController extends AbstractController
{
    /**
     * @var MailService
     */
    protected $mailService;

    /**
     * @var CustomerStatusRepository
     */
    protected $customerStatusRepository;

    /**
     * @var TokenStorage
     */
    protected $tokenStorage;

    /**
     * @var CartService
     */
    private $cartService;

    /**
     * @var OrderHelper
     */
    private $orderHelper;

    /**
     * WithdrawController constructor.
     *
     * @param MailService $mailService
     * @param CustomerStatusRepository $customerStatusRepository
     * @param TokenStorageInterface $tokenStorage
     * @param CartService $cartService
     * @param OrderHelper $orderHelper
     */
    public function __construct(
        MailService $mailService,
        CustomerStatusRepository $customerStatusRepository,
        TokenStorageInterface $tokenStorage,
        CartService $cartService,
        OrderHelper $orderHelper
    ) {
        $this->mailService = $mailService;
        $this->customerStatusRepository = $customerStatusRepository;
        $this->tokenStorage = $tokenStorage;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
        $this->cartService = $cartService;
        $this->orderHelper = $orderHelper;
    }

    /**
     * 退会画面.
     *
     * @Route("/mypage/withdraw", name="mypage_withdraw")
     * @Template("Mypage/withdraw.twig")
     */
    public function index(Request $request)
    {
        $builder = $this->formFactory->createBuilder();

        $event = new EventArgs(
            [
                'builder' => $builder,
            ],
            $request
        );
        $this->eventDispatcher->dispatch(EccubeEvents::FRONT_MYPAGE_WITHDRAW_INDEX_INITIALIZE, $event);

        $form = $builder->getForm();

        $form->handleRequest($request);

        if ($form->isSubmitted() && $form->isValid()) {
            switch ($request->get('mode')) {
                case 'confirm':
                    log_info('退会確認画面表示');

                    return $this->render(
                        'Mypage/withdraw_confirm.twig',
                        [
                            'form' => $form->createView(),
                        ]
                    );

                case 'complete':
                    log_info('退会処理開始');

                    /* @var $Customer \Eccube\Entity\Customer */
                    $Customer = $this->getUser();
                    $email = $Customer->getEmail();

                    // 退会ステータスに変更
                    $CustomerStatus = $this->customerStatusRepository->find(CustomerStatus::WITHDRAWING);
                    $Customer->setStatus($CustomerStatus);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                    $Customer->setEmail(StringUtil::random(60).'@dummy.dummy');

                    $this->entityManager->flush();

                    log_info('退会処理完了');

                    $event = new EventArgs(
                        [
                            'form' => $form,
                            'Customer' => $Customer,
                        ], $request
                    );
                    $this->eventDispatcher->dispatch(EccubeEvents::FRONT_MYPAGE_WITHDRAW_INDEX_COMPLETE, $event);

                    // メール送信
                    $this->mailService->sendCustomerWithdrawMail($Customer, $email);

                    // カートと受注のセッションを削除
                    $this->cartService->clear();
                    $this->orderHelper->removeSession();

                    // ログアウト
                    $this->tokenStorage->setToken(null);

                    log_info('ログアウト完了');

                    return $this->redirect($this->generateUrl('mypage_withdraw_complete'));
            }
        }

        return [
            'form' => $form->createView(),
        ];
    }

    /**
     * 退会完了画面.
     *
     * @Route("/mypage/withdraw_complete", name="mypage_withdraw_complete")
     * @Template("Mypage/withdraw_complete.twig")
     */
    public function complete(Request $request)

    {
        return [];
    }
}


1		<?php
2
3		/*
4		* This file is part of EC-CUBE
5		*
6		* Copyright(c) LOCKON CO.,LTD. All Rights Reserved.
7		*
8		* http://www.lockon.co.jp/
9		*
10		* For the full copyright and license information, please view the LICENSE
11		* file that was distributed with this source code.
12		*/
13
14		namespace Eccube\Controller\Mypage;
15
16		use Eccube\Controller\AbstractController;
17		use Eccube\Entity\Master\CustomerStatus;
18		use Eccube\Event\EccubeEvents;
19		use Eccube\Event\EventArgs;
20		use Eccube\Repository\Master\CustomerStatusRepository;
21		use Eccube\Service\CartService;
22		use Eccube\Service\MailService;
23		use Eccube\Service\OrderHelper;
24		use Eccube\Util\StringUtil;
25		use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
26		use Symfony\Component\HttpFoundation\Request;
27		use Symfony\Component\Routing\Annotation\Route;
28		use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorage;
29		use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
30
31		class WithdrawController extends AbstractController
32		{
33		/**
34		* @var MailService
35		*/
36		protected $mailService;
37
38		/**
39		* @var CustomerStatusRepository
40		*/
41		protected $customerStatusRepository;
42
43		/**
44		* @var TokenStorage
45	4	*/
46		protected $tokenStorage;
47
48		/**
49		* @var CartService
50	4	*/
51	4	private $cartService;
52	4
53		/**
54		* @var OrderHelper
55		*/
56		private $orderHelper;
57
58		/**
59		* WithdrawController constructor.
60		*
61	3	* @param MailService $mailService
62		* @param CustomerStatusRepository $customerStatusRepository
63	3	* @param TokenStorageInterface $tokenStorage
64		* @param CartService $cartService
65	3	* @param OrderHelper $orderHelper
66		*/
67	3	public function __construct(
68		MailService $mailService,
69	3	CustomerStatusRepository $customerStatusRepository,
70		TokenStorageInterface $tokenStorage,
71	3	CartService $cartService,
72		OrderHelper $orderHelper
73	3	) {
74		$this->mailService = $mailService;
75	3	$this->customerStatusRepository = $customerStatusRepository;
76		$this->tokenStorage = $tokenStorage;
		0 ignored issues – show Documentation Bug introduced 2018-06-08 04:37 UTC by Report Bug Copy Issue Report `$tokenStorage` is of type `object<Symfony\Component...\TokenStorageInterface>`, but the property `$tokenStorage` was declared to be of type `object<Symfony\Component...n\Storage\TokenStorage>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
77	3	$this->cartService = $cartService;
78	2	$this->orderHelper = $orderHelper;
79		}
80	1
81		/**
82	1	* 退会画面.
83	1	*
84		* @Route("/mypage/withdraw", name="mypage_withdraw")
85	1	* @Template("Mypage/withdraw.twig")
86		*/
87		public function index(Request $request)
88		{
89		$builder = $this->formFactory->createBuilder();
90	1
91		$event = new EventArgs(
92		[
93	1	'builder' => $builder,
94	1	],
95		$request
96		);
97	1	$this->eventDispatcher->dispatch(EccubeEvents::FRONT_MYPAGE_WITHDRAW_INDEX_INITIALIZE, $event);
98	1
99		$form = $builder->getForm();
100	1
101		$form->handleRequest($request);
102	1
103		if ($form->isSubmitted() && $form->isValid()) {
104	1	switch ($request->get('mode')) {
105		case 'confirm':
106	1	log_info('退会確認画面表示');
107	1
108	1	return $this->render(
109		'Mypage/withdraw_confirm.twig',
110	1	[
111		'form' => $form->createView(),
112		]
113	1	);
114
115		case 'complete':
116	1	log_info('退会処理開始');
117
118	1	/* @var $Customer \Eccube\Entity\Customer */
119		$Customer = $this->getUser();
120	1	$email = $Customer->getEmail();
121
122		// 退会ステータスに変更
123		$CustomerStatus = $this->customerStatusRepository->find(CustomerStatus::WITHDRAWING);
124		$Customer->setStatus($CustomerStatus);
		0 ignored issues – show Bug introduced 2018-06-26 09:41 UTC by Report Bug Copy Issue Report It seems like `$CustomerStatus` defined by `$this->customerStatusRep...merStatus::WITHDRAWING)` on line `123` can also be of type `object`; however, `Eccube\Entity\Customer::setStatus()` does only seem to accept `null\|object<Eccube\Entity\Master\CustomerStatus>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
125	1	$Customer->setEmail(StringUtil::random(60).'@dummy.dummy');
126
127		$this->entityManager->flush();
128
129		log_info('退会処理完了');
130
131		$event = new EventArgs(
132		[
133		'form' => $form,
134		'Customer' => $Customer,
135	1	], $request
136		);
137	1	$this->eventDispatcher->dispatch(EccubeEvents::FRONT_MYPAGE_WITHDRAW_INDEX_COMPLETE, $event);
138
139		// メール送信
140		$this->mailService->sendCustomerWithdrawMail($Customer, $email);
141
142		// カートと受注のセッションを削除
143		$this->cartService->clear();
144		$this->orderHelper->removeSession();
145
146		// ログアウト
147		$this->tokenStorage->setToken(null);
148
149		log_info('ログアウト完了');
150
151		return $this->redirect($this->generateUrl('mypage_withdraw_complete'));
152		}
153		}
154
155		return [
156		'form' => $form->createView(),
157		];
158		}
159
160		/**
161		* 退会完了画面.
162		*
163		* @Route("/mypage/withdraw_complete", name="mypage_withdraw_complete")
164		* @Template("Mypage/withdraw_complete.twig")
165		*/
166		public function complete(Request $request)
		0 ignored issues – show Unused Code introduced 2018-06-08 04:37 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
167		{
168		return [];
169		}
170		}
171

EC-CUBE / ec-cube

Push — 4.0 ( b48f64...137622 )

WithdrawController::index() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like