Failed Conditions
Pull Request — master (#2061)
by k-yamamura
46:49 queued 35:29
created
src/Eccube/Controller/Admin/Store/PluginController.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,6 @@
 block discarded – undo
29 29
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
30 30
 use Symfony\Component\Finder\Finder;
31 31
 use Symfony\Component\Yaml\Yaml;
32
-use Monolog\Logger;
33 32
 
34 33
 class FormEventSubscriber implements EventSubscriberInterface
35 34
 {
Please login to merge, or discard this patch.
src/Eccube/InstallApplication.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@
 block discarded – undo
39 39
 
40 40
         if (is_writable($logDir)) {
41 41
             if (file_exists($installLog) && !is_writable($installLog)) {
42
-                die($installLog . ' の書込権限を変更して下さい。');
42
+                die($installLog.' の書込権限を変更して下さい。');
43 43
             }
44 44
             // install step2 でログディレクトリに書き込み権限が付与されればログ出力を開始する.
45 45
             $app->register(new \Silex\Provider\MonologServiceProvider(), array(
Please login to merge, or discard this patch.
src/Eccube/ServiceProvider/DebugServiceProvider.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
 {
68 68
     public function register(Application $app)
69 69
     {
70
-        $app['var_dumper.cloner'] = $app->share(function ($app) {
70
+        $app['var_dumper.cloner'] = $app->share(function($app) {
71 71
             $cloner = new VarCloner();
72 72
 
73 73
             if (isset($app['debug.max_items'])) {
@@ -81,23 +81,23 @@  discard block
 block discarded – undo
81 81
             return $cloner;
82 82
         });
83 83
 
84
-        $app['data_collector.templates'] = $app->share($app->extend('data_collector.templates', function ($templates) {
84
+        $app['data_collector.templates'] = $app->share($app->extend('data_collector.templates', function($templates) {
85 85
             return array_merge($templates, array(array('dump', '@Debug/Profiler/dump.html.twig')));
86 86
         }));
87 87
 
88
-        $app['data_collector.dump'] = $app->share(function ($app) {
88
+        $app['data_collector.dump'] = $app->share(function($app) {
89 89
             return new DumpDataCollector($app['stopwatch'], $app['code.file_link_format'], null, null, new HtmlDumper());
90 90
         });
91 91
 
92
-        $app['data_collectors'] = $app->share($app->extend('data_collectors', function ($collectors, $app) {
93
-            $collectors['dump'] = $app->share(function ($app) {
92
+        $app['data_collectors'] = $app->share($app->extend('data_collectors', function($collectors, $app) {
93
+            $collectors['dump'] = $app->share(function($app) {
94 94
                 return $app['data_collector.dump'];
95 95
             });
96 96
 
97 97
             return $collectors;
98 98
         }));
99 99
 
100
-        $app['twig'] = $app->share($app->extend('twig', function ($twig, $app) {
100
+        $app['twig'] = $app->share($app->extend('twig', function($twig, $app) {
101 101
             if (class_exists('\Symfony\Bridge\Twig\Extension\DumpExtension')) {
102 102
                 $twig->addExtension(new DumpExtension($app['var_dumper.cloner']));
103 103
             }
@@ -105,13 +105,13 @@  discard block
 block discarded – undo
105 105
             return $twig;
106 106
         }));
107 107
 
108
-        $app['twig.loader.filesystem'] = $app->share($app->extend('twig.loader.filesystem', function ($loader, $app) {
108
+        $app['twig.loader.filesystem'] = $app->share($app->extend('twig.loader.filesystem', function($loader, $app) {
109 109
             $loader->addPath($app['debug.templates_path'], 'Debug');
110 110
 
111 111
             return $loader;
112 112
         }));
113 113
 
114
-        $app['debug.templates_path'] = function () {
114
+        $app['debug.templates_path'] = function() {
115 115
             $r = new \ReflectionClass('Symfony\Bundle\DebugBundle\DependencyInjection\Configuration');
116 116
 
117 117
             return dirname(dirname($r->getFileName())).'/Resources/views';
@@ -123,11 +123,11 @@  discard block
 block discarded – undo
123 123
         // This code is here to lazy load the dump stack. This default
124 124
         // configuration for CLI mode is overridden in HTTP mode on
125 125
         // 'kernel.request' event
126
-        VarDumper::setHandler(function ($var) use ($app) {
126
+        VarDumper::setHandler(function($var) use ($app) {
127 127
             $dumper = $app['data_collector.dump'];
128 128
             $cloner = $app['var_dumper.cloner'];
129 129
 
130
-            $handler = function ($var) use ($dumper, $cloner) {
130
+            $handler = function($var) use ($dumper, $cloner) {
131 131
                 $dumper->dump($cloner->cloneVar($var));
132 132
             };
133 133
 
Please login to merge, or discard this patch.
src/Eccube/Command/GeneratorCommand/AbstractPluginGenerator.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -348,7 +348,7 @@  discard block
 block discarded – undo
348 348
      * @param array $metadatas
349 349
      * @param array $fsList
350 350
      * @param $pluginCode
351
-     * @param $codePath
351
+     * @param string $codePath
352 352
      */
353 353
     protected function generateMigration(array $metadatas, array $fsList = array(), $pluginCode, $codePath)
354 354
     {
@@ -373,7 +373,7 @@  discard block
 block discarded – undo
373 373
      *
374 374
      * @param $pluginCode
375 375
      * @param array $metadatas
376
-     * @return mixed|string
376
+     * @return string
377 377
      */
378 378
     protected function makeMigration($pluginCode, array $metadatas)
379 379
     {
Please login to merge, or discard this patch.
src/Eccube/Command/GeneratorCommand/EntityFromDbGenerator.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -164,7 +164,7 @@
 block discarded – undo
164 164
             $cmf->setEntityManager($em);
165 165
             $metadatas = $cmf->getAllMetadata();
166 166
 
167
-            $filters = array_map(function ($value) {
167
+            $filters = array_map(function($value) {
168 168
                 return ucfirst(Inflector::camelize(str_replace('plg_', '', $value)));
169 169
             }, $tableList);
170 170
             $metadatas = MetadataFilter::filter($metadatas, $filters);
Please login to merge, or discard this patch.
src/Eccube/Command/GeneratorCommand/generatortemplate/ServiceProvider.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
         $app->match('/plugin/[lower_code]/hello', 'Plugin\[code]\Controller\[code]Controller::index')->bind('plugin_[code]_hello');
34 34
 
35 35
         // Form
36
-        $app['form.types'] = $app->share($app->extend('form.types', function ($types) use ($app) {
36
+        $app['form.types'] = $app->share($app->extend('form.types', function($types) use ($app) {
37 37
             $types[] = new [code]ConfigType();
38 38
 
39 39
             return $types;
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
         // }
58 58
 
59 59
         // ログファイル設定
60
-        $app['monolog.logger.[lower_code]'] = $app->share(function ($app) {
60
+        $app['monolog.logger.[lower_code]'] = $app->share(function($app) {
61 61
 
62 62
             $logger = new $app['monolog.logger.class']('[lower_code]');
63 63
 
Please login to merge, or discard this patch.