Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
43 | class OrderHelper |
||
44 | { |
||
45 | /** |
||
46 | * @var OrderItemTypeRepository |
||
47 | */ |
||
48 | protected $orderItemTypeRepository; |
||
49 | |||
50 | /** |
||
51 | * @var OrderStatusRepository |
||
52 | */ |
||
53 | protected $orderStatusRepository; |
||
54 | |||
55 | /** |
||
56 | * @var TaxRuleRepository |
||
57 | */ |
||
58 | protected $taxRuleRepository; |
||
59 | |||
60 | /** |
||
61 | * @var DeliveryFeeRepository |
||
62 | */ |
||
63 | protected $deliveryFeeRepository; |
||
64 | |||
65 | /** |
||
66 | * @var DeliveryRepository |
||
67 | */ |
||
68 | protected $deliveryRepository; |
||
69 | |||
70 | /** |
||
71 | * @var PaymentRepository |
||
72 | */ |
||
73 | protected $paymentRepository; |
||
74 | |||
75 | /** |
||
76 | * @var OrderRepository |
||
77 | */ |
||
78 | protected $orderRepository; |
||
79 | |||
80 | /** |
||
81 | * @var EntityManager |
||
82 | */ |
||
83 | protected $entityManager; |
||
84 | |||
85 | /** |
||
86 | * @var EccubeConfig |
||
87 | */ |
||
88 | protected $eccubeConfig; |
||
89 | |||
90 | /** |
||
91 | * @var \Mobile_Detect |
||
92 | */ |
||
93 | protected $mobileDetect; |
||
94 | |||
95 | /** |
||
96 | * @var DeviceTypeRepository |
||
97 | */ |
||
98 | protected $deviceTypeRepository; |
||
99 | |||
100 | /** |
||
101 | * OrderHelper constructor. |
||
102 | * |
||
103 | * @param OrderItemTypeRepository $orderItemTypeRepository |
||
104 | * @param OrderStatusRepository $orderStatusRepository |
||
|
|||
105 | * @param TaxRuleRepository $taxRuleRepository |
||
106 | * @param DeliveryFeeRepository $deliveryFeeRepository |
||
107 | * @param DeliveryRepository $deliveryRepository |
||
108 | * @param PaymentRepository $paymentRepository |
||
109 | * @param OrderRepository $orderRepository |
||
110 | * @param EntityManager $entityManager |
||
111 | * @param EccubeConfig $eccubeConfig |
||
112 | * @param \Mobile_Detect $mobileDetect |
||
113 | * @param DeviceTypeRepository $deviceTypeRepository |
||
114 | */ |
||
115 | 175 | public function __construct( |
|
116 | OrderItemTypeRepository $orderItemTypeRepository, |
||
117 | OrderStatusRepository $orderStatusRepository, |
||
118 | TaxRuleRepository $taxRuleRepository, |
||
119 | DeliveryFeeRepository $deliveryFeeRepository, |
||
120 | DeliveryRepository $deliveryRepository, |
||
121 | PaymentRepository $paymentRepository, |
||
122 | OrderRepository $orderRepository, |
||
123 | EntityManagerInterface $entityManager, |
||
124 | EccubeConfig $eccubeConfig, |
||
125 | \Mobile_Detect $mobileDetect, |
||
126 | DeviceTypeRepository $deviceTypeRepository |
||
127 | ) { |
||
128 | 175 | $this->orderItemTypeRepository = $orderItemTypeRepository; |
|
129 | 175 | $this->orderStatusRepository = $orderStatusRepository; |
|
130 | 175 | $this->taxRuleRepository = $taxRuleRepository; |
|
131 | 175 | $this->deliveryFeeRepository = $deliveryFeeRepository; |
|
132 | 175 | $this->deliveryRepository = $deliveryRepository; |
|
133 | 175 | $this->paymentRepository = $paymentRepository; |
|
134 | 175 | $this->orderRepository = $orderRepository; |
|
135 | 175 | $this->entityManager = $entityManager; |
|
136 | 175 | $this->eccubeConfig = $eccubeConfig; |
|
137 | 175 | $this->mobileDetect = $mobileDetect; |
|
138 | 175 | $this->deviceTypeRepository = $deviceTypeRepository; |
|
139 | } |
||
140 | |||
141 | /** |
||
142 | * 購入処理中の受注データを生成する. |
||
143 | * |
||
144 | * @param Customer $Customer |
||
145 | * @param array $CartItems |
||
146 | * |
||
147 | * @return Order |
||
148 | */ |
||
149 | 51 | public function createProcessingOrder(Customer $Customer, $CartItems, $preOrderId = null) |
|
150 | { |
||
151 | 51 | $OrderStatus = $this->orderStatusRepository->find(OrderStatus::PROCESSING); |
|
152 | 51 | $Order = new Order($OrderStatus); |
|
153 | |||
154 | 51 | if (!$preOrderId) { |
|
155 | // pre_order_idを生成 |
||
156 | 51 | $Order->setPreOrderId($this->createPreOrderId()); |
|
157 | } |
||
158 | |||
159 | // 顧客情報の設定 |
||
160 | 51 | $this->setCustomer($Order, $Customer); |
|
161 | |||
162 | 51 | $DeviceType = $this->deviceTypeRepository->find($this->mobileDetect->isMobile() ? DeviceType::DEVICE_TYPE_SP : DeviceType::DEVICE_TYPE_PC); |
|
163 | 51 | $Order->setDeviceType($DeviceType); |
|
164 | |||
165 | // 明細情報の設定 |
||
166 | 51 | $OrderItems = $this->createOrderItemsFromCartItems($CartItems); |
|
167 | 51 | $OrderItemsGroupBySaleType = array_reduce($OrderItems, function ($result, $item) { |
|
168 | /* @var OrderItem $item */ |
||
169 | 51 | $saleTypeId = $item->getProductClass()->getSaleType()->getId(); |
|
170 | 51 | $result[$saleTypeId][] = $item; |
|
171 | |||
172 | 51 | return $result; |
|
173 | 51 | }, []); |
|
174 | |||
175 | 51 | foreach ($OrderItemsGroupBySaleType as $OrderItems) { |
|
176 | 51 | $Shipping = $this->createShippingFromCustomer($Customer); |
|
177 | 51 | $Shipping->setOrder($Order); |
|
178 | 51 | $this->addOrderItems($Order, $Shipping, $OrderItems); |
|
179 | 51 | $this->setDefaultDelivery($Shipping); |
|
180 | 51 | $this->entityManager->persist($Shipping); |
|
181 | 51 | $Order->addShipping($Shipping); |
|
182 | } |
||
183 | |||
184 | 51 | $this->setDefaultPayment($Order); |
|
185 | |||
186 | 51 | $this->entityManager->persist($Order); |
|
187 | //$this->entityManager->flush(); |
||
188 | |||
189 | 51 | return $Order; |
|
190 | } |
||
191 | |||
192 | /** |
||
193 | * OrderをCartに変換します. |
||
194 | * |
||
195 | * @param Order $Order |
||
196 | * |
||
197 | * @return Cart |
||
198 | */ |
||
199 | 2 | public function convertToCart(Order $Order) |
|
200 | { |
||
201 | 2 | $Cart = new Cart(); |
|
202 | 2 | $Cart->setPreOrderId($Order->getPreOrderId()); |
|
203 | /** @var OrderItem $OrderItem */ |
||
204 | 2 | foreach ($Order->getProductOrderItems() as $OrderItem) { |
|
205 | 1 | $CartItem = new CartItem(); |
|
206 | 1 | $ProductClass = $OrderItem->getProductClass(); |
|
207 | 1 | $this->entityManager->refresh($ProductClass); |
|
208 | 1 | $CartItem->setProductClass($ProductClass); |
|
209 | 1 | $CartItem->setPrice($OrderItem->getPriceIncTax()); |
|
210 | 1 | $CartItem->setQuantity($OrderItem->getQuantity()); |
|
211 | 1 | $Cart->addCartItem($CartItem); |
|
212 | } |
||
213 | |||
214 | 2 | return $Cart; |
|
215 | } |
||
216 | |||
217 | 51 | private function createPreOrderId() |
|
218 | { |
||
219 | // ランダムなpre_order_idを作成 |
||
220 | View Code Duplication | do { |
|
221 | 51 | $preOrderId = sha1(StringUtil::random(32)); |
|
222 | |||
223 | 51 | $Order = $this->orderRepository->findOneBy( |
|
224 | [ |
||
225 | 51 | 'pre_order_id' => $preOrderId, |
|
226 | 'OrderStatus' => OrderStatus::PROCESSING, |
||
227 | ] |
||
228 | ); |
||
229 | 51 | } while ($Order); |
|
230 | |||
231 | 51 | return $preOrderId; |
|
232 | } |
||
233 | |||
234 | 51 | private function setCustomer(Order $Order, Customer $Customer) |
|
235 | { |
||
236 | 51 | if ($Customer->getId()) { |
|
237 | 34 | $Order->setCustomer($Customer); |
|
238 | } |
||
239 | |||
240 | 51 | $Order->copyProperties( |
|
241 | 51 | $Customer, |
|
242 | [ |
||
243 | 51 | 'id', |
|
244 | 'create_date', |
||
245 | 'update_date', |
||
246 | 'del_flg', |
||
247 | ] |
||
248 | ); |
||
249 | } |
||
250 | |||
251 | /** |
||
252 | * @param ArrayCollection $CartItems |
||
253 | * |
||
254 | * @return OrderItem[] |
||
255 | */ |
||
256 | 51 | private function createOrderItemsFromCartItems($CartItems) |
|
257 | { |
||
258 | 51 | $ProductItemType = $this->orderItemTypeRepository->find(OrderItemType::PRODUCT); |
|
259 | |||
260 | 51 | return array_map(function ($item) use ($ProductItemType) { |
|
261 | /* @var $item CartItem */ |
||
262 | /* @var $ProductClass \Eccube\Entity\ProductClass */ |
||
263 | 51 | $ProductClass = $item->getProductClass(); |
|
264 | /* @var $Product \Eccube\Entity\Product */ |
||
265 | 51 | $Product = $ProductClass->getProduct(); |
|
266 | |||
267 | 51 | $OrderItem = new OrderItem(); |
|
268 | $OrderItem |
||
269 | 51 | ->setProduct($Product) |
|
270 | 51 | ->setProductClass($ProductClass) |
|
271 | 51 | ->setProductName($Product->getName()) |
|
272 | 51 | ->setProductCode($ProductClass->getCode()) |
|
273 | 51 | ->setPrice($ProductClass->getPrice02()) |
|
274 | 51 | ->setQuantity($item->getQuantity()) |
|
275 | 51 | ->setOrderItemType($ProductItemType); |
|
276 | |||
277 | 51 | $ClassCategory1 = $ProductClass->getClassCategory1(); |
|
278 | 51 | if (!is_null($ClassCategory1)) { |
|
279 | 51 | $OrderItem->setClasscategoryName1($ClassCategory1->getName()); |
|
280 | 51 | $OrderItem->setClassName1($ClassCategory1->getClassName()->getName()); |
|
281 | } |
||
282 | 51 | $ClassCategory2 = $ProductClass->getClassCategory2(); |
|
283 | 51 | if (!is_null($ClassCategory2)) { |
|
284 | 43 | $OrderItem->setClasscategoryName2($ClassCategory2->getName()); |
|
285 | 43 | $OrderItem->setClassName2($ClassCategory2->getClassName()->getName()); |
|
286 | } |
||
287 | |||
288 | 51 | return $OrderItem; |
|
289 | 51 | }, $CartItems->toArray()); |
|
290 | } |
||
291 | |||
292 | 51 | private function createShippingFromCustomer(Customer $Customer) |
|
293 | { |
||
294 | 51 | $Shipping = new Shipping(); |
|
295 | $Shipping |
||
296 | 51 | ->setName01($Customer->getName01()) |
|
297 | 51 | ->setName02($Customer->getName02()) |
|
298 | 51 | ->setKana01($Customer->getKana01()) |
|
299 | 51 | ->setKana02($Customer->getKana02()) |
|
300 | 51 | ->setCompanyName($Customer->getCompanyName()) |
|
301 | 51 | ->setPhoneNumber($Customer->getPhoneNumber()) |
|
302 | 51 | ->setPostalCode($Customer->getPostalCode()) |
|
303 | 51 | ->setPref($Customer->getPref()) |
|
304 | 51 | ->setAddr01($Customer->getAddr01()) |
|
305 | 51 | ->setAddr02($Customer->getAddr02()); |
|
306 | |||
307 | 51 | return $Shipping; |
|
308 | } |
||
309 | |||
310 | 51 | private function setDefaultDelivery(Shipping $Shipping) |
|
330 | |||
331 | 51 | private function setDefaultPayment(Order $Order) |
|
332 | { |
||
333 | 51 | $OrderItems = $Order->getOrderItems(); |
|
334 | |||
335 | // 受注明細に含まれる販売種別を抽出. |
||
336 | 51 | $SaleTypes = []; |
|
337 | /** @var OrderItem $OrderItem */ |
||
361 | |||
362 | 51 | private function addOrderItems(Order $Order, Shipping $Shipping, array $OrderItems) |
|
371 | } |
||
372 |