Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like CartService often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use CartService, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 33 | class CartService |
||
|
|
|||
| 34 | { |
||
| 35 | /** |
||
| 36 | * @var Cart[] |
||
| 37 | */ |
||
| 38 | protected $carts; |
||
| 39 | |||
| 40 | /** |
||
| 41 | * @var SessionInterface |
||
| 42 | */ |
||
| 43 | protected $session; |
||
| 44 | |||
| 45 | /** |
||
| 46 | * @var \Doctrine\ORM\EntityManagerInterface |
||
| 47 | */ |
||
| 48 | protected $entityManager; |
||
| 49 | |||
| 50 | /** |
||
| 51 | * @var ItemHolderInterface |
||
| 52 | * |
||
| 53 | * @deprecated |
||
| 54 | */ |
||
| 55 | protected $cart; |
||
| 56 | |||
| 57 | /** |
||
| 58 | * @var ProductClassRepository |
||
| 59 | */ |
||
| 60 | protected $productClassRepository; |
||
| 61 | |||
| 62 | /** |
||
| 63 | * @var CartRepository |
||
| 64 | */ |
||
| 65 | protected $cartRepository; |
||
| 66 | |||
| 67 | /** |
||
| 68 | * @var CartItemComparator |
||
| 69 | */ |
||
| 70 | protected $cartItemComparator; |
||
| 71 | |||
| 72 | /** |
||
| 73 | * @var CartItemAllocator |
||
| 74 | */ |
||
| 75 | protected $cartItemAllocator; |
||
| 76 | |||
| 77 | /** |
||
| 78 | * @var OrderHelper |
||
| 79 | */ |
||
| 80 | protected $orderHelper; |
||
| 81 | |||
| 82 | /** |
||
| 83 | * @var OrderRepository |
||
| 84 | */ |
||
| 85 | protected $orderRepository; |
||
| 86 | |||
| 87 | /** |
||
| 88 | * @var TokenStorageInterface |
||
| 89 | */ |
||
| 90 | protected $tokenStorage; |
||
| 91 | |||
| 92 | /** |
||
| 93 | * @var AuthorizationCheckerInterface |
||
| 94 | */ |
||
| 95 | protected $authorizationChecker; |
||
| 96 | |||
| 97 | /** |
||
| 98 | * CartService constructor. |
||
| 99 | * |
||
| 100 | * @param SessionInterface $session |
||
| 101 | * @param EntityManagerInterface $entityManager |
||
| 102 | * @param ProductClassRepository $productClassRepository |
||
| 103 | * @param CartItemComparator $cartItemComparator |
||
| 104 | * @param CartItemAllocator $cartItemAllocator |
||
| 105 | * @param OrderHelper $orderHelper |
||
| 106 | * @param TokenStorageInterface $tokenStorage |
||
| 107 | * @param AuthorizationCheckerInterface $authorizationChecker |
||
| 108 | */ |
||
| 109 | 171 | public function __construct( |
|
| 110 | SessionInterface $session, |
||
| 111 | EntityManagerInterface $entityManager, |
||
| 112 | ProductClassRepository $productClassRepository, |
||
| 113 | CartRepository $cartRepository, |
||
| 114 | CartItemComparator $cartItemComparator, |
||
| 115 | CartItemAllocator $cartItemAllocator, |
||
| 116 | OrderHelper $orderHelper, |
||
| 117 | OrderRepository $orderRepository, |
||
| 118 | TokenStorageInterface $tokenStorage, |
||
| 119 | AuthorizationCheckerInterface $authorizationChecker |
||
| 120 | ) { |
||
| 121 | 171 | $this->session = $session; |
|
| 122 | 171 | $this->entityManager = $entityManager; |
|
| 123 | 171 | $this->productClassRepository = $productClassRepository; |
|
| 124 | 171 | $this->cartRepository = $cartRepository; |
|
| 125 | 171 | $this->cartItemComparator = $cartItemComparator; |
|
| 126 | 171 | $this->cartItemAllocator = $cartItemAllocator; |
|
| 127 | 171 | $this->orderHelper = $orderHelper; |
|
| 128 | 171 | $this->orderRepository = $orderRepository; |
|
| 129 | 171 | $this->tokenStorage = $tokenStorage; |
|
| 130 | 171 | $this->authorizationChecker = $authorizationChecker; |
|
| 131 | } |
||
| 132 | |||
| 133 | 131 | public function getCarts() |
|
| 134 | { |
||
| 135 | 131 | if (!empty($this->carts)) { |
|
| 136 | 85 | return $this->carts; |
|
| 137 | } |
||
| 138 | |||
| 139 | 131 | $cartKeys = $this->session->get('cart_keys', []); |
|
| 140 | 131 | $this->carts = $this->cartRepository->findBy(['cart_key' => $cartKeys], ['id' => 'DESC']); |
|
| 141 | |||
| 142 | 131 | return $this->carts; |
|
| 143 | } |
||
| 144 | |||
| 145 | /** |
||
| 146 | * 会員が保持する永続化されたカートと、非会員時のカートをマージする. |
||
| 147 | * |
||
| 148 | * @param Customer $Customer |
||
| 149 | */ |
||
| 150 | public function mergeFromPersistedCart(Customer $Customer) |
||
| 163 | |||
| 164 | /** |
||
| 165 | * @return ItemHolderInterface|Cart |
||
| 166 | */ |
||
| 167 | 65 | public function getCart() |
|
| 168 | { |
||
| 169 | 65 | $Carts = $this->getCarts(); |
|
| 170 | |||
| 171 | 65 | if (empty($Carts)) { |
|
| 172 | 4 | return null; |
|
| 173 | } |
||
| 174 | |||
| 175 | 63 | return current($Carts); |
|
| 176 | } |
||
| 177 | |||
| 178 | /** |
||
| 179 | * @param CartItem[] $cartItems |
||
| 180 | * |
||
| 181 | * @return CartItem[] |
||
| 182 | */ |
||
| 183 | 86 | protected function mergeAllCartItems($cartItems = []) |
|
| 184 | { |
||
| 185 | /** @var CartItem[] $allCartItems */ |
||
| 186 | 86 | $allCartItems = []; |
|
| 187 | |||
| 188 | 86 | foreach ($this->getCarts() as $Cart) { |
|
| 189 | 39 | $allCartItems = $this->mergeCartItems($Cart->getCartItems(), $allCartItems); |
|
| 190 | } |
||
| 191 | |||
| 192 | 86 | return $this->mergeCartItems($cartItems, $allCartItems); |
|
| 193 | } |
||
| 194 | |||
| 195 | /** |
||
| 196 | * @param $cartItems |
||
| 197 | * @param $allCartItems |
||
| 198 | * |
||
| 199 | * @return array |
||
| 200 | */ |
||
| 201 | 86 | protected function mergeCartItems($cartItems, $allCartItems) |
|
| 220 | |||
| 221 | 86 | protected function restoreCarts($cartItems) |
|
| 222 | { |
||
| 223 | 86 | if (empty($cartItems)) { |
|
| 224 | 2 | foreach ($this->getCarts() as $Cart) { |
|
| 225 | 1 | foreach ($Cart->getCartItems() as $i) { |
|
| 226 | 1 | $this->entityManager->remove($i); |
|
| 227 | 1 | $this->entityManager->flush($i); |
|
| 228 | } |
||
| 229 | 1 | $this->entityManager->remove($Cart); |
|
| 230 | 1 | $this->entityManager->flush($Cart); |
|
| 231 | } |
||
| 232 | 2 | $this->carts = []; |
|
| 233 | } |
||
| 234 | |||
| 235 | /** @var Cart[] $Carts */ |
||
| 236 | 86 | $Carts = []; |
|
| 237 | |||
| 238 | 86 | foreach ($cartItems as $item) { |
|
| 239 | 85 | $allocatedId = $this->cartItemAllocator->allocate($item); |
|
| 240 | 85 | $cartKey = $this->createCartKey($allocatedId, $this->getUser()); |
|
| 241 | |||
| 242 | 85 | if (isset($Carts[$cartKey])) { |
|
| 243 | 16 | $Cart = $Carts[$cartKey]; |
|
| 244 | 16 | $Cart->addCartItem($item); |
|
| 245 | 16 | $item->setCart($Cart); |
|
| 246 | } else { |
||
| 247 | /** @var Cart $Cart */ |
||
| 248 | 85 | $Cart = $this->cartRepository->findOneBy(['cart_key' => $cartKey]); |
|
| 249 | 85 | if ($Cart) { |
|
| 250 | 34 | foreach ($Cart->getCartItems() as $i) { |
|
| 251 | 34 | $this->entityManager->remove($i); |
|
| 252 | 34 | $this->entityManager->flush($i); |
|
| 253 | } |
||
| 254 | 34 | $this->entityManager->remove($Cart); |
|
| 255 | 34 | $this->entityManager->flush($Cart); |
|
| 256 | } |
||
| 257 | 85 | $Cart = new Cart(); |
|
| 258 | 85 | $Cart->setCartKey($cartKey); |
|
| 259 | 85 | $Cart->addCartItem($item); |
|
| 260 | 85 | $item->setCart($Cart); |
|
| 261 | 85 | $Carts[$cartKey] = $Cart; |
|
| 262 | } |
||
| 263 | } |
||
| 264 | |||
| 265 | 86 | $this->carts = array_values($Carts); |
|
| 266 | } |
||
| 267 | |||
| 268 | /** |
||
| 269 | * カートに商品を追加します. |
||
| 270 | * |
||
| 271 | * @param $ProductClass ProductClass 商品規格 |
||
| 272 | * @param $quantity int 数量 |
||
| 273 | * |
||
| 274 | * @return bool 商品を追加できた場合はtrue |
||
| 275 | */ |
||
| 276 | 85 | public function addProduct($ProductClass, $quantity = 1) |
|
| 307 | |||
| 308 | 2 | public function removeProduct($ProductClass) |
|
| 309 | { |
||
| 310 | 2 | View Code Duplication | if (!$ProductClass instanceof ProductClass) { |
| 311 | 1 | $ProductClassId = $ProductClass; |
|
| 312 | 1 | $ProductClass = $this->entityManager |
|
| 313 | 1 | ->getRepository(ProductClass::class) |
|
| 314 | 1 | ->find($ProductClassId); |
|
| 315 | 1 | if (is_null($ProductClass)) { |
|
| 316 | return false; |
||
| 317 | } |
||
| 318 | } |
||
| 319 | |||
| 320 | 2 | $removeItem = new CartItem(); |
|
| 321 | 2 | $removeItem->setPrice($ProductClass->getPrice02IncTax()); |
|
| 322 | 2 | $removeItem->setProductClass($ProductClass); |
|
| 323 | |||
| 324 | 2 | $allCartItems = $this->mergeAllCartItems(); |
|
| 325 | 2 | $foundIndex = -1; |
|
| 326 | 2 | foreach ($allCartItems as $index => $itemInCart) { |
|
| 327 | 1 | if ($this->cartItemComparator->compare($itemInCart, $removeItem)) { |
|
| 328 | 1 | $foundIndex = $index; |
|
| 329 | 1 | break; |
|
| 330 | } |
||
| 331 | } |
||
| 332 | |||
| 333 | 2 | array_splice($allCartItems, $foundIndex, 1); |
|
| 334 | 2 | $this->restoreCarts($allCartItems); |
|
| 335 | |||
| 336 | 2 | return true; |
|
| 337 | } |
||
| 338 | |||
| 339 | 80 | public function save() |
|
| 340 | { |
||
| 341 | 80 | $cartKeys = []; |
|
| 342 | 80 | foreach ($this->carts as $Cart) { |
|
| 343 | 78 | $Cart->setCustomer($this->getUser()); |
|
| 344 | 78 | $this->entityManager->persist($Cart); |
|
| 345 | 78 | foreach ($Cart->getCartItems() as $item) { |
|
| 346 | 78 | $this->entityManager->persist($item); |
|
| 347 | 78 | $this->entityManager->flush($item); |
|
| 348 | } |
||
| 349 | 78 | $this->entityManager->flush($Cart); |
|
| 350 | 78 | $cartKeys[] = $Cart->getCartKey(); |
|
| 351 | } |
||
| 352 | |||
| 353 | 80 | $this->session->set('cart_keys', $cartKeys); |
|
| 354 | |||
| 355 | 80 | return; |
|
| 356 | } |
||
| 357 | |||
| 358 | /** |
||
| 359 | * @param string $pre_order_id |
||
| 360 | * |
||
| 361 | * @return \Eccube\Service\CartService |
||
| 362 | */ |
||
| 363 | 52 | public function setPreOrderId($pre_order_id) |
|
| 369 | |||
| 370 | /** |
||
| 371 | * @return string |
||
| 372 | */ |
||
| 373 | 51 | public function getPreOrderId() |
|
| 377 | |||
| 378 | /** |
||
| 379 | * @return \Eccube\Service\CartService |
||
| 380 | */ |
||
| 381 | 10 | public function clear() |
|
| 382 | { |
||
| 383 | 10 | $Carts = $this->getCarts(); |
|
| 384 | 10 | if (!empty($Carts)) { |
|
| 401 | |||
| 402 | /** |
||
| 403 | * @param CartItemComparator $cartItemComparator |
||
| 404 | */ |
||
| 405 | 1 | public function setCartItemComparator($cartItemComparator) |
|
| 409 | |||
| 410 | /** |
||
| 411 | * 指定したインデックスにあるカートを優先にする |
||
| 412 | * |
||
| 413 | * @param int $index カートのインデックス |
||
| 414 | */ |
||
| 415 | 53 | public function setPrimary($index = 0) |
|
| 425 | |||
| 426 | 85 | protected function getUser() |
|
| 439 | |||
| 440 | 85 | protected function createCartKey($allocatedId, Customer $Customer = null) |
|
| 460 | } |
||
| 461 |