EccubeAuthenticationSuccessHandler::determineTargetUrl() - Code Metrics - Inspection of "ログイン失敗時のfailure用クラスの作成" - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 4.0 (#3859)

by k-yamamura

created 2018-09-19 05:29 UTC

determineTargetUrl() B

↳ Parent: EccubeAuthenticationSuccessHandler

Complexity

Conditions	11
Paths	9

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	11
nc	9
nop	1
dl	0
loc	31
rs	7.3166
c	0
b	0
f	0

How to fix Complexity

<?php

/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Eccube\Security\Http\Authentication;

use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Security\Http\Authentication\DefaultAuthenticationSuccessHandler;
use Symfony\Component\Security\Http\ParameterBagUtils;
use Symfony\Component\Security\Http\Util\TargetPathTrait;

class EccubeAuthenticationSuccessHandler extends DefaultAuthenticationSuccessHandler
{
    use TargetPathTrait;

    /**
     * Builds the target URL according to the defined options.
     *
     * @return string
     */
    protected function determineTargetUrl(Request $request)
    {
        if ($this->options['always_use_default_target_path']) {
            return $this->options['default_target_path'];
        }

        if ($targetUrl = ParameterBagUtils::getRequestParameterValue($request, $this->options['target_path_parameter'])) {
            if (preg_match('/^https?:\\\\/i', $targetUrl)) {
                $targetUrl = '/';
            }

            return $targetUrl;
        }

        if (null !== $this->providerKey && $targetUrl = $this->getTargetPath($request->getSession(), $this->providerKey)) {
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
            $this->removeTargetPath($request->getSession(), $this->providerKey);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}

            return $targetUrl;
        }

        if ($this->options['use_referer'] && $targetUrl = $request->headers->get('Referer')) {
            if (false !== $pos = strpos($targetUrl, '?')) {
                $targetUrl = substr($targetUrl, 0, $pos);
            }
            if ($targetUrl && $targetUrl !== $this->httpUtils->generateUri($request, $this->options['login_path'])) {
                return $targetUrl;
            }
        }

        return $this->options['default_target_path'];
    }

}


1			<?php
2
3			/*
4			* This file is part of EC-CUBE
5			*
6			* Copyright(c) LOCKON CO.,LTD. All Rights Reserved.
7			*
8			* http://www.lockon.co.jp/
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Eccube\Security\Http\Authentication;
15
16			use Symfony\Component\HttpFoundation\Request;
17			use Symfony\Component\Security\Http\Authentication\DefaultAuthenticationSuccessHandler;
18			use Symfony\Component\Security\Http\ParameterBagUtils;
19			use Symfony\Component\Security\Http\Util\TargetPathTrait;
20
21			class EccubeAuthenticationSuccessHandler extends DefaultAuthenticationSuccessHandler
22			{
23			use TargetPathTrait;
24
25			/**
26			* Builds the target URL according to the defined options.
27			*
28			* @return string
29			*/
30			protected function determineTargetUrl(Request $request)
31			{
32			if ($this->options['always_use_default_target_path']) {
33			return $this->options['default_target_path'];
34			}
35
36			if ($targetUrl = ParameterBagUtils::getRequestParameterValue($request, $this->options['target_path_parameter'])) {
37			if (preg_match('/^https?:\\\\/i', $targetUrl)) {
38			$targetUrl = '/';
39			}
40
41			return $targetUrl;
42			}
43
44			if (null !== $this->providerKey && $targetUrl = $this->getTargetPath($request->getSession(), $this->providerKey)) {
			0 ignored issues – show Bug introduced 2018-09-19 05:35 UTC by Report Bug Copy Issue Report It seems like `$request->getSession()` can be `null`; however, `getTargetPath()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
45			$this->removeTargetPath($request->getSession(), $this->providerKey);
			0 ignored issues – show Bug introduced 2018-09-19 05:35 UTC by Report Bug Copy Issue Report It seems like `$request->getSession()` can be `null`; however, `removeTargetPath()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
46
47			return $targetUrl;
48			}
49
50			if ($this->options['use_referer'] && $targetUrl = $request->headers->get('Referer')) {
51			if (false !== $pos = strpos($targetUrl, '?')) {
52			$targetUrl = substr($targetUrl, 0, $pos);
53			}
54			if ($targetUrl && $targetUrl !== $this->httpUtils->generateUri($request, $this->options['login_path'])) {
55			return $targetUrl;
56			}
57			}
58
59			return $this->options['default_target_path'];
60			}
61
62			}
63

EC-CUBE / ec-cube

Pull Request — 4.0 (#3859)

determineTargetUrl() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like