Eccube\Application

Complexity

Total Complexity

106

Size/Duplication

Total Lines	1030
Duplicated Lines	2.72 %

Coupling/Cohesion

Components	2
Dependencies	91

Test Coverage

Coverage

76.68%

Importance

Changes

0

22 Methods

Rating	Name	Duplication	Size	Complexity
B	isSessionStarted()	0	12	5
B	initCacheRequest()	0	63	7
A	getInstance()	0	8	2
A	clearInstance()	0	4	1
A	__clone()	0	4	1
A	__construct()	0	14	2
A	isBooted()	0	4	1
B	initConfig()	0	25	2
A	initLogger()	0	5	1
C	initialize()	22	222	12
B	initLocale()	0	29	5
B	initSession()	0	24	3
D	initRendering()	0	139	20
C	initMailer()	0	29	8
F	initDoctrine()	3	172	14
B	initSecurity()	0	99	3
B	initProxy()	3	12	5
A	initializePlugin()	0	15	4
A	setTestMode()	0	4	1
A	isTestMode()	0	4	1
B	checkDatabaseConnection()	0	24	3
B	parseConfig()	0	28	5

<?php
/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 */

namespace Eccube;

use Doctrine\DBAL\Types\Type;
use Eccube\Di\Scanner\ComponentScanner;
use Eccube\Di\Scanner\EntityEventScanner;
use Eccube\Di\Scanner\FormExtensionScanner;
use Eccube\Di\Scanner\FormTypeScanner;
use Eccube\Di\Scanner\QueryExtensionScanner;
use Eccube\Di\Scanner\RepositoryScanner;
use Eccube\Di\Scanner\ServiceScanner;
use Eccube\Doctrine\DBAL\Types\UTCDateTimeType;
use Eccube\Doctrine\DBAL\Types\UTCDateTimeTzType;
use Eccube\Doctrine\EventSubscriber\InitSubscriber;
use Eccube\Doctrine\ORM\Mapping\Driver\AnnotationDriver;
use Eccube\Entity\BaseInfo;
use Eccube\Plugin\ConfigManager as PluginConfigManager;
use Eccube\Routing\EccubeRouter;
use Eccube\ServiceProvider\CompatRepositoryProvider;
use Eccube\ServiceProvider\CompatServiceProvider;
use Eccube\ServiceProvider\DiServiceProvider;
use Eccube\ServiceProvider\EntityEventServiceProvider;
use Eccube\ServiceProvider\MobileDetectServiceProvider;
use Eccube\ServiceProvider\TwigLintServiceProvider;
use Sergiors\Silex\Routing\ChainUrlGenerator;
use Sergiors\Silex\Routing\ChainUrlMatcher;
use Symfony\Component\Dotenv\Dotenv;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Event\GetResponseEvent;
use Symfony\Component\HttpKernel\KernelEvents;

class Application extends \Silex\Application

Missing class doc comment

{
    use \Silex\Application\FormTrait;
    use \Silex\Application\UrlGeneratorTrait;
    use \Silex\Application\MonologTrait;
    use \Silex\Application\SwiftmailerTrait;
    use \Silex\Application\SecurityTrait;
    use \Silex\Application\TranslationTrait;
    use \Eccube\Application\ApplicationTrait;
    use \Eccube\Application\SecurityTrait;
    use \Eccube\Application\TwigTrait;

    protected static $instance;

    protected $initialized = false;
    protected $initializedPlugin = false;
    protected $testMode = false;

    public static function getInstance(array $values = array())

Missing function doc comment

    {
        if (!is_object(self::$instance)) {
            self::$instance = new Application($values);
        }

        return self::$instance;
    }

    public static function clearInstance()

Missing function doc comment

    {
        self::$instance = null;
    }

    final public function __clone()

Missing function doc comment

    {
        throw new \Exception('Clone is not allowed against '.get_class($this));
    }

    public function __construct(array $values = array())

Missing function doc comment

    {
        parent::__construct($values);

        if (is_null(self::$instance)) {
            self::$instance = $this;
        }

        // load config
        $this->initConfig();

        // init monolog
        $this->initLogger();
    }

    /**
     * Application::runが実行されているか親クラスのプロパティから判定
     *
     * @return bool
     */
    public function isBooted()
    {
        return $this->booted;
    }

    public function initConfig()

Missing function doc comment

    {
        // load .env
        $envFile = __DIR__.'/../../.env';
        if (file_exists($envFile)) {
            (new Dotenv())->load($envFile);
        }

        // load config
        $this['config'] = function() {

Expected 1 space after FUNCTION keyword; 0 found

            $configAll = array();
            $this->parseConfig('constant', $configAll)
                ->parseConfig('path', $configAll)
                ->parseConfig('config', $configAll)
                ->parseConfig('database', $configAll)
                ->parseConfig('mail', $configAll)
                ->parseConfig('log', $configAll)
                ->parseConfig('nav', $configAll, true)
                ->parseConfig('doctrine_cache', $configAll)
                ->parseConfig('http_cache', $configAll)
                ->parseConfig('session_handler', $configAll);

            return $configAll;
        };
    }

    public function initLogger()

Missing function doc comment

    {
        $app = $this;
        $this->register(new ServiceProvider\LogServiceProvider($app));

The call to LogServiceProvider::__construct() has too many arguments starting with $app.

    }

    public function initialize()

Missing function doc comment

    {
        if ($this->initialized) {
            return;
        }

        // init locale
        $this->initLocale();

        // init session
        if (!$this->isSessionStarted()) {
            $this->initSession();
        }

        // init twig
        $this->initRendering();

        // init provider
        $this->register(new \Silex\Provider\HttpCacheServiceProvider(), array(
            'http_cache.cache_dir' => __DIR__.'/../../app/cache/http/',
        ));
        $this->register(new \Silex\Provider\HttpFragmentServiceProvider());
        $this->register(new \Silex\Provider\FormServiceProvider());
        $this->register(new \Silex\Provider\SerializerServiceProvider());
        $this->register(new \Silex\Provider\ValidatorServiceProvider());
        $this->register(new \Saxulum\Validator\Provider\SaxulumValidatorProvider());
        $this->register(new MobileDetectServiceProvider());
        $this->register(new TwigLintServiceProvider());

        $this->error(function (\Exception $e, Request $request, $code) {
            if ($this['debug']) {
                return;
            }

            switch ($code) {
                case 403:
                    $title = 'アクセスできません。';
                    $message = 'お探しのページはアクセスができない状況にあるか、移動もしくは削除された可能性があります。';
                    break;
                case 404:
                    $title = 'ページがみつかりません。';
                    $message = 'URLに間違いがないかご確認ください。';
                    break;
                default:
                    $title = 'システムエラーが発生しました。';
                    $message = '大変お手数ですが、サイト管理者までご連絡ください。';
                    break;
            }

            return $this->render('error.twig', array(
                'error_title' => $title,
                'error_message' => $message,
            ));
        });

        // init mailer
        $this->initMailer();

        $this->register(new \Sergiors\Silex\Provider\DoctrineCacheServiceProvider());
        $this->register(new \Sergiors\Silex\Provider\AnnotationsServiceProvider(), [

Add a comma after each item in a multi-line array

            'annotations.debug' => $this['debug'],
            'annotations.options' => [

Add a comma after each item in a multi-line array

                'cache_driver' => $this['debug'] ? 'array' : 'filesystem',
                'cache_dir' => $this['debug'] ? null : __DIR__.'/../../app/cache/annotation'
            ]
        ]);

        // init doctrine orm
        $this->initDoctrine();

        // Set up the DBAL connection now to check for a proper connection to the database.
        $this->checkDatabaseConnection();

        // init security
        $this->initSecurity();

        $this->register(new \Sergiors\Silex\Provider\RoutingServiceProvider(), [

Add a comma after each item in a multi-line array

            'routing.cache_dir' => $this['debug'] ? null : __DIR__.'/../../app/cache/routing'
        ]);
        $this->register(new \Sergiors\Silex\Provider\TemplatingServiceProvider());
        $this->register(new \Sergiors\Silex\Provider\SensioFrameworkExtraServiceProvider(), [

Add a comma after each item in a multi-line array

            'request' => [

Add a comma after each item in a multi-line array

                'auto_convert' => true
            ]
        ]);
        // init proxy
        $this->initProxy();

        $enabledPlugins = $this['orm.em']->getRepository('Eccube\Entity\Plugin')->findAllEnabled();
        $configRootDir = $this['config']['root_dir'];
        $enabledPluginDirs = array_map(function($plugin) use ($configRootDir) {

Expected 1 space after FUNCTION keyword; 0 found

            return $configRootDir.'/app/Plugin/'.$plugin->getCode();
        }, $enabledPlugins);

        $pluginSubDirs = (function($dirName) use ($enabledPluginDirs) {

Expected 1 space after FUNCTION keyword; 0 found

            return array_map(function($pluginDir) use ($dirName) {

Expected 1 space after FUNCTION keyword; 0 found

                return $pluginDir . '/' . $dirName;

Concat operator must not be surrounded by spaces

            }, $enabledPluginDirs);
        });

        // init ec-cube service provider
        $this->register(new DiServiceProvider(), [

Add a comma after each item in a multi-line array

            'eccube.di.scanners' => [

Add a comma after each item in a multi-line array

                new ComponentScanner(array_merge([

Add a comma after each item in a multi-line array

                    $this['config']['root_dir'].'/app/Acme/Controller',
                    $this['config']['root_dir'].'/src/Eccube/Controller'
                ], $pluginSubDirs('Controller'))),
                new FormTypeScanner(array_merge([

Add a comma after each item in a multi-line array

                    $this['config']['root_dir'].'/src/Eccube/Form/Type'
                ], $pluginSubDirs('Form/Type'))),
                new FormExtensionScanner(array_merge([

Add a comma after each item in a multi-line array

                    $this['config']['root_dir'].'/src/Eccube/Form/Extension'
                ], $pluginSubDirs('Form/Extension'))),
                new ServiceScanner(array_merge([

Add a comma after each item in a multi-line array

                    $this['config']['root_dir'].'/src/Eccube/Service'
                ], $pluginSubDirs('Service'))),
                new RepositoryScanner(array_merge([

Add a comma after each item in a multi-line array

                    $this['config']['root_dir'].'/src/Eccube/Repository'
                ], $pluginSubDirs('Repository'))),
                new QueryExtensionScanner(array_merge([

Add a comma after each item in a multi-line array

                    $this['config']['root_dir'].'/src/Eccube/Repository'
                ], $pluginSubDirs('Repository'))),
                new EntityEventScanner(array_merge([

Add a comma after each item in a multi-line array

                    $this['config']['root_dir'].'/app/Acme/Entity'
                ], $pluginSubDirs('Entity')))
            ],
            'eccube.di.generator.dir' => $this['config']['root_dir'].'/app/cache/provider'
        ]);

        $this->register(new CompatRepositoryProvider());
        $this->register(new CompatServiceProvider());
        $this->register(new ServiceProvider\EccubeServiceProvider());

        $this->register(new \Silex\Provider\ServiceControllerServiceProvider());
        Request::enableHttpMethodParameterOverride(); // PUTやDELETEできるようにする

        // ルーティングの設定
        // TODO EccubeRoutingServiceProviderに移植する.
        $app = $this;
        $this['eccube.router'] = $this->protect(function($resoure, $cachePrefix) use ($app) {

Expected 1 space after FUNCTION keyword; 0 found

            $options = [

Add a comma after each item in a multi-line array

                'debug' => $app['debug'],
                'cache_dir' => $app['routing.cache_dir'],
                'matcher_base_class' => $app['request_matcher_class'],
                'matcher_class' => $app['request_matcher_class'],
                'matcher_cache_class' => $cachePrefix.'UrlMatcher',
                'generator_cache_class' => $cachePrefix.'UrlGenerator'
            ];
            $router = new EccubeRouter(
                $app['routing.loader'],
                $resoure,
                $options,
                $app['request_context'],
                $app['logger']
            );

            $router->setAdminPrefix($app['config']['admin_route']);
            $router->setUserDataPrefix($app['config']['user_data_route']);
            $router->setRequireHttps($app['config']['force_ssl']);

            return $router;
        });

        $this['eccube.router.origin'] = function ($app) {
            $resource = __DIR__.'/Controller';
            $cachePrefix = 'Origin';

            return $app['eccube.router']($resource, $cachePrefix);
        };

        $this['eccube.routers.plugin'] = [];

        $this['eccube.router.extend'] = function ($app) {
            // TODO ディレクトリ名は暫定
            $resource = $app['config']['root_dir'].'/app/Acme/Controller';
            $cachePrefix = 'Extend';

            $router = $app['eccube.router']($resource, $cachePrefix);

            return $router;
        };

        $this->extend('request_matcher', function ($matcher, $app) {
            $matchers = [];
            $matchers[] = $app['eccube.router.extend'];
            foreach ($app['eccube.routers.plugin'] as $router) {
                $matchers[] = $router;
            };
            $matchers[] = $app['eccube.router.origin'];
            $matchers[] = $matcher;

            return new ChainUrlMatcher($matchers, $app['request_context']);
        });

        $this->extend('url_generator', function ($generator, $app) {
            $generators = [];
            $generators[] = $app['eccube.router.extend'];
            foreach ($app['eccube.routers.plugin'] as $router) {
                $generators[] = $router;
            };
            $generators[] = $app['eccube.router.origin'];
            $generators[] = $generator;

            return new ChainUrlGenerator($generators, $app['request_context']);
        });

        // Route CollectionにEC-CUBEで定義したルーティングを追加(debug tool barに出力するため)
        $this->extend('routes', function ($routes, $app) {
            $routes->addCollection($app['eccube.router.extend']->getRouteCollection());
            foreach ($app['eccube.routers.plugin'] as $router) {
                $routes->addCollection($router->getRouteCollection());
            };
            $routes->addCollection($app['eccube.router.origin']->getRouteCollection());

            return $routes;
        });

        // init http cache
        $this->initCacheRequest();

        $this->initialized = true;
    }

    public function initLocale()

Missing function doc comment

    {
        // locale
        if (!empty($this['config']['locale'])) {
            \Locale::setDefault($this['config']['locale']);
        };

        // timezone
        if (!empty($this['config']['timezone'])) {
            date_default_timezone_set($this['config']['timezone']);
        }

        $this->register(new \Silex\Provider\TranslationServiceProvider(), array(
            'locale' => $this['config']['locale'],
            'translator.cache_dir' => $this['debug'] ? null : $this['config']['root_dir'].'/app/cache/translator',
            'locale_fallbacks' => ['ja', 'en'],
        ));
        $this->extend('translator', function ($translator, \Silex\Application $app) {
            $translator->addLoader('php', new \Symfony\Component\Translation\Loader\PhpFileLoader());

            $file = __DIR__.'/Resource/locale/messages.'.$app['locale'].'.php';
            if (file_exists($file)) {
                $translator->addResource('php', $file, $app['locale']);
                $translator->addResource('php', $file, $app['locale'], 'validators');
            }

            return $translator;
        });
    }

    public function initSession()

Missing function doc comment

    {
        $this->register(new \Silex\Provider\SessionServiceProvider(), array(
            'session.storage.save_path' => $this['config']['root_dir'].'/app/cache/eccube/session',
            'session.storage.options' => array(
                'name' => $this['config']['cookie_name'],
                'cookie_path' => $this['config']['root_urlpath'] ?: '/',
                'cookie_secure' => $this['config']['force_ssl'],
                'cookie_lifetime' => $this['config']['cookie_lifetime'],
                'cookie_httponly' => true,
                // cookie_domainは指定しない
                // http://blog.tokumaru.org/2011/10/cookiedomain.html
            ),
        ));

        $options = $this['config']['session_handler'];

        if ($options['enabled']) {
            // @see http://silex.sensiolabs.org/doc/providers/session.html#custom-session-configurations
            $this['session.storage.handler'] = null;
            ini_set('session.save_handler', $options['save_handler']);
            ini_set('session.save_path', $options['save_path']);
        }
    }

    public function initRendering()

Missing function doc comment

    {
        $this->register(new \Silex\Provider\TwigServiceProvider(), array(
            'twig.form.templates' => array('Form/form_layout.twig'),
        ));
        $this->extend('twig', function (\Twig_Environment $twig, \Silex\Application $app) {
            $twig->addExtension(new \Eccube\Twig\Extension\EccubeExtension($app));
            $twig->addExtension(new \Twig_Extension_StringLoader());

            return $twig;
        });

        $this->before(function (Request $request, \Silex\Application $app) {
            $app['admin'] = $app['front'] = false;
            $pathinfo = rawurldecode($request->getPathInfo());
            if (strpos($pathinfo, '/'.trim($app['config']['admin_route'], '/').'/') === 0) {
                $app['admin'] = true;
            } else {
                $app['front'] = true;
            }

            // フロント or 管理画面ごとにtwigの探索パスを切り替える.
            if ($app->isAdminRequest()) {

It seems like you code against a specific sub-type and not the parent class Silex\Application as the method isAdminRequest() does only exist in the following sub-classes of Silex\Application: Eccube\Application, Eccube\InstallApplication. Maybe you want to instanceof check for one of these explicitly?

                if (file_exists(__DIR__.'/../../app/template/admin')) {
                    $paths[] = __DIR__.'/../../app/template/admin';

$paths was never initialized. Although not strictly required by PHP, it is generally a good practice to add $paths = array(); before regardless.

                }
                $paths[] = $app['config']['template_admin_realdir'];

The variable $paths does not seem to be defined for all execution paths leading up to this point.

                $paths[] = __DIR__.'/../../app/Plugin';
                $cacheDir =  __DIR__.'/../../app/cache/twig/admin';
            } else {
                // モバイル端末時、smartphoneディレクトリを探索パスに追加する.
                if ($app['mobile_detect.device_type'] == \Eccube\Entity\Master\DeviceType::DEVICE_TYPE_SP) {
                    if (file_exists(__DIR__.'/../../app/template/smartphone')) {
                        $paths[] = __DIR__.'/../../app/template/smartphone';
                    }
                    $paths[] = __DIR__.'/Resource/template/smartphone';
                }

                if (file_exists($app['config']['template_realdir'])) {
                    $paths[] = $app['config']['template_realdir'];
                }
                $paths[] = $app['config']['template_default_realdir'];
                $paths[] = __DIR__.'/../../app/Plugin';
                $cacheDir =  __DIR__.'/../../app/cache/twig/'.$app['config']['template_code'];
            }
            $app['twig']->setCache($app['debug'] ? null : $cacheDir);
            $app['twig.loader']->addLoader(new \Twig_Loader_Filesystem($paths));

            // 管理画面のIP制限チェック.
            if ($app->isAdminRequest()) {

It seems like you code against a specific sub-type and not the parent class Silex\Application as the method isAdminRequest() does only exist in the following sub-classes of Silex\Application: Eccube\Application, Eccube\InstallApplication. Maybe you want to instanceof check for one of these explicitly?

                // IP制限チェック
                $allowHost = $app['config']['admin_allow_host'];
                if (count($allowHost) > 0) {
                    if (array_search($app['request_stack']->getCurrentRequest()->getClientIp(), $allowHost) === false) {
                        throw new \Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException();
                    }
                }
            }
        }, self::EARLY_EVENT);

        // twigのグローバル変数を定義.
        $this->on(\Symfony\Component\HttpKernel\KernelEvents::CONTROLLER, function (\Symfony\Component\HttpKernel\Event\FilterControllerEvent $event) {
            // 未ログイン時にマイページや管理画面以下にアクセスするとSubRequestで実行されるため,
            // $event->isMasterRequest()ではなく、グローバル変数が初期化済かどうかの判定を行う
            if (isset($this['twig_global_initialized']) && $this['twig_global_initialized'] === true) {
                return;
            }
            // ショップ基本情報
            $this['twig']->addGlobal('BaseInfo', $this[BaseInfo::class]);

            if ($this->isAdminRequest()) {
                // 管理画面
                // 管理画面メニュー
                $menus = array('', '', '');
                $this['twig']->addGlobal('menus', $menus);

                $Member = $this->user();
                if (is_object($Member)) {
                    // ログインしていれば管理者のロールを取得
                    $AuthorityRoles = $this['eccube.repository.authority_role']->findBy(array('Authority' => $Member->getAuthority()));

                    $roles = array();
                    $request = $event->getRequest();
                    foreach ($AuthorityRoles as $AuthorityRole) {
                        // 管理画面でメニュー制御するため相対パス全てをセット
                        $roles[] = $request->getBaseUrl().'/'.$this['config']['admin_route'].$AuthorityRole->getDenyUrl();
                    }

                    $this['twig']->addGlobal('AuthorityRoles', $roles);
                }

Blank line found at end of control structure

            } else {
                // フロント画面
                $request = $event->getRequest();
                $route = $request->attributes->get('_route');

                // ユーザ作成画面
                if ($route === 'user_data') {
                    $params = $request->attributes->get('_route_params');
                    $route = $params['route'];
                    // プレビュー画面
                } elseif ($request->get('preview')) {
                    $route = 'preview';
                }

                try {
                    $device_type_id = $this['mobile_detect.device_type'];

                    // TODO デバッグ用
                    if ($request->query->has('device_type_id')) {
                        $device_type_id = $request->get('device_type_id', \Eccube\Entity\Master\DeviceType::DEVICE_TYPE_PC);
                    }

                    $DeviceType = $this['eccube.repository.master.device_type']
                        ->find($device_type_id);
                    $qb = $this['eccube.repository.page_layout']->createQueryBuilder('p');
                    $PageLayout = $qb->select('p, pll,l, bp, b')
                        ->leftJoin('p.PageLayoutLayouts', 'pll')
                        ->leftJoin('pll.Layout', 'l')
                        ->leftJoin('l.BlockPositions', 'bp')
                        ->leftJoin('bp.Block', 'b')
                        ->where('p.url = :route')
                        ->andWhere('l.DeviceType = :DeviceType')
                        ->orderBy('bp.block_row', 'ASC')
                        ->setParameter('route', $route)
                        ->setParameter('DeviceType', $DeviceType)
                        ->getQuery()
                        ->getSingleResult();
                } catch (\Doctrine\ORM\NoResultException $e) {
                    $PageLayout = $this['eccube.repository.page_layout']->newPageLayout($DeviceType);

The variable $DeviceType does not seem to be defined for all execution paths leading up to this point.

                }

                $this['twig']->addGlobal('PageLayout', $PageLayout);
                $this['twig']->addGlobal('title', $PageLayout->getName());
            }

            $this['twig_global_initialized'] = true;
        });
    }

    public function initMailer()

Missing function doc comment

    {

        // メール送信時の文字エンコード指定(デフォルトはUTF-8)
        if (isset($this['config']['mail']['charset_iso_2022_jp']) && is_bool($this['config']['mail']['charset_iso_2022_jp'])) {
            if ($this['config']['mail']['charset_iso_2022_jp'] === true) {
                \Swift::init(function () {
                    \Swift_DependencyContainer::getInstance()
                        ->register('mime.qpheaderencoder')
                        ->asAliasOf('mime.base64headerencoder');
                    \Swift_Preferences::getInstance()->setCharset('iso-2022-jp');
                });
            }
        }

        $this->register(new \Silex\Provider\SwiftmailerServiceProvider());
        $this['swiftmailer.options'] = $this['config']['mail'];

        if (isset($this['config']['mail']['spool']) && is_bool($this['config']['mail']['spool'])) {
            $this['swiftmailer.use_spool'] = $this['config']['mail']['spool'];
        }
        // デフォルトはsmtpを使用
        $transport = $this['config']['mail']['transport'];
        if ($transport == 'sendmail') {
            $this['swiftmailer.transport'] = \Swift_SendmailTransport::newInstance();
        } elseif ($transport == 'mail') {
            $this['swiftmailer.transport'] = \Swift_MailTransport::newInstance();
        }
    }

    public function initDoctrine()

Missing function doc comment

    {
        $this->register(new EntityEventServiceProvider());
        $this->register(new \Silex\Provider\DoctrineServiceProvider(), array(

Add a comma after each item in a multi-line array

            'dbs.options' => array(

Add a comma after each item in a multi-line array

                'default' => $this['config']['database']
            )
        ));
        $this->register(new \Saxulum\DoctrineOrmManagerRegistry\Provider\DoctrineOrmManagerRegistryProvider());

        $app = $this;
        $this->extend('db.event_manager', function ($evm) use ($app) {
            $initSubscriber = new InitSubscriber($app);
            $evm->addEventSubscriber($initSubscriber);

            return $evm;
        });

        // UTCで保存
        // @see http://doctrine-orm.readthedocs.org/projects/doctrine-orm/en/latest/cookbook/working-with-datetime.html
        UTCDateTimeType::setTimeZone($this['config']['timezone']);
        UTCDateTimeTzType::setTimeZone($this['config']['timezone']);
        Type::overrideType('datetime', UTCDateTimeType::class);
        Type::overrideType('datetimetz', UTCDateTimeTzType::class);

        // プラグインのmetadata定義を合わせて行う.
        $pluginConfigs = PluginConfigManager::getPluginConfigAll($this['debug']);
        $ormMappings = array();
        $ormMappings[] = array(
             'type' => 'annotation',
             'namespace' => 'Eccube\Entity',
             'path' => array(

Add a comma after each item in a multi-line array

                 __DIR__.'/Entity'
             ),
             'use_simple_annotation_reader' => false,
         );

        // TODO namespace は暫定
        $ormMappings[] = array(
            'type' => 'annotation',
            'namespace' => 'Acme\Entity',
            'path' => array(
                __DIR__.'/../../app/Acme/Entity',
            ),
            'use_simple_annotation_reader' => false,
        );

        foreach ($pluginConfigs as $code) {
            $config = $code['config'];
            // Doctrine Extend
            if (isset($config['orm.path']) && is_array($config['orm.path'])) {
                $paths = array();
                foreach ($config['orm.path'] as $path) {
                    $paths[] = $this['config']['plugin_realdir'].'/'.$config['code'].$path;
                }
                $ormMappings[] = array(
                    'type' => 'yml',
                    'namespace' => 'Plugin\\'.$config['code'].'\\Entity',
                    'path' => $paths,
                );
                $ormMappings[] = array(
                    'type' => 'annotation',
                    'namespace' => 'Plugin\\'.$config['code'].'\\Entity',
                    'path' => $paths,
                    'use_simple_annotation_reader' => false,
                );
            }
        }

        $options = array(

Add a comma after each item in a multi-line array

            'mappings' => $ormMappings
        );

        if (!$this['debug']) {
            $cacheDrivers = array();
            if (array_key_exists('doctrine_cache', $this['config'])) {
                $cacheDrivers = $this['config']['doctrine_cache'];
            }

            if (array_key_exists('metadata_cache', $cacheDrivers)) {
                $options['metadata_cache'] = $cacheDrivers['metadata_cache'];
            }
            if (array_key_exists('query_cache', $cacheDrivers)) {
                $options['query_cache'] = $cacheDrivers['query_cache'];
            }
            if (array_key_exists('result_cache', $cacheDrivers)) {
                $options['result_cache'] = $cacheDrivers['result_cache'];
            }
            if (array_key_exists('hydration_cache', $cacheDrivers)) {
                $options['hydration_cache'] = $cacheDrivers['hydration_cache'];
            }
        }

        $this->register(new \Dflydev\Provider\DoctrineOrm\DoctrineOrmServiceProvider(), array(
            'orm.proxies_dir' => __DIR__.'/../../app/cache/doctrine/proxies',
            'orm.em.options' => $options,
            'orm.custom.functions.string' => array(
                'NORMALIZE' => 'Eccube\Doctrine\ORM\Query\Normalize',
            ),
            'orm.custom.functions.numeric' => array(
                'EXTRACT' => 'Eccube\Doctrine\ORM\Query\Extract',
            ),
        ));

        $this->extend(
            'orm.em.config',
            function (\Doctrine\ORM\Configuration $config, \Silex\Application $app) {

                /** @var $chain \Doctrine\Common\Persistence\Mapping\Driver\MappingDriverChain */
                $chain = $config->getMetadataDriverImpl();
                $drivers = $chain->getDrivers();
                foreach ($drivers as $namespace => $oldDriver) {
                    if ('Eccube\Entity' === $namespace) {
                        $newDriver = new AnnotationDriver(
                            $app['annotations'],
                            $oldDriver->getPaths());
                        $newDriver->setFileExtension($oldDriver->getFileExtension());
                        $newDriver->addExcludePaths($oldDriver->getExcludePaths());
                        $newDriver->setTraitProxiesDirectory(
                            realpath(__DIR__.'/../../app/proxy/entity'));
                        $chain->addDriver($newDriver, $namespace);
                    }
                }

                return $config;
            }
        );

        $this->extend('orm.em', function (\Doctrine\ORM\EntityManager $em, \Silex\Application $app) {
            // save
            $saveEventSubscriber = new \Eccube\Doctrine\EventSubscriber\SaveEventSubscriber($app);

$app of type object<Silex\Application> is not a sub-type of object<Eccube\Application>. It seems like you assume a child class of the class Silex\Application to be always present.

            $em->getEventManager()->addEventSubscriber($saveEventSubscriber);

            // load
            $loadEventSubscriber = new \Eccube\Doctrine\EventSubscriber\LoadEventSubscriber($app);

$app of type object<Silex\Application> is not a sub-type of object<Eccube\Application>. It seems like you assume a child class of the class Silex\Application to be always present.

            $em->getEventManager()->addEventSubscriber($loadEventSubscriber);

            // clear cache
            $clearCacheEventSubscriber = new \Eccube\Doctrine\EventSubscriber\ClearCacheEventSubscriber($app);

$app of type object<Silex\Application> is not a sub-type of object<Eccube\Application>. It seems like you assume a child class of the class Silex\Application to be always present.

            $em->getEventManager()->addEventSubscriber($clearCacheEventSubscriber);

            // filters
            $config = $em->getConfiguration();
            $config->addFilter("nostock_hidden", '\Eccube\Doctrine\Filter\NoStockHiddenFilter');
            $config->addFilter("incomplete_order_status_hidden", '\Eccube\Doctrine\Filter\OrderStatusFilter');

            return $em;
        });

        if (!$this['debug']) {
            // second level cacheの設定.
            $this->extend(
                'orm.em.config',
                function (\Doctrine\ORM\Configuration $config, \Silex\Application $app) {

The parameter $app is not used and could be removed.

                    $config->setSecondLevelCacheEnabled();
                    $cacheConfig = $config->getSecondLevelCacheConfiguration();
                    $regionConfig = $cacheConfig->getRegionsConfiguration();
                    // TODO キャッシュ先は設定で切り替えられるように
                    $cache = $this['orm.cache.factory'](
                        'filesystem',
                        [

Add a comma after each item in a multi-line array

                            'path' => __DIR__.'/../../app/cache/doctrine/second'
                        ]
                    );
                    $factory = new \Doctrine\ORM\Cache\DefaultCacheFactory($regionConfig, $cache);
                    $cacheConfig->setCacheFactory($factory);

                    return $config;
                }
            );
        }
    }

    public function initSecurity()

Missing function doc comment

    {
        $this->register(new \Silex\Provider\SecurityServiceProvider());
        $this->register(new \Silex\Provider\CsrfServiceProvider());
        $this->register(new \Silex\Provider\RememberMeServiceProvider());

        $this['security.firewalls'] = array(
            'admin' => array(
                'pattern' => "^/{$this['config']['admin_route']}/",
                'form' => array(
                    'login_path' => "/{$this['config']['admin_route']}/login",
                    'check_path' => "/{$this['config']['admin_route']}/login_check",
                    'username_parameter' => 'login_id',
                    'password_parameter' => 'password',
                    'with_csrf' => true,
                    'use_forward' => true,
                ),
                'logout' => array(
                    'logout_path' => "/{$this['config']['admin_route']}/logout",
                    'target_url' => "/{$this['config']['admin_route']}/",
                ),
                'users' => $this['orm.em']->getRepository('Eccube\Entity\Member'),
                'anonymous' => true,
            ),
            'customer' => array(
                'pattern' => '^/',
                'form' => array(
                    'login_path' => '/mypage/login',
                    'check_path' => '/login_check',
                    'username_parameter' => 'login_email',
                    'password_parameter' => 'login_pass',
                    'with_csrf' => true,
                    'use_forward' => true,
                ),
                'logout' => array(
                    'logout_path' => '/logout',
                    'target_url' => '/',
                ),
                'remember_me' => array(
                    'key' => sha1($this['config']['auth_magic']),
                    'name' => $this['config']['cookie_name'].'_rememberme',
                    // lifetimeはデフォルトの1年間にする
                    // 'lifetime' => $this['config']['cookie_lifetime'],
                    'path' => $this['config']['root_urlpath'] ?: '/',
                    'secure' => $this['config']['force_ssl'],
                    'httponly' => true,
                    'always_remember_me' => false,
                    'remember_me_parameter' => 'login_memory',
                ),
                'users' => $this['orm.em']->getRepository('Eccube\Entity\Customer'),
                'anonymous' => true,
            ),
        );

        $channel = null;
        // 強制SSL
        if ($this['config']['force_ssl'] == \Eccube\Common\Constant::ENABLED) {
            $channel = "https";
        }

        $this['security.access_rules'] = array(
            array("^/{$this['config']['admin_route']}/login", 'IS_AUTHENTICATED_ANONYMOUSLY', $channel),
            array("^/{$this['config']['admin_route']}/", 'ROLE_ADMIN', $channel),
            array('^/mypage/login', 'IS_AUTHENTICATED_ANONYMOUSLY', $channel),
            array('^/mypage/withdraw_complete', 'IS_AUTHENTICATED_ANONYMOUSLY', $channel),
            array('^/mypage/change', 'IS_AUTHENTICATED_FULLY', $channel),
            array('^/mypage', 'ROLE_USER', $channel),
        );

        $this['eccube.password_encoder'] = function ($app) {
            return new \Eccube\Security\Core\Encoder\PasswordEncoder($app['config']);
        };
        $this['security.encoder_factory'] = function ($app) {
            return new \Symfony\Component\Security\Core\Encoder\EncoderFactory(array(
                'Eccube\Entity\Customer' => $app['eccube.password_encoder'],
                'Eccube\Entity\Member' => $app['eccube.password_encoder'],
            ));
        };
        $this['eccube.event_listner.security'] = function ($app) {
            return new \Eccube\EventListener\SecurityEventListener($app['orm.em']);
        };

        // Voterの設定
        $this['authority_voter'] = function ($app) {
            return new \Eccube\Security\Voter\AuthorityVoter($app);
        };

        $this->extend('security.voters', function ($voters, \Silex\Application $app) {
            $voters[] = $app['authority_voter'];

            return $voters;
        });

        $this['security.access_manager'] = function ($app) {
            return new \Symfony\Component\Security\Core\Authorization\AccessDecisionManager($app['security.voters'], 'unanimous');
        };

        $this->on(\Symfony\Component\Security\Http\SecurityEvents::INTERACTIVE_LOGIN, array($this['eccube.event_listner.security'], 'onInteractiveLogin'));
    }

    /**
     * ロードバランサー、プロキシサーバの設定を行う
     */
    public function initProxy()
    {
        $config = $this['config'];
        if (isset($config['trusted_proxies_connection_only']) && !empty($config['trusted_proxies_connection_only'])) {
            $this->on(KernelEvents::REQUEST, function (GetResponseEvent $event) use ($config) {
                // サブリクエストのREMOTE_ADDRも動的に設定を行う必要があるため、KernelEvents::REQUESTを使用する
                Request::setTrustedProxies(array_merge(array($event->getRequest()->server->get('REMOTE_ADDR')), $config['trusted_proxies']));
            }, self::EARLY_EVENT);
        } elseif (isset($config['trusted_proxies']) && !empty($config['trusted_proxies'])) {
            Request::setTrustedProxies($config['trusted_proxies']);
        }
    }

    public function initializePlugin()

Missing function doc comment

    {
        if ($this->initializedPlugin) {
            return;
        }
        $this->register(new ServiceProvider\EccubePluginServiceProvider());

        // TODO Acme\ServiceProvider の初期化はここで OK?
        if (array_key_exists('service',$this['config'])) {

Add a single space after each comma delimiter

            foreach ($this['config']['service'] as $service) {
                $this->register(new $service);

Use parentheses when instantiating classes

            }
        }
        $this->initializedPlugin = true;
    }

    /**
     * PHPUnit を実行中かどうかを設定する.
     *
     * @param boolean $testMode PHPUnit を実行中の場合 true
     */
    public function setTestMode($testMode)
    {
        $this->testMode = $testMode;
    }

    /**
     * PHPUnit を実行中かどうか.
     *
     * @return boolean PHPUnit を実行中の場合 true
     */
    public function isTestMode()
    {
        return $this->testMode;
    }

    /**
     *
     * データベースの接続を確認
     * 成功 : trueを返却
     * 失敗 : \Doctrine\DBAL\DBALExceptionエラーが発生( 接続に失敗した場合 )、エラー画面を表示しdie()
     * 備考 : app['debug']がtrueの際は処理を行わない
     *
     * @return boolean true
     *
     */
    protected function checkDatabaseConnection()
    {
        if ($this['debug']) {
            return;
        }
        try {
            $this['db']->connect();
        } catch (\Doctrine\DBAL\DBALException $e) {
            $this['monolog']->error($e->getMessage());
            $this['twig.path'] = array(__DIR__.'/Resource/template/exception');
            $html = $this['twig']->render('error.twig', array(
                'error_title' => 'データーベース接続エラー',
                'error_message' => 'データーベースを確認してください',
            ));
            $response = new Response();
            $response->setContent($html);
            $response->setStatusCode('500');
            $response->headers->set('Content-Type', 'text/html');
            $response->send();
            die();

The method checkDatabaseConnection() contains an exit expression.

        }

        return true;
    }

    /**
     * Config ファイルをパースし、連想配列を返します.
     *
     * $config_name.yml ファイルをパースし、連想配列を返します.
     * $config_name.php が存在する場合は、 PHP ファイルに記述された連想配列を使用します。
     *
     * @param string $config_name Config 名称

Expected 2 spaces after parameter type; 1 found

     * @param array $configAll Config の連想配列

Expected 3 spaces after parameter type; 1 found

Expected 3 spaces after parameter name; 1 found

     * @param boolean $wrap_key Config の連想配列に config_name のキーを生成する場合 true, デフォルト false

Expected 4 spaces after parameter name; 1 found

     * @param string $ymlPath config yaml を格納したディレクトリ

Expected 2 spaces after parameter type; 1 found

Expected 5 spaces after parameter name; 1 found

     * @param string $distPath config yaml dist を格納したディレクトリ

Expected 2 spaces after parameter type; 1 found

Expected 4 spaces after parameter name; 1 found

     * @return Application
     */
    public function parseConfig($config_name, array &$configAll, $wrap_key = false, $ymlPath = null, $distPath = null)

Declare public methods first, then protected ones and finally private ones

    {
        $ymlPath = $ymlPath ? $ymlPath : __DIR__.'/../../app/config/eccube';
        $distPath = $distPath ? $distPath : __DIR__.'/../../src/Eccube/Resource/config';

        $config = [];
        $config_php = $ymlPath.'/'.$config_name.'.php';
        if (file_exists($config_php)) {
            $config = require $config_php;
        }

        // `%ROOT_DIR%`を絶対パスに変換
        $rootDir = realpath(__DIR__.'/../../');
        array_walk($config, function(&$value) use ($rootDir) {

Expected 1 space after FUNCTION keyword; 0 found

            $value = str_replace('%ROOT_DIR%', $rootDir, $value);
        });

        $config_php_dist = $distPath.'/'.$config_name.'.php';
        $config_dist = require $config_php_dist;

        if ($wrap_key) {
            $configAll = array_replace_recursive($configAll, array($config_name => $config_dist), array($config_name => $config));
        } else {
            $configAll = array_replace_recursive($configAll, $config_dist, $config);
        }

        return $this;
    }

    /**
     * セッションが開始されているかどうか.
     *
     * @return boolean セッションが開始済みの場合 true
     * @link http://php.net/manual/ja/function.session-status.php#113468
     */
    protected function isSessionStarted()
    {
        if (php_sapi_name() !== 'cli') {
            if (version_compare(phpversion(), '5.4.0', '>=')) {
                return session_status() === PHP_SESSION_ACTIVE ? true : false;
            } else {
                return session_id() === '' ? false : true;
            }
        }

        return false;
    }

    /**
     * Http Cache対応
     */
    protected function initCacheRequest()
    {
        // httpキャッシュが無効の場合はイベント設定を行わない.
        if (!$this['config']['http_cache']['enabled']) {
            return;
        }

        $app = $this;

        // Response Event(http cache対応、event実行は一番遅く設定)
        $this->on(\Symfony\Component\HttpKernel\KernelEvents::RESPONSE, function (\Symfony\Component\HttpKernel\Event\FilterResponseEvent $event) use ($app) {

            if (!$event->isMasterRequest()) {
                return;
            }

            $request = $event->getRequest();
            $response = $event->getResponse();

            $route = $request->attributes->get('_route');

            $etag = md5($response->getContent());

            if (strpos($route, 'admin') === 0) {
                // 管理画面

                // 管理画面ではコンテンツの中身が変更された時点でキャッシュを更新し、キャッシュの適用範囲はprivateに設定
                $response->setCache(array(
                    'etag' => $etag,
                    'private' => true,
                ));

                if ($response->isNotModified($request)) {
                    return $response;
                }

Blank line found at end of control structure

            } else {
                // フロント画面
                $cacheRoute = $app['config']['http_cache']['route'];

                if (in_array($route, $cacheRoute) === true) {
                    // キャッシュ対象となる画面lが含まれていた場合、キャッシュ化
                    // max-ageを設定しているためExpiresは不要
                    // Last-Modifiedだと比較する項目がないためETagで対応
                    // max-ageを設定していた場合、contentの中身が変更されても変更されない

                    $age = $app['config']['http_cache']['age'];

                    $response->setCache(array(
                        'etag' => $etag,
                        'max_age' => $age,
                        's_maxage' => $age,
                        'public' => true,
                    ));

                    if ($response->isNotModified($request)) {
                        return $response;
                    }
                }
            }

        }, -1024);
    }
}