Eccube\Controller\Admin\Product\ClassNameController

Complexity

Total Complexity

10

Size/Duplication

Total Lines	139
Duplicated Lines	45.32 %

Coupling/Cohesion

Components	1
Dependencies	12

Test Coverage

Coverage

92.59%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
B	index()	23	57	5
B	delete()	25	25	2
A	moveSortNo()	15	15	3

<?php
/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 */


namespace Eccube\Controller\Admin\Product;

use Doctrine\ORM\EntityManager;
use Eccube\Annotation\Inject;
use Eccube\Application;
use Eccube\Controller\AbstractController;
use Eccube\Entity\ClassName;
use Eccube\Event\EccubeEvents;
use Eccube\Event\EventArgs;
use Eccube\Form\Type\Admin\ClassNameType;
use Eccube\Repository\ClassNameRepository;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Symfony\Component\EventDispatcher\EventDispatcher;
use Symfony\Component\Form\FormFactory;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

/**
 * @Route(service=ClassNameController::class)
 */
class ClassNameController extends AbstractController
{
    /**
     * @Inject("orm.em")
     * @var EntityManager
     */
    protected $entityManager;

    /**
     * @Inject("eccube.event.dispatcher")
     * @var EventDispatcher
     */
    protected $eventDispatcher;

    /**
     * @Inject("form.factory")
     * @var FormFactory
     */
    protected $formFactory;

    /**
     * @Inject(ClassNameRepository::class)
     * @var ClassNameRepository
     */
    protected $classNameRepository;

    /**

Doc comment for parameter "$app" missing

Doc comment for parameter "$request" missing

Doc comment for parameter "$id" missing

     * @Route("/{_admin}/product/class_name", name="admin_product_class_name")
     * @Route("/{_admin}/product/class_name/{id}/edit", requirements={"id" = "\d+"}, name="admin_product_class_name_edit")
     * @Template("Product/class_name.twig")
     */

Missing @return tag in function comment

    public function index(Application $app, Request $request, $id = null)
    {
        if ($id) {
            $TargetClassName = $this->classNameRepository->find($id);
            if (!$TargetClassName) {
                throw new NotFoundHttpException('商品規格が存在しません');
            }
        } else {
            $TargetClassName = new \Eccube\Entity\ClassName();
        }

        $builder = $this->formFactory
            ->createBuilder(ClassNameType::class, $TargetClassName);

        $event = new EventArgs(
            array(
                'builder' => $builder,
                'TargetClassName' => $TargetClassName,
            ),
            $request
        );
        $this->eventDispatcher->dispatch(EccubeEvents::ADMIN_PRODUCT_CLASS_NAME_INDEX_INITIALIZE, $event);

        $form = $builder->getForm();

        if ($request->getMethod() === 'POST') {
            $form->handleRequest($request);
            if ($form->isValid()) {
                log_info('商品規格登録開始', array($id));

                $this->classNameRepository->save($TargetClassName);

                log_info('商品規格登録完了', array($id));

                $event = new EventArgs(
                    array(
                        'form' => $form,
                        'TargetClassName' => $TargetClassName,
                    ),
                    $request
                );
                $this->eventDispatcher->dispatch(EccubeEvents::ADMIN_PRODUCT_CLASS_NAME_INDEX_COMPLETE, $event);

                $app->addSuccess('admin.class_name.save.complete', 'admin');

                return $app->redirect($app->url('admin_product_class_name'));
            }
        }

        $ClassNames = $this->classNameRepository->getList();

        return [
            'form' => $form->createView(),
            'ClassNames' => $ClassNames,
            'TargetClassName' => $TargetClassName,
        ];
    }

    /**

Doc comment for parameter "$app" missing

Doc comment for parameter "$request" missing

Doc comment for parameter "$ClassName" missing

     * @Method("DELETE")
     * @Route("/{_admin}/product/class_name/{id}/delete", requirements={"id" = "\d+"}, name="admin_product_class_name_delete")
     */

Missing @return tag in function comment

    public function delete(Application $app, Request $request, ClassName $ClassName)

This method seems to be duplicated in your project.

    {
        $this->isTokenValid($app);

        log_info('商品規格削除開始', array($ClassName->getId()));

        try {
            $this->classNameRepository->delete($ClassName);

            $event = new EventArgs(['ClassName' => $ClassName,], $request);

Add a single space after each comma delimiter

            $this->eventDispatcher->dispatch(EccubeEvents::ADMIN_PRODUCT_CLASS_NAME_DELETE_COMPLETE, $event);

            $app->addSuccess('admin.class_name.delete.complete', 'admin');

            log_info('商品規格削除完了', array($ClassName->getId()));

Blank line found at end of control structure

        } catch (\Exception $e) {
            $message = $app->trans('admin.delete.failed.foreign_key', ['%name%' => '商品規格']);
            $app->addError($message, 'admin');

            log_error('商品企画削除エラー', [$ClassName->getId(), $e]);
        }

        return $app->redirect($app->url('admin_product_class_name'));
    }

    /**

Doc comment for parameter "$app" missing

Doc comment for parameter "$request" missing

     * @Method("POST")
     * @Route("/{_admin}/product/class_name/sort_no/move", name="admin_product_class_name_sort_no_move")
     */

Missing @return tag in function comment

    public function moveSortNo(Application $app, Request $request)

The parameter $app is not used and could be removed.

This method seems to be duplicated in your project.

    {
        if ($request->isXmlHttpRequest()) {
            $sortNos = $request->request->all();
            foreach ($sortNos as $classNameId => $sortNo) {
                $ClassName = $this->classNameRepository
                    ->find($classNameId);
                $ClassName->setSortNo($sortNo);
                $this->entityManager->persist($ClassName);

It seems like $ClassName defined by $this->classNameRepository->find($classNameId) on line 175 can also be of type null; however, Doctrine\ORM\EntityManager::persist() does only seem to accept object, maybe add an additional type check?

            }
            $this->entityManager->flush();
        }

        return true;
    }
}