Completed
Pull Request — experimental/3.1 (#2566)
by chihiro
155:15 queued 121:52
created
src/Eccube/Form/Type/Install/Step4Type.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
                 'label' => 'パスワード',
107 107
                 'required' => false,
108 108
             ))
109
-            ->addEventListener(FormEvents::POST_SUBMIT, function ($event) {
109
+            ->addEventListener(FormEvents::POST_SUBMIT, function($event) {
110 110
                 $form = $event->getForm();
111 111
                 $data = $form->getData();
112 112
                 try {
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
                     $conn = \Doctrine\DBAL\DriverManager::getConnection($connectionParams, $config);
132 132
                     $conn->connect();
133 133
                 } catch (\Exception $e) {
134
-                    $form['database']->addError(new FormError('データベースに接続できませんでした。' . $e->getMessage()));
134
+                    $form['database']->addError(new FormError('データベースに接続できませんでした。'.$e->getMessage()));
135 135
                 }
136 136
             });
137 137
     }
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
     public function validate($data, ExecutionContext $context, $param = null)
148 148
     {
149 149
         $parameters = $this->requestStack->getCurrentRequest()->get('install_step4');
150
-        if ($parameters['database'] != 'pdo_sqlite'){
150
+        if ($parameters['database'] != 'pdo_sqlite') {
151 151
             $context->getValidator()->validate($data, array(
152 152
                 new Assert\NotBlank()
153 153
             ));
Please login to merge, or discard this patch.
src/Eccube/Form/Type/Install/Step1Type.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 
27 27
 use Eccube\Annotation\FormType;
28 28
 use \Symfony\Component\Form\AbstractType;
29
-use \Symfony\Component\Form\Extension\Core\Type\CheckboxType;;
29
+use \Symfony\Component\Form\Extension\Core\Type\CheckboxType; ;
30 30
 use \Symfony\Component\Form\FormBuilderInterface;
31 31
 
32 32
 /**
Please login to merge, or discard this patch.
src/Eccube/Service/ShoppingService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1117,7 +1117,7 @@
 block discarded – undo
1117 1117
 
1118 1118
         // 配送日数が設定されている
1119 1119
         if ($deliveryDateFlag) {
1120
-            $period = new \DatePeriod (
1120
+            $period = new \DatePeriod(
1121 1121
                 new \DateTime($minDate.' day'),
1122 1122
                 new \DateInterval('P1D'),
1123 1123
                 new \DateTime($minDate + $this->appConfig['deliv_date_end_max'].' day')
Please login to merge, or discard this patch.
src/Eccube/Repository/BlockRepository.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -197,7 +197,7 @@
 block discarded – undo
197 197
             $this->appConfig['block_default_realdir'],
198 198
         );
199 199
         foreach ($readPaths as $readPath) {
200
-            $filePath = $readPath . '/' . $fileName . '.twig';
200
+            $filePath = $readPath.'/'.$fileName.'.twig';
201 201
             $fs = new Filesystem();
202 202
             if ($fs->exists($filePath)) {
203 203
                 return array(
Please login to merge, or discard this patch.
src/Eccube/ServiceProvider/CompatServiceProvider.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -20,34 +20,34 @@
 block discarded – undo
20 20
 
21 21
     public function register(Container $app)
22 22
     {
23
-        $app['eccube.service.cart'] = function () use ($app) {
23
+        $app['eccube.service.cart'] = function() use ($app) {
24 24
             return $app[CartService::class];
25 25
         };
26
-        $app['eccube.service.order'] = function () use ($app) {
26
+        $app['eccube.service.order'] = function() use ($app) {
27 27
             return $app[OrderService::class];
28 28
         };
29
-        $app['eccube.service.tax_rule'] = function () use ($app) {
29
+        $app['eccube.service.tax_rule'] = function() use ($app) {
30 30
             return $app[TaxRuleService::class];
31 31
         };
32
-        $app['eccube.service.plugin'] = function () use ($app) {
32
+        $app['eccube.service.plugin'] = function() use ($app) {
33 33
             return $app[PluginService::class];
34 34
         };
35
-        $app['eccube.service.mail'] = function () use ($app) {
35
+        $app['eccube.service.mail'] = function() use ($app) {
36 36
             return $app[MailService::class];
37 37
         };
38
-        $app['eccube.helper.order'] = function ($app) {
38
+        $app['eccube.helper.order'] = function($app) {
39 39
             return $app[OrderHelper::class];
40 40
         };
41
-        $app['eccube.service.csv.export'] = function () use ($app) {
41
+        $app['eccube.service.csv.export'] = function() use ($app) {
42 42
             return $app[CsvExportService::class];
43 43
         };
44
-        $app['eccube.service.shopping'] = function () use ($app) {
44
+        $app['eccube.service.shopping'] = function() use ($app) {
45 45
             return $app[ShoppingService::class];
46 46
         };
47
-        $app['eccube.service.payment'] = function () use ($app) {
47
+        $app['eccube.service.payment'] = function() use ($app) {
48 48
             return $app[PaymentService::class];
49 49
         };
50
-        $app['eccube.service.system'] = function () use ($app) {
50
+        $app['eccube.service.system'] = function() use ($app) {
51 51
             return $app[SystemService::class];
52 52
         };
53 53
 
Please login to merge, or discard this patch.
src/Eccube/ServiceProvider/TwigLintServiceProvider.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@
 block discarded – undo
23 23
             );
24 24
         }
25 25
 
26
-        $app[TwigLintValidator::class] = function (Container $app) {
26
+        $app[TwigLintValidator::class] = function(Container $app) {
27 27
             return new TwigLintValidator($app['twig']);
28 28
         };
29 29
 
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Product/ProductController.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -320,7 +320,7 @@  discard block
 block discarded – undo
320 320
                     }
321 321
 
322 322
                     $extension = $image->getClientOriginalExtension();
323
-                    $filename = date('mdHis') . uniqid('_') . '.' . $extension;
323
+                    $filename = date('mdHis').uniqid('_').'.'.$extension;
324 324
                     $image->move($this->appConfig['image_temp_realdir'], $filename);
325 325
                     $files[] = $filename;
326 326
                 }
@@ -399,7 +399,7 @@  discard block
 block discarded – undo
399 399
         $form = $builder->getForm();
400 400
 
401 401
         if (!$has_class) {
402
-            $ProductClass->setStockUnlimited((boolean)$ProductClass->getStockUnlimited());
402
+            $ProductClass->setStockUnlimited((boolean) $ProductClass->getStockUnlimited());
403 403
             $form['class']->setData($ProductClass);
404 404
         }
405 405
 
@@ -481,8 +481,8 @@  discard block
 block discarded – undo
481 481
                 $Categories = $form->get('Category')->getData();
482 482
                 $categoriesIdList = array();
483 483
                 foreach ($Categories as $Category) {
484
-                    foreach($Category->getPath() as $ParentCategory){
485
-                        if (!isset($categoriesIdList[$ParentCategory->getId()])){
484
+                    foreach ($Category->getPath() as $ParentCategory) {
485
+                        if (!isset($categoriesIdList[$ParentCategory->getId()])) {
486 486
                             $ProductCategory = $this->createProductCategory($Product, $ParentCategory, $count);
487 487
                             $this->entityManager->persist($ProductCategory);
488 488
                             $count++;
@@ -491,7 +491,7 @@  discard block
 block discarded – undo
491 491
                             $categoriesIdList[$ParentCategory->getId()] = true;
492 492
                         }
493 493
                     }
494
-                    if (!isset($categoriesIdList[$Category->getId()])){
494
+                    if (!isset($categoriesIdList[$Category->getId()])) {
495 495
                         $ProductCategory = $this->createProductCategory($Product, $Category, $count);
496 496
                         $this->entityManager->persist($ProductCategory);
497 497
                         $count++;
@@ -513,7 +513,7 @@  discard block
 block discarded – undo
513 513
                     $this->entityManager->persist($ProductImage);
514 514
 
515 515
                     // 移動
516
-                    $file = new File($this->appConfig['image_temp_realdir'] . '/' . $add_image);
516
+                    $file = new File($this->appConfig['image_temp_realdir'].'/'.$add_image);
517 517
                     $file->move($this->appConfig['image_save_realdir']);
518 518
                 }
519 519
 
@@ -533,7 +533,7 @@  discard block
 block discarded – undo
533 533
 
534 534
                     // 削除
535 535
                     $fs = new Filesystem();
536
-                    $fs->remove($this->appConfig['image_save_realdir'] . '/' . $delete_image);
536
+                    $fs->remove($this->appConfig['image_save_realdir'].'/'.$delete_image);
537 537
                 }
538 538
                 $this->entityManager->persist($Product);
539 539
                 $this->entityManager->flush();
@@ -668,7 +668,7 @@  discard block
 block discarded – undo
668 668
                     foreach ($deleteImages as $deleteImage) {
669 669
                         try {
670 670
                             $fs = new Filesystem();
671
-                            $fs->remove($this->appConfig['image_save_realdir'] . '/' . $deleteImage);
671
+                            $fs->remove($this->appConfig['image_save_realdir'].'/'.$deleteImage);
672 672
                         } catch (\Exception $e) {
673 673
                             // エラーが発生しても無視する
674 674
                         }
@@ -742,10 +742,10 @@  discard block
 block discarded – undo
742 742
 
743 743
                     // 画像ファイルを新規作成
744 744
                     $extension = pathinfo($Image->getFileName(), PATHINFO_EXTENSION);
745
-                    $filename = date('mdHis') . uniqid('_') . '.' . $extension;
745
+                    $filename = date('mdHis').uniqid('_').'.'.$extension;
746 746
                     try {
747 747
                         $fs = new Filesystem();
748
-                        $fs->copy($this->appConfig['image_save_realdir'] . '/' . $Image->getFileName(), $this->appConfig['image_save_realdir'] . '/' . $filename);
748
+                        $fs->copy($this->appConfig['image_save_realdir'].'/'.$Image->getFileName(), $this->appConfig['image_save_realdir'].'/'.$filename);
749 749
                     } catch (\Exception $e) {
750 750
                         // エラーが発生しても無視する
751 751
                     }
@@ -825,7 +825,7 @@  discard block
 block discarded – undo
825 825
         $em->getConfiguration()->setSQLLogger(null);
826 826
 
827 827
         $response = new StreamedResponse();
828
-        $response->setCallback(function () use ($app, $request) {
828
+        $response->setCallback(function() use ($app, $request) {
829 829
 
830 830
             // CSV種別を元に初期化.
831 831
             $this->csvExportService->initCsvType(CsvType::CSV_TYPE_PRODUCT);
@@ -865,7 +865,7 @@  discard block
 block discarded – undo
865 865
             // データ行の出力.
866 866
             $this->csvExportService->setExportQueryBuilder($qb);
867 867
 
868
-            $this->csvExportService->exportData(function ($entity, CsvExportService $csvService) use ($app, $request) {
868
+            $this->csvExportService->exportData(function($entity, CsvExportService $csvService) use ($app, $request) {
869 869
                 $Csvs = $csvService->getCsvs();
870 870
 
871 871
                 /** @var $Product \Eccube\Entity\Product */
@@ -908,9 +908,9 @@  discard block
 block discarded – undo
908 908
         });
909 909
 
910 910
         $now = new \DateTime();
911
-        $filename = 'product_' . $now->format('YmdHis') . '.csv';
911
+        $filename = 'product_'.$now->format('YmdHis').'.csv';
912 912
         $response->headers->set('Content-Type', 'application/octet-stream');
913
-        $response->headers->set('Content-Disposition', 'attachment; filename=' . $filename);
913
+        $response->headers->set('Content-Disposition', 'attachment; filename='.$filename);
914 914
         $response->send();
915 915
 
916 916
         log_info('商品CSV出力ファイル名', array($filename));
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Order/OrderController.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -303,7 +303,7 @@  discard block
 block discarded – undo
303 303
         log_info('受注削除開始', array($Order->getId()));
304 304
 
305 305
         // 出荷に紐付いている明細がある場合は削除できない.
306
-        $hasShipping = $Order->getItems()->exists(function ($k, $v) {
306
+        $hasShipping = $Order->getItems()->exists(function($k, $v) {
307 307
             return false === is_null($v->getShipping());
308 308
         });
309 309
         if ($hasShipping) {
@@ -361,7 +361,7 @@  discard block
 block discarded – undo
361 361
         $em->getConfiguration()->setSQLLogger(null);
362 362
 
363 363
         $response = new StreamedResponse();
364
-        $response->setCallback(function () use ($app, $request) {
364
+        $response->setCallback(function() use ($app, $request) {
365 365
 
366 366
             // CSV種別を元に初期化.
367 367
             $this->csvExportService->initCsvType(CsvType::CSV_TYPE_ORDER);
@@ -375,7 +375,7 @@  discard block
 block discarded – undo
375 375
 
376 376
             // データ行の出力.
377 377
             $this->csvExportService->setExportQueryBuilder($qb);
378
-            $this->csvExportService->exportData(function ($entity, $csvService) use ($app, $request) {
378
+            $this->csvExportService->exportData(function($entity, $csvService) use ($app, $request) {
379 379
 
380 380
                 $Csvs = $csvService->getCsvs();
381 381
 
@@ -416,9 +416,9 @@  discard block
 block discarded – undo
416 416
         });
417 417
 
418 418
         $now = new \DateTime();
419
-        $filename = 'order_' . $now->format('YmdHis') . '.csv';
419
+        $filename = 'order_'.$now->format('YmdHis').'.csv';
420 420
         $response->headers->set('Content-Type', 'application/octet-stream');
421
-        $response->headers->set('Content-Disposition', 'attachment; filename=' . $filename);
421
+        $response->headers->set('Content-Disposition', 'attachment; filename='.$filename);
422 422
         $response->send();
423 423
 
424 424
         log_info('受注CSV出力ファイル名', array($filename));
@@ -445,7 +445,7 @@  discard block
 block discarded – undo
445 445
         $em->getConfiguration()->setSQLLogger(null);
446 446
 
447 447
         $response = new StreamedResponse();
448
-        $response->setCallback(function () use ($app, $request) {
448
+        $response->setCallback(function() use ($app, $request) {
449 449
 
450 450
             // CSV種別を元に初期化.
451 451
             $this->csvExportService->initCsvType(CsvType::CSV_TYPE_SHIPPING);
@@ -459,7 +459,7 @@  discard block
 block discarded – undo
459 459
 
460 460
             // データ行の出力.
461 461
             $this->csvExportService->setExportQueryBuilder($qb);
462
-            $this->csvExportService->exportData(function ($entity, $csvService) use ($app, $request) {
462
+            $this->csvExportService->exportData(function($entity, $csvService) use ($app, $request) {
463 463
 
464 464
                 $Csvs = $csvService->getCsvs();
465 465
 
@@ -509,9 +509,9 @@  discard block
 block discarded – undo
509 509
         });
510 510
 
511 511
         $now = new \DateTime();
512
-        $filename = 'shipping_' . $now->format('YmdHis') . '.csv';
512
+        $filename = 'shipping_'.$now->format('YmdHis').'.csv';
513 513
         $response->headers->set('Content-Type', 'application/octet-stream');
514
-        $response->headers->set('Content-Disposition', 'attachment; filename=' . $filename);
514
+        $response->headers->set('Content-Disposition', 'attachment; filename='.$filename);
515 515
         $response->send();
516 516
 
517 517
         log_info('配送CSV出力ファイル名', array($filename));
Please login to merge, or discard this patch.
src/Eccube/Repository/PluginEventHandlerRepository.php 1 patch
Spacing   +31 added lines, -31 removed lines patch added patch discarded remove patch
@@ -42,8 +42,8 @@  discard block
 block discarded – undo
42 42
     {
43 43
         $qb = $this->createQueryBuilder('e')
44 44
             ->innerJoin('e.Plugin', 'p')
45
-            ->Orderby('e.event','ASC') 
46
-            ->addOrderby('e.priority','DESC');
45
+            ->Orderby('e.event', 'ASC') 
46
+            ->addOrderby('e.priority', 'DESC');
47 47
             ;
48 48
 
49 49
         return $qb->getQuery()->getResult();
@@ -52,65 +52,65 @@  discard block
 block discarded – undo
52 52
     public function getPriorityRange($type)
53 53
     {
54 54
 
55
-        if(PluginEventHandler::EVENT_HANDLER_TYPE_FIRST==$type){
56
-            $range_start=PluginEventHandler::EVENT_PRIORITY_FIRST_START;
57
-            $range_end=PluginEventHandler::EVENT_PRIORITY_FIRST_END;
58
-        }elseif(PluginEventHandler::EVENT_HANDLER_TYPE_LAST==$type){
59
-            $range_start=PluginEventHandler::EVENT_PRIORITY_LAST_START;
60
-            $range_end=PluginEventHandler::EVENT_PRIORITY_LAST_END;
61
-        }else{
62
-            $range_start=PluginEventHandler::EVENT_PRIORITY_NORMAL_START;
63
-            $range_end=PluginEventHandler::EVENT_PRIORITY_NORMAL_END;
55
+        if (PluginEventHandler::EVENT_HANDLER_TYPE_FIRST == $type) {
56
+            $range_start = PluginEventHandler::EVENT_PRIORITY_FIRST_START;
57
+            $range_end = PluginEventHandler::EVENT_PRIORITY_FIRST_END;
58
+        }elseif (PluginEventHandler::EVENT_HANDLER_TYPE_LAST == $type) {
59
+            $range_start = PluginEventHandler::EVENT_PRIORITY_LAST_START;
60
+            $range_end = PluginEventHandler::EVENT_PRIORITY_LAST_END;
61
+        } else {
62
+            $range_start = PluginEventHandler::EVENT_PRIORITY_NORMAL_START;
63
+            $range_end = PluginEventHandler::EVENT_PRIORITY_NORMAL_END;
64 64
         }
65
-        return array($range_start,$range_end);
65
+        return array($range_start, $range_end);
66 66
 
67 67
     }
68 68
 
69
-    public function calcNewPriority($event , $type)
69
+    public function calcNewPriority($event, $type)
70 70
     {
71 71
 
72
-        list($range_start,$range_end) = $this->getPriorityRange($type);
72
+        list($range_start, $range_end) = $this->getPriorityRange($type);
73 73
 
74 74
         $qb = $this->createQueryBuilder('e');
75 75
         $qb->andWhere("e.priority >= $range_end ")
76 76
            ->andWhere("e.priority <= $range_start ")
77 77
            ->andWhere('e.event = :event')
78
-           ->setParameter('event',$event)
78
+           ->setParameter('event', $event)
79 79
            ->setMaxResults(1)
80
-           ->orderBy('e.priority','ASC');
80
+           ->orderBy('e.priority', 'ASC');
81 81
 
82
-        $result=$qb->getQuery()->getResult();
83
-        if(count($result)){
84
-             return $result[0]->getPriority() -1;
85
-        }else{
82
+        $result = $qb->getQuery()->getResult();
83
+        if (count($result)) {
84
+             return $result[0]->getPriority() - 1;
85
+        } else {
86 86
              return $range_start;
87 87
         }
88 88
 
89 89
     }
90 90
 
91
-    public function upPriority($pluginEventHandler,$up=true)
91
+    public function upPriority($pluginEventHandler, $up = true)
92 92
     {
93 93
 
94
-        list($range_start,$range_end) = $this->getPriorityRange($pluginEventHandler->getHandlerType());
94
+        list($range_start, $range_end) = $this->getPriorityRange($pluginEventHandler->getHandlerType());
95 95
 
96 96
         $qb = $this->createQueryBuilder('e');
97 97
 
98 98
         $qb->andWhere("e.priority >= $range_end ")
99 99
            ->andWhere("e.priority <= $range_start ")
100
-           ->andWhere('e.priority '.($up ?  '>' : '<' ).' :pri')
100
+           ->andWhere('e.priority '.($up ? '>' : '<').' :pri')
101 101
            ->andWhere('e.event = :event')
102
-           ->setParameter('event',$pluginEventHandler->getEvent())
103
-           ->setParameter('pri',  $pluginEventHandler->getPriority()  )
102
+           ->setParameter('event', $pluginEventHandler->getEvent())
103
+           ->setParameter('pri', $pluginEventHandler->getPriority())
104 104
            ->setMaxResults(1)
105
-           ->orderBy('e.priority', ($up ? 'ASC':'DESC' )  );
105
+           ->orderBy('e.priority', ($up ? 'ASC' : 'DESC'));
106 106
 
107
-        $result=$qb->getQuery()->getResult();
107
+        $result = $qb->getQuery()->getResult();
108 108
 
109
-        if(count($result)){
110
-            $em =$this->getEntityManager();
109
+        if (count($result)) {
110
+            $em = $this->getEntityManager();
111 111
             $em->getConnection()->beginTransaction();
112 112
             // 2個のentityのprioriryを入れ替える
113
-            $tmp=$pluginEventHandler->getPriority();
113
+            $tmp = $pluginEventHandler->getPriority();
114 114
             $pluginEventHandler->setPriority($result[0]->getPriority());
115 115
             $result[0]->setPriority($tmp);
116 116
             $em->persist($result[0]);
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
             $em->flush();
119 119
             $em->getConnection()->commit();
120 120
             # 移動する
121
-        }else{
121
+        } else {
122 122
             # 移動しない
123 123
             throw new PluginException("Can't swap");
124 124
         }
Please login to merge, or discard this patch.