Completed
Pull Request — master (#2152)
by NOBU
82:06 queued 38:49
created
src/Eccube/Controller/Mypage/DeliveryController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@
 block discarded – undo
83 83
         // 遷移が正しくない場合、デフォルトであるマイページの配送先追加の画面を設定する
84 84
         if (!in_array($parentPage, $allowdParents)) {
85 85
             // @deprecated 使用されていないコード
86
-            $parentPage  = $app->url('mypage_delivery');
86
+            $parentPage = $app->url('mypage_delivery');
87 87
         }
88 88
 
89 89
         $builder = $app['form.factory']
Please login to merge, or discard this patch.
src/Eccube/Controller/UserDataController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@
 block discarded – undo
55 55
         $paths[] = $app['config']['user_data_realdir'];
56 56
         $app['twig.loader']->addLoader(new \Twig_Loader_Filesystem($paths));
57 57
 
58
-        $file = $PageLayout->getFileName() . '.twig';
58
+        $file = $PageLayout->getFileName().'.twig';
59 59
 
60 60
         $event = new EventArgs(
61 61
             array(
Please login to merge, or discard this patch.
src/Eccube/Controller/ForgotController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
                 // リセットキーの発行・有効期限の設定
65 65
                 $Customer
66 66
                     ->setResetKey($app['eccube.repository.customer']->getUniqueResetKey($app))
67
-                    ->setResetExpire(new \DateTime('+' . $app['config']['customer_reset_expire'] .' min'));
67
+                    ->setResetExpire(new \DateTime('+'.$app['config']['customer_reset_expire'].' min'));
68 68
 
69 69
                 // リセットキーを更新
70 70
                 $app['orm.em']->persist($Customer);
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
 
88 88
                 // ログ出力
89 89
                 $app['monolog']->addInfo(
90
-                    'send reset password mail to:'  . "{$Customer->getId()} {$Customer->getEmail()} {$request->getClientIp()}"
90
+                    'send reset password mail to:'."{$Customer->getId()} {$Customer->getEmail()} {$request->getClientIp()}"
91 91
                 );
92 92
             } else {
93 93
                 log_warning('Un active customer try send reset password email: ', array('Enter email' => $form->get('login_email')->getData()));
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
 
170 170
             // ログ出力
171 171
             $app['monolog']->addInfo(
172
-                'reset password complete:' . "{$Customer->getId()} {$Customer->getEmail()} {$request->getClientIp()}"
172
+                'reset password complete:'."{$Customer->getId()} {$Customer->getEmail()} {$request->getClientIp()}"
173 173
             );
174 174
         } else {
175 175
             throw new HttpException\AccessDeniedHttpException('不正なアクセスです。');
Please login to merge, or discard this patch.
src/Eccube/Repository/ProductRepository.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
                 $key = sprintf('keyword%s', $index);
114 114
                 $qb
115 115
                     ->andWhere(sprintf('NORMALIZE(p.name) LIKE NORMALIZE(:%s) OR NORMALIZE(p.search_word) LIKE NORMALIZE(:%s)', $key, $key))
116
-                    ->setParameter($key, '%' . $keyword . '%');
116
+                    ->setParameter($key, '%'.$keyword.'%');
117 117
             }
118 118
         }
119 119
 
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
             $qb
177 177
                 ->andWhere('p.id = :id OR p.name LIKE :likeid OR pc.code LIKE :likeid')
178 178
                 ->setParameter('id', $id)
179
-                ->setParameter('likeid', '%' . $searchData['id'] . '%');
179
+                ->setParameter('likeid', '%'.$searchData['id'].'%');
180 180
         }
181 181
 
182 182
         // code
Please login to merge, or discard this patch.
src/Eccube/Command/GeneratorCommand/AbstractPluginGenerator.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -348,7 +348,7 @@  discard block
 block discarded – undo
348 348
      * @param array $metadatas
349 349
      * @param array $fsList
350 350
      * @param $pluginCode
351
-     * @param $codePath
351
+     * @param string $codePath
352 352
      */
353 353
     protected function generateMigration(array $metadatas, array &$fsList = array(), $pluginCode, $codePath)
354 354
     {
@@ -373,7 +373,7 @@  discard block
 block discarded – undo
373 373
      *
374 374
      * @param $pluginCode
375 375
      * @param array $metadatas
376
-     * @return mixed|string
376
+     * @return string
377 377
      */
378 378
     protected function makeMigration($pluginCode, array $metadatas)
379 379
     {
Please login to merge, or discard this patch.
src/Eccube/Command/PluginCommand.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,6 @@
 block discarded – undo
33 33
 use Symfony\Component\Console\Input\InputOption;
34 34
 use Symfony\Component\Console\Output\OutputInterface;
35 35
 use Symfony\Component\Console\Question\Question;
36
-use Symfony\Component\Validator\Constraints as Assert;
37 36
 
38 37
 class PluginCommand extends \Knp\Command\Command
39 38
 {
Please login to merge, or discard this patch.
src/Eccube/ServiceProvider/EccubeServiceProvider.php 1 patch
Spacing   +61 added lines, -61 removed lines patch added patch discarded remove patch
@@ -41,28 +41,28 @@  discard block
 block discarded – undo
41 41
     public function register(BaseApplication $app)
42 42
     {
43 43
         // Service
44
-        $app['eccube.service.system'] = $app->share(function () use ($app) {
44
+        $app['eccube.service.system'] = $app->share(function() use ($app) {
45 45
             return new \Eccube\Service\SystemService($app);
46 46
         });
47
-        $app['view'] = $app->share(function () use ($app) {
47
+        $app['view'] = $app->share(function() use ($app) {
48 48
             return $app['twig'];
49 49
         });
50
-        $app['eccube.service.cart'] = $app->share(function () use ($app) {
50
+        $app['eccube.service.cart'] = $app->share(function() use ($app) {
51 51
             return new \Eccube\Service\CartService($app);
52 52
         });
53
-        $app['eccube.service.order'] = $app->share(function () use ($app) {
53
+        $app['eccube.service.order'] = $app->share(function() use ($app) {
54 54
             return new \Eccube\Service\OrderService($app);
55 55
         });
56
-        $app['eccube.service.tax_rule'] = $app->share(function () use ($app) {
56
+        $app['eccube.service.tax_rule'] = $app->share(function() use ($app) {
57 57
             return new \Eccube\Service\TaxRuleService($app['eccube.repository.tax_rule']);
58 58
         });
59
-        $app['eccube.service.plugin'] = $app->share(function () use ($app) {
59
+        $app['eccube.service.plugin'] = $app->share(function() use ($app) {
60 60
             return new \Eccube\Service\PluginService($app);
61 61
         });
62
-        $app['eccube.service.mail'] = $app->share(function () use ($app) {
62
+        $app['eccube.service.mail'] = $app->share(function() use ($app) {
63 63
             return new \Eccube\Service\MailService($app);
64 64
         });
65
-        $app['eccube.service.csv.export'] = $app->share(function () use ($app) {
65
+        $app['eccube.service.csv.export'] = $app->share(function() use ($app) {
66 66
             $csvService = new \Eccube\Service\CsvExportService();
67 67
             $csvService->setEntityManager($app['orm.em']);
68 68
             $csvService->setConfig($app['config']);
@@ -74,190 +74,190 @@  discard block
 block discarded – undo
74 74
 
75 75
             return $csvService;
76 76
         });
77
-        $app['eccube.service.shopping'] = $app->share(function () use ($app) {
77
+        $app['eccube.service.shopping'] = $app->share(function() use ($app) {
78 78
             return new \Eccube\Service\ShoppingService($app, $app['eccube.service.cart'], $app['eccube.service.order']);
79 79
         });
80 80
 
81 81
         // Repository
82
-        $app['eccube.repository.master.authority'] = $app->share(function () use ($app) {
82
+        $app['eccube.repository.master.authority'] = $app->share(function() use ($app) {
83 83
             return $app['orm.em']->getRepository('Eccube\Entity\Master\Authority');
84 84
         });
85
-        $app['eccube.repository.master.tag'] = $app->share(function () use ($app) {
85
+        $app['eccube.repository.master.tag'] = $app->share(function() use ($app) {
86 86
             return $app['orm.em']->getRepository('Eccube\Entity\Master\Tag');
87 87
         });
88
-        $app['eccube.repository.master.pref'] = $app->share(function () use ($app) {
88
+        $app['eccube.repository.master.pref'] = $app->share(function() use ($app) {
89 89
             return $app['orm.em']->getRepository('Eccube\Entity\Master\Pref');
90 90
         });
91
-        $app['eccube.repository.master.sex'] = $app->share(function () use ($app) {
91
+        $app['eccube.repository.master.sex'] = $app->share(function() use ($app) {
92 92
             return $app['orm.em']->getRepository('Eccube\Entity\Master\Sex');
93 93
         });
94
-        $app['eccube.repository.master.disp'] = $app->share(function () use ($app) {
94
+        $app['eccube.repository.master.disp'] = $app->share(function() use ($app) {
95 95
             return $app['orm.em']->getRepository('Eccube\Entity\Master\Disp');
96 96
         });
97
-        $app['eccube.repository.master.product_type'] = $app->share(function () use ($app) {
97
+        $app['eccube.repository.master.product_type'] = $app->share(function() use ($app) {
98 98
             return $app['orm.em']->getRepository('Eccube\Entity\Master\ProductType');
99 99
         });
100
-        $app['eccube.repository.master.page_max'] = $app->share(function () use ($app) {
100
+        $app['eccube.repository.master.page_max'] = $app->share(function() use ($app) {
101 101
             return $app['orm.em']->getRepository('Eccube\Entity\Master\PageMax');
102 102
         });
103
-        $app['eccube.repository.master.product_list_max'] = $app->share(function () use ($app) {
103
+        $app['eccube.repository.master.product_list_max'] = $app->share(function() use ($app) {
104 104
             return $app['orm.em']->getRepository('Eccube\Entity\Master\ProductListMax');
105 105
         });
106
-        $app['eccube.repository.master.product_list_order_by'] = $app->share(function () use ($app) {
106
+        $app['eccube.repository.master.product_list_order_by'] = $app->share(function() use ($app) {
107 107
             return $app['orm.em']->getRepository('Eccube\Entity\Master\ProductListOrderBy');
108 108
         });
109
-        $app['eccube.repository.master.order_status'] = $app->share(function () use ($app) {
109
+        $app['eccube.repository.master.order_status'] = $app->share(function() use ($app) {
110 110
             return $app['orm.em']->getRepository('Eccube\Entity\Master\OrderStatus');
111 111
         });
112
-        $app['eccube.repository.master.device_type'] = $app->share(function () use ($app) {
112
+        $app['eccube.repository.master.device_type'] = $app->share(function() use ($app) {
113 113
             return $app['orm.em']->getRepository('Eccube\Entity\Master\DeviceType');
114 114
         });
115
-        $app['eccube.repository.master.csv_type'] = $app->share(function () use ($app) {
115
+        $app['eccube.repository.master.csv_type'] = $app->share(function() use ($app) {
116 116
             return $app['orm.em']->getRepository('Eccube\Entity\Master\CsvType');
117 117
         });
118 118
 
119
-        $app['eccube.repository.delivery'] = $app->share(function () use ($app) {
119
+        $app['eccube.repository.delivery'] = $app->share(function() use ($app) {
120 120
             return $app['orm.em']->getRepository('Eccube\Entity\Delivery');
121 121
         });
122
-        $app['eccube.repository.delivery_date'] = $app->share(function () use ($app) {
122
+        $app['eccube.repository.delivery_date'] = $app->share(function() use ($app) {
123 123
             return $app['orm.em']->getRepository('Eccube\Entity\DeliveryDate');
124 124
         });
125
-        $app['eccube.repository.delivery_fee'] = $app->share(function () use ($app) {
125
+        $app['eccube.repository.delivery_fee'] = $app->share(function() use ($app) {
126 126
             return $app['orm.em']->getRepository('Eccube\Entity\DeliveryFee');
127 127
         });
128
-        $app['eccube.repository.delivery_time'] = $app->share(function () use ($app) {
128
+        $app['eccube.repository.delivery_time'] = $app->share(function() use ($app) {
129 129
             return $app['orm.em']->getRepository('Eccube\Entity\DeliveryTime');
130 130
         });
131
-        $app['eccube.repository.payment'] = $app->share(function () use ($app) {
131
+        $app['eccube.repository.payment'] = $app->share(function() use ($app) {
132 132
             return $app['orm.em']->getRepository('Eccube\Entity\Payment');
133 133
         });
134
-        $app['eccube.repository.payment_option'] = $app->share(function () use ($app) {
134
+        $app['eccube.repository.payment_option'] = $app->share(function() use ($app) {
135 135
             return $app['orm.em']->getRepository('Eccube\Entity\PaymentOption');
136 136
         });
137
-        $app['eccube.repository.category'] = $app->share(function () use ($app) {
137
+        $app['eccube.repository.category'] = $app->share(function() use ($app) {
138 138
             $CategoryRepository = $app['orm.em']->getRepository('Eccube\Entity\Category');
139 139
             $CategoryRepository->setApplication($app);
140 140
 
141 141
             return $CategoryRepository;
142 142
         });
143
-        $app['eccube.repository.customer'] = $app->share(function () use ($app) {
143
+        $app['eccube.repository.customer'] = $app->share(function() use ($app) {
144 144
             return $app['orm.em']->getRepository('Eccube\Entity\Customer');
145 145
         });
146
-        $app['eccube.repository.news'] = $app->share(function () use ($app) {
146
+        $app['eccube.repository.news'] = $app->share(function() use ($app) {
147 147
             return $app['orm.em']->getRepository('Eccube\Entity\News');
148 148
         });
149
-        $app['eccube.repository.mail_history'] = $app->share(function () use ($app) {
149
+        $app['eccube.repository.mail_history'] = $app->share(function() use ($app) {
150 150
             return $app['orm.em']->getRepository('Eccube\Entity\MailHistory');
151 151
         });
152
-        $app['eccube.repository.member'] = $app->share(function () use ($app) {
152
+        $app['eccube.repository.member'] = $app->share(function() use ($app) {
153 153
             $memberRepository = $app['orm.em']->getRepository('Eccube\Entity\Member');
154 154
             $memberRepository->setEncoderFactorty($app['security.encoder_factory']);
155 155
             return $memberRepository;
156 156
         });
157
-        $app['eccube.repository.order'] = $app->share(function () use ($app) {
157
+        $app['eccube.repository.order'] = $app->share(function() use ($app) {
158 158
             return $app['orm.em']->getRepository('Eccube\Entity\Order');
159 159
         });
160
-        $app['eccube.repository.product'] = $app->share(function () use ($app) {
160
+        $app['eccube.repository.product'] = $app->share(function() use ($app) {
161 161
             $productRepository = $app['orm.em']->getRepository('Eccube\Entity\Product');
162 162
             $productRepository->setApplication($app);
163 163
 
164 164
             return $productRepository;
165 165
         });
166
-        $app['eccube.repository.product_image'] = $app->share(function () use ($app) {
166
+        $app['eccube.repository.product_image'] = $app->share(function() use ($app) {
167 167
             return $app['orm.em']->getRepository('Eccube\Entity\ProductImage');
168 168
         });
169
-        $app['eccube.repository.product_class'] = $app->share(function () use ($app) {
169
+        $app['eccube.repository.product_class'] = $app->share(function() use ($app) {
170 170
             return $app['orm.em']->getRepository('Eccube\Entity\ProductClass');
171 171
         });
172
-        $app['eccube.repository.product_stock'] = $app->share(function () use ($app) {
172
+        $app['eccube.repository.product_stock'] = $app->share(function() use ($app) {
173 173
             return $app['orm.em']->getRepository('Eccube\Entity\ProductStock');
174 174
         });
175
-        $app['eccube.repository.product_tag'] = $app->share(function () use ($app) {
175
+        $app['eccube.repository.product_tag'] = $app->share(function() use ($app) {
176 176
             return $app['orm.em']->getRepository('Eccube\Entity\ProductTag');
177 177
         });
178
-        $app['eccube.repository.class_name'] = $app->share(function () use ($app) {
178
+        $app['eccube.repository.class_name'] = $app->share(function() use ($app) {
179 179
             return $app['orm.em']->getRepository('Eccube\Entity\ClassName');
180 180
         });
181
-        $app['eccube.repository.class_category'] = $app->share(function () use ($app) {
181
+        $app['eccube.repository.class_category'] = $app->share(function() use ($app) {
182 182
             return $app['orm.em']->getRepository('Eccube\Entity\ClassCategory');
183 183
         });
184
-        $app['eccube.repository.customer_favorite_product'] = $app->share(function () use ($app) {
184
+        $app['eccube.repository.customer_favorite_product'] = $app->share(function() use ($app) {
185 185
             return $app['orm.em']->getRepository('Eccube\Entity\CustomerFavoriteProduct');
186 186
         });
187
-        $app['eccube.repository.base_info'] = $app->share(function () use ($app) {
187
+        $app['eccube.repository.base_info'] = $app->share(function() use ($app) {
188 188
             $BaseInfoRepository = $app['orm.em']->getRepository('Eccube\Entity\BaseInfo');
189 189
             $BaseInfoRepository->setApplication($app);
190 190
 
191 191
             return $BaseInfoRepository;
192 192
         });
193
-        $app['eccube.repository.tax_rule'] = $app->share(function () use ($app) {
193
+        $app['eccube.repository.tax_rule'] = $app->share(function() use ($app) {
194 194
             $taxRuleRepository = $app['orm.em']->getRepository('Eccube\Entity\TaxRule');
195 195
             $taxRuleRepository->setApplication($app);
196 196
 
197 197
             return $taxRuleRepository;
198 198
         });
199
-        $app['eccube.repository.page_layout'] = $app->share(function () use ($app) {
199
+        $app['eccube.repository.page_layout'] = $app->share(function() use ($app) {
200 200
             $pageLayoutRepository = $app['orm.em']->getRepository('Eccube\Entity\PageLayout');
201 201
             $pageLayoutRepository->setApplication($app);
202 202
 
203 203
             return $pageLayoutRepository;
204 204
         });
205
-        $app['eccube.repository.block'] = $app->share(function () use ($app) {
205
+        $app['eccube.repository.block'] = $app->share(function() use ($app) {
206 206
             $blockRepository = $app['orm.em']->getRepository('Eccube\Entity\Block');
207 207
             $blockRepository->setApplication($app);
208 208
 
209 209
             return $blockRepository;
210 210
         });
211
-        $app['eccube.repository.order'] = $app->share(function () use ($app) {
211
+        $app['eccube.repository.order'] = $app->share(function() use ($app) {
212 212
             $orderRepository = $app['orm.em']->getRepository('Eccube\Entity\Order');
213 213
             $orderRepository->setApplication($app);
214 214
 
215 215
             return $orderRepository;
216 216
         });
217
-        $app['eccube.repository.customer_address'] = $app->share(function () use ($app) {
217
+        $app['eccube.repository.customer_address'] = $app->share(function() use ($app) {
218 218
             return $app['orm.em']->getRepository('Eccube\Entity\CustomerAddress');
219 219
         });
220
-        $app['eccube.repository.shipping'] = $app->share(function () use ($app) {
220
+        $app['eccube.repository.shipping'] = $app->share(function() use ($app) {
221 221
             return $app['orm.em']->getRepository('Eccube\Entity\Shipping');
222 222
         });
223
-        $app['eccube.repository.customer_status'] = $app->share(function () use ($app) {
223
+        $app['eccube.repository.customer_status'] = $app->share(function() use ($app) {
224 224
             return $app['orm.em']->getRepository('Eccube\Entity\Master\CustomerStatus');
225 225
         });
226
-        $app['eccube.repository.order_status'] = $app->share(function () use ($app) {
226
+        $app['eccube.repository.order_status'] = $app->share(function() use ($app) {
227 227
             return $app['orm.em']->getRepository('Eccube\Entity\Master\OrderStatus');
228 228
         });
229
-        $app['eccube.repository.mail_template'] = $app->share(function () use ($app) {
229
+        $app['eccube.repository.mail_template'] = $app->share(function() use ($app) {
230 230
             return $app['orm.em']->getRepository('Eccube\Entity\MailTemplate');
231 231
         });
232
-        $app['eccube.repository.csv'] = $app->share(function () use ($app) {
232
+        $app['eccube.repository.csv'] = $app->share(function() use ($app) {
233 233
             return $app['orm.em']->getRepository('Eccube\Entity\Csv');
234 234
         });
235
-        $app['eccube.repository.template'] = $app->share(function () use ($app) {
235
+        $app['eccube.repository.template'] = $app->share(function() use ($app) {
236 236
             return $app['orm.em']->getRepository('Eccube\Entity\Template');
237 237
         });
238
-        $app['eccube.repository.authority_role'] = $app->share(function () use ($app) {
238
+        $app['eccube.repository.authority_role'] = $app->share(function() use ($app) {
239 239
             return $app['orm.em']->getRepository('Eccube\Entity\AuthorityRole');
240 240
         });
241 241
 
242
-        $app['paginator'] = $app->protect(function () {
242
+        $app['paginator'] = $app->protect(function() {
243 243
             $paginator = new \Knp\Component\Pager\Paginator();
244 244
             $paginator->subscribe(new \Eccube\EventListener\PaginatorListener());
245 245
 
246 246
             return $paginator;
247 247
         });
248 248
 
249
-        $app['eccube.repository.help'] = $app->share(function () use ($app) {
249
+        $app['eccube.repository.help'] = $app->share(function() use ($app) {
250 250
             return $app['orm.em']->getRepository('Eccube\Entity\Help');
251 251
         });
252
-        $app['eccube.repository.plugin'] = $app->share(function () use ($app) {
252
+        $app['eccube.repository.plugin'] = $app->share(function() use ($app) {
253 253
             return $app['orm.em']->getRepository('Eccube\Entity\Plugin');
254 254
         });
255
-        $app['eccube.repository.plugin_event_handler'] = $app->share(function () use ($app) {
255
+        $app['eccube.repository.plugin_event_handler'] = $app->share(function() use ($app) {
256 256
             return $app['orm.em']->getRepository('Eccube\Entity\PluginEventHandler');
257 257
         });
258 258
         // em
259 259
         if (isset($app['orm.em'])) {
260
-            $app['orm.em'] = $app->share($app->extend('orm.em', function (\Doctrine\ORM\EntityManager $em, \Silex\Application $app) {
260
+            $app['orm.em'] = $app->share($app->extend('orm.em', function(\Doctrine\ORM\EntityManager $em, \Silex\Application $app) {
261 261
                 // tax_rule
262 262
                 $taxRuleRepository = $em->getRepository('Eccube\Entity\TaxRule');
263 263
                 $taxRuleRepository->setApplication($app);
@@ -284,13 +284,13 @@  discard block
 block discarded – undo
284 284
         }
285 285
 
286 286
         // Form\Type
287
-        $app['form.type.extensions'] = $app->share($app->extend('form.type.extensions', function ($extensions) use ($app) {
287
+        $app['form.type.extensions'] = $app->share($app->extend('form.type.extensions', function($extensions) use ($app) {
288 288
             $extensions[] = new \Eccube\Form\Extension\HelpTypeExtension();
289 289
             $extensions[] = new \Eccube\Form\Extension\FreezeTypeExtension();
290 290
 
291 291
             return $extensions;
292 292
         }));
293
-        $app['form.types'] = $app->share($app->extend('form.types', function ($types) use ($app) {
293
+        $app['form.types'] = $app->share($app->extend('form.types', function($types) use ($app) {
294 294
             $types[] = new \Eccube\Form\Type\NameType($app['config']);
295 295
             $types[] = new \Eccube\Form\Type\KanaType($app['config']);
296 296
             $types[] = new \Eccube\Form\Type\TelType($app['config']);
Please login to merge, or discard this patch.