InvalidItemException::fromProductClass() - Code Metrics - Inspection of "複数配送設定画面で在庫エラーになったときにカートに戻ってしまう不具合を修正" - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — experimental/sf (#3265)

by Kiyotaka

created 2018-07-05 09:41 UTC

InvalidItemException::fromProductClass() A

↳ Parent: InvalidItemException

Complexity

Conditions	3
Paths	4

Size

Total Lines

Duplication

Lines	12
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
cc	3
nc	4
nop	2
dl	12
loc	12
rs	9.8666
c	0
b	0
f	0
ccs	0
cts	7
cp	0
crap	12

<?php

/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Eccube\Service\PurchaseFlow;

use Eccube\Entity\ProductClass;

class InvalidItemException extends \Exception

{
    private $messageArgs = [];

    private $warning;

    public function __construct($message = null, $messageArgs = [], $warning = false)
    {
        parent::__construct($message);
        $this->messageArgs = $messageArgs;
        $this->warning = $warning;
    }

    /**
     * @return array
     */
    public function getMessageArgs()
    {
        return $this->messageArgs;
    }

    /**
     * @return bool
     */
    public function isWarning()
    {
        return $this->warning;
    }

    /**

     * @return InvalidItemException
     */
    public static function fromProductClass($errorMessage, ProductClass $ProductClass)

    {
        $productName = $ProductClass->getProduct()->getName();
        if ($ProductClass->hasClassCategory1()) {
            $productName .= ' - '.$ProductClass->getClassCategory1()->getName();
        }
        if ($ProductClass->hasClassCategory2()) {
            $productName .= ' - '.$ProductClass->getClassCategory2()->getName();
        }

        return new self($errorMessage, ['%product%' => $productName]);
    }
}


1			<?php
2
3			/*
4			* This file is part of EC-CUBE
5			*
6			* Copyright(c) LOCKON CO.,LTD. All Rights Reserved.
7			*
8			* http://www.lockon.co.jp/
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Eccube\Service\PurchaseFlow;
15
16			use Eccube\Entity\ProductClass;
17
18			class InvalidItemException extends \Exception
			0 ignored issues – show introduced 2017-07-20 09:47 UTC by Report Bug Copy Issue Report Missing class doc comment Loading history...
19			{
20			private $messageArgs = [];
21
22			private $warning;
23
24	72		public function __construct($message = null, $messageArgs = [], $warning = false)
25			{
26	72		parent::__construct($message);
27	72		$this->messageArgs = $messageArgs;
28	72		$this->warning = $warning;
29			}
30
31			/**
32			* @return array
33			*/
34			public function getMessageArgs()
35			{
36			return $this->messageArgs;
37			}
38
39			/**
40			* @return bool
41			*/
42	14		public function isWarning()
43			{
44	14		return $this->warning;
45			}
46
47			/**
			0 ignored issues – show introduced 2018-06-08 04:37 UTC by Report Bug Copy Issue Report Doc comment for parameter "$errorMessage" missing Loading history... introduced 2017-07-28 03:49 UTC by Report Bug Copy Issue Report Doc comment for parameter "$ProductClass" missing Loading history...
48			* @return InvalidItemException
49			*/
50		View Code Duplication	public static function fromProductClass($errorMessage, ProductClass $ProductClass)
			0 ignored issues – show Duplication introduced 2018-06-08 04:37 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
51			{
52			$productName = $ProductClass->getProduct()->getName();
53			if ($ProductClass->hasClassCategory1()) {
54			$productName .= ' - '.$ProductClass->getClassCategory1()->getName();
55			}
56			if ($ProductClass->hasClassCategory2()) {
57			$productName .= ' - '.$ProductClass->getClassCategory2()->getName();
58			}
59
60			return new self($errorMessage, ['%product%' => $productName]);
61			}
62			}
63

EC-CUBE / ec-cube

Pull Request — experimental/sf (#3265)

InvalidItemException::fromProductClass() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like