Completed
Pull Request — experimental/sf (#3157)
by Kentaro
151:58 queued 143:16
created
src/Eccube/Service/CsvExportService.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -326,7 +326,6 @@
 block discarded – undo
326 326
 
327 327
     /**
328 328
      * @param $row
329
-     * @param null $callback
330 329
      */
331 330
     public function fputcsv($row)
332 331
     {
Please login to merge, or discard this patch.
src/Eccube/Doctrine/ORM/Tools/Pagination/Paginator.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@
 block discarded – undo
57 57
     /**
58 58
      * Constructor.
59 59
      *
60
-     * @param Query|QueryBuilder $query               A Doctrine ORM query or query builder.
60
+     * @param Query $query               A Doctrine ORM query or query builder.
61 61
      * @param boolean            $fetchJoinCollection Whether the query joins a collection (true by default).
62 62
      */
63 63
     public function __construct($query, $fetchJoinCollection = true)
Please login to merge, or discard this patch.
src/Eccube/Doctrine/Query/WhereClause.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -53,6 +53,9 @@
 block discarded – undo
53 53
         $this->params = $params;
54 54
     }
55 55
 
56
+    /**
57
+     * @param Expr\Comparison $expr
58
+     */
56 59
     private static function newWhereClause($expr, $x, $y)
57 60
     {
58 61
         if ($y) {
Please login to merge, or discard this patch.
src/Eccube/ServiceProvider/QueriesServiceProvider.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,6 @@
 block discarded – undo
16 16
      * This method should only be used to configure services and parameters.
17 17
      * It should not get services.
18 18
      *
19
-     * @param Container $pimple A container instance
20 19
      */
21 20
     public function register(Container $app)
22 21
     {
Please login to merge, or discard this patch.
src/Eccube/Service/PluginService.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,6 @@
 block discarded – undo
33 33
 use Eccube\Entity\Plugin;
34 34
 use Eccube\Entity\PluginEventHandler;
35 35
 use Eccube\Exception\PluginException;
36
-use Eccube\Plugin\ConfigManager;
37 36
 use Eccube\Plugin\ConfigManager as PluginConfigManager;
38 37
 use Eccube\Repository\PluginEventHandlerRepository;
39 38
 use Eccube\Repository\PluginRepository;
Please login to merge, or discard this patch.
Doc Comments   +19 added lines, -3 removed lines patch added patch discarded remove patch
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
      * @param string $path   path to tar.gz/zip plugin file
140 140
      * @param int    $source
141 141
      *
142
-     * @return mixed
142
+     * @return boolean
143 143
      *
144 144
      * @throws PluginException
145 145
      * @throws \Exception
@@ -263,6 +263,10 @@  discard block
 block discarded – undo
263 263
         }
264 264
     }
265 265
 
266
+    /**
267
+     * @param string $archive
268
+     * @param string $dir
269
+     */
266 270
     public function unpackPluginArchive($archive, $dir)
267 271
     {
268 272
         $extension = pathinfo($archive, PATHINFO_EXTENSION);
@@ -322,6 +326,9 @@  discard block
 block discarded – undo
322 326
         }
323 327
     }
324 328
 
329
+    /**
330
+     * @param string $yml
331
+     */
325 332
     public function readYml($yml)
326 333
     {
327 334
         if (file_exists($yml)) {
@@ -339,6 +346,9 @@  discard block
 block discarded – undo
339 346
         // ディレクトリ名などに使われれるので厳しめ
340 347
     }
341 348
 
349
+    /**
350
+     * @param string $path
351
+     */
342 352
     public function deleteFile($path)
343 353
     {
344 354
         $f = new Filesystem();
@@ -358,6 +368,9 @@  discard block
 block discarded – undo
358 368
         return $this->projectRoot.'/app/Plugin/'.$name;
359 369
     }
360 370
 
371
+    /**
372
+     * @param string $d
373
+     */
361 374
     public function createPluginDir($d)
362 375
     {
363 376
         $b = @mkdir($d);
@@ -418,6 +431,9 @@  discard block
 block discarded – undo
418 431
         return $p;
419 432
     }
420 433
 
434
+    /**
435
+     * @param string $method
436
+     */
421 437
     public function callPluginManagerMethod($meta, $method)
422 438
     {
423 439
         $class = '\\Plugin'.'\\'.$meta['code'].'\\'.'PluginManager';
@@ -951,7 +967,7 @@  discard block
 block discarded – undo
951 967
      * [プラグインコード]/Resource/assets
952 968
      * 配下に置かれているファイルが所定の位置へコピーされる
953 969
      *
954
-     * @param $pluginBaseDir
970
+     * @param string $pluginBaseDir
955 971
      * @param $pluginCode
956 972
      */
957 973
     public function copyAssets($pluginBaseDir, $pluginCode)
@@ -987,7 +1003,7 @@  discard block
 block discarded – undo
987 1003
      * @param string $pluginVersion
988 1004
      * @param string $remoteVersion
989 1005
      *
990
-     * @return mixed
1006
+     * @return boolean
991 1007
      */
992 1008
     public function isUpdate($pluginVersion, $remoteVersion)
993 1009
     {
Please login to merge, or discard this patch.
app/Acme/Controller/RoutingTestController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
      *
28 28
      * @param Application $app
29 29
      *
30
-     * @return \Symfony\Component\HttpFoundation\Response
30
+     * @return string
31 31
      */
32 32
     public function testAdmin(Application $app)
33 33
     {
Please login to merge, or discard this patch.
codeception/_support/Interactions/DragAndDropBy.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -12,6 +12,9 @@
 block discarded – undo
12 12
 
13 13
 class DragAndDropBy extends WebDriverActions
14 14
 {
15
+    /**
16
+     * @param \Facebook\WebDriver\Remote\RemoteWebElement $source
17
+     */
15 18
     public function __construct(WebDriver $driver, $source, $x_offset, $y_offset)
16 19
     {
17 20
         parent::__construct($driver);
Please login to merge, or discard this patch.
codeception/_support/Interactions/WaitAction.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -14,6 +14,9 @@
 block discarded – undo
14 14
      */
15 15
     private $timeout_in_second;
16 16
 
17
+    /**
18
+     * @param integer $timeout_in_second
19
+     */
17 20
     function __construct($timeout_in_second)
18 21
     {
19 22
         $this->timeout_in_second = $timeout_in_second;
Please login to merge, or discard this patch.
codeception/_support/Page/Admin/CustomerManagePage.php 1 patch
Doc Comments   +12 added lines patch added patch discarded remove patch
@@ -48,12 +48,18 @@  discard block
 block discarded – undo
48 48
         return $this;
49 49
     }
50 50
 
51
+    /**
52
+     * @param integer $rowNum
53
+     */
51 54
     public function 一覧_編集($rowNum)
52 55
     {
53 56
         $this->tester->click("#search_form > div.c-contentsArea__cols > div > div > div.card.rounded.border-0.mb-4 > div > table > tbody > tr:nth-child(${rowNum}) > td:nth-child(2) > a");
54 57
         return $this;
55 58
     }
56 59
 
60
+    /**
61
+     * @param integer $rowNum
62
+     */
57 63
     public function 一覧_削除($rowNum, $execute = true)
58 64
     {
59 65
         $this->tester->click("#search_form > div.c-contentsArea__cols > div > div > div.card.rounded.border-0.mb-4 > div > table > tbody > tr:nth-child(${rowNum}) > td.align-middle.pr-3 > div > div > a");
@@ -67,6 +73,9 @@  discard block
 block discarded – undo
67 73
         return $this;
68 74
     }
69 75
 
76
+    /**
77
+     * @param integer $rowNum
78
+     */
70 79
     public function 一覧_仮会員メール再送($rowNum)
71 80
     {
72 81
         $this->tester->click(['xpath' => "//*[@id='search_form']//div/table/tbody/tr[${rowNum}]/td[6]/div/div[1]/a"]);
@@ -92,6 +101,9 @@  discard block
 block discarded – undo
92 101
         $this->tester->click('#search_form > div.c-contentsArea__cols > div > div > div.row.justify-content-between.mb-2 > div.col-5.text-right > div:nth-child(2) > div > button:nth-child(2)');
93 102
     }
94 103
 
104
+    /**
105
+     * @param integer $rowNum
106
+     */
95 107
     public function 一覧_会員ID($rowNum)
96 108
     {
97 109
         return $this->tester->grabTextFrom("#search_form > div.c-contentsArea__cols > div > div > div.card.rounded.border-0.mb-4 > div > table > tbody > tr:nth-child(${rowNum}) > td.align-middle.pl-3");
Please login to merge, or discard this patch.