Completed
Pull Request — experimental/sf (#3157)
by Kentaro
151:58 queued 143:16
created
codeception/_support/Page/Front/ShoppingLoginPage.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -27,6 +27,9 @@
 block discarded – undo
27 27
 class ShoppingLoginPage extends AbstractFrontPage
28 28
 {
29 29
 
30
+    /**
31
+     * @param \AcceptanceTester $I
32
+     */
30 33
     public static function at($I)
31 34
     {
32 35
         $page = new self($I);
Please login to merge, or discard this patch.
codeception/acceptance/AA0PluginInstallerCest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,5 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-use Codeception\Util\Fixtures;
4 3
 use Page\Admin\OwnersPluginPage;
5 4
 
6 5
 /**
Please login to merge, or discard this patch.
codeception/acceptance/EA01TopCest.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -1,7 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3 3
 use Codeception\Util\Fixtures;
4
-use Page\Admin\CustomerManagePage;
5 4
 use Page\Admin\OrderManagePage;
6 5
 use Page\Admin\TopPage;
7 6
 
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
         // 購入された商品が受注管理画面のページにて反映されていることを確認
45 45
         $config = Fixtures::get('config');
46 46
         $findOrders = Fixtures::get('findOrders');
47
-        $NewOrders = array_filter($findOrders(), function ($Order) use ($config) {
47
+        $NewOrders = array_filter($findOrders(), function($Order) use ($config) {
48 48
             return $Order->getOrderStatus()->getId() == \Eccube\Entity\Master\OrderStatus::NEW;
49 49
         });
50 50
         $I->see(count($NewOrders), TopPage::$受付状況_新規受付数);
Please login to merge, or discard this patch.
codeception/acceptance/EA02AuthenticationCest.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -1,7 +1,5 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-use Codeception\Util\Fixtures;
4
-
5 3
 /**
6 4
  * @group admin
7 5
  * @group admin01
Please login to merge, or discard this patch.
codeception/acceptance/EA07BasicinfoCest.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -1,8 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-use Codeception\Util\Fixtures;
4 3
 use Page\Admin\CsvSettingsPage;
5
-use Page\Admin\CustomerAgreementSettingPage;
6 4
 use Page\Admin\DeliveryEditPage;
7 5
 use Page\Admin\DeliveryManagePage;
8 6
 use Page\Admin\MailSettingsPage;
@@ -10,7 +8,6 @@  discard block
 block discarded – undo
10 8
 use Page\Admin\PaymentManagePage;
11 9
 use Page\Admin\ShopSettingPage;
12 10
 use Page\Admin\TaxManagePage;
13
-use Page\Admin\TradelawSettingPage;
14 11
 
15 12
 /**
16 13
  * @group admin
Please login to merge, or discard this patch.
codeception/acceptance/EA09ShippingCest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 use Page\Admin\ShippingManagePage;
6 6
 use Page\Admin\ShippingEditPage;
7 7
 use Page\Admin\OrderEditPage;
8
-use Eccube\Entity\Master\ShippingStatus;
9 8
 
10 9
 /**
11 10
  * @group admin
Please login to merge, or discard this patch.
codeception/acceptance/EF06OtherCest.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -1,7 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3 3
 use Codeception\Util\Fixtures;
4
-use Eccube\Entity\Master\CustomerStatus;
5 4
 
6 5
 /**
7 6
  * @group front
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@
 block discarded – undo
81 81
         $createCustomer = Fixtures::get('createCustomer');
82 82
         $customer = $createCustomer();
83 83
         $I->resetEmails();
84
-        $I->submitForm('#form1',[
84
+        $I->submitForm('#form1', [
85 85
             'login_email' => $customer->getEmail()
86 86
         ]);
87 87
         $I->see('パスワード発行メールの送信 完了', 'div.ec-pageHeader h1');
Please login to merge, or discard this patch.
codeception/acceptance/ZZ99PluginUninstallerCest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,5 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-use Codeception\Util\Fixtures;
4 3
 use Page\Admin\OwnersPluginPage;
5 4
 
6 5
 /**
Please login to merge, or discard this patch.
src/Eccube/Controller/AbstractController.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -153,6 +153,9 @@  discard block
 block discarded – undo
153 153
         $this->addWarning('admin.delete.warning', 'admin');
154 154
     }
155 155
 
156
+    /**
157
+     * @param string $targetPath
158
+     */
156 159
     public function setLoginTargetPath($targetPath, $namespace = null)
157 160
     {
158 161
         if (is_null($namespace)) {
@@ -169,7 +172,7 @@  discard block
 block discarded – undo
169 172
      * @param array  $path An array of path parameters
170 173
      * @param array  $query An array of query parameters
171 174
      *
172
-     * @return Response A Response instance
175
+     * @return \Symfony\Component\HttpFoundation\Response A Response instance
173 176
      */
174 177
     public function forwardToRoute($route, array $path = [], array $query = [])
175 178
     {
Please login to merge, or discard this patch.