Completed
Pull Request — experimental/sf (#3426)
by k-yamamura
122:47 queued 115:15
created
src/Eccube/Service/CsvExportService.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -326,7 +326,6 @@
 block discarded – undo
326 326
 
327 327
     /**
328 328
      * @param $row
329
-     * @param null $callback
330 329
      */
331 330
     public function fputcsv($row)
332 331
     {
Please login to merge, or discard this patch.
src/Eccube/Doctrine/Query/WhereClause.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -53,6 +53,9 @@
 block discarded – undo
53 53
         $this->params = $params;
54 54
     }
55 55
 
56
+    /**
57
+     * @param Expr\Comparison $expr
58
+     */
56 59
     private static function newWhereClause($expr, $x, $y)
57 60
     {
58 61
         if ($y) {
Please login to merge, or discard this patch.
codeception/_support/Interactions/DragAndDropBy.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -12,6 +12,9 @@
 block discarded – undo
12 12
 
13 13
 class DragAndDropBy extends WebDriverActions
14 14
 {
15
+    /**
16
+     * @param \Facebook\WebDriver\Remote\RemoteWebElement $source
17
+     */
15 18
     public function __construct(WebDriver $driver, $source, $x_offset, $y_offset)
16 19
     {
17 20
         parent::__construct($driver);
Please login to merge, or discard this patch.
codeception/_support/Interactions/WaitAction.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -14,6 +14,9 @@
 block discarded – undo
14 14
      */
15 15
     private $timeout_in_second;
16 16
 
17
+    /**
18
+     * @param integer $timeout_in_second
19
+     */
17 20
     function __construct($timeout_in_second)
18 21
     {
19 22
         $this->timeout_in_second = $timeout_in_second;
Please login to merge, or discard this patch.
codeception/_support/Page/Admin/CustomerManagePage.php 1 patch
Doc Comments   +12 added lines patch added patch discarded remove patch
@@ -48,12 +48,18 @@  discard block
 block discarded – undo
48 48
         return $this;
49 49
     }
50 50
 
51
+    /**
52
+     * @param integer $rowNum
53
+     */
51 54
     public function 一覧_編集($rowNum)
52 55
     {
53 56
         $this->tester->click("#search_form > div.c-contentsArea__cols > div > div > div.card.rounded.border-0.mb-4 > div > table > tbody > tr:nth-child(${rowNum}) > td:nth-child(2) > a");
54 57
         return $this;
55 58
     }
56 59
 
60
+    /**
61
+     * @param integer $rowNum
62
+     */
57 63
     public function 一覧_削除($rowNum, $execute = true)
58 64
     {
59 65
         $this->tester->click("#search_form > div.c-contentsArea__cols > div > div > div.card.rounded.border-0.mb-4 > div > table > tbody > tr:nth-child(${rowNum}) > td.align-middle.pr-3 > div > div > a");
@@ -67,6 +73,9 @@  discard block
 block discarded – undo
67 73
         return $this;
68 74
     }
69 75
 
76
+    /**
77
+     * @param integer $rowNum
78
+     */
70 79
     public function 一覧_仮会員メール再送($rowNum)
71 80
     {
72 81
         $this->tester->click(['xpath' => "//*[@id='search_form']//div/table/tbody/tr[${rowNum}]/td[6]/div/div[1]/a"]);
@@ -92,6 +101,9 @@  discard block
 block discarded – undo
92 101
         $this->tester->click('#search_form > div.c-contentsArea__cols > div > div > div.row.justify-content-between.mb-2 > div.col-5.text-right > div:nth-child(2) > div > button:nth-child(2)');
93 102
     }
94 103
 
104
+    /**
105
+     * @param integer $rowNum
106
+     */
95 107
     public function 一覧_会員ID($rowNum)
96 108
     {
97 109
         return $this->tester->grabTextFrom("#search_form > div.c-contentsArea__cols > div > div > div.card.rounded.border-0.mb-4 > div > table > tbody > tr:nth-child(${rowNum}) > td.align-middle.pl-3");
Please login to merge, or discard this patch.
codeception/_support/Page/Front/ShoppingLoginPage.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -27,6 +27,9 @@
 block discarded – undo
27 27
 class ShoppingLoginPage extends AbstractFrontPage
28 28
 {
29 29
 
30
+    /**
31
+     * @param \AcceptanceTester $I
32
+     */
30 33
     public static function at($I)
31 34
     {
32 35
         $page = new self($I);
Please login to merge, or discard this patch.
src/Eccube/Controller/AbstractController.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -153,6 +153,9 @@  discard block
 block discarded – undo
153 153
         $this->addWarning('admin.delete.warning', 'admin');
154 154
     }
155 155
 
156
+    /**
157
+     * @param string $targetPath
158
+     */
156 159
     public function setLoginTargetPath($targetPath, $namespace = null)
157 160
     {
158 161
         if (is_null($namespace)) {
@@ -169,7 +172,7 @@  discard block
 block discarded – undo
169 172
      * @param array  $path An array of path parameters
170 173
      * @param array  $query An array of query parameters
171 174
      *
172
-     * @return Response A Response instance
175
+     * @return \Symfony\Component\HttpFoundation\Response A Response instance
173 176
      */
174 177
     public function forwardToRoute($route, array $path = [], array $query = [])
175 178
     {
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/AdminController.php 1 patch
Doc Comments   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -334,10 +334,10 @@  discard block
 block discarded – undo
334 334
     }
335 335
 
336 336
     /**
337
-     * @param $em
337
+     * @param \Doctrine\ORM\EntityManagerInterface $em
338 338
      * @param array $excludes
339 339
      *
340
-     * @return array
340
+     * @return null|Request
341 341
      */
342 342
     protected function findOrderStatus($em, array $excludes)
343 343
     {
@@ -354,10 +354,10 @@  discard block
 block discarded – undo
354 354
     }
355 355
 
356 356
     /**
357
-     * @param $em
357
+     * @param \Doctrine\ORM\EntityManagerInterface $em
358 358
      * @param array $excludes
359 359
      *
360
-     * @return array
360
+     * @return null|Request
361 361
      */
362 362
     protected function getOrderEachStatus($em, array $excludes)
363 363
     {
@@ -387,11 +387,11 @@  discard block
 block discarded – undo
387 387
     }
388 388
 
389 389
     /**
390
-     * @param $em
391
-     * @param $dateTime
390
+     * @param \Doctrine\ORM\EntityManagerInterface $em
391
+     * @param \DateTime $dateTime
392 392
      * @param array $excludes
393 393
      *
394
-     * @return array
394
+     * @return null|Request
395 395
      */
396 396
     protected function getSalesByMonth($em, $dateTime, array $excludes)
397 397
     {
@@ -425,11 +425,11 @@  discard block
 block discarded – undo
425 425
     }
426 426
 
427 427
     /**
428
-     * @param $em
429
-     * @param $dateTime
428
+     * @param \Doctrine\ORM\EntityManagerInterface $em
429
+     * @param \DateTime $dateTime
430 430
      * @param array $excludes
431 431
      *
432
-     * @return array
432
+     * @return null|Request
433 433
      */
434 434
     protected function getSalesByDay($em, $dateTime, array $excludes)
435 435
     {
@@ -463,9 +463,9 @@  discard block
 block discarded – undo
463 463
     }
464 464
 
465 465
     /**
466
-     * @param $em
466
+     * @param \Doctrine\ORM\EntityManagerInterface $em
467 467
      *
468
-     * @return mixed
468
+     * @return null|Request
469 469
      *
470 470
      * @throws NoResultException
471 471
      * @throws \Doctrine\ORM\NonUniqueResultException
@@ -486,9 +486,9 @@  discard block
 block discarded – undo
486 486
     }
487 487
 
488 488
     /**
489
-     * @param $em
489
+     * @param \Doctrine\ORM\EntityManagerInterface $em
490 490
      *
491
-     * @return mixed
491
+     * @return null|Request
492 492
      *
493 493
      * @throws NoResultException
494 494
      * @throws \Doctrine\ORM\NonUniqueResultException
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Content/FileController.php 1 patch
Doc Comments   +13 added lines patch added patch discarded remove patch
@@ -278,6 +278,10 @@  discard block
 block discarded – undo
278 278
         return $paths;
279 279
     }
280 280
 
281
+    /**
282
+     * @param string $topDir
283
+     * @param Request $request
284
+     */
281 285
     private function getTree($topDir, $request)
282 286
     {
283 287
         $finder = Finder::create()->in($topDir)
@@ -314,6 +318,9 @@  discard block
 block discarded – undo
314 318
         return $tree;
315 319
     }
316 320
 
321
+    /**
322
+     * @param string $nowDir
323
+     */
317 324
     private function getFileList($nowDir)
318 325
     {
319 326
         $topDir = $this->getuserDataDir();
@@ -366,6 +373,9 @@  discard block
 block discarded – undo
366 373
         return str_replace('\\', '/', realpath($path));
367 374
     }
368 375
 
376
+    /**
377
+     * @param string $topDir
378
+     */
369 379
     protected function checkDir($targetDir, $topDir)
370 380
     {
371 381
         $targetDir = realpath($targetDir);
@@ -374,6 +384,9 @@  discard block
 block discarded – undo
374 384
         return strpos($targetDir, $topDir) === 0;
375 385
     }
376 386
 
387
+    /**
388
+     * @return string
389
+     */
377 390
     private function convertStrFromServer($target)
378 391
     {
379 392
         if ($this->encode == self::SJIS) {
Please login to merge, or discard this patch.