Completed
Pull Request — experimental/sf (#3426)
by k-yamamura
122:47 queued 115:15
created
src/Eccube/Twig/Extension/EccubeExtension.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
     /**
44 44
      * Returns a list of functions to add to the existing list.
45 45
      *
46
-     * @return array An array of functions
46
+     * @return TwigFunction[] An array of functions
47 47
      */
48 48
     public function getFunctions()
49 49
     {
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
     /**
68 68
      * Returns a list of filters.
69 69
      *
70
-     * @return array
70
+     * @return TwigFilter[]
71 71
      */
72 72
     public function getFilters()
73 73
     {
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
     /**
94 94
      * Name of this extension
95 95
      *
96
-     * @return string
96
+     * @return double
97 97
      */
98 98
     public function getCalcIncTax($price, $tax_rate, $tax_rule)
99 99
     {
Please login to merge, or discard this patch.
src/Eccube/Util/CacheUtil.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -41,6 +41,9 @@
 block discarded – undo
41 41
         $this->kernel = $kernel;
42 42
     }
43 43
 
44
+    /**
45
+     * @param string $env
46
+     */
44 47
     public function clearCache($env = null)
45 48
     {
46 49
         $console = new Application($this->kernel);
Please login to merge, or discard this patch.
src/Eccube/Util/StringUtil.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -121,7 +121,7 @@
 block discarded – undo
121 121
     /**
122 122
      * 文字コードの判定
123 123
      *
124
-     * @param $value
124
+     * @param string $value
125 125
      *
126 126
      * @return string
127 127
      */
Please login to merge, or discard this patch.
src/Eccube/Service/CartService.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -438,6 +438,9 @@
 block discarded – undo
438 438
         return $user;
439 439
     }
440 440
 
441
+    /**
442
+     * @param string $allocatedId
443
+     */
441 444
     protected function createCartKey($allocatedId, Customer $Customer = null)
442 445
     {
443 446
         if ($Customer instanceof Customer) {
Please login to merge, or discard this patch.
src/Eccube/Service/Composer/ComposerProcessService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -229,7 +229,7 @@
 block discarded – undo
229 229
     /**
230 230
      * Get mode
231 231
      *
232
-     * @return mixed|string
232
+     * @return string
233 233
      */
234 234
     public function getMode()
235 235
     {
Please login to merge, or discard this patch.
src/Eccube/Service/PluginService.php 1 patch
Doc Comments   +13 added lines, -7 removed lines patch added patch discarded remove patch
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
      * @param string $path   path to tar.gz/zip plugin file
148 148
      * @param int    $source
149 149
      *
150
-     * @return mixed
150
+     * @return boolean
151 151
      *
152 152
      * @throws PluginException
153 153
      * @throws \Exception
@@ -274,8 +274,8 @@  discard block
 block discarded – undo
274 274
     }
275 275
 
276 276
     /**
277
-     * @param $archive
278
-     * @param $dir
277
+     * @param string $archive
278
+     * @param string $dir
279 279
      *
280 280
      * @throws PluginException
281 281
      */
@@ -344,6 +344,9 @@  discard block
 block discarded – undo
344 344
         }
345 345
     }
346 346
 
347
+    /**
348
+     * @param string $yml
349
+     */
347 350
     public function readYml($yml)
348 351
     {
349 352
         if (file_exists($yml)) {
@@ -361,6 +364,9 @@  discard block
 block discarded – undo
361 364
         // ディレクトリ名などに使われれるので厳しめ
362 365
     }
363 366
 
367
+    /**
368
+     * @param string $path
369
+     */
364 370
     public function deleteFile($path)
365 371
     {
366 372
         $f = new Filesystem();
@@ -381,7 +387,7 @@  discard block
 block discarded – undo
381 387
     }
382 388
 
383 389
     /**
384
-     * @param $d
390
+     * @param string $d
385 391
      *
386 392
      * @throws PluginException
387 393
      */
@@ -456,7 +462,7 @@  discard block
 block discarded – undo
456 462
 
457 463
     /**
458 464
      * @param $meta
459
-     * @param $method
465
+     * @param string $method
460 466
      */
461 467
     public function callPluginManagerMethod($meta, $method)
462 468
     {
@@ -997,7 +1003,7 @@  discard block
 block discarded – undo
997 1003
      * [プラグインコード]/Resource/assets
998 1004
      * 配下に置かれているファイルが所定の位置へコピーされる
999 1005
      *
1000
-     * @param $pluginBaseDir
1006
+     * @param string $pluginBaseDir
1001 1007
      * @param $pluginCode
1002 1008
      */
1003 1009
     public function copyAssets($pluginBaseDir, $pluginCode)
@@ -1033,7 +1039,7 @@  discard block
 block discarded – undo
1033 1039
      * @param string $pluginVersion
1034 1040
      * @param string $remoteVersion
1035 1041
      *
1036
-     * @return mixed
1042
+     * @return boolean
1037 1043
      */
1038 1044
     public function isUpdate($pluginVersion, $remoteVersion)
1039 1045
     {
Please login to merge, or discard this patch.
src/Eccube/Command/PluginGenerateCommand.php 1 patch
Doc Comments   +21 added lines patch added patch discarded remove patch
@@ -147,6 +147,9 @@  discard block
 block discarded – undo
147 147
         return $version;
148 148
     }
149 149
 
150
+    /**
151
+     * @param string $pluginDir
152
+     */
150 153
     protected function createDirectories($pluginDir)
151 154
     {
152 155
         $dirs = [
@@ -165,6 +168,9 @@  discard block
 block discarded – undo
165 168
         }
166 169
     }
167 170
 
171
+    /**
172
+     * @param string $pluginDir
173
+     */
168 174
     protected function createConfig($pluginDir, $name, $code, $version)
169 175
     {
170 176
         $source = <<<EOL
@@ -176,12 +182,18 @@  discard block
 block discarded – undo
176 182
         $this->fs->dumpFile($pluginDir.'/config.yml', $source);
177 183
     }
178 184
 
185
+    /**
186
+     * @param string $pluginDir
187
+     */
179 188
     protected function createMessages($pluginDir)
180 189
     {
181 190
         $this->fs->dumpFile($pluginDir.'/Resource/locale/messages.ja.yaml', '');
182 191
         $this->fs->dumpFile($pluginDir.'/Resource/locale/validators.ja.yaml', '');
183 192
     }
184 193
 
194
+    /**
195
+     * @param string $pluginDir
196
+     */
185 197
     protected function createTwigBlock($pluginDir, $code)
186 198
     {
187 199
         $source = <<<EOL
@@ -206,6 +218,9 @@  discard block
 block discarded – undo
206 218
         $this->fs->dumpFile($pluginDir.'/TwigBlock.php', $source);
207 219
     }
208 220
 
221
+    /**
222
+     * @param string $pluginDir
223
+     */
209 224
     protected function createNav($pluginDir, $code)
210 225
     {
211 226
         $source = <<<EOL
@@ -230,6 +245,9 @@  discard block
 block discarded – undo
230 245
         $this->fs->dumpFile($pluginDir.'/Nav.php', $source);
231 246
     }
232 247
 
248
+    /**
249
+     * @param string $pluginDir
250
+     */
233 251
     protected function createEvent($pluginDir, $code)
234 252
     {
235 253
         $source = <<<EOL
@@ -254,6 +272,9 @@  discard block
 block discarded – undo
254 272
         $this->fs->dumpFile($pluginDir.'/Event.php', $source);
255 273
     }
256 274
 
275
+    /**
276
+     * @param string $pluginDir
277
+     */
257 278
     protected function createConfigController($pluginDir, $code)
258 279
     {
259 280
         $snakecased = Container::underscore($code);
Please login to merge, or discard this patch.
src/Eccube/DependencyInjection/EccubeExtension.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -96,6 +96,9 @@  discard block
 block discarded – undo
96 96
         $this->configureTranslations($container, $enabled, $pluginDir);
97 97
     }
98 98
 
99
+    /**
100
+     * @param string $pluginDir
101
+     */
99 102
     protected function configureTwigPaths(ContainerBuilder $container, $enabled, $pluginDir)
100 103
     {
101 104
         $paths = [];
@@ -114,6 +117,9 @@  discard block
 block discarded – undo
114 117
         }
115 118
     }
116 119
 
120
+    /**
121
+     * @param string $pluginDir
122
+     */
117 123
     protected function configureTranslations(ContainerBuilder $container, $enabled, $pluginDir)
118 124
     {
119 125
         $paths = [];
@@ -155,6 +161,9 @@  discard block
 block discarded – undo
155 161
         return empty($tables) ? false : true;
156 162
     }
157 163
 
164
+    /**
165
+     * @param string $pluginDir
166
+     */
158 167
     protected function getPluginDirectories($pluginDir)
159 168
     {
160 169
         $finder = (new Finder())
Please login to merge, or discard this patch.
src/Eccube/Service/PurchaseFlow/Processor/PointProcessor.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -179,7 +179,7 @@
 block discarded – undo
179 179
      * 明細追加処理.
180 180
      *
181 181
      * @param ItemHolderInterface $itemHolder
182
-     * @param $discount
182
+     * @param integer $discount
183 183
      */
184 184
     private function addPointDiscountItem(ItemHolderInterface $itemHolder, $discount)
185 185
     {
Please login to merge, or discard this patch.