EC-CUBE / ec-cube

codeception/acceptance/EF06OtherCest.php

Unused Use Statements -1 removed lines

@@ -1,7 +1,6 @@
 <?php
 
 use Codeception\Util\Fixtures;
-use Eccube\Entity\Master\CustomerStatus;
 
 /**
  * @group front

src/Eccube/Controller/AbstractController.php

Doc Comments +4 added lines, -1 removed lines

@@ -153,6 +153,9 @@ 
         $this->addWarning('admin.delete.warning', 'admin');
     }
 
+    /**
+     * @param string $targetPath
+     */
     public function setLoginTargetPath($targetPath, $namespace = null)
     {
         if (is_null($namespace)) {
@@ -169,7 +172,7 @@ 
      * @param array  $path An array of path parameters
      * @param array  $query An array of query parameters
      *
-     * @return Response A Response instance
+     * @return \Symfony\Component\HttpFoundation\Response A Response instance
      */
     public function forwardToRoute($route, array $path = [], array $query = [])
     {

src/Eccube/Controller/Admin/AdminController.php

Doc Comments +14 added lines, -14 removed lines

@@ -334,10 +334,10 @@ 
     }
 
     /**
-     * @param $em
+     * @param \Doctrine\ORM\EntityManagerInterface $em
      * @param array $excludes
      *
-     * @return array
+     * @return null|Request
      */
     protected function findOrderStatus($em, array $excludes)
     {
@@ -354,10 +354,10 @@ 
     }
 
     /**
-     * @param $em
+     * @param \Doctrine\ORM\EntityManagerInterface $em
      * @param array $excludes
      *
-     * @return array
+     * @return null|Request
      */
     protected function getOrderEachStatus($em, array $excludes)
     {
@@ -387,11 +387,11 @@ 
     }
 
     /**
-     * @param $em
-     * @param $dateTime
+     * @param \Doctrine\ORM\EntityManagerInterface $em
+     * @param \DateTime $dateTime
      * @param array $excludes
      *
-     * @return array
+     * @return null|Request
      */
     protected function getSalesByMonth($em, $dateTime, array $excludes)
     {
@@ -425,11 +425,11 @@ 
     }
 
     /**
-     * @param $em
-     * @param $dateTime
+     * @param \Doctrine\ORM\EntityManagerInterface $em
+     * @param \DateTime $dateTime
      * @param array $excludes
      *
-     * @return array
+     * @return null|Request
      */
     protected function getSalesByDay($em, $dateTime, array $excludes)
     {
@@ -463,9 +463,9 @@ 
     }
 
     /**
-     * @param $em
+     * @param \Doctrine\ORM\EntityManagerInterface $em
      *
-     * @return mixed
+     * @return null|Request
      *
      * @throws NoResultException
      * @throws \Doctrine\ORM\NonUniqueResultException
@@ -486,9 +486,9 @@ 
     }
 
     /**
-     * @param $em
+     * @param \Doctrine\ORM\EntityManagerInterface $em
      *
-     * @return mixed
+     * @return null|Request
      *
      * @throws NoResultException
      * @throws \Doctrine\ORM\NonUniqueResultException

src/Eccube/Controller/Admin/Content/FileController.php

Doc Comments +13 added lines

@@ -278,6 +278,10 @@ 
         return $paths;
     }
 
+    /**
+     * @param string $topDir
+     * @param Request $request
+     */
     private function getTree($topDir, $request)
     {
         $finder = Finder::create()->in($topDir)
@@ -314,6 +318,9 @@ 
         return $tree;
     }
 
+    /**
+     * @param string $nowDir
+     */
     private function getFileList($nowDir)
     {
         $topDir = $this->getuserDataDir();
@@ -366,6 +373,9 @@ 
         return str_replace('\\', '/', realpath($path));
     }
 
+    /**
+     * @param string $topDir
+     */
     protected function checkDir($targetDir, $topDir)
     {
         $targetDir = realpath($targetDir);
@@ -374,6 +384,9 @@ 
         return strpos($targetDir, $topDir) === 0;
     }
 
+    /**
+     * @return string
+     */
     private function convertStrFromServer($target)
     {
         if ($this->encode == self::SJIS) {

src/Eccube/Controller/Admin/Customer/CustomerController.php

Doc Comments -1 removed lines

@@ -273,7 +273,6 @@
      *
      * @Route("/%eccube_admin_route%/customer/export", name="admin_customer_export")
      *
-     * @param Application $app
      * @param Request $request
      *
      * @return StreamedResponse

src/Eccube/Controller/Admin/Product/CsvImportController.php

Doc Comments +4 added lines, -3 removed lines

@@ -784,6 +784,7 @@ 
      *
      * @param $row
      * @param Product $Product
+     * @param CsvImportService $data
      */
     protected function createProductImage($row, Product $Product, $data, $headerByKey)
     {
@@ -830,7 +831,7 @@ 
      *
      * @param $row
      * @param Product $Product
-     * @param $data
+     * @param CsvImportService $data
      * @param $headerByKey
      */
     protected function createProductCategory($row, Product $Product, $data, $headerByKey)
@@ -950,7 +951,7 @@ 
      *
      * @param $row
      * @param Product $Product
-     * @param $data
+     * @param CsvImportService $data
      * @param $headerByKey
      * @param null $ClassCategory1
      * @param null $ClassCategory2
@@ -1102,7 +1103,7 @@ 
      * @param $row
      * @param Product $Product
      * @param ProductClass $ProductClass
-     * @param $data
+     * @param CsvImportService $data
      *
      * @return ProductClass
      */

src/Eccube/Controller/Admin/Product/ProductController.php

Doc Comments +1 added lines

@@ -976,6 +976,7 @@
      *
      * @param \Eccube\Entity\Product $Product
      * @param \Eccube\Entity\Category $Category
+     * @param integer $count
      *
      * @return \Eccube\Entity\ProductCategory
      */

src/Eccube/Controller/Admin/Product/TagController.php

Doc Comments -1 removed lines

@@ -43,7 +43,6 @@
      * @Template("@admin/Product/tag.twig")
      *
      * @param Request $request
-     * @param Tag|null $Tag
      *
      * @return array|\Symfony\Component\HttpFoundation\RedirectResponse
      */

src/Eccube/Controller/Admin/Setting/System/LogController.php

Doc Comments +1 added lines, -1 removed lines

@@ -76,7 +76,7 @@
     /**
      * parse log file
      *
-     * @param $logFile
+     * @param string $logFile
      * @param $formData
      *
      * @return array