EC-CUBE / ec-cube

codeception/acceptance/ZZ99PluginUninstallerCest.php

Unused Use Statements -1 removed lines

@@ -1,6 +1,5 @@
 <?php
 
-use Codeception\Util\Fixtures;
 use Page\Admin\OwnersPluginPage;
 
 /**

src/Eccube/Service/CartService.php

Doc Comments +3 added lines

@@ -438,6 +438,9 @@
         return $user;
     }
 
+    /**
+     * @param string $allocatedId
+     */
     protected function createCartKey($allocatedId, Customer $Customer = null)
     {
         if ($Customer instanceof Customer) {

src/Eccube/Service/Composer/ComposerProcessService.php

Doc Comments +1 added lines, -1 removed lines

@@ -229,7 +229,7 @@
     /**
      * Get mode
      *
-     * @return mixed|string
+     * @return string
      */
     public function getMode()
     {

src/Eccube/Service/PluginService.php

Doc Comments +13 added lines, -7 removed lines

@@ -147,7 +147,7 @@ 
      * @param string $path   path to tar.gz/zip plugin file
      * @param int    $source
      *
-     * @return mixed
+     * @return boolean
      *
      * @throws PluginException
      * @throws \Exception
@@ -274,8 +274,8 @@ 
     }
 
     /**
-     * @param $archive
-     * @param $dir
+     * @param string $archive
+     * @param string $dir
      *
      * @throws PluginException
      */
@@ -344,6 +344,9 @@ 
         }
     }
 
+    /**
+     * @param string $yml
+     */
     public function readYml($yml)
     {
         if (file_exists($yml)) {
@@ -361,6 +364,9 @@ 
         // ディレクトリ名などに使われれるので厳しめ
     }
 
+    /**
+     * @param string $path
+     */
     public function deleteFile($path)
     {
         $f = new Filesystem();
@@ -381,7 +387,7 @@ 
     }
 
     /**
-     * @param $d
+     * @param string $d
      *
      * @throws PluginException
      */
@@ -456,7 +462,7 @@ 
 
     /**
      * @param $meta
-     * @param $method
+     * @param string $method
      */
     public function callPluginManagerMethod($meta, $method)
     {
@@ -997,7 +1003,7 @@ 
      * [プラグインコード]/Resource/assets
      * 配下に置かれているファイルが所定の位置へコピーされる
      *
-     * @param $pluginBaseDir
+     * @param string $pluginBaseDir
      * @param $pluginCode
      */
     public function copyAssets($pluginBaseDir, $pluginCode)
@@ -1033,7 +1039,7 @@ 
      * @param string $pluginVersion
      * @param string $remoteVersion
      *
-     * @return mixed
+     * @return boolean
      */
     public function isUpdate($pluginVersion, $remoteVersion)
     {

src/Eccube/Command/PluginGenerateCommand.php

Doc Comments +21 added lines

@@ -147,6 +147,9 @@ 
         return $version;
     }
 
+    /**
+     * @param string $pluginDir
+     */
     protected function createDirectories($pluginDir)
     {
         $dirs = [
@@ -165,6 +168,9 @@ 
         }
     }
 
+    /**
+     * @param string $pluginDir
+     */
     protected function createConfig($pluginDir, $name, $code, $version)
     {
         $source = <<<EOL
@@ -176,12 +182,18 @@ 
         $this->fs->dumpFile($pluginDir.'/config.yml', $source);
     }
 
+    /**
+     * @param string $pluginDir
+     */
     protected function createMessages($pluginDir)
     {
         $this->fs->dumpFile($pluginDir.'/Resource/locale/messages.ja.yaml', '');
         $this->fs->dumpFile($pluginDir.'/Resource/locale/validators.ja.yaml', '');
     }
 
+    /**
+     * @param string $pluginDir
+     */
     protected function createTwigBlock($pluginDir, $code)
     {
         $source = <<<EOL
@@ -206,6 +218,9 @@ 
         $this->fs->dumpFile($pluginDir.'/TwigBlock.php', $source);
     }
 
+    /**
+     * @param string $pluginDir
+     */
     protected function createNav($pluginDir, $code)
     {
         $source = <<<EOL
@@ -230,6 +245,9 @@ 
         $this->fs->dumpFile($pluginDir.'/Nav.php', $source);
     }
 
+    /**
+     * @param string $pluginDir
+     */
     protected function createEvent($pluginDir, $code)
     {
         $source = <<<EOL
@@ -254,6 +272,9 @@ 
         $this->fs->dumpFile($pluginDir.'/Event.php', $source);
     }
 
+    /**
+     * @param string $pluginDir
+     */
     protected function createConfigController($pluginDir, $code)
     {
         $snakecased = Container::underscore($code);

src/Eccube/DependencyInjection/EccubeExtension.php

Doc Comments +9 added lines

@@ -96,6 +96,9 @@ 
         $this->configureTranslations($container, $enabled, $pluginDir);
     }
 
+    /**
+     * @param string $pluginDir
+     */
     protected function configureTwigPaths(ContainerBuilder $container, $enabled, $pluginDir)
     {
         $paths = [];
@@ -114,6 +117,9 @@ 
         }
     }
 
+    /**
+     * @param string $pluginDir
+     */
     protected function configureTranslations(ContainerBuilder $container, $enabled, $pluginDir)
     {
         $paths = [];
@@ -155,6 +161,9 @@ 
         return empty($tables) ? false : true;
     }
 
+    /**
+     * @param string $pluginDir
+     */
     protected function getPluginDirectories($pluginDir)
     {
         $finder = (new Finder())

src/Eccube/Service/PurchaseFlow/Processor/PointProcessor.php

Doc Comments +1 added lines, -1 removed lines

@@ -179,7 +179,7 @@
      * 明細追加処理.
      *
      * @param ItemHolderInterface $itemHolder
-     * @param $discount
+     * @param integer $discount
      */
     private function addPointDiscountItem(ItemHolderInterface $itemHolder, $discount)
     {

codeception/_support/Page/Admin/ShippingCsvUploadPage.php

Doc Comments +3 added lines

@@ -33,6 +33,9 @@
         parent::__construct($I);
     }
 
+    /**
+     * @param \AcceptanceTester $I
+     */
     public static function go($I)
     {
         $page = new ProductCsvUploadPage($I);

codeception/_support/Page/Admin/ShippingManagePage.php

Doc Comments +18 added lines

@@ -45,12 +45,18 @@ 
         return $this;
     }
 
+    /**
+     * @param string $value
+     */
     public function 入力_ご注文者お名前($value)
     {
         $this->tester->fillField(['id' => 'admin_search_shipping_order_name'], $value);
         return $this;
     }
 
+    /**
+     * @param string $value
+     */
     public function 入力_ご注文者お名前フリガナ($value)
     {
         $this->tester->fillField(['id' => 'admin_search_shipping_order_kana'], $value);
@@ -78,6 +84,9 @@ 
         return $this;
     }
 
+    /**
+     * @param integer $rowNum
+     */
     public function 一覧_編集($rowNum)
     {
         $this->tester->click(['xpath' => "//*[@id='form_bulk']/div[2]/div/table/tbody/tr[${rowNum}]/td[2]/a"]);
@@ -137,16 +146,25 @@ 
         $this->tester->click('#form_bulk #btn_bulk_mail');
     }
 
+    /**
+     * @param integer $rowNum
+     */
     public function 一覧_チェックボックス($rowNum)
     {
         $this->tester->click(['xpath' => "//*[@id='form_bulk']/div[2]/div/table/tbody/tr[${rowNum}]/td[1]/input"]);
     }
 
+    /**
+     * @param integer $rowNum
+     */
     public function 取得_出荷伝票番号($rowNum)
     {
         return $this->tester->grabTextFrom("#form_bulk table > tbody > tr:nth-child(${rowNum}) > td:nth-child(3)");
     }
 
+    /**
+     * @param integer $rowNum
+     */
     public function 取得_出荷日($rowNum)
     {
         return $this->tester->grabTextFrom("#form_bulk table > tbody > tr:nth-child(${rowNum}) > td:nth-child(7)");