EC-CUBE /
ec-cube
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 27 | class CustomerAddressEditPage extends AbstractFrontPage |
||
| 28 | { |
||
| 29 | public function __construct(\AcceptanceTester $I) |
||
| 30 | { |
||
| 31 | parent::__construct($I); |
||
| 32 | } |
||
| 33 | |||
| 34 | public static function at($I) |
||
| 35 | { |
||
| 36 | $page = new self($I); |
||
| 37 | $page->tester->see('マイページ/お届け先一覧', 'div.ec-pageHeader h1'); |
||
| 38 | return $page; |
||
| 39 | } |
||
| 40 | |||
| 41 | public function 入力_姓($value) |
||
| 42 | { |
||
| 43 | $this->tester->fillField(['id' => 'customer_address_name_name01'], $value); |
||
| 44 | return $this; |
||
| 45 | } |
||
| 46 | |||
| 47 | public function 入力_名($value) |
||
| 48 | { |
||
| 49 | $this->tester->fillField(['id' => 'customer_address_name_name02'], $value); |
||
| 50 | return $this; |
||
| 51 | } |
||
| 52 | |||
| 53 | public function 入力_セイ($value) |
||
| 54 | { |
||
| 55 | $this->tester->fillField(['id' => 'customer_address_kana_kana01'], $value); |
||
| 56 | return $this; |
||
| 57 | } |
||
| 58 | |||
| 59 | public function 入力_メイ($value) |
||
| 60 | { |
||
| 61 | $this->tester->fillField(['id' => 'customer_address_kana_kana02'], $value); |
||
| 62 | return $this; |
||
| 63 | } |
||
| 64 | |||
| 65 | public function 入力_郵便番号($value) |
||
| 66 | { |
||
| 67 | $this->tester->fillField(['id' => 'customer_address_postal_code'], $value); |
||
| 68 | |||
| 69 | return $this; |
||
| 70 | } |
||
| 71 | |||
| 72 | public function 入力_都道府県($value) |
||
| 73 | { |
||
| 74 | $this->tester->selectOption(['id' => 'customer_address_address_pref'], $value); |
||
| 75 | return $this; |
||
| 76 | } |
||
| 77 | |||
| 78 | public function 入力_市区町村名($value) |
||
| 79 | { |
||
| 80 | $this->tester->fillField(['id' => 'customer_address_address_addr01'], $value); |
||
| 81 | return $this; |
||
| 82 | } |
||
| 83 | |||
| 84 | public function 入力_番地_ビル名($value) |
||
| 85 | { |
||
| 86 | $this->tester->fillField(['id' => 'customer_address_address_addr02'], $value); |
||
| 87 | return $this; |
||
| 88 | } |
||
| 89 | |||
| 90 | public function 入力_電話番号($value) |
||
| 91 | { |
||
| 92 | $this->tester->fillField(['id' => 'customer_address_phone_number'], $value); |
||
| 93 | |||
| 94 | return $this; |
||
| 95 | } |
||
| 96 | |||
| 97 | public function 登録する() |
||
| 98 | { |
||
| 99 | $this->tester->click('div.ec-RegisterRole__actions button'); |
||
| 100 | } |
||
| 101 | } |
||
| 102 |
