Failed Conditions
Pull Request — 4.0 (#4528)
by Kentaro
07:39
created

LoggerFacade   A

Complexity

Total Complexity 6

Size/Duplication

Total Lines 56
Duplicated Lines 100 %

Coupling/Cohesion

Components 1
Dependencies 0

Importance

Changes 0
Metric Value
dl 56
loc 56
rs 10
c 0
b 0
f 0
wmc 6
lcom 1
cbo 0

4 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 5 5 1
A init() 8 8 2
A create() 8 8 2
A getContainer() 4 4 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace Eccube\DependencyInjection\Facade;
4
5
use Eccube\Log\Logger;
6
use Symfony\Component\DependencyInjection\ContainerInterface;
7
8
/**
9
 * XXX ContainerInterface は不要かも
10
 */
11 View Code Duplication
class LoggerFacade
0 ignored issues
show
Coding Style introduced by
Since you have declared the constructor as private, maybe you should also declare the class as final.
Loading history...
Duplication introduced by
This class seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
12
{
13
    /** @var self|null */
14
    private static $instance = null;
15
16
    /** @var ContainerInterface */
17
    private static $Container;
18
19
    /** @var Logger */
20
    private static $Logger;
21
22
    /**
23
     * @param ContainerInterface $container
24
     */
25
    private function __construct(ContainerInterface $container, Logger $Logger)
26
    {
27
        self::$Container = $container;
28
        self::$Logger = $Logger;
29
    }
30
31
    /**
32
     * @param ContainerInterface $container
33
     *
34
     * @return null|LoggerFacade
35
     */
36
    public static function init(ContainerInterface $container, Logger $Logger)
37
    {
38
        if (null === self::$instance) {
39
            self::$instance = new self($container, $Logger);
40
        }
41
42
        return self::$instance;
43
    }
44
45
    /**
46
     * @return Logger
47
     * @throws \Exception
48
     */
49
    public static function create()
50
    {
51
        if (null === self::$instance) {
52
            throw new \Exception("Facade is not instantiated");
53
        }
54
55
        return self::$Logger;
56
    }
57
58
    /**
59
     * @deprecated
60
     * @return ContainerInterface
61
     */
62
    public static function getContainer()
63
    {
64
        return self::$Container;
65
    }
66
}
67