It seems like $finder->getIterator() targeting Symfony\Component\Finder\Finder::getIterator() can also be of type array<integer,object<Sym...nt\Finder\SplFileInfo>>; however, Eccube\Doctrine\Common\C...der::loadFromIterator() does only seem to accept object<Iterator>, maybe add an additional type check?
This check looks at variables that are passed out again to other methods.
If the outgoing method call has stricter type requirements than the method itself, an issue is raised.
An additional type check may prevent trouble.
Loading history...
86
}
87
88
/**
89
* Load fixtures from Iterator.
90
*
91
* @param \Iterator $Iterator Iterator of \SplFileInfo
92
*
93
* @return array fixtures.
94
*/
95
2
public function loadFromIterator(\Iterator $Iterator)
96
{
97
2
$fixtures = [];
98
2
foreach ($Iterator as $fixture) {
99
// TODO $fixture が \SplFileInfo ではない場合の対応
100
2
$CsvFixture = new CsvFixture($fixture->openFile());
101
2
$this->addFixture($CsvFixture);
102
2
$fixtures[] = $CsvFixture;
103
}
104
105
2
return $fixtures;
106
}
107
108
1
public function getFixtures()
109
{
110
1
return $this->fixtures;
111
}
112
113
3
public function addFixture(FixtureInterface $fixture)
EC-CUBE /
ec-cube
Kentaro Ohkouchi
This check looks at variables that are passed out again to other methods.
If the outgoing method call has stricter type requirements than the method itself, an issue is raised.
An additional type check may prevent trouble.