Issues in PluginCommandTrait.php - All Issues - Inspection of "Merge pull request #4285 from lqdung1992/fix-doctr..." - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 4.0 ( 268f2c...88f012 )

by Hideki

created 2019-10-28 11:59 UTC

src/Eccube/Command/PluginCommandTrait.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) EC-CUBE CO.,LTD. All Rights Reserved.
 *
 * http://www.ec-cube.co.jp/
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Eccube\Command;

use Eccube\Repository\PluginRepository;
use Eccube\Service\PluginService;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Style\SymfonyStyle;

trait PluginCommandTrait
{
    /**
     * @var PluginService
     */
    protected $pluginService;

    /**
     * @var PluginRepository
     */
    protected $pluginRepository;

    /**
     * @param PluginService $pluginService
     * @required
     */
    public function setPluginService(PluginService $pluginService)
    {
        $this->pluginService = $pluginService;
    }

    /**
     * @param PluginRepository $pluginRepository
     * @required
     */
    public function setPluginRepository(PluginRepository $pluginRepository)
    {
        $this->pluginRepository = $pluginRepository;
    }

    protected function clearCache(SymfonyStyle $io)
    {
        try {
            /* @var Command $command */
            $command = $this->getApplication()->get('cache:clear');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $command->run(new ArrayInput([
                'command' => 'cache:clear',
                '--no-warmup' => true,
            ]), $io);
        } catch (\Exception $e) {
            $io->error($e->getMessage());
        }
    }
}


1			<?php
2
3			/*
4			* This file is part of EC-CUBE
5			*
6			* Copyright(c) EC-CUBE CO.,LTD. All Rights Reserved.
7			*
8			* http://www.ec-cube.co.jp/
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Eccube\Command;
15
16			use Eccube\Repository\PluginRepository;
17			use Eccube\Service\PluginService;
18			use Symfony\Component\Console\Command\Command;
19			use Symfony\Component\Console\Input\ArrayInput;
20			use Symfony\Component\Console\Style\SymfonyStyle;
21
22			trait PluginCommandTrait
23			{
24			/**
25			* @var PluginService
26			*/
27			protected $pluginService;
28
29			/**
30			* @var PluginRepository
31			*/
32			protected $pluginRepository;
33
34			/**
35			* @param PluginService $pluginService
36			* @required
37			*/
38			public function setPluginService(PluginService $pluginService)
39			{
40			$this->pluginService = $pluginService;
41			}
42
43			/**
44			* @param PluginRepository $pluginRepository
45			* @required
46			*/
47			public function setPluginRepository(PluginRepository $pluginRepository)
48			{
49			$this->pluginRepository = $pluginRepository;
50			}
51
52			protected function clearCache(SymfonyStyle $io)
53			{
54			try {
55			/* @var Command $command */
56			$command = $this->getApplication()->get('cache:clear');
			0 ignored issues – show Bug introduced 2018-06-08 04:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `getApplication()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
57			$command->run(new ArrayInput([
58			'command' => 'cache:clear',
59			'--no-warmup' => true,
60			]), $io);
61			} catch (\Exception $e) {
62			$io->error($e->getMessage());
63			}
64			}
65			}
66

EC-CUBE / ec-cube

Push — 4.0 ( 268f2c...88f012 )

src/Eccube/Command/PluginCommandTrait.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like