Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 9 | class PurchaseFlow |
||
|
|
|||
| 10 | { |
||
| 11 | /** |
||
| 12 | * @var ArrayCollection|ItemHolderProcessor[] |
||
| 13 | */ |
||
| 14 | protected $itemHolderProcessors; |
||
| 15 | |||
| 16 | /** |
||
| 17 | * @var ArrayCollection|ItemProcessor[] |
||
| 18 | */ |
||
| 19 | protected $itemProcessors; |
||
| 20 | |||
| 21 | /** |
||
| 22 | * @var ArrayCollection|PurchaseProcessor[] |
||
| 23 | */ |
||
| 24 | protected $purchaseProcessors; |
||
| 25 | |||
| 26 | public function __construct() |
||
| 32 | |||
| 33 | public function setItemProcessors(ArrayCollection $processors) |
||
| 37 | |||
| 38 | public function setItemHolderProcessors(ArrayCollection $processors) |
||
| 42 | |||
| 43 | public function setPurchaseProcessors(ArrayCollection $processors) |
||
| 47 | |||
| 48 | public function calculate(ItemHolderInterface $itemHolder, PurchaseContext $context) |
||
| 72 | |||
| 73 | /** |
||
| 74 | * @param ItemHolderInterface $target |
||
| 75 | * @param PurchaseContext $context |
||
| 76 | * |
||
| 77 | * @throws PurchaseException |
||
| 78 | */ |
||
| 79 | public function purchase(ItemHolderInterface $target, PurchaseContext $context) |
||
| 85 | |||
| 86 | public function addPurchaseProcessor(PurchaseProcessor $processor) |
||
| 90 | |||
| 91 | public function addItemHolderProcessor(ItemHolderProcessor $prosessor) |
||
| 95 | |||
| 96 | public function addItemProcessor(ItemProcessor $prosessor) |
||
| 100 | |||
| 101 | /** |
||
| 102 | * @param ItemHolderInterface $itemHolder |
||
| 103 | */ |
||
| 104 | protected function calculateTotal(ItemHolderInterface $itemHolder) |
||
| 118 | |||
| 119 | View Code Duplication | protected function calculateSubTotal(ItemHolderInterface $itemHolder) |
|
| 134 | |||
| 135 | /** |
||
| 136 | * @param ItemHolderInterface $itemHolder |
||
| 137 | */ |
||
| 138 | View Code Duplication | protected function calculateDeliveryFeeTotal(ItemHolderInterface $itemHolder) |
|
| 149 | |||
| 150 | /** |
||
| 151 | * @param ItemHolderInterface $itemHolder |
||
| 152 | */ |
||
| 153 | View Code Duplication | protected function calculateDiscount(ItemHolderInterface $itemHolder) |
|
| 165 | |||
| 166 | /** |
||
| 167 | * @param ItemHolderInterface $itemHolder |
||
| 168 | */ |
||
| 169 | View Code Duplication | protected function calculateCharge(ItemHolderInterface $itemHolder) |
|
| 180 | |||
| 181 | /** |
||
| 182 | * @param ItemHolderInterface $itemHolder |
||
| 183 | */ |
||
| 184 | View Code Duplication | protected function calculateTax(ItemHolderInterface $itemHolder) |
|
| 194 | |||
| 195 | /** |
||
| 196 | * @param ItemHolderInterface $itemHolder |
||
| 197 | */ |
||
| 198 | protected function calculateAll(ItemHolderInterface $itemHolder) |
||
| 207 | } |
||
| 208 |