Completed
Pull Request — experimental/3.1 (#2655)
by chihiro
89:30
created
src/Eccube/DI/AutoWiring/RepositoryAutoWiring.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
 {
31 31
     /**
32 32
      * RepositoryAutoWiring constructor.
33
-     * @param array|string[] $scanDirs
33
+     * @param string[] $scanDirs
34 34
      */
35 35
     public function __construct($scanDirs)
36 36
     {
Please login to merge, or discard this patch.
src/Eccube/Service/EntityProxyService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -194,7 +194,7 @@
 block discarded – undo
194 194
 
195 195
     /**
196 196
      * EntityからTraitを削除.
197
-     * @param $entityTokens Tokens Entityのトークン
197
+     * @param Tokens $entityTokens Tokens Entityのトークン
198 198
      * @param $trait string 削除するTraitのFQCN
199 199
      */
200 200
     private function removeTrait($entityTokens, $trait)
Please login to merge, or discard this patch.
src/Eccube/ServiceProvider/QueriesServiceProvider.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,6 @@
 block discarded – undo
16 16
      * This method should only be used to configure services and parameters.
17 17
      * It should not get services.
18 18
      *
19
-     * @param Container $pimple A container instance
20 19
      */
21 20
     public function register(Container $app)
22 21
     {
Please login to merge, or discard this patch.
src/Eccube/DI/AutoWiring/RepositoryDefinition.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -32,9 +32,9 @@
 block discarded – undo
32 32
 
33 33
     /**
34 34
      * RepositoryDefinition constructor.
35
-     * @param $id
36
-     * @param $refClass
37
-     * @param $entityClass
35
+     * @param string $id
36
+     * @param \ReflectionClass $refClass
37
+     * @param string $entityClass
38 38
      */
39 39
     public function __construct($id, $refClass, $entityClass)
40 40
     {
Please login to merge, or discard this patch.
src/Eccube/Service/Composer/OutputParser.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -127,7 +127,7 @@
 block discarded – undo
127 127
 
128 128
     /**
129 129
      * @param $rowArray
130
-     * @param $key
130
+     * @param string $key
131 131
      * @return array
132 132
      */
133 133
     private static function parseArrayInfoOutput($rowArray, $key)
Please login to merge, or discard this patch.
src/Eccube/Repository/DeliveryRepository.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@
 block discarded – undo
42 42
 
43 43
     /**
44 44
      * @deprecated 呼び出し元で制御する
45
-     * @param $id
45
+     * @param integer $id
46 46
      * @return Delivery|null|object
47 47
      */
48 48
     public function findOrCreate($id)
Please login to merge, or discard this patch.
src/Eccube/Service/PluginService.php 1 patch
Doc Comments   +21 added lines, -1 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
      *
115 115
      * @param string $path   path to tar.gz/zip plugin file
116 116
      * @param int    $source
117
-     * @return mixed
117
+     * @return boolean
118 118
      * @throws PluginException
119 119
      * @throws \Exception
120 120
      */
@@ -177,6 +177,10 @@  discard block
 block discarded – undo
177 177
     }
178 178
 
179 179
     // インストール事後処理
180
+
181
+    /**
182
+     * @param integer $source
183
+     */
180 184
     public function postInstall($config, $event, $source)
181 185
     {
182 186
         // Proxyのクラスをロードせずにスキーマを更新するために、
@@ -223,6 +227,10 @@  discard block
 block discarded – undo
223 227
         }
224 228
     }
225 229
 
230
+    /**
231
+     * @param string $archive
232
+     * @param string $dir
233
+     */
226 234
     public function unpackPluginArchive($archive, $dir)
227 235
     {
228 236
         $extension = pathinfo($archive, PATHINFO_EXTENSION);
@@ -282,6 +290,9 @@  discard block
 block discarded – undo
282 290
         }
283 291
     }
284 292
 
293
+    /**
294
+     * @param string $yml
295
+     */
285 296
     public function readYml($yml)
286 297
     {
287 298
         if (file_exists($yml)) {
@@ -299,6 +310,9 @@  discard block
 block discarded – undo
299 310
         // ディレクトリ名などに使われれるので厳しめ
300 311
     }
301 312
 
313
+    /**
314
+     * @param string $path
315
+     */
302 316
     public function deleteFile($path)
303 317
     {
304 318
         $f = new Filesystem();
@@ -318,6 +332,9 @@  discard block
 block discarded – undo
318 332
         return $this->appConfig['plugin_realdir'].'/'.$name;
319 333
     }
320 334
 
335
+    /**
336
+     * @param string $d
337
+     */
321 338
     public function createPluginDir($d)
322 339
     {
323 340
         $b = @mkdir($d);
@@ -375,6 +392,9 @@  discard block
 block discarded – undo
375 392
         return $p;
376 393
     }
377 394
 
395
+    /**
396
+     * @param string $method
397
+     */
378 398
     public function callPluginManagerMethod($meta, $method)
379 399
     {
380 400
         $class = '\\Plugin'.'\\'.$meta['code'].'\\'.'PluginManager';
Please login to merge, or discard this patch.