PurchaseFlowServiceProvider::register() - Code Metrics - Inspection of "[WIP] ポイント機能の実装" - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — experimental/3.1 (#2624)

by Kentaro

created 2017-11-17 10:04 UTC

PurchaseFlowServiceProvider::register() B

↳ Parent: PurchaseFlowServiceProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines	102
Code Lines	68

Duplication

Lines	36
Ratio	35.29 %

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
cc	1
eloc	68
nc	1
nop	1
dl	36
loc	102
rs	8.2857
c	4
b	0
f	0

How to fix Long Method

<?php

namespace Eccube\ServiceProvider;

use Doctrine\Common\Collections\ArrayCollection;
use Eccube\Entity\BaseInfo;
use Eccube\Entity\Customer;
use Eccube\Entity\ItemHolderInterface;
use Eccube\Repository\DeliveryRepository;
use Eccube\Service\PurchaseFlow\Processor as Processor;
use Eccube\Service\PurchaseFlow\PurchaseContext;
use Eccube\Service\PurchaseFlow\PurchaseFlow;
use Pimple\Container;
use Pimple\ServiceProviderInterface;

class PurchaseFlowServiceProvider implements ServiceProviderInterface

{
    public function register(Container $app)

    {
        $app['eccube.purchase.context'] = $app->protect(function (ItemHolderInterface $origin = null, Customer $user = null) {
            return new PurchaseContext($origin, $user);
        });

        $app['eccube.purchase.flow.cart.item_processors'] = function (Container $app) {
            $processors = new ArrayCollection();
            $processors[] = new Processor\DisplayStatusValidator();
            $processors[] = new Processor\SaleLimitValidator();
            $processors[] = new Processor\DeliverySettingValidator($app[DeliveryRepository::class]);
            $processors[] = new Processor\StockValidator();

            return $processors;
        };

        $app['eccube.purchase.flow.cart.holder_processors'] = function (Container $app) {
            $processors = new ArrayCollection();
            $processors[] = new Processor\PaymentProcessor($app[DeliveryRepository::class]);
            $processors[] = new Processor\PaymentTotalLimitValidator($app['config']['max_total_fee']);
            $processors[] = new Processor\DeliveryFeeFreeProcessor($app[BaseInfo::class]);
            $processors[] = new Processor\PaymentTotalNegativeValidator();

            return $processors;
        };

        $app['eccube.purchase.flow.cart'] = function (Container $app) {
            $flow = new PurchaseFlow();
            $flow->setItemProcessors($app['eccube.purchase.flow.cart.item_processors']);
            $flow->setItemHolderProcessors($app['eccube.purchase.flow.cart.holder_processors']);

            return $flow;
        };

        $app['eccube.purchase.flow.shopping.item_processors'] = function (Container $app) {

            $processors = new ArrayCollection();
            $processors[] = new Processor\StockValidator();
            $processors[] = new Processor\DisplayStatusValidator();

            return $processors;
        };

        $app['eccube.purchase.flow.shopping.holder_processors'] = function (Container $app) {
            $processors = new ArrayCollection();
            $processors[] = new Processor\PaymentTotalLimitValidator($app['config']['max_total_fee']);
            $processors[] = new Processor\DeliveryFeeProcessor($app['orm.em']);
            $processors[] = new Processor\PaymentTotalNegativeValidator();
            $processors[] = new Processor\UsePointProcessor($app['orm.em'], $app[BaseInfo::class]);
            $processors[] = new Processor\AddPointProcessor($app['orm.em'], $app[BaseInfo::class]);
            $processors[] = new Processor\SubstractPointProcessor($app[BaseInfo::class]);
            return $processors;

        };

        $app['eccube.purchase.flow.shopping.purchase'] = function (Container $app) {

            $processors = new ArrayCollection();
            $processors[] = new Processor\UsePointToCustomerPurchaseProcessor();
            return $processors;

        };

        $app['eccube.purchase.flow.shopping'] = function (Container $app) {
            $flow = new PurchaseFlow();
            $flow->setItemProcessors($app['eccube.purchase.flow.shopping.item_processors']);
            $flow->setItemHolderProcessors($app['eccube.purchase.flow.shopping.holder_processors']);
            $flow->setPurchaseProcessors($app['eccube.purchase.flow.shopping.purchase']);

            return $flow;
        };

        $app['eccube.purchase.flow.order.item_processors'] = function (Container $app) {

            $processors = new ArrayCollection();
            $processors[] = new Processor\StockValidator();

            return $processors;
        };

        $app['eccube.purchase.flow.order.holder_processors'] = function (Container $app) {
            $processors = new ArrayCollection();
            $processors[] = new Processor\PaymentTotalLimitValidator($app['config']['max_total_fee']);
            $processors[] = new Processor\UpdateDatePurchaseProcessor($app['config']);
            $processors[] = new Processor\UsePointProcessor($app['orm.em'], $app[BaseInfo::class]);
            $processors[] = new Processor\AddPointProcessor($app['orm.em'], $app[BaseInfo::class]);
            $processors[] = new Processor\SubstractPointProcessor($app[BaseInfo::class]);

            return $processors;
        };

        $app['eccube.purchase.flow.order.purchase'] = function (Container $app) {
            $processors = new ArrayCollection();
            $processors[] = new Processor\AdminOrderRegisterPurchaseProcessor($app);


            return $processors;
        };

        $app['eccube.purchase.flow.order'] = function (Container $app) {
            $flow = new PurchaseFlow();
            $flow->setItemProcessors($app['eccube.purchase.flow.order.item_processors']);
            $flow->setItemHolderProcessors($app['eccube.purchase.flow.order.holder_processors']);
            $flow->setPurchaseProcessors($app['eccube.purchase.flow.order.purchase']);

            return $flow;
        };
    }
}


1		<?php
2
3		namespace Eccube\ServiceProvider;
4
5		use Doctrine\Common\Collections\ArrayCollection;
6		use Eccube\Entity\BaseInfo;
7		use Eccube\Entity\Customer;
8		use Eccube\Entity\ItemHolderInterface;
9		use Eccube\Repository\DeliveryRepository;
10		use Eccube\Service\PurchaseFlow\Processor as Processor;
11		use Eccube\Service\PurchaseFlow\PurchaseContext;
12		use Eccube\Service\PurchaseFlow\PurchaseFlow;
13		use Pimple\Container;
14		use Pimple\ServiceProviderInterface;
15
16		class PurchaseFlowServiceProvider implements ServiceProviderInterface
		0 ignored issues – show introduced 2017-10-13 11:30 UTC by Report Bug Copy Issue Report Missing class doc comment Loading history...
17		{
18		public function register(Container $app)
		0 ignored issues – show introduced 2017-10-13 11:30 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
19		{
20		$app['eccube.purchase.context'] = $app->protect(function (ItemHolderInterface $origin = null, Customer $user = null) {
21		return new PurchaseContext($origin, $user);
22		});
23
24		$app['eccube.purchase.flow.cart.item_processors'] = function (Container $app) {
25		$processors = new ArrayCollection();
26		$processors[] = new Processor\DisplayStatusValidator();
27		$processors[] = new Processor\SaleLimitValidator();
28		$processors[] = new Processor\DeliverySettingValidator($app[DeliveryRepository::class]);
29		$processors[] = new Processor\StockValidator();
30
31		return $processors;
32		};
33
34		$app['eccube.purchase.flow.cart.holder_processors'] = function (Container $app) {
35		$processors = new ArrayCollection();
36		$processors[] = new Processor\PaymentProcessor($app[DeliveryRepository::class]);
37		$processors[] = new Processor\PaymentTotalLimitValidator($app['config']['max_total_fee']);
38		$processors[] = new Processor\DeliveryFeeFreeProcessor($app[BaseInfo::class]);
39		$processors[] = new Processor\PaymentTotalNegativeValidator();
40
41		return $processors;
42		};
43
44		$app['eccube.purchase.flow.cart'] = function (Container $app) {
45		$flow = new PurchaseFlow();
46		$flow->setItemProcessors($app['eccube.purchase.flow.cart.item_processors']);
47		$flow->setItemHolderProcessors($app['eccube.purchase.flow.cart.holder_processors']);
48
49		return $flow;
50		};
51
52		$app['eccube.purchase.flow.shopping.item_processors'] = function (Container $app) {
		0 ignored issues – show Unused Code introduced 2017-10-13 11:30 UTC by Report Bug Copy Issue Report The parameter `$app` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
53		$processors = new ArrayCollection();
54		$processors[] = new Processor\StockValidator();
55		$processors[] = new Processor\DisplayStatusValidator();
56
57		return $processors;
58		};
59
60	View Code Duplication	$app['eccube.purchase.flow.shopping.holder_processors'] = function (Container $app) {
61		$processors = new ArrayCollection();
62		$processors[] = new Processor\PaymentTotalLimitValidator($app['config']['max_total_fee']);
63		$processors[] = new Processor\DeliveryFeeProcessor($app['orm.em']);
64		$processors[] = new Processor\PaymentTotalNegativeValidator();
65		$processors[] = new Processor\UsePointProcessor($app['orm.em'], $app[BaseInfo::class]);
66		$processors[] = new Processor\AddPointProcessor($app['orm.em'], $app[BaseInfo::class]);
67		$processors[] = new Processor\SubstractPointProcessor($app[BaseInfo::class]);
68		return $processors;
		0 ignored issues – show introduced 2017-11-13 06:19 UTC by Report Bug Copy Issue Report Missing blank line before return statement Loading history...
69		};
70
71		$app['eccube.purchase.flow.shopping.purchase'] = function (Container $app) {
		0 ignored issues – show Unused Code introduced 2017-11-13 06:19 UTC by Report Bug Copy Issue Report The parameter `$app` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
72		$processors = new ArrayCollection();
73		$processors[] = new Processor\UsePointToCustomerPurchaseProcessor();
74		return $processors;
		0 ignored issues – show introduced 2017-11-13 06:19 UTC by Report Bug Copy Issue Report Missing blank line before return statement Loading history...
75		};
76
77	View Code Duplication	$app['eccube.purchase.flow.shopping'] = function (Container $app) {
78		$flow = new PurchaseFlow();
79		$flow->setItemProcessors($app['eccube.purchase.flow.shopping.item_processors']);
80		$flow->setItemHolderProcessors($app['eccube.purchase.flow.shopping.holder_processors']);
81		$flow->setPurchaseProcessors($app['eccube.purchase.flow.shopping.purchase']);
82
83		return $flow;
84		};
85
86		$app['eccube.purchase.flow.order.item_processors'] = function (Container $app) {
		0 ignored issues – show Unused Code introduced 2017-11-13 06:19 UTC by Report Bug Copy Issue Report The parameter `$app` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
87		$processors = new ArrayCollection();
88		$processors[] = new Processor\StockValidator();
89
90		return $processors;
91		};
92
93	View Code Duplication	$app['eccube.purchase.flow.order.holder_processors'] = function (Container $app) {
94		$processors = new ArrayCollection();
95		$processors[] = new Processor\PaymentTotalLimitValidator($app['config']['max_total_fee']);
96		$processors[] = new Processor\UpdateDatePurchaseProcessor($app['config']);
97		$processors[] = new Processor\UsePointProcessor($app['orm.em'], $app[BaseInfo::class]);
98		$processors[] = new Processor\AddPointProcessor($app['orm.em'], $app[BaseInfo::class]);
99		$processors[] = new Processor\SubstractPointProcessor($app[BaseInfo::class]);
100
101		return $processors;
102		};
103
104		$app['eccube.purchase.flow.order.purchase'] = function (Container $app) {
105		$processors = new ArrayCollection();
106		$processors[] = new Processor\AdminOrderRegisterPurchaseProcessor($app);
		0 ignored issues – show Unused Code introduced 2017-10-13 11:30 UTC by Report Bug Copy Issue Report The call to `AdminOrderRegisterPurchaseProcessor::__construct()` has too many arguments starting with `$app`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
107
108		return $processors;
109		};
110
111	View Code Duplication	$app['eccube.purchase.flow.order'] = function (Container $app) {
112		$flow = new PurchaseFlow();
113		$flow->setItemProcessors($app['eccube.purchase.flow.order.item_processors']);
114		$flow->setItemHolderProcessors($app['eccube.purchase.flow.order.holder_processors']);
115		$flow->setPurchaseProcessors($app['eccube.purchase.flow.order.purchase']);
116
117		return $flow;
118		};
119		}
120		}
121

EC-CUBE / ec-cube

Pull Request — experimental/3.1 (#2624)

PurchaseFlowServiceProvider::register() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like