Eccube\Service\Calculator\Strategy\CalculateTotalStrategy

Complexity

Total Complexity

4

Size/Duplication

Total Lines	38
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	execute()	9	9	1
A	setApplication()	5	5	1
A	setOrder()	5	5	1
A	getTargetTypes()	4	4	1

<?php
namespace Eccube\Service\Calculator\Strategy;

use Eccube\Application;
use Eccube\Entity\Master\OrderItemType;
use Eccube\Entity\Master\TaxType;
use Eccube\Entity\Master\TaxDisplayType;
use Eccube\Entity\Cart;
use Eccube\Entity\Order;
use Eccube\Entity\PurchaseInterface;
use Eccube\Entity\ShipmentItem;
use Eccube\Entity\Shipping;
use Eccube\Repository\Master\OrderItemTypeRepository;
use Eccube\Service\Calculator\ShipmentItemCollection;

/**
 * 明細の合計を集計して Order にセットする.
 */
class CalculateTotalStrategy implements CalculateStrategyInterface

This class seems to be duplicated in your project.

{
    /* @var Application $app */
    protected $app;

    /* @var Order $Order */
    protected $Order;

    /** @var OrderItemTypeRepository */
    protected $OrderItemTypeRepository;

    public function execute(ShipmentItemCollection $ShipmentItems)

Missing function doc comment

    {
        $total = $ShipmentItems->reduce(
            function($total, $ShipmentItem) {

Expected 1 space after FUNCTION keyword; 0 found

                return $total + $ShipmentItem->getPrice() * $ShipmentItem->getQuantity();
            }, 0
        );
        $this->Order->setTotal($total);
    }

    public function setApplication(Application $app)

Missing function doc comment

    {
        $this->app = $app;
        return $this;

Missing blank line before return statement

    }

    public function setOrder(PurchaseInterface $Order)

Missing function doc comment

    {
        $this->Order = $Order;

It seems like $Order of type object<Eccube\Entity\PurchaseInterface> is incompatible with the declared type object<Eccube\Entity\Order> of property $Order.

        return $this;

Missing blank line before return statement

    }

    public function getTargetTypes()

Missing function doc comment

    {
        return [Order::class, Cart::class];
    }
}