Eccube\Service\Calculator\CalculateContext

Complexity

Total Complexity

13

Size/Duplication

Total Lines	76
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

87.5%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	executeCalculator()	0	16	4
A	buildCalculator()	0	8	3
A	calculateOrder()	0	15	3
A	setCalculateStrategies()	0	4	1
A	getCalculateStrategies()	0	4	1
A	setOrder()	0	5	1

<?php
namespace Eccube\Service\Calculator;

use Eccube\Entity\Order;
use Eccube\Entity\PurchaseInterface;
use Eccube\Entity\ShipmentItem;
use Eccube\Service\Calculator\Strategy\CalculateStrategyInterface;

class CalculateContext

Missing class doc comment

{
    /* @var Order $Order */
    protected $Order;

    /* @var ShipmentItemCollection $ShipmentItems */
    protected $ShipmentItems = []; // Collection になってる？

    // $app['eccube.calculate.strategies'] に DI する
    /* @var \Eccube\Service\Calculator\CalculateStrategyCollection CalculateStrategies */
    protected $CalculateStrategies;

    public function executeCalculator()

Missing function doc comment

    {
        $this->buildCalculator($this->CalculateStrategies);

        /** @var ShipmentItem $ShipmentItem */
        foreach($this->ShipmentItems as $ShipmentItem) {
            if ($ShipmentItem instanceof ShipmentItem) {
                if (!$this->Order->getItems()->contains($ShipmentItem)) {
                    $ShipmentItem->setOrder($this->Order);
                    $this->Order->addShipmentItem($ShipmentItem);
                    // ここのタイミングで Persist 可能?
                }
            }
        }
        return $this->calculateOrder($this->Order);

Missing blank line before return statement

    }

    public function buildCalculator(\Eccube\Service\Calculator\CalculateStrategyCollection $strategies)

Missing function doc comment

    {
        foreach ($strategies as $Strategy) {
            if (in_array($this->ShipmentItems->getType(), $Strategy->getTargetTypes())) {
                $Strategy->execute($this->ShipmentItems);
            }
        }
    }

    /**

Doc comment for parameter "$Order" missing

     * TODO
     * 集計は全部ここでやる. 明細を加算するのみ.
     * 計算結果を Order にセットし直すのもここでやる.
     * DI で別クラスにした方がいいかも
     */

Missing @return tag in function comment

    public function calculateOrder(PurchaseInterface $Order)
    {
        // OrderDetails の計算結果を Order にセットする
        if ($this->Order instanceof Order) { // TODO context のほうで判定したい
            $subTotal = $Order->calculateSubTotal();
            $Order->setSubtotal($subTotal);
            $total = $Order->getTotalPrice();
            if ($total < 0) {
                $total = 0;
            }
            $Order->setTotal($total);
            $Order->setPaymentTotal($total);
        }
        return $Order;

Missing blank line before return statement

    }

    public function setCalculateStrategies(\Eccube\Service\Calculator\CalculateStrategyCollection $strategies)

Missing function doc comment

    {
        $this->CalculateStrategies = $strategies;
    }

    public function getCalculateStrategies()

Missing function doc comment

    {
        return $this->CalculateStrategies;
    }

    public function setOrder(PurchaseInterface $Order)

Missing function doc comment

    {
        $this->Order = $Order;

It seems like $Order of type object<Eccube\Entity\PurchaseInterface> is incompatible with the declared type object<Eccube\Entity\Order> of property $Order.

        $this->ShipmentItems = new ShipmentItemCollection($Order->getItems()->toArray(), get_class($this->Order));
    }
}