EC-CUBE / ec-cube

src/Eccube/Controller/Admin/Store/PluginController.php

Doc Comments +1 added lines, -1 removed lines

@@ -642,7 +642,7 @@
      *
      * @param Request $request
      * @param $authKey
-     * @param $url
+     * @param string $url
      * @return array
      */
     private function getRequestApi(Request $request, $authKey, $url)

Spacing +23 added lines, -23 removed lines

@@ -58,7 +58,7 @@ 
         foreach ($Plugins as $Plugin) {
 
             $form = $app['form.factory']
-                ->createNamedBuilder('form' . $Plugin->getId(), 'plugin_management', null, array(
+                ->createNamedBuilder('form'.$Plugin->getId(), 'plugin_management', null, array(
                     'plugin_id' => $Plugin->getId(),
                 ))
                 ->getForm();
@@ -67,7 +67,7 @@ 
 
             try {
                 // プラグイン用設定画面があれば表示(プラグイン用のサービスプロバイダーに定義されているか)
-                $configPages[$Plugin->getCode()] = $app->url('plugin_' . $Plugin->getCode() . '_config');
+                $configPages[$Plugin->getCode()] = $app->url('plugin_'.$Plugin->getCode().'_config');
             } catch (\Exception $e) {
                 // プラグインで設定画面のルートが定義されていない場合は無視
             }
@@ -89,7 +89,7 @@ 
         if (!is_null($authKey)) {
 
             // オーナーズストア通信
-            $url = $app['config']['owners_store_url'] . '?method=list';
+            $url = $app['config']['owners_store_url'].'?method=list';
             list($json, $httpHeader) = $this->getRequestApi($request, $authKey, $url);
 
             if ($json) {
@@ -150,7 +150,7 @@ 
         $Plugin = $app['eccube.repository.plugin']->find($id);
 
         $form = $app['form.factory']
-            ->createNamedBuilder('form' . $id, 'plugin_management', null, array(
+            ->createNamedBuilder('form'.$id, 'plugin_management', null, array(
                 'plugin_id' => null, // placeHolder
             ))
             ->getForm();
@@ -168,10 +168,10 @@ 
                     $formFile = $form['plugin_archive']->getData();
 
                     $tmpDir = $app['eccube.service.plugin']->createTempDir();
-                    $tmpFile = sha1(Str::random(32)) . '.' . $formFile->getClientOriginalExtension();
+                    $tmpFile = sha1(Str::random(32)).'.'.$formFile->getClientOriginalExtension();
 
                     $formFile->move($tmpDir, $tmpFile);
-                    $app['eccube.service.plugin']->update($Plugin, $tmpDir . '/' . $tmpFile);
+                    $app['eccube.service.plugin']->update($Plugin, $tmpDir.'/'.$tmpFile);
 
                     $fs = new Filesystem();
                     $fs->remove($tmpDir);
@@ -340,11 +340,11 @@ 
                     $formFile = $form['plugin_archive']->getData();
 
                     $tmpDir = $service->createTempDir();
-                    $tmpFile = sha1(Str::random(32)) . '.' . $formFile->getClientOriginalExtension(); // 拡張子を付けないとpharが動かないので付ける
+                    $tmpFile = sha1(Str::random(32)).'.'.$formFile->getClientOriginalExtension(); // 拡張子を付けないとpharが動かないので付ける
 
                     $formFile->move($tmpDir, $tmpFile);
 
-                    $service->install($tmpDir . '/' . $tmpFile);
+                    $service->install($tmpDir.'/'.$tmpFile);
 
                     $fs = new Filesystem();
                     $fs->remove($tmpDir);
@@ -391,7 +391,7 @@ 
         if (!is_null($authKey)) {
 
             // オーナーズストア通信
-            $url = $app['config']['owners_store_url'] . '?method=list';
+            $url = $app['config']['owners_store_url'].'?method=list';
             list($json, $httpHeader) = $this->getRequestApi($request, $authKey, $url);
 
             if ($json === false) {
@@ -465,7 +465,7 @@ 
                         }
 
                     } else {
-                        $message = $data['error_code'] . ' : ' . $data['error_message'];
+                        $message = $data['error_code'].' : '.$data['error_message'];
                     }
                 } else {
                     $success = 0;
@@ -507,7 +507,7 @@ 
         if (!is_null($authKey)) {
 
             // オーナーズストア通信
-            $url = $app['config']['owners_store_url'] . '?method=download&product_id=' . $id;
+            $url = $app['config']['owners_store_url'].'?method=download&product_id='.$id;
             list($json, $httpHeader) = $this->getRequestApi($request, $authKey, $url);
 
             if ($json === false) {
@@ -532,22 +532,22 @@ 
                             $extension = pathinfo($item['file_name'], PATHINFO_EXTENSION);
 
                             $tmpDir = $service->createTempDir();
-                            $tmpFile = sha1(Str::random(32)) . '.' . $extension;
+                            $tmpFile = sha1(Str::random(32)).'.'.$extension;
 
                             // ファイル作成
                             $fs = new Filesystem();
-                            $fs->dumpFile($tmpDir . '/' . $tmpFile, $file);
+                            $fs->dumpFile($tmpDir.'/'.$tmpFile, $file);
 
                             if ($action == 'install') {
 
-                                $service->install($tmpDir . '/' . $tmpFile, $id);
+                                $service->install($tmpDir.'/'.$tmpFile, $id);
                                 $app->addSuccess('admin.plugin.install.complete', 'admin');
 
                             } else if ($action == 'update') {
 
                                 $Plugin = $app['eccube.repository.plugin']->findOneBy(array('source' => $id));
 
-                                $service->update($Plugin, $tmpDir . '/' . $tmpFile);
+                                $service->update($Plugin, $tmpDir.'/'.$tmpFile);
                                 $app->addSuccess('admin.plugin.update.complete', 'admin');
 
                                 Cache::clear($app, false);
@@ -558,7 +558,7 @@ 
                             $fs->remove($tmpDir);
 
                             // ダウンロード完了通知処理(正常終了時)
-                            $url = $app['config']['owners_store_url'] . '?method=commit&product_id=' . $id . '&status=1&version=' . $version;
+                            $url = $app['config']['owners_store_url'].'?method=commit&product_id='.$id.'&status=1&version='.$version;
                             $this->getRequestApi($request, $authKey, $url);
 
                             return $app->redirect($app->url('admin_store_plugin'));
@@ -572,7 +572,7 @@ 
                         }
 
                     } else {
-                        $message = $data['error_code'] . ' : ' . $data['error_message'];
+                        $message = $data['error_code'].' : '.$data['error_message'];
                     }
                 } else {
                     $message = "EC-CUBEオーナーズストアにエラーが発生しています。";
@@ -581,7 +581,7 @@ 
         }
 
         // ダウンロード完了通知処理(エラー発生時)
-        $url = $app['config']['owners_store_url'] . '?method=commit&product_id=' . $id . '&status=0&version=' . $version . '&message=' . urlencode($message);
+        $url = $app['config']['owners_store_url'].'?method=commit&product_id='.$id.'&status=0&version='.$version.'&message='.urlencode($message);
         $this->getRequestApi($request, $authKey, $url);
 
         $app->addError($message, 'admin');
@@ -653,9 +653,9 @@ 
                 'ignore_errors' => false,
                 'timeout' => 60,
                 'header' => array(
-                    'Authorization: ' . base64_encode($authKey),
-                    'x-eccube-store-url: ' . base64_encode($request->getSchemeAndHttpHost() . $request->getBasePath()),
-                    'x-eccube-store-version: ' . base64_encode(Constant::VERSION)
+                    'Authorization: '.base64_encode($authKey),
+                    'x-eccube-store-url: '.base64_encode($request->getSchemeAndHttpHost().$request->getBasePath()),
+                    'x-eccube-store-version: '.base64_encode(Constant::VERSION)
                 )
             )
         );
@@ -680,10 +680,10 @@ 
 
             switch ($statusCode) {
                 case '404':
-                    $message = $statusCode . ' : ' . $message;
+                    $message = $statusCode.' : '.$message;
                     break;
                 case '500':
-                    $message = $statusCode . ' : ' . $message;
+                    $message = $statusCode.' : '.$message;
                     break;
                 default:
                     $message = "EC-CUBEオーナーズストアにエラーが発生しています。";

src/Eccube/Controller/Admin/Store/TemplateController.php

Unused Use Statements -1 removed lines

@@ -28,7 +28,6 @@
 use Eccube\Entity\Master\DeviceType;
 use Eccube\Util\Str;
 use Symfony\Component\Filesystem\Filesystem;
-use Symfony\Component\Finder\Finder;
 use Symfony\Component\Form\FormError;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;

Spacing +27 added lines, -27 removed lines

@@ -65,15 +65,15 @@ 
                     ->find($form['selected']->getData());
 
                 // path.ymlの再構築
-                $file = $app['config']['root_dir'] . '/app/config/eccube/path.yml';
+                $file = $app['config']['root_dir'].'/app/config/eccube/path.yml';
                 $config = Yaml::parse($file);
 
                 $templateCode = $Template->getCode();
                 $config['template_code'] = $templateCode;
-                $config['template_realdir'] = $config['root_dir'] . '/app/template/' . $templateCode;
-                $config['template_html_realdir'] = $config['root_dir'] . '/html/template/' . $templateCode;
-                $config['front_urlpath'] = $config['root_urlpath'] . '/template/' . $templateCode;
-                $config['block_realdir'] =$config['template_realdir'] . '/Block';
+                $config['template_realdir'] = $config['root_dir'].'/app/template/'.$templateCode;
+                $config['template_html_realdir'] = $config['root_dir'].'/html/template/'.$templateCode;
+                $config['front_urlpath'] = $config['root_urlpath'].'/template/'.$templateCode;
+                $config['block_realdir'] = $config['template_realdir'].'/Block';
 
                 file_put_contents($file, Yaml::dump($config));
 
@@ -108,19 +108,19 @@ 
         // 該当テンプレートのディレクトリ
         $config = $app['config'];
         $templateCode = $Template->getCode();
-        $targetRealDir = $config['root_dir'] . '/app/template/' . $templateCode;
-        $targetHtmlRealDir = $config['root_dir'] . '/html/template/' . $templateCode;
+        $targetRealDir = $config['root_dir'].'/app/template/'.$templateCode;
+        $targetHtmlRealDir = $config['root_dir'].'/html/template/'.$templateCode;
 
         // 一時ディレクトリ
         $uniqId = sha1(Str::random(32));
-        $tmpDir = $config['template_temp_realdir'] . '/' . $uniqId;
-        $appDir = $tmpDir . '/app';
-        $htmlDir = $tmpDir . '/html';
+        $tmpDir = $config['template_temp_realdir'].'/'.$uniqId;
+        $appDir = $tmpDir.'/app';
+        $htmlDir = $tmpDir.'/html';
 
         // ファイル名
-        $tarFile = $config['template_temp_realdir'] . '/' . $uniqId . '.tar';
-        $tarGzFile = $tarFile . '.gz';
-        $downloadFileName = $Template->getCode() . '.tar.gz';
+        $tarFile = $config['template_temp_realdir'].'/'.$uniqId.'.tar';
+        $tarGzFile = $tarFile.'.gz';
+        $downloadFileName = $Template->getCode().'.tar.gz';
 
         // 該当テンプレートを一時ディレクトリへコピーする.
         $fs = new Filesystem();
@@ -140,14 +140,14 @@ 
 
         // ダウンロード完了後にファイルを削除する.
         // http://stackoverflow.com/questions/15238897/removing-file-after-delivering-response-with-silex-symfony
-        $app->finish(function (Request $request, Response $response, \Silex\Application $app) use (
+        $app->finish(function(Request $request, Response $response, \Silex\Application $app) use (
             $tmpDir,
             $tarFile,
             $tarGzFile
         ) {
-            $app['monolog']->addDebug('remove temp file: ' . $tmpDir);
-            $app['monolog']->addDebug('remove temp file: ' . $tarFile);
-            $app['monolog']->addDebug('remove temp file: ' . $tarGzFile);
+            $app['monolog']->addDebug('remove temp file: '.$tmpDir);
+            $app['monolog']->addDebug('remove temp file: '.$tarFile);
+            $app['monolog']->addDebug('remove temp file: '.$tarGzFile);
             $fs = new Filesystem();
             $fs->remove($tmpDir);
             $fs->remove($tarFile);
@@ -188,8 +188,8 @@ 
         // テンプレートディレクトリの削除
         $config = $app['config'];
         $templateCode = $Template->getCode();
-        $targetRealDir = $config['root_dir'] . '/app/template/' . $templateCode;
-        $targetHtmlRealDir = $config['root_dir'] . '/html/template/' . $templateCode;
+        $targetRealDir = $config['root_dir'].'/app/template/'.$templateCode;
+        $targetHtmlRealDir = $config['root_dir'].'/html/template/'.$templateCode;
 
         $fs = new Filesystem();
         $fs->remove($targetRealDir);
@@ -232,18 +232,18 @@ 
                 // 該当テンプレートのディレクトリ
                 $config = $app['config'];
                 $templateCode = $Template->getCode();
-                $targetRealDir = $config['root_dir'] . '/app/template/' . $templateCode;
-                $targetHtmlRealDir = $config['root_dir'] . '/html/template/' . $templateCode;
+                $targetRealDir = $config['root_dir'].'/app/template/'.$templateCode;
+                $targetHtmlRealDir = $config['root_dir'].'/html/template/'.$templateCode;
 
                 // 一時ディレクトリ
                 $uniqId = sha1(Str::random(32));
-                $tmpDir = $config['template_temp_realdir'] . '/' . $uniqId;
-                $appDir = $tmpDir . '/app';
-                $htmlDir = $tmpDir . '/html';
+                $tmpDir = $config['template_temp_realdir'].'/'.$uniqId;
+                $appDir = $tmpDir.'/app';
+                $htmlDir = $tmpDir.'/html';
 
                 $formFile = $form['file']->getData();
                 // ファイル名
-                $archive = $templateCode . '.' . $formFile->getClientOriginalExtension();
+                $archive = $templateCode.'.'.$formFile->getClientOriginalExtension();
 
                 // ファイルを一時ディレクトリへ移動.
                 $formFile->move($tmpDir, $archive);
@@ -252,11 +252,11 @@ 
                 try {
                     if ($formFile->getClientOriginalExtension() == 'zip') {
                         $zip = new \ZipArchive();
-                        $zip->open($tmpDir . '/' . $archive);
+                        $zip->open($tmpDir.'/'.$archive);
                         $zip->extractTo($tmpDir);
                         $zip->close();
                     } else {
-                        $phar = new \PharData($tmpDir . '/' . $archive);
+                        $phar = new \PharData($tmpDir.'/'.$archive);
                         $phar->extractTo($tmpDir, null, true);
                     }
                 } catch (\Exception $e) {

src/Eccube/Controller/Install/InstallController.php

Doc Comments +3 added lines

@@ -250,6 +250,9 @@
     }
 
 
+    /**
+     * @param InstallApplication $app
+     */
     private function checkModules($app)
     {
         foreach ($this->required_modules as $module) {

Spacing +41 added lines, -41 removed lines

@@ -60,9 +60,9 @@ 
 
     public function __construct()
     {
-        $this->config_path = __DIR__ . '/../../../../app/config/eccube';
-        $this->dist_path = __DIR__ . '/../../Resource/config';
-        $this->cache_path = __DIR__ . '/../../../../app/cache';
+        $this->config_path = __DIR__.'/../../../../app/config/eccube';
+        $this->dist_path = __DIR__.'/../../Resource/config';
+        $this->cache_path = __DIR__.'/../../../../app/cache';
     }
 
     private function isValid(Request $request, Form $form)
@@ -147,7 +147,7 @@ 
 
         if (empty($sessionData['shop_name'])) {
 
-            $config_file = $this->config_path . '/config.yml';
+            $config_file = $this->config_path.'/config.yml';
             $fs = new Filesystem();
 
             if ($fs->exists($config_file)) {
@@ -161,21 +161,21 @@ 
                 }
 
                 // セキュリティの設定
-                $config_file = $this->config_path . '/path.yml';
+                $config_file = $this->config_path.'/path.yml';
                 $config = Yaml::parse(file_get_contents($config_file));
                 $sessionData['admin_dir'] = $config['admin_route'];
 
-                $config_file = $this->config_path . '/config.yml';
+                $config_file = $this->config_path.'/config.yml';
                 $config = Yaml::parse(file_get_contents($config_file));
 
                 $allowHost = $config['admin_allow_host'];
                 if (count($allowHost) > 0) {
                     $sessionData['admin_allow_hosts'] = Str::convertLineFeed(implode("\n", $allowHost));
                 }
-                $sessionData['admin_force_ssl'] = (bool)$config['force_ssl'];
+                $sessionData['admin_force_ssl'] = (bool) $config['force_ssl'];
 
                 // メール設定
-                $config_file = $this->config_path . '/mail.yml';
+                $config_file = $this->config_path.'/mail.yml';
                 $config = Yaml::parse(file_get_contents($config_file));
                 $mail = $config['mail'];
                 $sessionData['mail_backend'] = $mail['transport'];
@@ -212,7 +212,7 @@ 
 
         if (empty($sessionData['database'])) {
 
-            $config_file = $this->config_path . '/database.yml';
+            $config_file = $this->config_path.'/database.yml';
             $fs = new Filesystem();
 
             if ($fs->exists($config_file)) {
@@ -285,7 +285,7 @@ 
                 $host = $request->getSchemeAndHttpHost();
                 $basePath = $request->getBasePath();
                 $params = array(
-                    'http_url' => $host . $basePath,
+                    'http_url' => $host.$basePath,
                     'shop_name' => $sessionData['shop_name'],
                 );
 
@@ -306,13 +306,13 @@ 
     //    インストール完了
     public function complete(InstallApplication $app, Request $request)
     {
-        $config_file = $this->config_path . '/path.yml';
+        $config_file = $this->config_path.'/path.yml';
         $config = Yaml::parse(file_get_contents($config_file));
 
         $host = $request->getSchemeAndHttpHost();
         $basePath = $request->getBasePath();
 
-        $adminUrl = $host . $basePath . '/' . $config['admin_dir'];
+        $adminUrl = $host.$basePath.'/'.$config['admin_dir'];
 
         return $app['twig']->render('complete.twig', array(
             'admin_url' => $adminUrl,
@@ -332,17 +332,17 @@ 
     {
         foreach ($this->required_modules as $module) {
             if (!extension_loaded($module)) {
-                $app->addDanger('[必須] ' . $module . ' 拡張モジュールが有効になっていません。', 'install');
+                $app->addDanger('[必須] '.$module.' 拡張モジュールが有効になっていません。', 'install');
             }
         }
 
         if (!extension_loaded('pdo_mysql') && !extension_loaded('pdo_pgsql')) {
-            $app->addDanger('[必須] ' . 'pdo_pgsql又はpdo_mysql 拡張モジュールを有効にしてください。', 'install');
+            $app->addDanger('[必須] '.'pdo_pgsql又はpdo_mysql 拡張モジュールを有効にしてください。', 'install');
         }
 
         foreach ($this->recommended_module as $module) {
             if (!extension_loaded($module)) {
-                $app->addWarning('[推奨] ' . $module . ' 拡張モジュールが有効になっていません。', 'install');
+                $app->addWarning('[推奨] '.$module.' 拡張モジュールが有効になっていません。', 'install');
             }
         }
 
@@ -360,7 +360,7 @@ 
             if (!function_exists('apache_get_modules')) {
                 $app->addWarning('mod_rewrite が有効になっているか不明です。', 'install');
             } elseif (!in_array('mod_rewrite', apache_get_modules())) {
-                $app->addDanger('[必須] ' . 'mod_rewriteを有効にしてください。', 'install');
+                $app->addDanger('[必須] '.'mod_rewriteを有効にしてください。', 'install');
             }
         } elseif (isset($_SERVER['SERVER_SOFTWARE']) && strpos('Microsoft-IIS', $_SERVER['SERVER_SOFTWARE']) !== false) {
             // iis
@@ -371,7 +371,7 @@ 
 
     private function setPDO()
     {
-        $config_file = $this->config_path . '/database.yml';
+        $config_file = $this->config_path.'/database.yml';
         $config = Yaml::parse(file_get_contents($config_file));
 
         try {
@@ -406,7 +406,7 @@ 
      */
     private function getEntityManager()
     {
-        $config_file = $this->config_path . '/database.yml';
+        $config_file = $this->config_path.'/database.yml';
         $database = Yaml::parse(file_get_contents($config_file));
 
         $this->app->register(new \Silex\Provider\DoctrineServiceProvider(), array(
@@ -414,15 +414,15 @@ 
         ));
 
         $this->app->register(new \Dflydev\Silex\Provider\DoctrineOrm\DoctrineOrmServiceProvider(), array(
-            'orm.proxies_dir' => __DIR__ . '/../../app/cache/doctrine',
+            'orm.proxies_dir' => __DIR__.'/../../app/cache/doctrine',
             'orm.em.options' => array(
                 'mappings' => array(
                     array(
                         'type' => 'yml',
                         'namespace' => 'Eccube\Entity',
                         'path' => array(
-                            __DIR__ . '/../../Resource/doctrine',
-                            __DIR__ . '/../../Resource/doctrine/master',
+                            __DIR__.'/../../Resource/doctrine',
+                            __DIR__.'/../../Resource/doctrine/master',
                         ),
                     ),
 
@@ -450,11 +450,11 @@ 
     {
         $this->resetNatTimer();
 
-        $config_file = $this->config_path . '/database.yml';
+        $config_file = $this->config_path.'/database.yml';
         $database = Yaml::parse(file_get_contents($config_file));
         $config['database'] = $database['database'];
 
-        $config_file = $this->config_path . '/config.yml';
+        $config_file = $this->config_path.'/config.yml';
         $baseConfig = Yaml::parse(file_get_contents($config_file));
         $config['config'] = $baseConfig;
 
@@ -510,11 +510,11 @@ 
     {
         $this->resetNatTimer();
 
-        $config_file = $this->config_path . '/database.yml';
+        $config_file = $this->config_path.'/database.yml';
         $database = Yaml::parse(file_get_contents($config_file));
         $config['database'] = $database['database'];
 
-        $config_file = $this->config_path . '/config.yml';
+        $config_file = $this->config_path.'/config.yml';
         $baseConfig = Yaml::parse(file_get_contents($config_file));
         $config['config'] = $baseConfig;
 
@@ -577,7 +577,7 @@ 
         $config = new Configuration($app['db']);
         $config->setMigrationsNamespace('DoctrineMigrations');
 
-        $migrationDir = __DIR__ . '/../../Resource/doctrine/migration';
+        $migrationDir = __DIR__.'/../../Resource/doctrine/migration';
         $config->setMigrationsDirectory($migrationDir);
         $config->registerMigrationsFromDirectory($migrationDir);
 
@@ -605,7 +605,7 @@ 
     private function getProtectedDirs()
     {
         $protectedDirs = array();
-        $base = __DIR__ . '/../../../..';
+        $base = __DIR__.'/../../../..';
         $dirs = array(
             '/html',
             '/app',
@@ -618,7 +618,7 @@ 
         );
 
         foreach ($dirs as $dir) {
-            if (!is_writable($base . $dir)) {
+            if (!is_writable($base.$dir)) {
                 $protectedDirs[] = $dir;
             }
         }
@@ -629,7 +629,7 @@ 
     private function createConfigYamlFile($data, $auth = true)
     {
         $fs = new Filesystem();
-        $config_file = $this->config_path . '/config.yml';
+        $config_file = $this->config_path.'/config.yml';
 
         if ($fs->exists($config_file)) {
             $config = Yaml::parse(file_get_contents($config_file));
@@ -660,7 +660,7 @@ 
         $content = str_replace(
             $target,
             $replace,
-            file_get_contents($this->dist_path . '/config.yml.dist')
+            file_get_contents($this->dist_path.'/config.yml.dist')
         );
         $fs->dumpFile($config_file, $content);
 
@@ -674,7 +674,7 @@ 
 
     private function addInstallStatus()
     {
-        $config_file = $this->config_path . '/config.yml';
+        $config_file = $this->config_path.'/config.yml';
         $config = Yaml::parse(file_get_contents($config_file));
         $config['eccube_install'] = 1;
         $yml = Yaml::dump($config);
@@ -686,7 +686,7 @@ 
     private function createDatabaseYamlFile($data)
     {
         $fs = new Filesystem();
-        $config_file = $this->config_path . '/database.yml';
+        $config_file = $this->config_path.'/database.yml';
         if ($fs->exists($config_file)) {
             $fs->remove($config_file);
         }
@@ -719,7 +719,7 @@ 
         $content = str_replace(
             $target,
             $replace,
-            file_get_contents($this->dist_path . '/database.yml.dist')
+            file_get_contents($this->dist_path.'/database.yml.dist')
         );
 
         $fs->dumpFile($config_file, $content);
@@ -730,7 +730,7 @@ 
     private function createMailYamlFile($data)
     {
         $fs = new Filesystem();
-        $config_file = $this->config_path . '/mail.yml';
+        $config_file = $this->config_path.'/mail.yml';
         if ($fs->exists($config_file)) {
             $fs->remove($config_file);
         }
@@ -747,7 +747,7 @@ 
         $content = str_replace(
             $target,
             $replace,
-            file_get_contents($this->dist_path . '/mail.yml.dist')
+            file_get_contents($this->dist_path.'/mail.yml.dist')
         );
         $fs->dumpFile($config_file, $content);
 
@@ -757,7 +757,7 @@ 
     private function createPathYamlFile($data, Request $request)
     {
         $fs = new Filesystem();
-        $config_file = $this->config_path . '/path.yml';
+        $config_file = $this->config_path.'/path.yml';
         if ($fs->exists($config_file)) {
             $fs->remove($config_file);
         }
@@ -765,7 +765,7 @@ 
         $ADMIN_ROUTE = $data['admin_dir'];
         $TEMPLATE_CODE = 'default';
         $USER_DATA_ROUTE = 'user_data';
-        $ROOT_DIR = realpath(__DIR__ . '/../../../../');
+        $ROOT_DIR = realpath(__DIR__.'/../../../../');
         $ROOT_URLPATH = $request->getBasePath();
 
         $target = array('${ADMIN_ROUTE}', '${TEMPLATE_CODE}', '${USER_DATA_ROUTE}', '${ROOT_DIR}', '${ROOT_URLPATH}');
@@ -775,7 +775,7 @@ 
         $content = str_replace(
             $target,
             $replace,
-            file_get_contents($this->dist_path . '/path.yml.dist')
+            file_get_contents($this->dist_path.'/path.yml.dist')
         );
         $fs->dumpFile($config_file, $content);
 
@@ -784,7 +784,7 @@ 
 
     private function sendAppData($params)
     {
-        $config_file = $this->config_path . '/database.yml';
+        $config_file = $this->config_path.'/database.yml';
         $db_config = Yaml::parse(file_get_contents($config_file));
 
         $this->setPDO();
@@ -796,7 +796,7 @@ 
         }
 
         if ($db_config['database']['driver'] === 'pdo_mysql') {
-            $db_ver = 'MySQL:' . $version;
+            $db_ver = 'MySQL:'.$version;
         } else {
             $db_ver = $version;
         }
@@ -814,7 +814,7 @@ 
 
         $header = array(
             'Content-Type: application/x-www-form-urlencoded',
-            'Content-Length: ' . strlen($data),
+            'Content-Length: '.strlen($data),
         );
         $context = stream_context_create(
             array(

src/Eccube/Controller/Mypage/DeliveryController.php

Doc Comments +2 added lines, -2 removed lines

@@ -35,7 +35,7 @@ 
      * Index
      *
      * @param  Application $app
-     * @return string
+     * @return \Symfony\Component\HttpFoundation\Response
      */
     public function index(Application $app, Request $request)
     {
@@ -51,7 +51,7 @@ 
      *
      * @param  Application $app
      * @request  Symfony\Component\HttpFoundation\Request $app
-     * @return mixed
+     * @return \Symfony\Component\HttpFoundation\Response
      */
     public function edit(Application $app, Request $request, $id = null)
     {

Spacing +1 added lines, -1 removed lines

@@ -79,7 +79,7 @@
 
         // 遷移が正しくない場合、デフォルトであるマイページの配送先追加の画面を設定する
         if (!in_array($parentPage, $allowdParents)) {
-            $parentPage  = $app->url('mypage_delivery');
+            $parentPage = $app->url('mypage_delivery');
         }
 
         /* @var $form \Symfony\Component\Form\FormInterface */

src/Eccube/Controller/Mypage/MypageController.php

Doc Comments +5 added lines, -6 removed lines

@@ -62,7 +62,7 @@ 
      * @param Application $app
      * @param Request     $request
      *
-     * @return string
+     * @return \Symfony\Component\HttpFoundation\Response
      */
     public function index(Application $app, Request $request)
     {
@@ -89,7 +89,7 @@ 
      * @param Application $app
      * @param Request     $request
      *
-     * @return string
+     * @return \Symfony\Component\HttpFoundation\Response
      */
     public function history(Application $app, Request $request, $id)
     {
@@ -118,7 +118,7 @@ 
      * @param Request     $request
      * @param id     $id
      *
-     * @return string
+     * @return \Symfony\Component\HttpFoundation\RedirectResponse
      */
     public function order(Application $app, Request $request, $id)
     {
@@ -155,7 +155,7 @@ 
      * @param Application $app
      * @param Request     $request
      *
-     * @return string
+     * @return \Symfony\Component\HttpFoundation\Response
      */
     public function favorite(Application $app, Request $request)
     {
@@ -182,9 +182,8 @@ 
 
     /**
      * @param Application $app
-     * @param Request     $request
      *
-     * @return string
+     * @return \Symfony\Component\HttpFoundation\RedirectResponse
      */
     public function delete(Application $app, $id)
     {

src/Eccube/Controller/Mypage/WithdrawController.php

Doc Comments +1 added lines, -1 removed lines

@@ -87,7 +87,7 @@
      * Complete
      *
      * @param  Application $app
-     * @return mixed
+     * @return \Symfony\Component\HttpFoundation\Response
      */
     public function complete(Application $app, Request $request)
     {

Spacing +1 added lines, -1 removed lines

@@ -62,7 +62,7 @@
                         // 会員削除
                         $email = $Customer->getEmail();
                         // メールアドレスにダミーをセット
-                        $Customer->setEmail(Str::random(60) . '@dummy.dummy');
+                        $Customer->setEmail(Str::random(60).'@dummy.dummy');
                         $Customer->setDelFlg(Constant::ENABLED);
 
                         $app['orm.em']->flush();

src/Eccube/Controller/ShoppingController.php

Doc Comments +1 added lines

@@ -1188,6 +1188,7 @@
 
     /**
      * 非会員でのお客様情報変更時の入力チェック
+     * @param Application $app
      */
     private function customerValidation($app, $data) {
 

Spacing +10 added lines, -10 removed lines

@@ -221,7 +221,7 @@ 
 
                 $MailHistory = new MailHistory();
                 $MailHistory
-                    ->setSubject('[' . $app['eccube.repository.base_info']->get()->getShopName() . '] ' . $MailTemplate->getSubject())
+                    ->setSubject('['.$app['eccube.repository.base_info']->get()->getShopName().'] '.$MailTemplate->getSubject())
                     ->setMailBody($body)
                     ->setMailTemplate($MailTemplate)
                     ->setSendDate(new \DateTime())
@@ -493,7 +493,7 @@ 
                 ->setFax03($CustomerAddress->getFax03())
                 ->setZip01($CustomerAddress->getZip01())
                 ->setZip02($CustomerAddress->getZip02())
-                ->setZipCode($CustomerAddress->getZip01() . $CustomerAddress->getZip02())
+                ->setZipCode($CustomerAddress->getZip01().$CustomerAddress->getZip02())
                 ->setPref($CustomerAddress->getPref())
                 ->setAddr01($CustomerAddress->getAddr01())
                 ->setAddr02($CustomerAddress->getAddr02());
@@ -619,7 +619,7 @@ 
                         ->setTel03($data['tel03'])
                         ->setZip01($data['zip01'])
                         ->setZip02($data['zip02'])
-                        ->setZipCode($data['zip01'] . $data['zip02'])
+                        ->setZipCode($data['zip01'].$data['zip02'])
                         ->setPref($data['pref'])
                         ->setAddr01($data['addr01'])
                         ->setAddr02($data['addr02'])
@@ -640,7 +640,7 @@ 
                     ->setTel03($data['tel03'])
                     ->setZip01($data['zip01'])
                     ->setZip02($data['zip02'])
-                    ->setZipCode($data['zip01'] . $data['zip02'])
+                    ->setZipCode($data['zip01'].$data['zip02'])
                     ->setPref($data['pref'])
                     ->setAddr01($data['addr01'])
                     ->setAddr02($data['addr02']);
@@ -706,7 +706,7 @@ 
                     ->setTel03($data['customer_tel03'])
                     ->setZip01($data['customer_zip01'])
                     ->setZip02($data['customer_zip02'])
-                    ->setZipCode($data['customer_zip01'] . $data['customer_zip02'])
+                    ->setZipCode($data['customer_zip01'].$data['customer_zip02'])
                     ->setPref($pref)
                     ->setAddr01($data['customer_addr01'])
                     ->setAddr02($data['customer_addr02'])
@@ -812,7 +812,7 @@ 
                     ->setTel03($data['tel03'])
                     ->setZip01($data['zip01'])
                     ->setZip02($data['zip02'])
-                    ->setZipCode($data['zip01'] . $data['zip02'])
+                    ->setZipCode($data['zip01'].$data['zip02'])
                     ->setPref($data['pref'])
                     ->setAddr01($data['addr01'])
                     ->setAddr02($data['addr02']);
@@ -831,7 +831,7 @@ 
                     ->setTel03($data['tel03'])
                     ->setZip01($data['zip01'])
                     ->setZip02($data['zip02'])
-                    ->setZipCode($data['zip01'] . $data['zip02'])
+                    ->setZipCode($data['zip01'].$data['zip02'])
                     ->setPref($data['pref'])
                     ->setAddr01($data['addr01'])
                     ->setAddr02($data['addr02'])
@@ -1055,7 +1055,7 @@ 
                                 ->setFax03($CustomerAddress->getFax03())
                                 ->setZip01($CustomerAddress->getZip01())
                                 ->setZip02($CustomerAddress->getZip02())
-                                ->setZipCode($CustomerAddress->getZip01() . $CustomerAddress->getZip02())
+                                ->setZipCode($CustomerAddress->getZip01().$CustomerAddress->getZip02())
                                 ->setPref($CustomerAddress->getPref())
                                 ->setAddr01($CustomerAddress->getAddr01())
                                 ->setAddr02($CustomerAddress->getAddr02())
@@ -1153,7 +1153,7 @@ 
                     ->setTel03($data['tel03'])
                     ->setZip01($data['zip01'])
                     ->setZip02($data['zip02'])
-                    ->setZipCode($data['zip01'] . $data['zip02'])
+                    ->setZipCode($data['zip01'].$data['zip02'])
                     ->setPref($data['pref'])
                     ->setAddr01($data['addr01'])
                     ->setAddr02($data['addr02'])
@@ -1202,7 +1202,7 @@ 
 
         $errors[] = $app['validator']->validateValue($data['customer_name02'], array(
             new Assert\NotBlank(),
-            new Assert\Length(array('max' => $app['config']['name_len'], )),
+            new Assert\Length(array('max' => $app['config']['name_len'],)),
             new Assert\Regex(array('pattern' => '/^[^\s ]+$/u', 'message' => 'form.type.name.firstname.nothasspace'))
         ));
 

src/Eccube/Form/DataTransformer/EntityToIdTransformer.php

Doc Comments +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
 
     /**
      * @param ObjectManager $om
-     * @param stging $className
+     * @param string $className
      */
     public function __construct(ObjectManager $om, $className)
     {

src/Eccube/Form/Type/Admin/ShipmentItemType.php

Doc Comments +3 added lines

@@ -36,6 +36,9 @@
 {
     protected $app;
 
+    /**
+     * @param \Silex\Application $app
+     */
     public function __construct($app)
     {
         $this->app = $app;

Spacing +1 added lines, -1 removed lines

@@ -91,7 +91,7 @@
                 )));
 
         $app = $this->app;
-        $builder->addEventListener(FormEvents::PRE_SUBMIT, function (FormEvent $event) use ($app) {
+        $builder->addEventListener(FormEvents::PRE_SUBMIT, function(FormEvent $event) use ($app) {
             // モーダルからのPOST時に、金額等をセットする.
             if ('modal' === $app['request']->get('modal')) {
                 $data = $event->getData();