Failed Conditions
Push — improve/performance ( a6615f...85882a )
by Ryo
422:59 queued 414:38
created
src/Eccube/Controller/Admin/Order/OrderController.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
         $em->getConfiguration()->setSQLLogger(null);
185 185
 
186 186
         $response = new StreamedResponse();
187
-        $response->setCallback(function () use ($app, $request) {
187
+        $response->setCallback(function() use ($app, $request) {
188 188
 
189 189
             // CSV種別を元に初期化.
190 190
             $app['eccube.service.csv.export']->initCsvType(CsvType::CSV_TYPE_ORDER);
@@ -198,7 +198,7 @@  discard block
 block discarded – undo
198 198
 
199 199
             // データ行の出力.
200 200
             $app['eccube.service.csv.export']->setExportQueryBuilder($qb);
201
-            $app['eccube.service.csv.export']->exportData(function ($entity, $csvService) {
201
+            $app['eccube.service.csv.export']->exportData(function($entity, $csvService) {
202 202
 
203 203
                 $Csvs = $csvService->getCsvs();
204 204
 
@@ -228,9 +228,9 @@  discard block
 block discarded – undo
228 228
         });
229 229
 
230 230
         $now = new \DateTime();
231
-        $filename = 'order_' . $now->format('YmdHis') . '.csv';
231
+        $filename = 'order_'.$now->format('YmdHis').'.csv';
232 232
         $response->headers->set('Content-Type', 'application/octet-stream');
233
-        $response->headers->set('Content-Disposition', 'attachment; filename=' . $filename);
233
+        $response->headers->set('Content-Disposition', 'attachment; filename='.$filename);
234 234
         $response->send();
235 235
 
236 236
         return $response;
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
253 253
         $em->getConfiguration()->setSQLLogger(null);
254 254
 
255 255
         $response = new StreamedResponse();
256
-        $response->setCallback(function () use ($app, $request) {
256
+        $response->setCallback(function() use ($app, $request) {
257 257
 
258 258
             // CSV種別を元に初期化.
259 259
             $app['eccube.service.csv.export']->initCsvType(CsvType::CSV_TYPE_SHIPPING);
@@ -267,7 +267,7 @@  discard block
 block discarded – undo
267 267
 
268 268
             // データ行の出力.
269 269
             $app['eccube.service.csv.export']->setExportQueryBuilder($qb);
270
-            $app['eccube.service.csv.export']->exportData(function ($entity, $csvService) {
270
+            $app['eccube.service.csv.export']->exportData(function($entity, $csvService) {
271 271
 
272 272
                 $Csvs = $csvService->getCsvs();
273 273
 
@@ -305,9 +305,9 @@  discard block
 block discarded – undo
305 305
         });
306 306
 
307 307
         $now = new \DateTime();
308
-        $filename = 'shipping_' . $now->format('YmdHis') . '.csv';
308
+        $filename = 'shipping_'.$now->format('YmdHis').'.csv';
309 309
         $response->headers->set('Content-Type', 'application/octet-stream');
310
-        $response->headers->set('Content-Disposition', 'attachment; filename=' . $filename);
310
+        $response->headers->set('Content-Disposition', 'attachment; filename='.$filename);
311 311
         $response->send();
312 312
 
313 313
         return $response;
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Product/CategoryController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
         $em->getConfiguration()->setSQLLogger(null);
165 165
 
166 166
         $response = new StreamedResponse();
167
-        $response->setCallback(function () use ($app, $request) {
167
+        $response->setCallback(function() use ($app, $request) {
168 168
 
169 169
             // CSV種別を元に初期化.
170 170
             $app['eccube.service.csv.export']->initCsvType(CsvType::CSV_TYPE_CATEGORY);
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
 
179 179
             // データ行の出力.
180 180
             $app['eccube.service.csv.export']->setExportQueryBuilder($qb);
181
-            $app['eccube.service.csv.export']->exportData(function ($entity, $csvService) {
181
+            $app['eccube.service.csv.export']->exportData(function($entity, $csvService) {
182 182
 
183 183
                 $Csvs = $csvService->getCsvs();
184 184
 
@@ -198,9 +198,9 @@  discard block
 block discarded – undo
198 198
         });
199 199
 
200 200
         $now = new \DateTime();
201
-        $filename = 'category_' . $now->format('YmdHis') . '.csv';
201
+        $filename = 'category_'.$now->format('YmdHis').'.csv';
202 202
         $response->headers->set('Content-Type', 'application/octet-stream');
203
-        $response->headers->set('Content-Disposition', 'attachment; filename=' . $filename);
203
+        $response->headers->set('Content-Disposition', 'attachment; filename='.$filename);
204 204
         $response->send();
205 205
 
206 206
         return $response;
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Product/ClassCategoryController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -95,7 +95,7 @@
 block discarded – undo
95 95
         $num = $app['eccube.repository.product_class']->createQueryBuilder('pc')
96 96
             ->select('count(pc.id)')
97 97
             ->where('pc.ClassCategory1 = :id OR pc.ClassCategory2 = :id')
98
-            ->setParameter('id',$id)
98
+            ->setParameter('id', $id)
99 99
             ->getQuery()
100 100
             ->getSingleScalarResult();
101 101
         if ($num > 0) {
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Product/ProductClassController.php 3 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
                     $class2Valied = $this->isValiedCategory($ClassName2);
95 95
 
96 96
                     // 規格が選択されていないか、選択された状態で分類が保有されていれば、画面表示
97
-                    if($class1Valied && $class2Valied){
97
+                    if ($class1Valied && $class2Valied) {
98 98
                         $hasClassCategoryFlg = true;
99 99
                     }
100 100
 
@@ -582,7 +582,7 @@  discard block
 block discarded – undo
582 582
         // 個別消費税
583 583
         $BaseInfo = $app['eccube.repository.base_info']->get();
584 584
         if ($BaseInfo->getOptionProductTaxRule() == Constant::ENABLED) {
585
-            if($productClassOrig->getTaxRate()) {
585
+            if ($productClassOrig->getTaxRate()) {
586 586
                 $productClassDest->setTaxRate($productClassOrig->getTaxRate());
587 587
                 if ($productClassDest->getTaxRule() && !$productClassDest->getTaxRule()->getDelFlg()) {
588 588
                     $productClassDest->getTaxRule()->setTaxRate($productClassOrig->getTaxRate());
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -138,7 +138,7 @@
 block discarded – undo
138 138
                                 'allow_add' => true,
139 139
                                 'allow_delete' => true,
140 140
                                 'data' => $ProductClasses,
141
-                             ));
141
+                                ));
142 142
 
143 143
                         $event = new EventArgs(
144 144
                             array(
Please login to merge, or discard this patch.
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -511,6 +511,7 @@
 block discarded – undo
511 511
     /**
512 512
      * 登録、更新時のエラー画面表示
513 513
      *
514
+     * @param boolean $not_product_class
514 515
      */
515 516
     protected function render($app, $Product, $ProductClass, $not_product_class, $classForm, $error = null)
516 517
     {
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Setting/Shop/PaymentController.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -70,10 +70,10 @@  discard block
 block discarded – undo
70 70
                 // ファイルアップロード
71 71
                 $file = $form['payment_image']->getData();
72 72
                 $fs = new Filesystem();
73
-                if ($file && $fs->exists($app['config']['image_temp_realdir'] . '/' . $file)) {
73
+                if ($file && $fs->exists($app['config']['image_temp_realdir'].'/'.$file)) {
74 74
                     $fs->rename(
75
-                        $app['config']['image_temp_realdir'] . '/' . $file,
76
-                        $app['config']['image_save_realdir'] . '/' . $file
75
+                        $app['config']['image_temp_realdir'].'/'.$file,
76
+                        $app['config']['image_save_realdir'].'/'.$file
77 77
                     );
78 78
                 }
79 79
 
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
         if (isset($images['payment_image_file'])) {
101 101
             $image = $images['payment_image_file'];
102 102
             $extension = $image->guessExtension();
103
-            $filename = date('mdHis') . uniqid('_') . '.' . $extension;
103
+            $filename = date('mdHis').uniqid('_').'.'.$extension;
104 104
             $image->move($app['config']['image_temp_realdir'], $filename);
105 105
         }
106 106
 
@@ -127,12 +127,12 @@  discard block
 block discarded – undo
127 127
         foreach ($Payments as $Payment) {
128 128
             if ($Payment->getId() != $id) {
129 129
                 $Payment->setRank($rank);
130
-                $rank ++;
130
+                $rank++;
131 131
             }
132 132
         }
133 133
         $app['orm.em']->flush();
134 134
 
135
-        $app->addSuccess('admin.delete.complete', 'admin') ;
135
+        $app->addSuccess('admin.delete.complete', 'admin');
136 136
 
137 137
         return $app->redirect($app->url('admin_setting_shop_payment'));
138 138
     }
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Setting/System/LogController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@
 block discarded – undo
62 62
         $log = array();
63 63
         $message = array();
64 64
 
65
-        foreach (array_reverse(file($logFile, FILE_IGNORE_NEW_LINES | FILE_SKIP_EMPTY_LINES)) as $line) {
65
+        foreach (array_reverse(file($logFile, FILE_IGNORE_NEW_LINES|FILE_SKIP_EMPTY_LINES)) as $line) {
66 66
             // 上限に達した場合、処理を抜ける
67 67
             if (count($log) >= $formData['line_max']) {
68 68
                 break;
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Setting/System/SecurityController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
                 // 現在のセキュリティ情報を更新
53 53
                 $adminRoot = $app['config']['admin_route'];
54 54
 
55
-                $configFile = $app['config']['root_dir'] . '/app/config/eccube/config.yml';
55
+                $configFile = $app['config']['root_dir'].'/app/config/eccube/config.yml';
56 56
                 $config = Yaml::parse(file_get_contents($configFile));
57 57
                 // trim処理
58 58
                 $allowHost = Str::convertLineFeed($data['admin_allow_host']);
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
 
83 83
                 if ($adminRoot != $data['admin_route_dir']) {
84 84
                     // admin_routeが変更されればpath.ymlを更新
85
-                    $pathFile = $app['config']['root_dir'] . '/app/config/eccube/path.yml';
85
+                    $pathFile = $app['config']['root_dir'].'/app/config/eccube/path.yml';
86 86
                     $config = Yaml::parse(file_get_contents($pathFile));
87 87
                     $config['admin_route'] = $data['admin_route_dir'];
88 88
 
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
                     $this->getSecurity($app)->setToken(null);
95 95
 
96 96
                     // 管理者画面へ再ログイン
97
-                    return $app->redirect($request->getBaseUrl() . '/' . $config['admin_route']);
97
+                    return $app->redirect($request->getBaseUrl().'/'.$config['admin_route']);
98 98
                 }
99 99
 
100 100
                 $app->addSuccess('admin.sysmte.security.save.complete', 'admin');
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
             if (count($allowHost) > 0) {
108 108
                 $form->get('admin_allow_host')->setData(Str::convertLineFeed(implode("\n", $allowHost)));
109 109
             }
110
-            $form->get('force_ssl')->setData((bool)$app['config']['force_ssl']);
110
+            $form->get('force_ssl')->setData((bool) $app['config']['force_ssl']);
111 111
         }
112 112
 
113 113
         return $app->render('Setting/System/security.twig', array(
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Setting/System/SystemController.php 2 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
 
50 50
                 return $phpinfo;
51 51
 
52
-               break;
52
+                break;
53 53
             default:
54 54
                 break;
55 55
         }
@@ -61,8 +61,8 @@  discard block
 block discarded – undo
61 61
         ));
62 62
     }
63 63
 
64
-     public function getSystemInfo(Application $app)
65
-     {
64
+        public function getSystemInfo(Application $app)
65
+        {
66 66
         $system = $app['eccube.service.system'];
67 67
         $server = $app['request'];
68 68
 
@@ -78,5 +78,5 @@  discard block
 block discarded – undo
78 78
         $arrSystemInfo[] = array('title' => 'HTTPユーザーエージェント', 'value' => $server->headers->get('User-Agent'));
79 79
 
80 80
         return $arrSystemInfo;
81
-     }
81
+        }
82 82
 }
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -67,13 +67,13 @@
 block discarded – undo
67 67
         $server = $app['request'];
68 68
 
69 69
         $arrSystemInfo = array(
70
-            array('title' => 'EC-CUBE',     'value' => Constant::VERSION),
71
-            array('title' => 'サーバーOS',    'value' => php_uname()),
72
-            array('title' => 'DBサーバー',    'value' => $system->getDbversion()),
73
-            array('title' => 'WEBサーバー',   'value' => $server->server->get("SERVER_SOFTWARE")),
70
+            array('title' => 'EC-CUBE', 'value' => Constant::VERSION),
71
+            array('title' => 'サーバーOS', 'value' => php_uname()),
72
+            array('title' => 'DBサーバー', 'value' => $system->getDbversion()),
73
+            array('title' => 'WEBサーバー', 'value' => $server->server->get("SERVER_SOFTWARE")),
74 74
         );
75 75
 
76
-        $value = phpversion() . ' (' . implode(', ', get_loaded_extensions()) . ')';
76
+        $value = phpversion().' ('.implode(', ', get_loaded_extensions()).')';
77 77
         $arrSystemInfo[] = array('title' => 'PHP', 'value' => $value);
78 78
         $arrSystemInfo[] = array('title' => 'HTTPユーザーエージェント', 'value' => $server->headers->get('User-Agent'));
79 79
 
Please login to merge, or discard this patch.
src/Eccube/Controller/BlockController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@
 block discarded – undo
38 38
 
39 39
         if ($app['eccube.layout']) {
40 40
             foreach ($app['eccube.layout']->getBlocPositions() as $blocPositions) {
41
-                if ($blocPositions->getTargetId() == constant("Eccube\Entity\BlocPosition::" . $position)) {
41
+                if ($blocPositions->getTargetId() == constant("Eccube\Entity\BlocPosition::".$position)) {
42 42
                     $blocks[] = $blocPositions->getBloc();
43 43
                 }
44 44
             }
Please login to merge, or discard this patch.