Failed Conditions
Push — improve/performance ( a6615f...85882a )
by Ryo
422:59 queued 414:38
created
src/Eccube/Controller/Admin/Product/CsvImportController.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -583,6 +583,7 @@  discard block
 block discarded – undo
583 583
     /**
584 584
      * 登録、更新時のエラー画面表示
585 585
      *
586
+     * @param string $twig
586 587
      */
587 588
     protected function render($app, $form, $headers, $twig)
588 589
     {
@@ -682,6 +683,7 @@  discard block
 block discarded – undo
682 683
 
683 684
     /**
684 685
      * 商品カテゴリの削除、登録
686
+     * @param CsvImportService $data
685 687
      */
686 688
     protected function createProductCategory($row, Product $Product, $app, $data)
687 689
     {
@@ -725,6 +727,7 @@  discard block
 block discarded – undo
725 727
 
726 728
     /**
727 729
      * 商品規格分類1、商品規格分類2がnullとなる商品規格情報を作成
730
+     * @param CsvImportService $data
728 731
      */
729 732
     protected function createProductClass($row, Product $Product, $app, $data, $ClassCategory1 = null, $ClassCategory2 = null)
730 733
     {
@@ -866,6 +869,7 @@  discard block
 block discarded – undo
866 869
 
867 870
     /**
868 871
      * 商品規格情報を更新
872
+     * @param CsvImportService $data
869 873
      */
870 874
     protected function updateProductClass($row, Product $Product, ProductClass $ProductClass, $app, $data)
871 875
     {
@@ -1012,6 +1016,7 @@  discard block
 block discarded – undo
1012 1016
     /**
1013 1017
      * 登録、更新時のエラー画面表示
1014 1018
      *
1019
+     * @param string $message
1015 1020
      */
1016 1021
     protected function addErrors($message)
1017 1022
     {
Please login to merge, or discard this patch.
src/Eccube/Service/CsvExportService.php 1 patch
Doc Comments   -2 removed lines patch added patch discarded remove patch
@@ -325,7 +325,6 @@  discard block
 block discarded – undo
325 325
 
326 326
     /**
327 327
      * @param $row
328
-     * @param null $callback
329 328
      */
330 329
     public function fputcsv($row)
331 330
     {
@@ -424,7 +423,6 @@  discard block
 block discarded – undo
424 423
      * XXX self::setExportQueryBuilder() をコールする前に EntityManager を取得したいので、引数で渡している
425 424
      *
426 425
      * @param array $searchData セッションから取得した検索条件の配列
427
-     * @param EntityManager $em
428 426
      */
429 427
     protected function findDeserializeObjects(array &$searchData)
430 428
     {
Please login to merge, or discard this patch.
src/Eccube/Application.php 1 patch
Doc Comments   +1 added lines, -11 removed lines patch added patch discarded remove patch
@@ -1117,14 +1117,4 @@
 block discarded – undo
1117 1117
                         ));
1118 1118
 
1119 1119
                         if ($response->isNotModified($request)) {
1120
-                            return $response;
1121
-                        }
1122
-                    }
1123
-                }
1124
-            }
1125
-
1126
-        }, -1024);
1127
-
1128
->>>>>>> k-yamamura/feature-httpcache
1129
-    }
1130
-}
1120
+                            return $response
1131 1121
\ No newline at end of file
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Product/ProductClassController.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -511,6 +511,7 @@
 block discarded – undo
511 511
     /**
512 512
      * 登録、更新時のエラー画面表示
513 513
      *
514
+     * @param boolean $not_product_class
514 515
      */
515 516
     protected function render($app, $Product, $ProductClass, $not_product_class, $classForm, $error = null)
516 517
     {
Please login to merge, or discard this patch.