PurchaseFlowPass::process() - Code Metrics - Inspection of "Merge pull request #3295 from oywc410/eccube4_129_..." - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — experimental/sf ( 267a6e...28d741 )

by Ryo

created 2018-07-13 11:04 UTC

PurchaseFlowPass::process() A

↳ Parent: PurchaseFlowPass

Complexity

Conditions	5
Paths	5

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	19
CRAP Score	5

Importance

Changes

Metric	Value
cc	5
nc	5
nop	1
dl	0
loc	32
rs	9.0968
c	0
b	0
f	0
ccs	19
cts	19
cp	1
crap	5

<?php

/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Eccube\DependencyInjection\Compiler;

use Doctrine\Common\Annotations\AnnotationReader;
use Doctrine\Common\Annotations\AnnotationRegistry;
use Eccube\Annotation\CartFlow;
use Eccube\Annotation\OrderFlow;
use Eccube\Annotation\ShoppingFlow;
use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Reference;

class PurchaseFlowPass implements CompilerPassInterface

{
    const ITEM_PREPROCESSOR_TAG = 'eccube.item.preprocessor';
    const ITEM_VALIDATOR_TAG = 'eccube.item.validator';
    const ITEM_HOLDER_PREPROCESSOR_TAG = 'eccube.item.holder.preprocessor';
    const ITEM_HOLDER_VALIDATOR_TAG = 'eccube.item.holder.validator';
    const PURCHASE_PROCESSOR_TAG = 'eccube.purchase.processor';

    public function process(ContainerBuilder $container)
    {
        $flowDefs = [
            CartFlow::class => $container->getDefinition('eccube.purchase.flow.cart'),
            ShoppingFlow::class => $container->getDefinition('eccube.purchase.flow.shopping'),
            OrderFlow::class => $container->getDefinition('eccube.purchase.flow.order'),
        ];

        $processorTags = [
            self::ITEM_PREPROCESSOR_TAG => 'addItemPreprocessor',
            self::ITEM_VALIDATOR_TAG => 'addItemValidator',
            self::ITEM_HOLDER_PREPROCESSOR_TAG => 'addItemHolderPreprocessor',
            self::ITEM_HOLDER_VALIDATOR_TAG => 'addItemHolderValidator',
            self::PURCHASE_PROCESSOR_TAG => 'addPurchaseProcessor',
        ];

        AnnotationRegistry::registerAutoloadNamespace('Eccube\Annotation', __DIR__.'/../../../../src');
        $reader = new AnnotationReader();

        foreach ($processorTags as $tag => $methodName) {
            $ids = $container->findTaggedServiceIds($tag);
            foreach ($ids as $id => $tags) {
                $def = $container->getDefinition($id);
                foreach ($flowDefs as $annotationName => $purchaseFlowDef) {
                    $anno = $reader->getClassAnnotation(new \ReflectionClass($def->getClass()), $annotationName);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
                    if ($anno) {
                        $purchaseFlowDef->addMethodCall($methodName, [new Reference($id)]);
                    }
                }
            }
        }
    }
}


1		<?php
2
3		/*
4		* This file is part of EC-CUBE
5		*
6		* Copyright(c) LOCKON CO.,LTD. All Rights Reserved.
7		*
8		* http://www.lockon.co.jp/
9		*
10		* For the full copyright and license information, please view the LICENSE
11		* file that was distributed with this source code.
12		*/
13
14		namespace Eccube\DependencyInjection\Compiler;
15
16		use Doctrine\Common\Annotations\AnnotationReader;
17		use Doctrine\Common\Annotations\AnnotationRegistry;
18		use Eccube\Annotation\CartFlow;
19		use Eccube\Annotation\OrderFlow;
20		use Eccube\Annotation\ShoppingFlow;
21		use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
22		use Symfony\Component\DependencyInjection\ContainerBuilder;
23		use Symfony\Component\DependencyInjection\Reference;
24
25		class PurchaseFlowPass implements CompilerPassInterface
		0 ignored issues – show introduced 2018-07-11 14:39 UTC by Report Bug Copy Issue Report Missing class doc comment Loading history...
26		{
27		const ITEM_PREPROCESSOR_TAG = 'eccube.item.preprocessor';
28		const ITEM_VALIDATOR_TAG = 'eccube.item.validator';
29		const ITEM_HOLDER_PREPROCESSOR_TAG = 'eccube.item.holder.preprocessor';
30		const ITEM_HOLDER_VALIDATOR_TAG = 'eccube.item.holder.validator';
31		const PURCHASE_PROCESSOR_TAG = 'eccube.purchase.processor';
32
33	9	public function process(ContainerBuilder $container)
34		{
35		$flowDefs = [
36	9	CartFlow::class => $container->getDefinition('eccube.purchase.flow.cart'),
37	9	ShoppingFlow::class => $container->getDefinition('eccube.purchase.flow.shopping'),
38	9	OrderFlow::class => $container->getDefinition('eccube.purchase.flow.order'),
39		];
40
41		$processorTags = [
42	9	self::ITEM_PREPROCESSOR_TAG => 'addItemPreprocessor',
43	9	self::ITEM_VALIDATOR_TAG => 'addItemValidator',
44	9	self::ITEM_HOLDER_PREPROCESSOR_TAG => 'addItemHolderPreprocessor',
45	9	self::ITEM_HOLDER_VALIDATOR_TAG => 'addItemHolderValidator',
46	9	self::PURCHASE_PROCESSOR_TAG => 'addPurchaseProcessor',
47		];
48
49	9	AnnotationRegistry::registerAutoloadNamespace('Eccube\Annotation', __DIR__.'/../../../../src');
50	9	$reader = new AnnotationReader();
51
52	9	foreach ($processorTags as $tag => $methodName) {
53	9	$ids = $container->findTaggedServiceIds($tag);
54	9	foreach ($ids as $id => $tags) {
55	9	$def = $container->getDefinition($id);
56	9	foreach ($flowDefs as $annotationName => $purchaseFlowDef) {
57	9	$anno = $reader->getClassAnnotation(new \ReflectionClass($def->getClass()), $annotationName);
		0 ignored issues – show Bug introduced 2018-07-11 14:39 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$anno` is correct as `$reader->getClassAnnotat...ss()), $annotationName)` (which targets `Doctrine\Common\Annotati...r::getClassAnnotation()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
58	9	if ($anno) {
59	9	$purchaseFlowDef->addMethodCall($methodName, [new Reference($id)]);
60		}
61		}
62		}
63		}
64		}
65		}
66

EC-CUBE / ec-cube

Push — experimental/sf ( 267a6e...28d741 )

PurchaseFlowPass::process() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like